GitLab

BUG=chromium-os:16557
TEST=unit_tests --gtest_filter="CrosNetworkFunctions*"

Review URL: https://chromiumcodereview.appspot.com/10134028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133631 0039d316-1c4b-4281-b951-d872f2087c98

This change widens a suppression rule for Bug 51988, widens the suppression rule for Bug 119677, and adds a new rule for Bug 124758.

TBR=thakis
BUG=51988,119677,124758
TEST=make the "Chromium OS Heapcheck" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10155021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133630 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16557
TEST=unit_tests --gtest_filter="CrosNetworkFunctions*"

Review URL: https://chromiumcodereview.appspot.com/10164026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=build success


Review URL: http://codereview.chromium.org/10163016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133628 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133627 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133626 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112749
TEST=See 112749 or 121262 for the test case that works now.


Review URL: http://codereview.chromium.org/10084022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133625 0039d316-1c4b-4281-b951-d872f2087c98

Modify FlimflamDeviceClient's PIN operation methods and Register to use CallMethodWithErrorCallback
Modify FlimflamServiceClient::Connect to use CallMethodWithErrorCallback

BUG=chromium-os:16557
TEST=chromeos_tests

Review URL: https://chromiumcodereview.appspot.com/10170020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133624 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=more angry emails
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10200009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133623 0039d316-1c4b-4281-b951-d872f2087c98

The JSON schema compiler can now handle binary data as an
internal type.

BUG=123687
TEST=None


Review URL: http://codereview.chromium.org/10198005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133621 0039d316-1c4b-4281-b951-d872f2087c98

Trace events collected from suid sandbox'd threads need to report
their real pid and not the sandbox'd pid so data can be correlated
with system event data.

BUG=chromium-os:27809
TEST=check sandbox'd trace data against the output of ps

Change-Id: Ia8c7725ac6e4f18a2114de027a5d19ba15f49e60


Review URL: http://codereview.chromium.org/10165015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133619 0039d316-1c4b-4281-b951-d872f2087c98

A user reported a case where their safe-browsing database was not
updating.  Corrupt data in the add_chunks and sub_chunks area was
causing a 413 server response (even though the post was not
excessively large).  This change explicitly checks the checksums,
causing invalid databases to be reset.

This case could happen if the user's computer crashes before a
previous update was entirely committed to disk.  In most cases,
finalizing the next update would detect the corrupt data, but in this
case he error response from the server prevented the corruption from
being detected.

BUG=120219
TEST=none

Review URL: http://codereview.chromium.org/10093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124642
TEST=none


Review URL: http://codereview.chromium.org/10180008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133617 0039d316-1c4b-4281-b951-d872f2087c98

1) Don't pass the path as the site. We don't support site-specific clearing,
   so just pass an empty string.
2) Append the plugin's name to the profile-specific Pepper data directory.


Review URL: http://codereview.chromium.org/10202002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133616 0039d316-1c4b-4281-b951-d872f2087c98

Remove DOMView.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10171006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124736

Review URL: https://chromiumcodereview.appspot.com/10155020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133614 0039d316-1c4b-4281-b951-d872f2087c98

Currently all 1x art files are repacked into chrome.pak files.

This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.

As a first step this CL does the following:
 - add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
 - stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
 - update the Mac and Windows installer code to package the extra pak files.

Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.

BUG=114311
TEST=Ran on Windows, and Mac and Linux.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132517

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132760

Review URL: https://chromiumcodereview.appspot.com/10024050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133613 0039d316-1c4b-4281-b951-d872f2087c98

This change updates a couple of suppression rules started after switching "Chromium OS" memory bots from i386 to x86_64.

TBR=thakis
BUG=68069,119677
TEST=make the "Chromium OS UI (valgrind)" bots and the "Chromium OS Heapcheck" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10196008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:25279
TEST=visual inspection of changes since R18
TBR=zelidrag

Review URL: http://codereview.chromium.org/10065004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:27899
TEST=build success

Review URL: https://chromiumcodereview.appspot.com/10168027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133608 0039d316-1c4b-4281-b951-d872f2087c98

On the Mac, we populate NSImage from bitmaps in resource bundles. Introduce ImageSkia which contains vector of SkBitmaps. Previously this functionality was within ImageRepSkia. ImageSkia exposes this.

Move gfx::Image::GetSkBitmapAtIndex and gfx::Image::GetNumSkBitmaps to ImageSkia

BUG=122992
TEST=None

Review URL: http://codereview.chromium.org/10086023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=build with chromeos=0/1 use_titlecase=0/1


Review URL: http://codereview.chromium.org/10167025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133606 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10198006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133605 0039d316-1c4b-4281-b951-d872f2087c98

Fix gesture events and touch events to scale delta and touch radius information as well

Review URL: http://codereview.chromium.org/10175002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133604 0039d316-1c4b-4281-b951-d872f2087c98

- Make LauncherView::CalculateIdealBounds to return last visible index;
- In LauncherView::LauncherItemAdded, use the last visible index to determine if
  we need the animation;

BUG=122482
TEST=Verify fix for issue 122482.


Review URL: http://codereview.chromium.org/10068027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133603 0039d316-1c4b-4281-b951-d872f2087c98

In this CL, we replace the old index system with a smarter one.
Its basically the same index system used for default user profile images.


BUG=124035
TEST=


Review URL: http://codereview.chromium.org/10021066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123961
TEST=added new test


Review URL: http://codereview.chromium.org/10151001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133601 0039d316-1c4b-4281-b951-d872f2087c98

Also fix style issues while I'm here.

BUG=none
TEST=none
R=dbeam


Review URL: http://codereview.chromium.org/10186011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133599 0039d316-1c4b-4281-b951-d872f2087c98

Fix a number of problems with the GoogleURLTracker, mostly around the multiple-searches-simultaneously use case:

* The old code used members to track things like "what's the search URL".  But since there's one GoogleURLTracker and potentially many simultaneously open tabs doing searches, this caused problems with searches overwriting the data for previous searches, leading to infobars that would redo the wrong search.  The new code stuffs this sort of data into the infobar delegate so it's safe to have many simultaneous infobars, which are now tracked in a map.

* Related to the above issue, we'd call registrar_.RemoveAll() any time an infobar was closed or we got a committed or closed notification.  But since multiple tabs could in theory be listening for notifications, this was wrong.  This could cause infobars to sometimes not appear when doing searches in multiple tabs.  Now we are more surgical with our notifications.

* Made accepting one infobar close all of them and trigger all of them to re-search.  Similarly, canceling any one infobar now cancels them all.

* The unittest code has been made more robust, if a bit confusing. I changed the way the helper code provided mock search domain responses to make it safe to provide a response whether or not a query had actually happened.  This way if something goes wrong and we don't query at the places we think we should, we won't have hangs or data corruption or anything else.  The downside here is that in order to avoid actually needing a WebContents*, NavigationController*, InfoBarTabHelper*, etc. to be constructed, I instead use simple ints that are reinterpret_cast<>()ed to the various types to serve as unique pointers.  The GoogleURLTracker itself doesn't actually deref these pointers, so this is safe, and it neatly sidesteps having to mock out a bunch of different things, but it's fairly unorthodox.

* More unittests for cases that the original code didn't cover, e.g. multiple simultaneous infobars.

This does NOT yet deal with a major cause of bug 110158 that the GoogleURLTracker does not correctly handle instant (and maybe also prerendering).  I wanted to make the underlying framework more sane and robust before trying to fix that.

BUG=54274,110158
TEST=Moving to different countries causes a "you moved" infobar to trigger when the user does a search.  No matter how many tabs have infobars, accepting or rejecting the new Google TLD should close them all, and if the TLD was accepted, redo all their searches on the new TLD.
Review URL: https://chromiumcodereview.appspot.com/4880003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133598 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123171
TEST=Verify fix for issue 123171.


Review URL: http://codereview.chromium.org/10197003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133597 0039d316-1c4b-4281-b951-d872f2087c98

This updates the Chrome OS versions of the strings on the
about page that are used to communicate update status to
refer to Chrome OS instead of Google Chrome.

BUG=124347
TEST=manual


Review URL: http://codereview.chromium.org/10186013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133596 0039d316-1c4b-4281-b951-d872f2087c98

Due to a race between when window show/hide animations change IsVisible() and "solo" window counting for determining header transparency, a missed update when windows are hidden, and FramePainter::PaintHeader() being called repeatedly with different clip rects for widget updates, we could get into a state where the window header has different transparency values behind various views::View widgets.

Fix this by using Window::TargetVisibility() instead of IsVisible() and monitoring for window visibility change events.

BUG=123866
TEST=manual, see bug


Review URL: http://codereview.chromium.org/10192001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133595 0039d316-1c4b-4281-b951-d872f2087c98

First committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133472
(was reverted, due to missing SHARED_INTERMEDIATE_DIR include dir in chrome_browser.gypi)

Review URL: http://codereview.chromium.org/10123016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133594 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133593 0039d316-1c4b-4281-b951-d872f2087c98

Lands the FFmpeg roll for M20.  Manual test pass completed
by vendors and myself.  ASAN/Valgrind testing on Linux/Mac
platforms on ia32/x64.  TSAN testing on Windows, no new
traces are expected.

ffmpeg_revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=133551

ffmpeg_hash:
http://git.chromium.org/gitweb/?p=chromium/third_party/ffmpeg.git;a=commit;h=f8d71c394e071249f26703669baf1093009620d7

List of remaining diff's from upstream:
http://pastebin.com/t5jTbvm9

BUG=49709, 124684
TEST=Video Test Matrix. unittests + asan/valgrind.

Review URL: https://chromiumcodereview.appspot.com/10196006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133592 0039d316-1c4b-4281-b951-d872f2087c98

Also adds it to the build to ensure it doesn't suffer bit-rot again, and
include Java-side component.


Review URL: http://codereview.chromium.org/10171009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133591 0039d316-1c4b-4281-b951-d872f2087c98

Turns out I cannot get the browser to crash reliably using
about:inducebrowsercrashforrealz anymore. The chrome:// URL works fine.

R=dennisjeffrey@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10200010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133589 0039d316-1c4b-4281-b951-d872f2087c98

PanelBrowserTitlebarGtk, derived from BrowserTitlebar, can allow us to add
panel-specific logic easily, instead of mixing everything in BrowserTitlebar.

This is needed when we're going to add custom button support for panels. We need to paint close and minimize button different from the standard ones and we also need to add unminimize button support.

BUG=none
TEST=existing tests due to no new functionaility


Review URL: http://codereview.chromium.org/10169019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133586 0039d316-1c4b-4281-b951-d872f2087c98

We record seek performance using the product of:
- Video formats: webm and ogv.
- Network constraints: cable, wifi, and no constraints.
- Seek cases: long, short, and buffered seeks.
- Video location: cached and un-cached videos.

BUG=122749
TEST=manual run


Review URL: http://codereview.chromium.org/9960063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133585 0039d316-1c4b-4281-b951-d872f2087c98

 -testPrefsLineEntryForFullscreenAllowed
 -testPrefsLineEntryForFullscreenExit
 -testPatternsForAllowFullscreenAndPointerLock
 -testPatternsForAllowMouseLock
 -testNoMouseLockRequest
 -testUnableToLockMouse
 -SearchForTextOutsideOfContainer

Added additional tests:

 -testEnterTabFSWhileInBrowserFS
 -testNoMouseLockInBrowserFS
 -testMouseLockExitWhenBrowserLoseFocus
 -ExitTabFSToBrowserFS
 -F11KeyExistsTabAndBrowserFS

BUG=122481
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10082033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133584 0039d316-1c4b-4281-b951-d872f2087c98