- 02 Dec, 2020 40 commits
-
-
Clark DuVall authored
If an interface has only one implementer, R8 will merge the interface with the implementer. This causes problems if DexSplitter moves this class into a DFM, as the parent dex may have a reference to the interface, which is now a reference to the implementation in the DFM. This will cause a LinkageError at runtime, since the parent ClassLoader will try to load the reference to a class found in the child ClassLoader. I timed the proguard step for monochrome_bundle on my machine locally, the whole thing takes about 100s while _VerifySplitDexFiles takes about 3s. The verify step will only be run for bundles with isolated splits enabled which use the chrome module (monochrome/trichrome chrome bundles). Bug: 1154065 Change-Id: I453f10354ca20f355c8a946ed611a9ff186ab50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567476 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#832657}
-
Darren Shen authored
This change is part of a larger refactor to remove InputMethodEngineBase::KeyboardEvent in favour of ui::KeyEvent. Assistive suggesters use KeyboardEvent.key, which, for special keys like the arrow keys, are actually based off KeyboardEvent.code (with some variations like Escape -> Esc): https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/input_method/input_method_engine_base.cc;l=42;drc=5af06c5ea5983c42aecf4ac02ba38730a51bed6b Change the suggesters to use code so that it's easier to switch to ui::KeyEvent. This is a mechanical change: - If the key is Up/Down/Left/Right, then the code is Arrow + key: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/input_method/input_method_engine_base.cc;l=50;drc=5af06c5ea5983c42aecf4ac02ba38730a51bed6b - If the key is Esc, the code is Escape: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/input_method/input_method_engine_base.cc;l=52;drc=5af06c5ea5983c42aecf4ac02ba38730a51bed6b - If the key is Enter, the code is Enter: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/input_method/input_method_engine_base.cc;l=55;drc=5af06c5ea5983c42aecf4ac02ba38730a51bed6b Bug: b/174612548 Change-Id: Ib2dd08925546229567df07b0a9d427e67ef0b24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568910Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#832656}
-
Josiah K authored
Magnifier correctly follow focus again in ARC++ apps - fixes regression due to migration of full-screen and docked magnifiers to use chrome.automation events to control magnifier. AX-Relnotes: N/A. Bug: 1154364 Change-Id: I67d3b2ec502ec8bc3f9bb5f249be75b7434d7dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568432Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#832655}
-
Jesse Schettler authored
To align with the spec, set the Scan app's minimum width to 600px and its minimum height to 420px. Bug: 1059779 Change-Id: Ibdcb95f47533748c4be2b57892edfab7c61aaed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568070 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#832654}
-
Thanh Nguyen authored
This CL allows us to inject local state to LocalSearchService. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: I83dbdeb1e1161393b6408866a99b8ddce1c43530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560283 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832653}
-
David Van Cleve authored
Our docs say that this new field should be called "unavailable_local_operation_fallback", but we implemented it as "unavailable_local_issuance_fallback". To fix the inconsistency, this mechanical change swaps out "UnavailableLocalIssuanceFallback" for "UnavailableLocalOperationFallback" and "unavailable_local_issuance_fallback" for "unavailable_local_operation_fallback" in the following directories: - services/network/public/mojom - services/network/trust_tokens R=svaldez CC=ykevin@google.com Fixed: 1154057 Change-Id: I09eda98d0487435e5bf7797c93ecfb3b47073b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566476 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#832652}
-
Evan Stade authored
This relocates some portions of ShortcutHelper into the new component directory //component/webapps. (See bug 1151772 for naming discussion.) For the most part, this is code that's used in the pre-install flow, which will be useful to WebLayer. Some bits are not needed for pre-install, but are relocated with the intention of keeping related code co-located. ShortcutInfo is also relocated. IconUtils is created for utilities that handle shortcut/webapp icons. WebappsUtils is created for general utilities. This has the side effect of modularizing much of ShortcutHelper and all of ShortcutInfo. The parts that are left behind in //chrome/browser/android should probably be moved into the chrome.browser.webapps package. Bug: 1147291,1151772 Change-Id: Iaa69a9108614a358fdf79b5405c86e5b5c5c6786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545901Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#832651}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: I1dc6cdc529b21298943d7157b810e85533a645e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560335 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#832650}
-
Hiroshige Hayashizaki authored
To unify how CanExecuteScripts() is checked across classic script evaluation code paths. This CL doesn't change the behavior. Bug: 1111134 Change-Id: If95a32043c52767eda05f16f9630edee26c5e75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544938 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#832649}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/449a78b1e20e..69662a99d30d 2020-12-01 gvaish@chromium.org Add API Level guard for allowedCapturePolicy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4ce770853d3c535de0560f255c21bf8623d760e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832648}
-
David Van Cleve authored
This change updates the Trust Tokens issuance helper to treat responses bearing empty Sec-Trust-Token headers as "successful" issuance responses that contain no tokens. This was initially implicitly supported by the "v0" BoringSSL cryptographic logic, but the change to the "v1" cryptographic logic altered BoringSSL's behavior to no longer treat an empty string as a well-formed response containing 0 tokens. This is still useful behavior to have: we'd like to avoid console errors in the case that the issuer wants to defer judgment about what, or how many, tokens to issue until a later time, for instance. Consequently, we're implementing this behavior explicitly at the Trust Tokens-over-HTTP level: see go/successfully-issuing-no-tokens for some related background (internal, sorry, due to discussion of server-side implementation details). I've updated the "process an issuance response" pseudocode in the design doc to cover this: https://docs.google.com/document/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit#heading=h.2kzxtyuk0nvu R=csharrison Test: Adds an issuance helper unit test covering this case Change-Id: I4f747a1ce3b2d5b937d69895f2ce78382a60d42a Fixed: 1124443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561046 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#832647}
-
Xing Liu authored
addCompletedDownload for Android download manager is deprecated on Q and causing crash on R. This CL removes another call site of this on P+. Bug: 1120233 Change-Id: Ic8596d7664a831d9c78f6f7f90de5ac65fb8f385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565224Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832646}
-
Jeremy Roman authored
It's slightly more efficient. Change-Id: I1bbc9e2ad89b82c81b67a3b3df615879a8d7519e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562821 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#832645}
-
Felipe Andrade authored
Fix typos on method descriptions. This is a clean up work, done while implementing the feature described on the bug below. Bug: 983041 Change-Id: I132e92d6b3031e164798f4f04617d4384ef26ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566953Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#832644}
-
wutao authored
Bug: b/173754439 Test: manual Change-Id: I9d825c2d9025b185af3d2382176cf62318848ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566737Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#832643}
-
Michael Hansen authored
Use <h1> and <h2> in Nearby pages and dialogs rather than divs to aid navigation when using screen readers. This includes minor CSS adjustments on the device name and data usage settings dialogs to match specs. Screenshots: https://screenshot.googleplex.com/8sbJPa5K7ALz8jt.png https://screenshot.googleplex.com/53J93D2XDCxjvjz.png Fixed: 1148538 Change-Id: I66420f3c4c28f0e5338567b4ed511da6f4f3baac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567996Reviewed-by:
-
Max Curran authored
page load was in the user's content languages. The user's content languages loosely match the languages the user has translated to before or has blocked for translation. This new UMA histogram will therefore give us an idea of how often page loads are in languages that the user doesn't understand. Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing Bug: 1114868 Change-Id: I170e33a4c36ac5c52bdf4cff2098c1bab94ed0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559227 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#832641}
-
Fergal Daly authored
Currently it triggers when ShouldSkipEarlyCommitPendingForCrashedFrame but it's expected that this leads to same-site-instance frame swaps because a crashed frame is being replaced. So this is just noise. Also, it seems that the this bug never occurs when ShouldSkipEarlyCommitPendingForCrashedFrame is enabled. https://crrev.com/c/2563047/12 shows that this no longer triggers with this enabled, there is one failure but it's unrelated to this validation. Bug: 1146573 Change-Id: Ia79cae066c96ef0e70963a7584f13278eebc8521 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563047Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832640}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6035f4a5832a..de5da1203dda 2020-12-01 kahinds@microsoft.com [Loc] Migrate snippets to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieb6efebe8f7503793d9f25ba1ba62e993801ebe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568770Reviewed-by:
-
Yuki Shiino authored
The issue 839117 was fixed by the new bindings generator, so removes workarounds and related tests. Bug: 839117 Change-Id: I5d017b6453997171258f716814901d5d24cc42ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558084Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#832638}
-
Glen Robertson authored
Lazily-initialised keyed service factories are not correctly set to produce null services while testing, nor can they correctly run ServiceIsCreatedWithContext. This introduces bugs that are non-obvious from the interface in keyed_service_base_factory. This CL adds a DCHECK so users of ServiceIsCreatedWithContext and ServiceIsNULLWhileTesting will be notified that those methods won't work as expected, and a TODO to enforce the check on all factories. Split out from crrev.com/c/2539813 Bug: 1150733 Change-Id: I628fe3268a287d2e2e9a6eab94f0d91e9633a62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554194 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL adds JavaBridgeBasicsTest#testWebViewAfterRenderViewSwapped to recreate the regression scenario described in https://crbug.com/572053, and to verify that the new code works as expected. Bug: 1105935 Change-Id: Ie527f0c452a9d3eac7fe0c91797b792eff15c23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564931Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#832636}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606845551-f7436cdc1d8a17c203d7167ce8ba0cc00b1d3773.profdata to chrome-mac-master-1606866872-6478f0eeef26240489c363d20f8bb4402f4721d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id0677571d20fa0943ddd33ffd724661373d660e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568836Reviewed-by:
-
Joe DeBlasio authored
crrev.com/c/2437914 expanded what domains were captured as part of the target embedding heuristic, however it also introduced a large cache of new false positives that exceed our ability to allowlist. This CL makes three small changes to mitigate the impact of that change: 1. It permits cross-TLD embeddings (e.g. google.com.mx no longer matches google.com). 2. It adds additional words to our common words list that cause a number of high-profile false positives (e.g. "hotels"). 3. It adds a small set of domains that are are important to protect from embedding, but use a common word in their name (e.g. "office.com"). These domains are flagged if they're embedded, but not if the domain name ends with "-DOMAIN", e.g. (home-office.com). These changes are pretty small, and strictly reduce the set of domains flagged by target embedding, so should be quite low risk. Alongside proactive allowlisting, this should allow us to re-enable target embedding. Bug: 1150994 Change-Id: I1e0f562f0677e63a33068eed24ddca721d51aea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568814 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#832634}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606845551-c0991c25d04e0fb7cdc34afe442412c8219bff33.profdata to chrome-linux-master-1606866872-076ef2cd1816657315a741fd9794312ae37134c8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2f9abc66734d2115abee341c9d2bb4c4e897a7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568716Reviewed-by:
-
David Jacobo authored
This CL just moves methods around on the header so it matches the order in the implementation and viceversa, more cleaing/grouping is needed. Bug: None Test: Build. Change-Id: I49084e9b868dedab1cf58cf90edc7caef5e72259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568932 Auto-Submit: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#832632}
-
Fergal Daly authored
I expect that Live and MustBeReplaced are both false when the crash occurs but this is to be sure. Bug: 1146573 Change-Id: Ia5ecf022f4ab5384011ed2d5d61efdd24cf1e884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565222 Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Norman Rosas authored
//components/h…, and //components/i... also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I09143210a5a98a1476c9da04b66ae80e17a4a963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566888 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#832630}
-
Dan Harrington authored
- Copied tests from FeedNewTabPageTest to work with v2 - Added a fake feed server, so that we can load fake cards in tests. We'll use this to replace use of feed_large.gcl.bin from feedv1. - updated fake response proto to provide prefetch metadata Change-Id: I705cea688b189e45f395e069f6c4e997aff1f175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561642 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#832629}
-
Gordon Seto authored
Update profile discovery page to only select one profile at a time. Add installing eSIM profiles from the profile discovery page. Update activation code page description when no eSIM profiles were found, add message and error message to eSIM final page. Screenshots: https://screenshot.googleplex.com/BrmvC8t88ei2fZZ.png https://screenshot.googleplex.com/gcHndSi2XtU4WUg.png https://screenshot.googleplex.com/7Xz4oKQMeYdZ283.png https://screenshot.googleplex.com/8NMh78dNWUNq5Gd.png Bug: 1093185 Change-Id: I61628f012fb19d383260b3cf26a30a1c7cff6d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561040Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#832628}
-
Brandon Wylie authored
This is a reland of 068a70b1 Internal change to remove the use of LocationBarLayout#performSearchQuery: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3428545 Original change's description: > [ToolbarMVC] Move loadUrl logic to LocationBarMediator > > Bug: 1147581 > Change-Id: Ic19a6f597138d6d9a769ac1fb186a317d8e3f3fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551466 > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830389} Bug: 1147581 Change-Id: I0c523ff90079294db6e38da24ba764386c6abd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558955 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Angela Yoeurng authored
This CL removes the CGI param keys from being taken into account during relevancy scoring. This is done in the History Quick Provider and the Bookmark Provider. This CL also adds a feature flag to gate the change. Bug: 982773 Change-Id: I46816dfe196a3911f709efcc086c79ef5d0ecd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542727 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#832626}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/986c7fb8caea..51c01588f31e 2020-12-01 mtklein@google.com add CPU feature detection for iOS / ARM Mac 2020-12-01 bsalomon@google.com Don't drop mip map mode in GrTextureOp->GrTextureEffect fallback 2020-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 59aa1ef1975a to 234fccfb1818 (18 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Test: Test: Test: FramebufferObjectTest* Change-Id: I52b5e16a7c8185cc4b6e32a52b7681788929d86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568641Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I6fbd3686d8993bdd75fe25f5849f8da39bc87550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562183 Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Andrew Moylan authored
As part of the rollout of SmartDimModelV3 builtin model, alternative threshold values were explored in Finch experiments. This CL switches the hard-coded default to the best-discovered value. See crbug.com/937063#c37 for details. Bug: 937063 Change-Id: I22bc2dc614f1680a7c2c62aa5ac4231315cc8ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563526 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#832623}
-
Andrew Comminos authored
Now that the event wait time has been increased, this test should be less flaky. Re-enable it accordingly. Bug: 1124978 Change-Id: I221ea9cb96106801d9266e94447660c323ecdd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567110Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#832622}
-
Min Qin authored
BUG=1154181 Change-Id: I8d8c056db57fc79ce8c5d11b7d8499b665a2fe84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567485 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#832621}
-
Thomas Guilbert authored
This CL uses video.requestVideoFrameCallback to make sure a frame is displayed before ending the test. It's possible this test might still flake if the overflow menu doesn't show up on screen in time. Bug: 1145491 Change-Id: Ic402b396cf49d9c2e6853a039e44f739bb2cc014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567571 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#832620}
-
Andre Le authored
Currently in tablet mode, hotseat is shown by default when spoken feedback is enabled. This behavior has caused an issue of blocking apps content. This fix contains: - Change the API in ShelfWidget for ForceToShowHotseat() to accommodate multiple calls. Also changed its name to ForceShowHotseatInTabletMode() since it only works in tablet mode. - Not showing hotseat by default when spoken feedback is enabled. - Make the drag handle become a button to show/hide hotseat (only when spoken feedback is enabled). - Add observer to the drag handle to observe changes in hotseat state. - Apply the changes for ScrollableShelfView and use set_manually_extended() in HandleAccessibleActionScrollToMakeVisible() to avoid conflicts. Fixed: 1136151 Change-Id: I1d9c12645978b14c8f13e062e145cf9006bc600d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541923 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#832619}
-
danakj authored
This removes a usage of WidgetBaseClient from outside of WidgetBase, by passing the main thread implementation of the mojom interface FrameWidgetInputHandler through WidgetBase to the WidgetInputHandler classes, and on to the FrameWidgetInputHandlerImpl. Then that class can access the WebFrameWidgetImpl's version of the mojom interface through the pointer. R=dtapuska@chromium.org Change-Id: I26286cab13cad88bcb906f4ec879834be676db32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563080 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#832618}
-
