GitLab

BUG=131282
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10831019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148477 0039d316-1c4b-4281-b951-d872f2087c98

CID=103708
BUG=
TEST=
TBR=tommi

Review URL: https://chromiumcodereview.appspot.com/10834013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148476 0039d316-1c4b-4281-b951-d872f2087c98

CID=104393
BUG=
TEST=
TBR=mihaip@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10828021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148475 0039d316-1c4b-4281-b951-d872f2087c98

Now that http://crbug.com/115123 is fixed, we can remove the views implementation, and
along the way we can remove the ShowAboutChromeDialog function from BrowseWindow
and the platform-specific overridden functions.

BUG=138724
R=pkasting@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10800096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148474 0039d316-1c4b-4281-b951-d872f2087c98

Clearing the stream_parser_map_ (which represents the list of source buffers) creates an inconsistent state where source buffers should still be available to WebKit (JavaScript) but they have been removed internally. Source buffers should only be removed when RemoveId() is called or upon destruction. 

This change was originally committed as http://src.chromium.org/viewvc/chrome?view=rev&revision=148149 (Patch Set 1) and then reverted because it exposed a memory leak. Turns out the StreamParser was holding on to a reference to the ChunkDemuxer until after the initialization in order to ensure the init callback got called. So for tests that never append an initialization segment, the StreamParser reference prevented the ChunkDemuxer from being deconstructed, causing the memory leak. Before this patch, Shutdown() would remove all the StreamParsers so this wasn't a problem. 

A subsequent patch will not allow StreamParser to hang on to its ChunkDemuxer reference. This is ok because if ChunkDemuxer gets deconstructed, the callback is no longer relevant. 

For reference, the memory leak looks like this: 
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%281%29/builds/11523/steps/memory%20test%3A%20media/logs/stdio 

BUG=138578
, WK88949 
TEST=http/tests/media/media-source/video-media-source-add-and-remove-ids.html, ChunkDemuxerTest.TestEndOfStreamWithNoAppends


Review URL: https://chromiumcodereview.appspot.com/10822024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148473 0039d316-1c4b-4281-b951-d872f2087c98

named.

BUG=none
TEST=none
R=oshima@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10828026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148471 0039d316-1c4b-4281-b951-d872f2087c98

Tested this by running Duke Nukem w/i NaClBox with
http://codereview.chromium.org/10823018/ patched into native_client,
using the command line:

bash -c 'ulimit -v 1000000;  /mm/bsy/chromium/chromium64.git0/src/out/Release/chrome --user-data-dir=/tmp/udd'

to verify that the crash log shows up.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2776
TEST= Manual.


Review URL: https://chromiumcodereview.appspot.com/10823019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148470 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=3
CID=104154,104155,104156
BUG=
TEST=
TBR=jeremy


Review URL: https://chromiumcodereview.appspot.com/10829024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148469 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139061


Review URL: https://chromiumcodereview.appspot.com/10834019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148468 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148467 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tomhudson@chromium.org
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148466 0039d316-1c4b-4281-b951-d872f2087c98

When trying to re-login, we might be at the user pods screen.


R=ivankr@chromium.org
BUG=None
TEST=chromeos_login.ChromeosLogin.testLogoutWithNoWindows
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10820021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148465 0039d316-1c4b-4281-b951-d872f2087c98

Move WaitForLoadStop from ui_test_utils to browser_test_utils so that it can be reused in content_browsertests.

BUG=90448
TBR=viettrungluu
Review URL: https://chromiumcodereview.appspot.com/10823029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=
CID=102400
TBR=jamesr

Review URL: https://chromiumcodereview.appspot.com/10829028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148462 0039d316-1c4b-4281-b951-d872f2087c98

(Views only) Replace the content settings icons and the dummy icons on the Website Settings UI with the set of new content settings icons.


BUG=113688
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10828002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148461 0039d316-1c4b-4281-b951-d872f2087c98

- moving check to bb_run_tests so VM builders don't bother
  running it

R=yfriedman@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10832020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148460 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148459 0039d316-1c4b-4281-b951-d872f2087c98

R=rsesek@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10823008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148458 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=1
CID=103693
BUG=
TEST=
TBR=rvargas


Review URL: https://chromiumcodereview.appspot.com/10828025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148457 0039d316-1c4b-4281-b951-d872f2087c98

chrome/test/data/plugin moved to content/test/data/plugin

BUG=139053
TEST=NONE
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10833023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148456 0039d316-1c4b-4281-b951-d872f2087c98

build_sdk.py: Also added --libraries to build only libraries.
generate_make.py: Added HEADERS tag and HEADERS_DEST to .dsc file to allow a 
library to specify public headers and a place to install them.

BUG=none
TEST=none
R=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10823016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148455 0039d316-1c4b-4281-b951-d872f2087c98

This moves CursorManager into ash/wm/ and makes it an implementation of a new
CursorClient interface. It's really an implementation detail of ash. Then
create a desktop version of this interface.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10692170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132351
TEST=AesDecryptorTest, plus manual playback in browser


Review URL: https://chromiumcodereview.appspot.com/10651006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148453 0039d316-1c4b-4281-b951-d872f2087c98

with per-platform default settings (currently off for all but cros).

This is in preparation for turning on HW decode by default one platform at a time.

BUG=133827,133828


Review URL: https://chromiumcodereview.appspot.com/10805070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148452 0039d316-1c4b-4281-b951-d872f2087c98

Bubble windows sometimes had drawing artifacts. It looks like this was caused by the blur filter we added to those windows.

This CL removes the blur filter (partial revert of r134795 and r147628).

BUG=138761
TEST=Ran and verified that bubble windows looked ok on external display.


Review URL: https://chromiumcodereview.appspot.com/10833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139069
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10820022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148450 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148449 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148448 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10832014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148446 0039d316-1c4b-4281-b951-d872f2087c98

Cancel/OK should be consistent between Create, Manage, and Delete dialogs.
 
BUG=138590
TEST= Manual testing 

Review URL: https://chromiumcodereview.appspot.com/10827011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148445 0039d316-1c4b-4281-b951-d872f2087c98

(1) Bail immediately when BEST_MATCH is requested (as is the case for the AutocompleteClassifier) as the ShortcutsProvider does not currently allow matches to score highly enough to be "best".
(2) Check for input text that's a prefix of the shortcut in question, and mark the whole prefix as a match at once.  This reduces the number of cases where we have both lots of input words AND a long unclassified chunk of output string (the case where things are slow).
(3) Rewrite the general-case matching algorithm to be noticeably faster.  (Not sure of the complexity analysis but I think the worst case is more like O(n*n) than the previous O(m*n*n) and the average case should be much faster than that.  With the test profile and disabling the above two optimizations, typing a letter in my debug build resulted in a hang of about 2 seconds as opposed to several minutes.)

We could probably still do better; in particular, one optimization we could make for all the providers would be to provide them a conservative estimate of how many total characters would be visible in the omnibox dropdown and then have them trim the contents and description fields accordingly before matching.  However, a true conservative estimate -- which would assume that we had e.g. a string of 'i's -- would in the worst case still be several thousand characters wide, I don't want to do the plumbing work, and this optimization seems unnecessary at the moment anyway.

BUG=138242
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10831004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148444 0039d316-1c4b-4281-b951-d872f2087c98

Commit this instead of http://codereview.chromium.org/10834009/

R=jvoung@chromium.org,arthurhsu@chromium.org
BUG=none
TEST=nacl_integration
CID=104221

Review URL: https://chromiumcodereview.appspot.com/10828019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148443 0039d316-1c4b-4281-b951-d872f2087c98

With this change, if launched from shell as root, the uninstaller will:
* Not show any confirmation UX
* Not prompt for admin elevation

Also in this cl, cleanup some of the shared Mac constants by pushing
more into into constants_mac and fixing up the naming style. This
required minor updates to the prefpane and daemon controller.

BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10807061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125863
TEST=Tested change on linux build /w chromeos=1


Review URL: https://chromiumcodereview.appspot.com/10796115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148441 0039d316-1c4b-4281-b951-d872f2087c98

 * cracks isolated path in FileSystemURL ctor
 * FileUtils no longer need to crack the isolated path by themselves
 * Make IsolatedFileUtil inherit from LocalFileUtil
 * Have a separate FileUtil for DraggedFileUtil, which inherits from IsolatedFileUtil

BUG=134078,138022
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/10810053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=try


Review URL: https://chromiumcodereview.appspot.com/10823015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148439 0039d316-1c4b-4281-b951-d872f2087c98

Converts SearchViewController to use live NTP content using views::WebView
instead of placeholder solid rect views::View.

TEST=Launch CrOS/Aura with --enabled-instant-extended-api, observe interactive "Most Visited" section on NTP
BUG=133529
R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10787028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148438 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=3
CID=(104210, 104215),104237,104238
BUG=
TEST=
TBR=jln,bolms,brettw

Review URL: https://chromiumcodereview.appspot.com/10825016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148437 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122913
TEST=None
TBR=acolwell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148436 0039d316-1c4b-4281-b951-d872f2087c98