- 10 Nov, 2017 40 commits
-
-
John Abd-El-Malek authored
This is a followup to r514556 per comments in https://chromium-review.googlesource.com/c/chromium/tools/build/+/758799/. Bug: Change-Id: If42ea0e4bd43f10a5a44f7ce16dd4c721c9f3603 Reviewed-on: https://chromium-review.googlesource.com/761976 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515481}
-
Hidehiko Abe authored
Rewrite GetProperties_TetherNetwork test with fake. BUG=234463 TEST=Ran bots. Change-Id: If991bbbccb221578d9db614790eb244593205efd Reviewed-on: https://chromium-review.googlesource.com/749602Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#515480}
-
Catherine Mullings authored
This CL includes the initial changes to support the new extension API that merges the page action and browser action APIs. Namely this CL adds changes to support the new manifest key called "extension_action" and defines the new API. Bug: Change-Id: Id8975237c02df85c1144451e00de5b116e3bab21 Reviewed-on: https://chromium-review.googlesource.com/714651 Commit-Queue: catmullings <catmullings@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515479}
-
Manish Jethani authored
With crrev.com/c/641294 we introduced user style sheets, but without taking into account custom properties. This patch adds support for custom properties in user style sheets by calling StyleResolver::ApplyMatchedProperties for user rules in the correct order. BUG=632009,781223 Change-Id: I1c103fc37484835008b1b55e9b3b8099af50a48a Reviewed-on: https://chromium-review.googlesource.com/754247Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#515478}
-
Miguel Casas-Sanchez authored
This CL adds a new file vaapi_video_decode_accelerator_unittest and adds it to media_unittests when use_vaapi is true. The new file is then compiled as part of the top level chromiumos_preflight group (in particular by chromeos_amd64-generic_chromium_compile_only_ng), and also in the linux_chromium_chromeos_ bots. This CL also adds a few test cases, dealing mostly with the interaction of input buffers and the VaVDA's internal |decoder_|. (More tests to come). Note that: vaapi_..._unittest needs vaapi to be compiled but not to be run. Bug: 717265 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4b8768e79401170269190292ebf18ef616adb1f8 Reviewed-on: https://chromium-review.googlesource.com/753756 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#515477}
-
Yoshifumi Inoue authored
This patch disables LayoutNG for block-level contenteditable until we're ready to start working on. Also gives us more test opportunities of mixed-tree layout. This patch is continued from the patch[1]. The idea of this patch is attaching legacy layout object to block-level element if it is editaible instead of NG layout object. Hence, this patch doesn't disable inline-level contenteditable, e.g. <span contenteditable>foo</span>. Following patch will handle inline-level contenteditable as similar as RUBY in NG block layout object. [1] http://crrev.com/c/734962 [LayoutNG] Disable LayoutNG for contenteditable Bug: 707656 Change-Id: Ia7a20d88f2e9499dc614791e46021072e4702669 Reviewed-on: https://chromium-review.googlesource.com/758309 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#515476}
-
Alexey Kozyatinskiy authored
All except one in debugger-pause folder. R=chenwilliam@chromium.org Bug: chromium:667560 Change-Id: I5feb2808726219c608301b77a3a406063c0d04be Reviewed-on: https://chromium-review.googlesource.com/761196Reviewed-by:
Will Chen <chenwilliam@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515475}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/22499b0969ac..832536627766 $ git log 22499b096..832536627 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 angle-deps-roller Roll skia/third_party/externals/angle2/ 9e888a46f..ee6884e7b (1 commit) 2017-11-10 egdaniel Revert "Dynamically load the vulkan library in our test tools" Created with: roll-dep src/third_party/skia BUG=783054 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ic8a46e40c2a38f4f05946ef67fc8dd53f0a08f33 Reviewed-on: https://chromium-review.googlesource.com/762124Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515474}
-
Yutaka Hirano authored
This CL replaces Domain::kTest with ordinary Domain::kNet failures. As Domain now has only one element (kNet), this CL removes the enum entirely. Bug: 748491 Change-Id: If593ee0111b18dfdd2bb6ba98332f0ed93dd78e4 Reviewed-on: https://chromium-review.googlesource.com/749612Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#515473}
-
Scott Violet authored
These tests now pass since PDF were made to work (755440). BUG=755272 TEST=test only change TBR=msw@chromium.org Change-Id: Id79e8aa6dbf810a5f6789943e5b6a2665e2dc3e4 Reviewed-on: https://chromium-review.googlesource.com/761956Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515472}
-
Mark Mentovai authored
6f6f8a144d89 Add FileModificationTime 13e17bf90f1e Fix FileModificationTime for Android e2b9ab3ed202 win: Tests shouldn’t freak out when CodeView PDB links are absent 0e3c38a4ca52 win: Make ProcessSnapshotTest.CrashpadInfoChild use a loaded module b8f61fdc8b1e Add TimevalToTimespec and use it to get CurrentTime on macOS Bug: 782781 Change-Id: Id8943d8e245cf3cbdb97ad52bcd664fa9dddab2a Reviewed-on: https://chromium-review.googlesource.com/761878 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#515471}
-
Wenzhao Zang authored
1) We need larger bullets, which is essentially the same with setting different sizes (or FontList) for the bullets and placeholder. 2) We need letter spacing, which can be done by making the line advance more each time in |RenderTextHarfBuzz::ShapeRunWithFont|. Bug: 719015 Change-Id: Ie5370e44d767e54264fa2e4ccb02a481063558da Reviewed-on: https://chromium-review.googlesource.com/732526Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#515470}
-
Will Harris authored
This is a reland of bc2056c3 Original change's description: > Change size in memory mapped region to size_t > > Subsequently, remove some static_casts that are no longer needed. > > On Windows, while it is possible to create a file mapping of a file > > 32-bits long it is not possible to create the view to the file > mapping, so changing this to size_t should have no loss of functionality. > > BUG=778316 > > Change-Id: I81cd2e0808794fdb83fc21c796367369ea2da220 > Reviewed-on: https://chromium-review.googlesource.com/755114 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515257} Bug: 778316 Change-Id: I7456feb2e84fc8bf78514d570f868212093500dd Reviewed-on: https://chromium-review.googlesource.com/761408Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515469}
-
Timothy Loh authored
The durable storage permission is automatically granted or denied based on various heuristics and we never prompt the user for permission. This patch removes this permission from histograms which are only logged for permissions that prompt. Bug: 638076 Change-Id: I7b421f87b5eb2f6fcb0527a90efe1b7908842e4d Reviewed-on: https://chromium-review.googlesource.com/756476Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515468}
-
Yuwei Huang authored
This CL implements OAuthTokenGetter for Android. This is part of the project of implementing a centralized access token getter in client C++ code, so that multiple components like telemetry logger, ICE config fetcher, and session connector can use the same token fetcher without requesting access token back and forth through JNI. Bug: 780736 Change-Id: I265fe963ef6f9e1720b3a7e3f209704be8686957 Reviewed-on: https://chromium-review.googlesource.com/760184 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#515467}
-
Dave Schuyler authored
This Cl replaces the use of paper-menu in MD extensions with an iron-selector Bug: 779282 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I424fbced792781e1ad2a063ab50ce9a93f156660 Reviewed-on: https://chromium-review.googlesource.com/762107Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#515466}
-
Ian Vollick authored
This reverts commit 053d939f. Reason for revert: Hit testing artifacts. Original change's description: > [vr] Ensure that hit testing uses the same stacking order as rendering > > The rendering code was updated to sort elements in tree rather than > depth order in this cl: > https://chromium-review.googlesource.com/c/chromium/src/+/727342 > > The hit testing code, however, was not similarly updated. Consequently, > there can be discrepancies. This CL updates the hit testing code to > use nearly the same stacking order as rendering. Note: it is not quite > perfect because the ui renderer still summons swaths of elements from > the scene explicitly. Eventually, the ui renderer will simply sort > and render all elements in the tree and these will be truly identical. > However, until then, this ensures we do use the same element sorting > routines. > > Bug: None > Change-Id: I12483713f19b678aa9a69b91e5d910e408b73007 > Reviewed-on: https://chromium-review.googlesource.com/754554 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#514136} TBR=vollick@chromium.org,mthiesse@chromium.org,cjgrant@chromium.org Change-Id: I920d8ffcb2dc7aad53ed021d272302cad060f083 Reviewed-on: https://chromium-review.googlesource.com/763007 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#515465}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/7501b1c3d110..d2f37d85bd0a $ git log 7501b1c3d..d2f37d85b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd3eb1e8192a71cd0fb054952b173e7663214bcf Reviewed-on: https://chromium-review.googlesource.com/762065Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515464}
-
Ian Vollick authored
The following CL caused a regression in DrawFrame wall time (and a progression in self time). https://chromium-review.googlesource.com/c/chromium/src/+/752344 I'd changed how we plumbed the current frame time in VrShellGl and this CL speculatively reverts that change. TBR=klausw@chromium.org,mthiesse@chromium.org Bug: None Change-Id: Ie89dfcf515b0c87614bcdeb27a3d87c21ffc83f4 Reviewed-on: https://chromium-review.googlesource.com/763047Reviewed-by:
-
Yuly Novikov authored
Also build angle_perftests on Android builders BUG=675997 TBR=eyaich@chromium.org,dpranke@chromium.org Change-Id: I9e73e19599e3cc435f02960839f2e780402d0188 Reviewed-on: https://chromium-review.googlesource.com/752582 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#515462}
-
Chris Harrelson authored
Going to see if this reduces the crash rate on Windows. TBR=pdr@chromium.org Bug: 781301 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I87df512006b5a71e8ab82b918662e4cdc5eb27b9 Reviewed-on: https://chromium-review.googlesource.com/762338Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515461}
-
Giovanni Ortuño Urquidi authored
Rather than navigating to a third party website that probably has no way to get back to the original app, we bounce back to an existing browser window. Bug: 772803 Change-Id: Ie662bfa59e920d059ade3cc06d77664732ab31fe Reviewed-on: https://chromium-review.googlesource.com/706882 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#515460}
-
Shivani Sharma authored
Since multiple transactions can now be added to Writers, those transactions will have a WRITE bit set. Thus remove the DCHECKS that assume otherwise in HttpCache::DoneWithResponseHeaders. Bug: 750725 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I791177522956ca23d6702254bbf7ee0b25c83bdf Reviewed-on: https://chromium-review.googlesource.com/760540Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#515459}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14592920..c8bfcb14 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic25a1925dc5146416f56a0af3b0e4771620d8384 Reviewed-on: https://chromium-review.googlesource.com/762576Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515458}
-
Luciano Pacheco authored
Add named arguments to "bool" arguments with default values for readability, as identified by the following command: $ git ls-files | grep -E '*\.(h)$' | xargs egrep --color \ "bool = (false|true)" Also update the unnamed double argument in the transform include file, IdentityTransformOperation.h Bug: 781101 Change-Id: I7cd541b1329063805c60b3ee86247d494f8793b4 Reviewed-on: https://chromium-review.googlesource.com/759272Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#515457}
-
Lily Houghton authored
This adds a CronetMetricsDelegate interface, as well as addMetricsDelegate and removeMetricsDelegate methods, which are used to register/unregister metrics callbacks. Currently the callback is never actually called; this is simply defining the interface and registration methods. Bug: 702796 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0a3933bf623265d675e3a10ef5ed25149c89e101 Reviewed-on: https://chromium-review.googlesource.com/748819 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515456}
-
Yoshifumi Inoue authored
This patch makes |SelectionModifier| constructors to take |SelectionInDOMTree| instead of |VisibleSelection| since constructors don't need to take |VisibleSelection|, to reduce usage usage of |VisibleSelection| for improving code health. Bug: 657237 Change-Id: Ibe8989566d23530b13bd50d9365da2339051f571 Reviewed-on: https://chromium-review.googlesource.com/760062Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515455}
-
Yuichiro Hanada authored
The cause of the failure was fixed in crrev.com/c/645586. Bug:515596 Test: Run the test 100 times on local machine Change-Id: I64c613b23f3147f5c8cdb69f9c23adb1cb7bff21 Reviewed-on: https://chromium-review.googlesource.com/667556 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#515454}
-
Kunihiko Sakamoto authored
This fixes a bug where @font-face with font-display: optional causes unnecessary font downloads of subsequent sources when the first source fails to download by the "short time limit" (100ms). Bug: 770978 Change-Id: I24ad7c803d04b9eb310b6b916c999660a23c61b5 Reviewed-on: https://chromium-review.googlesource.com/760137Reviewed-by:
-
Stuart Langley authored
This patch removes the hand crafted implementation of WTF type traits with the versions now available in the std:: type_traits library. The first patch will have the WTF versions use the std:: implementation, a followup patch will remove the WTF versions entirely. This patch replaces the implementations of -> with: WTF::IsCopyAssignable -> std::is_copy_assignable WTF::IsMoveAssignable -> std::is_move_assignable WTF::IsTriviallyCopyAssignable -> std::is_trivially_copy_assignable WTF::IsTriviallyMoveAssignable* -> std::is_trivially_move_assignable WTF::IsDestructible -> std::is_destructible WTF::IsTriviallyDefaultConstructible -> std::is_trivially_default_constructible Bug: 579462 Change-Id: I4ac335929e298f8b28a23021fef8e58ae855f3c6 Reviewed-on: https://chromium-review.googlesource.com/756258 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#515452}
-
Joel Hockey authored
Fixes ICU flush and pivot buffer causing fuzzing error. BUILD.gn updated to not set WIN32_LEAN_AND_MEAN which is defined in libxml. Bug: 722420 Change-Id: Ib4ff2f870f99fb78e02f9841e33f6ad7e72e059e Reviewed-on: https://chromium-review.googlesource.com/759919 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515451}
-
Findit authored
This reverts commit c4ea951f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 515427 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M0ZWE5NTFmMzZlYTFjMTk2MGQ1Njk0OTQyZGE5OWMzN2M2ODE3YWYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Mac/34475 Original change's description: > Serialize more of message_center::Notification for mojo. > > Adds NotificationType and (partial) RichNotificationData. Now you can > see progress bars in download item notifications on Chrome OS when > using --enable-features=NativeNotifications > > Bug: 578868 > Change-Id: I781c10387479ed921f0a7b4efce262b18f04844f > Reviewed-on: https://chromium-review.googlesource.com/755317 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515427} Change-Id: I3eac7eb2400781c22fd59c8f6eb7fc2cdd80e1b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 578868 Reviewed-on: https://chromium-review.googlesource.com/762881 Cr-Commit-Position: refs/heads/master@{#515450}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I4ed482399911f51506d9aea50fbad090c4c22b18 Reviewed-on: https://chromium-review.googlesource.com/762987Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#515449}
-
Tatsuhisa Yamaguchi authored
This is a preparation before enabling the feature by default. Bug: 780688 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4a1bf78085f24289a9e2c8955815ebc6752d95ff Reviewed-on: https://chromium-review.googlesource.com/758279Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/9e888a46f04d..ee6884e7be66 $ git log 9e888a46f..ee6884e7b --date=short --no-merges --format='%ad %ae %s' 2017-11-09 geofflang Generate generic error messages for Error objects without messages. Created with: roll-dep src/third_party/angle BUG=783054 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I73a79aab393f4a52c030dde8fb945571e3758f47 Reviewed-on: https://chromium-review.googlesource.com/762519Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515447}
-
Kyle Horimoto authored
This CL changes icons such that: (1) If no networks exist for the network type, a light-grey "0-bar" icon is displayed. (2) If at least one network exists for the network type but none of them are connected, a light-grey icon with an X is displayed. (3) If the network type is disabled, a darker strikethrough icon is displayed. (4) If a network is connecting, the icon is animated. (5) If a network is connected, an icon displaying the signal strength is displayed. Bug: 764110, 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie433e21017bda469da81f7a297f08cf3cd515fd6 Reviewed-on: https://chromium-review.googlesource.com/762598Reviewed-by: -
Matt Menke authored
Also convert ChromeMojoProxyResolverFactory to a ProxyResolverFactory. The class now relies on the the proxy service to manage its own lifetime, instead of expecting to be responsible for managing that itself. Bug: 754007 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifab3624ea083b4e1e00beaa66e274ab8d0656496 Reviewed-on: https://chromium-review.googlesource.com/660723Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515445}
-
Lily Houghton authored
[Cronet] Define CronetMetrics class implementing the iOS NSURLSessionTaskTransactionMetrics interface This creates a class |CronetMetrics| which provides setters for all of the propeties defined in NSURLSessionTaskTransactionMetrics. Bug: 702796 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icdcc917001c0ceb20107e2f128dba88259330f78 Reviewed-on: https://chromium-review.googlesource.com/744401 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#515444}
-
Patti authored
Extract the BackgroundColorHoverButton from the ProfileChooserView and turn it into a standalone View which is compliant with the Harmony spec. This prepares the HoverButton to be used in the Harmony Page Info bubble view. Notable changes include the blue background changing to a gray one, and some padding changes. Screenshot - https://drive.google.com/open?id=1z97-fEe9LTw0BCBpIMZj9-ft34UYXMGa Bug: 535074 Change-Id: Idd964d17868a7057d5c18b1b96c6d150b7a6d866 Reviewed-on: https://chromium-review.googlesource.com/730031 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#515443}
-
Gregory Chatzinoff authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I11e058b4dbb86a547ffbb7d96fd5c11286ec80d2 Reviewed-on: https://chromium-review.googlesource.com/759141Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
-
