- 03 Jan, 2020 40 commits
-
-
Emily Stark authored
When a page runs active mixed content (or an active resource loaded with a certificate error), the origin's host is marked in SSLHostStateDelegate. The SSLHostStateDelegate is then queried to set mixed content flags on the NavigationEntry, which feeds into the SecurityLevel of the page. Before this CL, the host of the NavigationEntry's URL was being used to query SSLHostStateDelegate, but this means that mixed content flags weren't being set correctly for pages where the URL didn't match the actual origin (for example, about:blank). This CL changes SSLManager to query SSLHostStateDelegate with the committed origin of the root FrameNavigationEntry instead of the URL. As noted in the test in this CL, mixed content is still not being tracked properly for the initial about:blank navigation in a window or frame. That is tracked in https://crbug.com/1038765. This change creates a slightly weird UI; when an about:blank page is marked with active mixed content, the "about:" part is crossed-out (as seen in https://crbug.com/526218). A follow-up CL will fix that by only striking-through https:// schemes in the omnibox. Bug: 609527 Change-Id: Ia0f13290a5769006edea3719642a11faefe9ae8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986189 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#728294}
-
James Cook authored
The "desc" attribute is not sufficient to provide context to the translators because identical strings will be collapsed in the translation console. Add additional string constants, eliminate the shared "toggleOn" and "toggleOff" strings, and provide the "meaning" attribute in the GRD file to disambiguate. See bugs for details, or https://www.chromium.org/developers/design-documents/ui-localization Bug: 1031145 Bug: b/145301624 Change-Id: I3daf288f5a8a0dbf9ebd65575e7ff77144880ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986862Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#728293}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6e6c3a30e17..8bade6c45870 Created with: gclient setdep -r src-internal@8bade6c45870 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Icd18adbd3b13720a9d2ad7424d35c9f07a4f2cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986610Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728292}
-
Bence Béky authored
This reduces duplicate code. The only side effect is that now packets built by MakeAckPacket() are saved in |saved_frames_|, but they are in fact never retransmitted. Change-Id: If6301deea0da015600f76b794478c21372f872c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982790 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#728291}
-
Eric Orth authored
DoH probes are run using a runner object, similar to the main DnsTransaction interface. This importantly allows creating multiple concurrent runs of the probes with different URLRequestContexts, and it allows independently cancelling those runs. Failure and available-DoH-server tracking are both still global, rather than tracked per-context, as until upcoming CLs spreading the new capabilities to more levels, probes are still only run for the primary context. Bug: 1022059 Change-Id: I1a20a31f9670da805652f1791fc4fbce0c27652d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984313 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#728290}
-
Regan Hsu authored
Currently, there is an extra "Learn More" in the browser language settings. This error was introduced when replacing "Learn More" links with settings-localized-link in os settings. Since browser settings is not using the settings-localized-link element, but shares the same strings used by os settings, a new string that does not contain "Learn More" in the sentence must be introduced. Fixed: 1038878 Change-Id: Ib450994561e9ea9908543c60377448120361a6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984377Reviewed-by:
-
Moe Ahmadi authored
before: https://screenshot.googleplex.com/M5ENgtHmDrF after: https://screenshot.googleplex.com/tgrmVBKYGjO Bug: 1030911 Change-Id: Ida41a52d1b2e305ae467a1f83452cfd084b26c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979148 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728288}
-
Piotr Bialecki authored
Clean up and changes required to bring in WPT tests for hit test API. - minor clean up in webxr-test.js - store input_sources_ in a map, add 2 setter methods since the mojo properties were renamed but keep the old setters for back-compat - add webxr_test_constants_fake_world.js with logic to create a valid FakeXRWorld with given dimensions and a constant VALID_FAKE_WORLD - move transform-related asserts to webxr_test_asserts.js, change all variables storing the assert functions to `const`, add semicolons - add `DVLOG(3)`s in XRHitTestSource and XRSession Changes: Change-Id: I98ac5ed09cda877afb24e28df09ee4cd818d56f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986326 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#728287}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ccd45a5efe06..dfde190ab0ed git log ccd45a5efe06..dfde190ab0ed --date=short --first-parent --format='%ad %ae %s' 2020-01-03 benjaminwagner@google.com [infra] Upgrade Win to 2019 2020-01-03 egdaniel@google.com Updated proxy isProtected to return a GrProtected enum. 2020-01-03 mtklein@google.com remove almost all Release ASAN bots 2020-01-03 brianosman@google.com split CPU BonusConfigs SAN bots out explicitly 2020-01-03 ethannicholas@google.com SkSL description methods are now only present in debug mode Created with: gclient setdep -r src/third_party/skia@dfde190ab0ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I0078d89cf6cc5e2501239cdcb151aeee7baafa2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986609Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728286}
-
Joshua Bell authored
Events dispatched via dispatchEvent() in script should not trigger side effects in Indexed DB objects. For untrusted events, propagate correctly but otherwise early-exit from the dispatch functions. Bug: 1032890 Change-Id: If4057ad2820419ef363e8e5f21670b3565946388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983272 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#728285}
-
Samuel Huang authored
Also allow output to be optional again (output written to console, but without SRCDIR modification). Bug: 979886 Change-Id: Ia1e77ec8e73b0be44e3f1f84de4559ad233b169e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986853 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728284}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/de97fb4ac4c6..81ee4d29192d git log de97fb4ac4c6..81ee4d29192d --date=short --first-parent --format='%ad %ae %s' 2020-01-03 shrekshao@google.com Workaround EXT_texture_norm16 for OpenGL ES drivers Created with: gclient setdep -r src/third_party/angle@81ee4d29192d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1000354 Tbr: courtneygo@google.com Change-Id: Ifc921d860865b2f832a277e64dc73107c5b3b2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986895Reviewed-by:
-
Bence Béky authored
Use NoopDecoderStreamErrorDelegate and NoopQpackStreamSenderDelegate implementations from test_tools instead of defining new ones. There is no need to crash on decoder stream errors or encoder stream data, because |qpack_encoder_| is set up not to use the dynamic table and no decoder stream data is fed to it. Also add const qualifier to four methods. Change-Id: Ibd103f3598458f2369e4ff7ce37b3855bfeabfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986259 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
-
Peter Boström authored
Replaces GetToolbarActionViewForId with GetExtensionsToolbarContainer to be used directly (with GetViewForId). This is intended to be used to pop out and show bubbles which cannot be added to the ExtensionsContainer interface as it is defined outside of Views. This also implements GetDefaultExtensionDialogAnchorView inside WebAppFrameToolbarView and updates BrowserView::GetExtensionsContainer to work with ToolbarButtonProvider. These two combined fix a crash when uninstalling an extension inside a web-app window. Bug: chromium:1021905 Change-Id: I9b9d23adca85600212846fa0fdb8db9d43dcf6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986305Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728281}
-
Nicolás Peña Moreno authored
Currently, some tests work under the assumption that the height of the viewport is exactly 600px. While this is true for tests running on our bots, it's not true for tests running on WPT.fyi. Thus, this assumption is removed from those tests. Bug: 1036013 Change-Id: I34b057730e22bc208cbb958d179195445def8b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984678Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#728280}
-
Mason Freed authored
*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not *** revert this CL. Instead, please disable the offending test(s) and *** add them to the crbug.com/1035582 section of TestExpectations. I *** will then take care of them as I fix up the remainder of these *** tests. Feel free to cc me if you create a bug. Thanks. This CL enables the FormControlsRefresh flag by default on all Desktop platforms except Mac. The Mac release is tracked in crbug.com/1012108. Because many layout tests use form controls, including tests that are not directly testing form controls, this CL requires around 1200 tests to be rebaselined. The bug at [1] tracks the effort to re-baseline all of these tests and remove these new lines from TestExpectations. This will be done in pieces, to reduce the code review burden. The bug at [2] tracks cleaning up some of these tests eventually, as there are new tests (see [3]) that directly test the appearance of the new form controls, and those likely supersede many rebaselines in this CL. However, I would like to get this landed first, as it might require several Revert/Reland cycles to get landed for good, and then I can come back and do the cleanup. This CL deletes a handful of form control popup web_tests that are badly broken by this change, but are also superseded by new tests of the new popups. [1] https://crbug.com/1035582 [2] https://crbug.com/1034611 [3] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/virtual/controls-refresh/ Bug: 1012106, 1035582, 1034611 Change-Id: Ib499da1db0df480dc61efee8231718aee13f24a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967608Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#728279}
-
David Bokan authored
Since https://crrev.com/c/1980984 has decoupled latching from scroll animation state, we can now simply use the latched node for sending of scrollend and overscroll events to DOM. We simply require that the latched node be preserved past the GSE so that in the next commit we can pass it along for dispatching the scrollend event. This CL removes |scroll_animating_latched_element_id_| (which was actually unused since the previous CL) and |scroll_animating_overscroll_target_element_id_|. The latter was previously needed since ScrollAnimated would clear the latched node if an animation wasn't created (e.g. at the extent). Since the latch is now maintained, it can be used in its place. This CL renames |last_scroller_element_id_| to |last_latched_scroller_| and makes it match the |CurrentlyScrollingNode|, with the only exception being that it gets cleared only after the first commit after the CurrentlyScrollingNode is cleared. Bug: 940508 Change-Id: I2d0c63bd97c3bc1a9bd0158a08b3352b09bfb1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981195 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728278}
-
Moe Ahmadi authored
Bug: 1034997 Change-Id: If85a4399ecb99257e4733caba20dac70b5686488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985169 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Sophie Chang authored
This makes it easier to refactor CanApply for the URL-keyed hints. The new ShouldTargetNavigation in hints manager is temporary and will be removed once prediction manager is fully live. Bug: 1036490 Change-Id: I5855abc507ff1f12f9c392d234b9bfb71d9acb8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986250 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#728276}
-
Andrew Grieve authored
As per discussion: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/RcJgJdkNIdg/discussion Bug: 846432 Change-Id: I0d1abb42c79278d5edf03091a47fce03d5897c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984356 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#728275}
-
Quinten Yearsley authored
Bug: 1002702 Change-Id: I3100574c1c4a3677c710021d755e91f5db23a87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982686Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#728274}
-
Reilly Grant authored
This change updates //chrome/installer to explicitly choose between run-once callbacks and run-repeatedly callbacks. For the most part this is a no-op. In the case of CallbackWorkItem it has been modified to take separate callbacks for install and rollback tasks. Bug: 1007639 Change-Id: Id4475eec8ad34a057beb1a48442f7e03dc36c368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938042 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#728273}
-
Lijin Shen authored
The if check is too strict. Add some tests to prevent from regression. Bug: 1036645 Change-Id: I0902b74fcec616f9a563b1a746b6f7bd09153c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986199 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#728272}
-
Yusuf Sengul authored
Bug: 1036043 Change-Id: Ia80a822b886b030bc1d7bd6846b810c9e2c20193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977392 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#728271}
-
Xianzhu Wang authored
It had the following values: kWebScrollbarButtonsPlacementNone, kWebScrollbarButtonsPlacementSingle, kWebScrollbarButtonsPlacementDoubleStart, kWebScrollbarButtonsPlacementDoubleEnd, kWebScrollbarButtonsPlacementDoubleBoth. Now none of the platforms supports double buttons (i.e. two scrollbar buttons at one end of the scrollbar), so the last 3 values were not used. The first two values are used to check whether scrollbars should have buttons. This can be achieved with a simpler API (NativeThemeHasButtons() in this CL). Note that we still support double buttons in custom scrollbars which are used by web sites such as google spreadsheets. (TBR for trivial changes under content/common and third_party/blink/public) TBR=dgozman@chromium.org Change-Id: Iff4d22ec667affb91cb1a98871b7bd3707d5b099 Bug: 1009063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966987 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728270}
-
Boris Sazonov authored
Adds an assert to verify that sign-in is allowed before starting it. To fix tests broken by this assert, this CL also adds an explicit ExternalAuthUtils param to SigninManager. This is necessary for the upcoming removal of AccountIdProvider.canBeUsed. Bug: 914920 Change-Id: Ib2ddd446446539fc45534818d30b5e6dab4fef73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985006Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#728269}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7426a76a4d80..a6e6c3a30e17 Created with: gclient setdep -r src-internal@a6e6c3a30e17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I33fdc0ac545f429409f387e7fe41af774bf5c562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986335Reviewed-by:
-
Reilly Grant authored
This change updates the base::Callbacks and calls to base::Bind() in //google_apis/gcm to explicitly choose betwenn call-once and call-repeatedly semantics. Bug: 1007790 Change-Id: I1f253bd17bca0e5e9975eab429d7a377ced0f962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939891 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#728267}
-
Josh Simmons authored
Bug: 1030813 Change-Id: I9bc146a28099334ebb1c87e4dce5b65795a8a892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986255 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#728266}
-
Chris Harrelson authored
1. It is no longer possible to cause recursion in RestoreScrollPositionAndViewState, so delete code that protects against that. 2. Remove now-unused parameter. Refactor CL: https://chromium-review.googlesource.com/c/chromium/src/+/1981806 Change-Id: I93d99d1a301f97303186459949963c1da11144d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982788Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
-
kylechar authored
Move DrmOverlayManager and DrmOverlayCandidates out of common and into gpu since they are no longer used by host code. Also finish cleanup in a few places missed in the previous CL. Bug: 936425 Change-Id: I61530dccf431150576c88f6bba1fb52eb37d5e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986850 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#728264}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I32361158eb74da2d004ad31d02bfaf1f6a5a2127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986858Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#728263}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/71b51fa69ee9..430f61e2a241 git log 71b51fa69ee9..430f61e2a241 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 jalyn@microsoft.com Prevent unhandled exception in ModelBreakpoint 2020-01-03 Rob.Paveza@microsoft.com Silent failure in _innerStyleSheetChanged Created with: gclient setdep -r src/third_party/devtools-frontend/src@430f61e2a241 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1019538 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6136d9bff6271eea2b61501085da10bf7b27f1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986897Reviewed-by:
-
Vladimir Levin authored
This patch does two things: 1. Removes the display locking fuzzer, since its dictionary is testing a now non-existent javascript api. It is also seems to be leaky (see referenced bug as an example) 2. Adds render-subtree keywords to the css fuzzer's dictionary, so that that fuzzer exercises the render-subtree code. R=chrishtr@chromium.org, rakina@chromium.org Bug: 1031946 Change-Id: Ic21b353a38d651c42e9179806f71670ae5e72e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986887Reviewed-by:
-
Sadrul Habib Chowdhury authored
FrameMetrics and related code in ui/latency/ have remain unused for a while. So remove them from the tree. We can bring them back if/when we need to. BUG=790761 Change-Id: Ifc1f6db447cd2e7c5be752b4054cffdb700d0628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984718 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#728260}
-
Reilly Grant authored
This change updates //chrome/attestation to use base::OnceCallback rather than base::Callback (and base::Bind/Closure). To do so AttestationFlow has been refactored to no longer bind the completion callback into multiple callbacks and the control flow is now much more linear. Functionality is unaffected. Bug: 1007652 Change-Id: I11e449cc508ea33f997edd865250cabf23664c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935174 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728259}
-
Clark DuVall authored
This should help figuring out where the duplicate IDs are coming from. Bug: 996940 Change-Id: I3e3611e83ed563cf883729f307bbe2b66ac6b74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977186Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#728258}
-
shrekshao authored
Fix the issue where requesting GL_WEBGL_multi_draw_instanced_base_vertex_base_instance returns null when GL_WEBGL_multi_draw is first requested on passthrough. TBR=kbr@chromium.org Bug: 891861 Change-Id: Ib9c15787c8eef79c71d71386a3e1ac4add1f92d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986124Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#728257}
-
Tarun Bansal authored
Make it possible to configure loading predictor table size using field trials. The next step is to experiment with different sizes. Change-Id: I607f83e0ca557466d434143fa1894900a135cf7d Bug: 1038703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984253Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#728256}
-
John Palmer authored
Change-Id: I8efa1dce401bd3088972a58881c7ff1eeed68fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986466 Auto-Submit: John Palmer <jopalmer@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#728255}
-
