- 23 Aug, 2019 40 commits
-
-
Alex Cooper authored
TBR=grt@chromium.org Change-Id: I7ccc19d5cf5d4956b534f7ca3ebd72bf3cb68b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769043Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#689973}
-
Joe DeBlasio authored
This CL mostly reverts crrev/c/1717191, but includes updated strings. The interstitial now looks like this: https://storage.cloud.google.com/chromium-translation-screenshots/a0e10eb89867355fc98c930e468397e8dadf4f17 Bug: 996794 Change-Id: Ib5b85f16184bab7cbad955d07a75b648b6f34b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765661 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#689972}
-
Tomasz Wiszkowski authored
Add metric counting how frequently - and what kind of suggestions our users delete. Bug: 991430 Change-Id: Iea6a65e08829149ac8607cfaee84e2c7652f9eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746759Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#689971}
-
Darin Fisher authored
This is in preparation for fixing bug 989458. The main change is to make the dependencies between the various files no longer circular. This makes the code and state transitions a bit easier to follow. A bunch of types are extracted out of webrtc_logging_handler_host.h and into webrtc_log_uploader.h. This makes WebRtcLoggingHandlerHost more cleanly the "frontend" part of the logging system, and WebRtcLogUploader and its associated types as the lowest level "backend" part. WebRtcLogBuffer is extracted out into its own header file since it is needed at various levels and from places that don't need to depend on webrtc_log_uploader.h. Also cleans up some stale comments about code running on the IO thread that now only runs on the UI thread. Simplifies StartRtcDump method and hides WeakPtr capability of WebRtcLoggingHandlerHost. Cleans up a few other random small things. Bug: 989458 Change-Id: I997c04d535114801029f077357e975c95b0bd7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762465 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689970}
-
Jonah Chin authored
Due to using the actual constructed layoutObject font (which already has zoom applied) for font-sizes measured in ex and ch, we end up applying zoom twice. This problem was specific to the use of ex and ch measurements on fonts, and not on other html components. This patch involves factoring out a single zoom where ex and ch sizing is applied to a font. Bug: 408777 Change-Id: If9ae7e9efcca472ca7518b7c7d62537e6842bac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752935 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#689969}
-
Dana Fried authored
Label text was previously middle-aligned even in the multiline case, despite our text renderer being able to render all vertical alignments. This caused hover card titles to animate vertically and be cut off strangely during transitions between tabs with different numbers of title lines. This CL adds the ability to support vertical alignment for multiline labels, and then aligns the title label on the hover card to ALIGN_TOP so that during transitions from a hover card with one line to one with two title lines results in the first line of the title staying in place while the bottom line is revealed during the animation, which is far more visually pleasing. Because RenderText does not yet support vertical alignment for single- line text, DCHECK guards have been added (as they were previously added to prevent incompatibility between multiline and elision mode) and also TODO reminders to extend functionality to single-line in the future. Bug: 984963, 996905 Change-Id: Ibd2ef6a3c8502a272654b673f83893e06ac5fb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764942 Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#689968}
-
Dana Fried authored
This was a visual bug with the new tab previews system active - a card could continue to update as it was animating away from a tab, causing it to become stuck on the old tab. Bug: 996820 Change-Id: If0023dd1eaa275ed9660aa36eaad3cc2389f834f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766003 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#689967}
-
Andres Medina authored
The script default behavior changes with this patch. The script will now use the clang revision defined in //tools/clang/scripts/update.py instead of ToT if no extra parameters are passed. Also, script now provides a "revision" flag in case the user wants to use a particular clang revision. Bug: 996873 Test: Manual build. Change-Id: I5e196782b84dc8d461e1c0daa33582b977563b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766007Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andres Medina <medinaandres@chromium.org> Cr-Commit-Position: refs/heads/master@{#689966}
-
Jinsuk Kim authored
This CL extends the experiment milestone to M80. Bug: 937946 Change-Id: If91159b3c490a3cad9440008aae9dcfd04150993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767461Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#689965}
-
Friedrich Horschig authored
This CL replaces only the credit card icons for Android with versions without gray borderline. Only the credit card settings are immediately affected — all other instances seem to use images from the native side. The larger goal is to have nicer icons in autofill chips and fallback sheets in the keyboard accessory. Bug: 985318 Change-Id: I4c140233f13ce68acc3b72af105f16b73233f421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730916 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#689964}
-
Avi Drissman authored
This used to fail on non-Google Chrome builds due to the use of custom resource rules, but we don’t do that any more. Adjust defaults. BUG=none Change-Id: Ic9e0b110fdcb47feb8878be35feb60f326556789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762759Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689963}
-
Brian Geffon authored
BUG=chromium:993569 Change-Id: Ib6725b6dc708882a67132973d20db8240e5ad489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765331Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#689962}
-
Gaoping Huang authored
This CL contains the graph model that tracks the events fired from WebAudio backend. A follow-up CL will be uploaded soon to use `dagre` to layout the graph model. A relevant CL is uploaded to add `dagre` as a front_end module: https://chromium-review.googlesource.com/c/chromium/src/+/1749643 Bug: 974343 Change-Id: Ie276e593e3b35c12d898677993c994256fc0df41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753704Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689961}
-
Egor Pasko authored
Re-enabling the test after mitigation landed (crrev.com/689916). Bug: 990551 Change-Id: I657cd9088191ebe22b7fa918b4b44b3ed3567ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768525Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#689960}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/222a4fb01b0a..b6e0bc79fa4e Created with: gclient setdep -r src-internal@b6e0bc79fa4e The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I60ac119b943f62995a9c1a84a306d17d0025e5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769029Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689959}
-
Yasmin authored
Before: https://screenshot.googleplex.com/8JxHd0a026T After: https://screenshot.googleplex.com/S5TARg9MT8t Bug: 994703 Change-Id: I5f6905cb5730c8f35bb997ec0114d6df36b90c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763766 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#689958}
-
Lijin Shen authored
Currently, incognito bg color is identical to tab switcher bg color. This CL tries to update tab switcher bg color to match the latest color matrics. Bug: 985064 Change-Id: I2d64346fa91bbb4e034a98a9f929b676ff2a9af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767243Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#689957}
-
Yasmin authored
Bug: 988461 Change-Id: I820bca05f073ef379178d7cf17fbbb7efbaba4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764131Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/2b2ee71..952ccb9 952ccb9 CherryPick LocaleMatcher API in ICU Fuchsia also needs LocaleMatcher. https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=35401 Bug: v8:7051 Change-Id: I66c7b07b776962358fd4cbcd16b12d9626383ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766892Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689955}
-
John Abd-El-Malek authored
TBR=treib@chromium.org Change-Id: I1e3310dc4a689bb6f1fb862b2c3a03b575da2b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769046Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#689954}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/890a65b17d95..472c74c60ca2 git log 890a65b17d95..472c74c60ca2 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 syoussefi@chromium.org Translator: Allow tree validation in children of TCompiler Created with: gclient setdep -r src/third_party/angle@472c74c60ca2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: I63a7983e9b4c61c0c61582b0e499cb36e9691bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769019Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689953}
-
Alex Clarke authored
We had problems going on with test flakiness caused when ChromeTabbedActivity.setupCompositorContent runs earlier than it used to, typically before NewTabPage is constructed. This is problematic because the LayoutManager tries to hide the empty page when the NTP is created resulting in MainIntentActionType.SWITCH_TABS getting recorded. With the exception of MainIntentBehaviorMetricsIntegrationTest#testCreateNtp these seem to have gone away so I'm reverting the changes. Bug: 982081, 980587 Change-Id: I64809492ed8bfda932f9a93ff8e3329e61e57e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749189Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#689952}
-
Andrew Lee authored
Change-Id: I9524e0dc0eadeb51cf53c16d756bd4f641debf55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764932Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Cr-Commit-Position: refs/heads/master@{#689951}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/07489b86416c..e7aecaad3386 git log 07489b86416c..e7aecaad3386 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 primiano@google.com Merge "Minor refactoring to config protos" Created with: gclient setdep -r src/third_party/perfetto@e7aecaad3386 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ifbdb28f5f16fdf6d3720cabaf4095e734d980593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769024Reviewed-by:
-
Piotr Bialecki authored
Ship anchor information from ARCore side to blink. The data will be surfaced to the JavaScript side in subsequent CLs. Bug: 992029 Change-Id: Ica8a0d424c64c96d9d1c3679be07e5569bc6bd8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763876Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#689949}
-
Himanshu Jaju authored
The user could disable the default dialer app which would cause chrome to crash since no activity can be resolved for dial intent Bug: 996644 Change-Id: If410e7b8ff491fc6321f23414ff8007ebb77f6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768760Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
-
Ben Mason authored
Fixed: I have disabled building of the system image in next-* builds so there should no longer be an issue. next-* builds can be re-enabled when bundletool is updated. This reverts commit 7c77403d. Original change's description: > Revert "Enable dist fusing for all feature modules." > > This reverts commit 27ca1df7. > > Reason for revert: This CL causes an official build failure > https://crbug.com/996658 > > Original change's description: > > Enable dist fusing for all feature modules. > > > > Change-Id: I66848fec159450a6d531e0af3f867988aa8b148f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763431 > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > Commit-Queue: Ben Mason <benmason@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689075} > > TBR=tiborg@chromium.org,benmason@chromium.org > > Change-Id: Ib696df42847a54c1257fae41ecb544df40f47e75 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764159 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689454} TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id4687e7980b238cdbea04a1c8921b57a974f7cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768946Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#689947}
-
Sigurdur Asgeirsson authored
Also use an empty match regexpr for maximal compliance with output. Bug: 996826 Change-Id: I8aaf27cc561752a6f202fed44b9f41f529b00aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768858Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689946}
-
James Cook authored
Specifically, assistant, IME, and cros_network_config headers. The forward headers are much smaller (best case, tens of thousands of lines smaller, considering all transitive includes). Also introduce TrayNetworkModelObserver as a separate class so that classes wanting to inherit the observer interface don't need to include the whole TrayNetworkModelState header (and its transitive cros_network_config.mojom.h includes). Bug: 996418,922875 Test: bots Change-Id: Ib1d28c0dfedcae91743e3367f4462726d37014b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764522 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689945}
-
François Beaufort authored
This is a no-op since [Exposed=Window] is the default for interfaces. It updates Blink's WebIDL to match the specification as modified in, https://github.com/w3c/picture-in-picture/pull/164 Change-Id: I8aafda2233dd2e39153721e813711aec9b43afe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767667 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#689944}
-
Mia Glaese authored
Bug: 982018 Change-Id: I28705cff7085007ece4a802e03409f95996c3103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745572 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#689943}
-
Miyoung Shin authored
This CL converts ServiceWorkerObjectAssociated{Ptr, PtrInfo, Request} and ServiceWorkerObjectHostAssociated{Ptr, PtrInfo} in content and blink to the new Mojo types, and uses pending_associated_remote<ServiceWorkerObjectHost> and pending_associated_receiver<ServiceWorkerObject> in service_worker_object.mojom. Bug: 955171, 978694 Change-Id: I112f4246eddb7b0ec3e3b1e1574962e95357b06c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765132Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#689942}
-
Aga Wronska authored
This aligns the code among all places where PAC is used to simplify the maintenance: * Lock screen - time limits * Login screen - time change * In session - timezone/time change To simplify testing of the ParentAccessWidget and reflect the way it works a few additional changes were made to the code: * The widget is not owned by LoginScreenController, to avoid adding additional helpers there. * Only one instance of the widget is created at a time - this reflects the fact that widget is modal and interaction with underlying objects is blocked * Make sure that the widget is destroyed when it is dismissed rather than tie its lifetime with LoginScreenController Bug: 991318, 972117 Test: LockContentsViewUnitTest + manually Change-Id: I392d12315204f1420871915ac6b6ccf9660aca66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762597 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#689941}
-
Nicolás Peña Moreno authored
The two tests that rely on http/tests/misc/resources/resource-timing-sizes-cors-preflight.js are incorrect because CORS preflights should not trigger new Resource Timing entries. This change reverts the changes made in 793f7c35 and fixes the tests. Bug: 982924 Change-Id: Ic656f9fc0cd6dadfa66d1176765696817bcec8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696525Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Becca Hughes authored
Mark off the record sessions as sensitive and stop them from being displayed on the lock screen. BUG=996779 Change-Id: I927ca5b4208f4d092bace9174d95e761d78559f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764900Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2255b34f..60eaabde Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie0a038a16741ed7ade6ddc89524f15c99dd752b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768781Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689938}
-
Alex Clarke authored
We are trying to prioritize loading and compositing tasks during early load but because Document::load_event_delay_timer_ is currently TaskType::kNetworking the load event ends up firing sooner than expected causing various web_tests to fail. Specifically its the relative order between different on* callbacks which is at issue. Most other callbacks use kDOMManipulation or kMediaEvent. Using kNetworking here means that we can fire it too early — using kDOMManipulation guarantees that (almost) all on*() callbacks will run in order. This change is correct per https://html.spec.whatwg.org/#delay-the-load-event which states: "Except where otherwise specified, the task source for the tasks mentioned in this section is the DOM manipulation task source." Bug: 971191 Change-Id: Id8b503a40582de6cd388be8dadc496242ac087c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765929 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689937}
-
Vladimir Levin authored
This patch ensures that we block visual overflow if the child paint is blocked. Otherwise, this can cause DCHECKs, when the visual overflow is needed for a child of a locked element. Specifically, in these cases paint is already clean. R=chrishtr@chromium.org Bug: 989939 Change-Id: I55c05a92564f4967efa542f38bce682ffa739606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766433Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689936}
-
Aga Wronska authored
Bug: 996966 Change-Id: I11dde55997ef1f8d4e9a0a31c999020b6a427bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767602Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Rayan Kanso authored
TBR=estevenson@chromium.org Bug: 996320 Change-Id: I4bfd39f0bce5942167f1756b75768413ac7a657f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765849 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
-
