- 25 Nov, 2019 40 commits
-
-
Antonio Gomes authored
... and RTCStatsResponseBase. It is also possible to merge RTCStatsResponse and RTCStatsResponseBase in a future step, once they are both solely used in renderer/modules/peerconnection. Today, there is still some code in renderer/platform using RTCStatsResponseBase. BUG=787254, 919392 R=guidou@chormium.org, haraken@chromium.org Change-Id: I788a81507447d990ca7d047d4a370f3bf8ec73d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930941 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#718607}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9f9b8c9c. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I08ce0cdebb5b33c66d1c3e999bfefde3ca8744b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933481Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718606}
-
sreejakshetty@chromium.org authored
- Add kBackForwardCacheMemoryControl feature which can be controlled via experiment. - Introduce "memory_threshold_for_back_forward_cache_in_mb" to control the factor via experiment. Bug: 1017090 Change-Id: I44d95da16f4023ea5b8ad890dd539784c74006c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875091Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#718605}
-
Colin Blundell authored
This class will shortly be supplied to blocking pages other than SSLBlockingPage (e.g., in supporting captive portals). Hence, make it visible. Bug: 1025059 Change-Id: I9713fd160774ef8903ff217c76594ec17e3a732e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932437Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718604}
-
Colin Blundell authored
This addition is necessary following https://chromium-review.googlesource.com/c/chromium/src/+/1926471; without it, weblayer_shell crashes at startup on Android due to not being able to find safe browsing Java files. Change-Id: I506f1f0c28304e963780829b3e6bf172ee03ca60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932798Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718603}
-
Tsuyoshi Horo authored
Bug: 1026147 Change-Id: I059799f7055c9eca1e6605838b061a7ca46c57cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930354Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718602}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b1393d70e91a..04e074d1aae0 git log b1393d70e91a..04e074d1aae0 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src 24347673152e..2b89fd4e2734 (1 commits) 2019-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 131a1ba8d06a..afc52b0b26d7 (7 commits) 2019-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 43fe7bafb14e..38b4db48f98c (4 commits) Created with: gclient setdep -r src/third_party/angle@04e074d1aae0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None,chromium:None Tbr: cwallez@google.com Change-Id: I3565f0db23e532857e917974bc340b12a252c9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718601}
-
Tim Schumann authored
This reverts commit 13ea1158. Reason for revert: Suspected to have broken the fuchsia-x64-dbg CI: instance: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg/3167 logs: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg [3236/8507] SOLINK ./lib/libpolicy_component.so FAILED: lib/libpolicy_component.so lib/libpolicy_component.so.TOC lib.unstripped/libpolicy_component.so python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --strip=../../buildtools/third_party/eu-strip/bin/eu-strip --sofile="./lib.unstripped/libpolicy_component.so" --tocfile="./lib/libpolicy_component.so.TOC" --output="./lib/libpolicy_component.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-soname="libpolicy_component.so" -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--color-diagnostics --target=x86_64-fuchsia -Wl,-z,stack-size=0x800000 -Wl,--no-as-needed -lfdio -Wl,--as-needed -m64 -Werror -nostdlib++ --sysroot=../../third_party/fuchsia-sdk/sdk/arch/x64/sysroot -L../../third_party/fuchsia-sdk/sdk/arch/x64/lib -o "./lib.unstripped/libpolicy_component.so" @"./lib/libpolicy_component.so.rsp" ld.lld: error: undefined symbol: MutableProfileOAuth2TokenServiceDelegate::MutableProfileOAuth2TokenServiceDelegate(SigninClient*, AccountTrackerService*, network::NetworkConnectionTracker*, scoped_refptr<TokenWebData>, signin::AccountConsistencyMethod, bool, base::RepeatingCallback<bool ()>) >>> referenced by profile_oauth2_token_service_builder.cc >>> obj/components/signin/internal/identity_manager/identity_manager/profile_oauth2_token_service_builder.o:(std::__Cr::__unique_if<MutableProfileOAuth2TokenServiceDelegate>::__unique_single std::__Cr::make_unique<MutableProfileOAuth2TokenServiceDelegate, SigninClient*&, AccountTrackerService*&, network::NetworkConnectionTracker*&, scoped_refptr<TokenWebData>&, signin::AccountConsistencyMethod&, bool&, base::RepeatingCallback<bool ()> >(SigninClient*&, AccountTrackerService*&, network::NetworkConnectionTracker*&, scoped_refptr<TokenWebData>&, signin::AccountConsistencyMethod&, bool&, base::RepeatingCallback<bool ()>&&)) clang: error: ld.lld command failed with exit code 1 (use -v to see invocation) Original change's description: > [signin] Do not build MultableProfileOAuth2TokenService delegate on ChromeOS and iOS > > Change-Id: I4ca19ca4996dc7caab44d75125040a20ae8e6649 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930818 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718589} TBR=droger@chromium.org,msarda@chromium.org,sinhak@chromium.org Change-Id: I4c8d779ce984ffb30f155423e50e6e59a44a71ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932366Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#718600}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/693bde6a69a2..ad9d72b765c5 git log 693bde6a69a2..ad9d72b765c5 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 almuthanna@google.com Cover find function and modify Karma reporting 2019-11-25 yangguo@chromium.org Roll js_protocol.pdl and css_properties.json5 from upstream Created with: gclient setdep -r src/third_party/devtools-frontend/src@ad9d72b765c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idb84a60c4720a301880f02366222335121a37659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934094Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbc3e409299b..5d1805321ee6 Created with: gclient setdep -r src-internal@5d1805321ee6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I26aea55abde58c879a61c8caff42f33f257c7a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934096Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718598}
-
David Roger authored
Fixed: 777774 Change-Id: I9abee0112f345ea4421c4f809588066f976fc645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929817 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#718597}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4a0fd75b105f..4a5ee9541e55 git log 4a0fd75b105f..4a5ee9541e55 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 lalitm@google.com Merge "trace_processor: migrate all slice/counter tests to use track instead of ref" Created with: gclient setdep -r src/third_party/perfetto@4a5ee9541e55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibe79cb744fc89c4737102118c6be96c3705a2ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934093Reviewed-by:
-
Mathias Carlen authored
Before this patch android specific build targets were not gated by the is_android build flag. In preparation of the autofill assistant extension api we need to be able to add autofill_assistant as deps to non android targets. This patch gates what's needed and exposes strings in the AA component so that it can properly build on non android platforms. R=arbesser@google.com Bug: b/143736397 Change-Id: Ic1c962fa795bd8cff3d043430fb2bf1f49165745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929223Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718595}
-
Ross McIlroy authored
BUG=chromium:1028072 Change-Id: Ic71c6d0ad1d764a6b10619d641a4c42e90e8c448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932780 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#718594}
-
Renato Silva authored
Changes the direction of arrows on Chrome OS OOBE for RTL languages. OOBE Back and Next buttons now show the expected direction. Tested locally. Bug: 1016376 Change-Id: I8a00e900f9b3c02c9bca69a8f98d9c8a72244dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929829Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#718593}
-
Tanja Gornak authored
Bug: 1023813 Change-Id: I45edd98889dc82693ad3ea0cb16f2bf2d2e95db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911746Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#718592}
-
Olya Kalitova authored
Adds additional build deps to policy_fuzzer target so it would pass check on includes. Initial description: Initializes DBusThreadManager and CommandLine needed as a part of a policy_fuzzer setup. Test: gn gen out/libfuzzer --check Bug: 1015318 Change-Id: Iac41303e096b7a5f9ad664f228f58c336a64eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930809Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#718591}
-
Morten Stenshorne authored
We currently don't let a break before a float affect the appeal of breaking inside their container. This is possible and fairly straight-forward to implement, at least for floats that don't participate in an inline formatting context. Also, since we're not hooking the floats up to the break appeal system at all yet, we won't see class A breakpoints between floats, or between a float and an in-flow block, which the spec actually requires. Will get back to this when inline formatting context float fragmentation is supported. Being as consistent as possible regardless of a float belonging to an inline formatting context or not seems like a good idea. Let's figure out what's feasible for inline formatting context floats first. Bug: 829028 Change-Id: Iccb22d91865ca6aad464c2ee12462843281643a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929825Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#718590}
-
David Roger authored
Change-Id: I4ca19ca4996dc7caab44d75125040a20ae8e6649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930818 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=skyostil@chromium.org Bug: 1023677 Change-Id: Id0eb2d63bf765a6f0b4a4e6add2a41964a8e4b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926870 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#718588}
-
Anton Bikineev authored
This speeds up stack scanning by ~2x (VisitStackRoots scope). Change-Id: Ic3eab8091f48950b7ebdfbaeffe348e8a7e537ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929054 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718587}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: Ibdc5739609f3507fe28753b7603d375f735b20a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929821Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718586}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I0f1dfb9fafe99d71dd45485d9f822acfaee489a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930897Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718585}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2cab5168..8f2a89dc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f436726e11c4ba2f99d9c1dbc1d076ce94d2a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933479Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718584}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4706026ed847..56b1f53bcd83 git log 4706026ed847..56b1f53bcd83 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 eseckler@chromium.org telemetry: Fix a TODO. Created with: gclient setdep -r src/third_party/catapult@56b1f53bcd83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I485516ec76cd558f154a2dcef747727054908317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934090Reviewed-by:
-
Alice Wang authored
This CL simplifis the class AnimationLooper and fixes the bug that the current version of AnimationLooper cannot be stopped when the user disables the animators on device. Bug: 1026602 Change-Id: I722cb8d41f47028aef4ae4cf9b5dcc5ee8b5791a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926469 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718582}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2ad66eccb5d5..31b01c053492 git log 2ad66eccb5d5..31b01c053492 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 saza@webrtc.org Fuzz APM float interface with up to 8 channels Created with: gclient setdep -r src/third_party/webrtc@31b01c053492 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5f8c4d1910f752aebf0531997593b4a16da64078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934091Reviewed-by:
-
Mikel Astiz authored
Prior to this patch, the two existing functions to build GUID-keyed maps were heavily coupled and there were fragile underlying assumptions that made it work (e.g. there were potentially entries in |guid_to_remote_node_map_| that didn't actually match any local GUID). Instead, let's centralize the matching logic into one single function, and adopt a unified map to represent the matches. This simplifies the code and enforces more strict invariants without the need for DCHECKs. Bug: 978430 Change-Id: Ieea0db8d43376e204b793dcc64b2dc84d521b289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929216 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#718580}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: Ibb7dafa9011c83fb40a268b7484984fe121cc934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929824Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718579}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I6300c4e09253c6d28cb48fcf05ac3697a5877516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930570Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718578}
-
Aya ElAttar authored
Moved the browsertests of safe browsing policies and content settings policies and all related stuff from policy_browsertests to separate files. Bug: 1002483 Change-Id: If7a659bb7256ef3593802bb12cc89735bd636cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929225 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718577}
-
Alex Danilo authored
Setting overflow-x:scroll forces a scroll bar to be shown. On the sub-menu, use overflow-x:auto always so the browser handles deciding when a scroll bar should be drawn. No new tests, covered by existing unit tests. Bug: 1001481 Change-Id: Icf84c0ea9a40b65383bcb7be23be84d2f0ee3a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933858Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718576}
-
David Roger authored
Dice migration is complete now. Bug: 777774 Change-Id: I3637199e6607db5a0f30e1760c66367e7a31eb9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928704 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: 975956 Change-Id: Ice65c1cabd5dab3ea8764a81dff137cb816b492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919141 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#718574}
-
Noel Gordon authored
The icon are currently drawn cut-off in the 16px item-icon box. Assume they have a 0 0 20 20 viewBox. Add that to their SVG and scale down to 16px x 16px (width x height) to center them in the .item-icon box. Bug: 1028050, 955920 hange-Id: I8da467fd33d5c526f73772b26480b9dd46ec9bf6 Change-Id: I8da467fd33d5c526f73772b26480b9dd46ec9bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934129Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL temporarliy disables web tests that will be impacted by the upcoming top-level await implementation in V8's REPL mode. There are two changes that require layout tests to be disabled: V8's implementation of top-level await: https://crrev.com/c/1900464. Removal of manual wrapping of async/await code in the DevTools fronted: https://crrev.com/c/1928927. Some of the web tests are disabled because V8 REPL mode *always* returns a promise, resulting in slightly different stack traces. These need to be rebaselined but are included in this CL to make reverts easier. Bug: chromium:1021921 Change-Id: If262b66b51168265f1582c9b5f5d85dcd92525ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930656Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#718572}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d493dead. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." 38d64f34 "Make DecompressionStream error checking stricter" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/trusted-types NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If771aac5a5706595aed87ef1085497a22b6bfe53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933476Reviewed-by:
-
Henrique Ferreiro authored
WebSandboxSupport::GetFallbackFontForCharacter() and MatchFontByPostscriptNameOrFullFontName(), FontCache::GetFontForCharacter(), gfx::GetFallbackFontForChar(), and CachedFont::GetFallbackFontForChar() were relying on returning an empty filename inside their FallbackFontData out parameter or return value in the case of failure. This CL changes them to explicitly return a boolean value. Change-Id: I4d81caa9bd3a173d7c37cd871c6a9373c56bc157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926136 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718570}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e9b68f332a30..b1393d70e91a git log e9b68f332a30..b1393d70e91a --date=short --no-merges --format='%ad %ae %s' 2019-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 45dde9ad6dde..85f3e93d13f3 (1 commits) Created with: gclient setdep -r src/third_party/angle@b1393d70e91a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: courtneygo@google.com Change-Id: Idddbb0876afe9fe564a3d3050dde5705ae69b049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934088Reviewed-by:
-
Michael Ershov authored
The test was marked as flaky more then a year ago. The bug from the TODO is fixed and closed. And I was not able to reproduce the problem localy and via several runs on test servers. Bug: 877416, 787602 Change-Id: Iae0d816c94dedbfb0db779a7b492e7619eba1939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926480Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#718568}
-
