- 17 Jul, 2019 18 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7438850501ca..fbb6af45481f Created with: gclient setdep -r src-internal@fbb6af45481f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=holte@google.com,shimazu@google.com,mohsen@google.com,pmarko@google.com,mamir@google.com Change-Id: I61b4af5b3438cde5a1c95eecf62adc5379124461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704981Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678056}
-
Jianfeng Wang authored
URLRequest job tracks the running total of raw network bytes that have been read for each request. This is useful when determining the total number of bytes that are still inflight. Refactor related APIs to export this information to NQE. Change-Id: I1209ca81429a22aa216c726c4381392d7f2e0e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688356Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Jianfeng Wang <jfwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#678055}
-
Melissa Zhang authored
Dividing the intent picker error metric between before and after picker shown. This allows us to better understand the error metrics to isolate where errors are occurring. BUG=983408 Test: Manual testing, unit_tests Change-Id: I25c0db3531cbe08ebf5df282a40ca3244e4d8eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701023Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#678054}
-
Clark DuVall authored
Failing on Mojo Android bot: https://ci.chromium.org/p/chromium/builders/ci/Mojo%20Android/17793 TBR=jam@chromium.org Bug: 984099 Change-Id: I5adec7f70ca1dfcf89472aecca46894916741dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705033 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#678053}
-
Jianfeng Wang authored
The number of in-flight requests can tell the observed queueing delay in the next few seconds. The higher count of in-flight requests would cause a high network queueing delay. Only tracks the peak values to eliminate the noises in the data. Adds methods to track the mapping between the peak number of in-flight requests to the peak observed queueing delay within a measurement period. Change-Id: Id7093ffe65ad6cb5f7a0d050a403040d4bda9fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700280 Commit-Queue: Jianfeng Wang <jfwang@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ffee6baa..4e0603c2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iccf41d57027e9ea1c8cd3b0d43066d39852715c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704358Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678051}
-
John Emau authored
Addressing axe-core failure of missing labels with ARIA technique ARIA17: Using grouping roles to identify related form controls. https://www.w3.org/TR/WCAG20-TECHS/ARIA17.html Without this change screen readers would not announce the group when a radio button received focus and would announce the radio placement order as if all radio buttons in the panel was one group, for example: "Desktop radio button checked 2 of 5" instead of ... "Device group, Desktop radio button checked 2 of 2" Screenshot (axe-core failures): https://i.imgur.com/INN9oaP.png Screenshot (Throttling accessibility tree): https://i.imgur.com/0TVwIG6.png Screenshot (Devices NVDA Speech Viewer): https://i.imgur.com/3iwpsig.png Screenshot (Throttling NVDA Speech Viewer): https://i.imgur.com/9JyueO7.png Bug: 963183 Change-Id: Ic36e507d816228248ac6671edbc72305d5fdab1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696356 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#678050}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/600a04528655..d57d3f905ac4 $ git log 600a04528..d57d3f905 --date=short --no-merges --format='%ad %ae %s' 2019-07-16 fkastenholz IETF CONNECTION CLOSE code is varint encoded 2019-07-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_check_connected_before_flush. 2019-07-15 bnc Use GetReadableRegion() instead of PeekRegion() in QuicReceiveControlStream::OnDataAvailable(). 2019-07-15 ianswett Deprecate rolled-back flag gfe2_reloadable_flag_quic_optimize_inflight_check in the false position because it will be replaced with IETF recovery's PTO. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I136174350a9afae833444074859ec0bafed7d405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704714 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#678049}
-
liberato@chromium.org authored
Change-Id: I1cfd32ce5b87468f9c05b41fbce89255b49a233d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703456 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#678048}
-
Tommy C. Li authored
Currently, the clock icon is very heavy-weight compared to the other omnibox iconography. That was not intended. This CL adds a revised (from Joel) icon that is more in-line with the other icons in the omnibox. Bug: 982852 Change-Id: I5fa73cfad2a89a52f322b1cef2680361d0c5baa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704949Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#678047}
-
Cici Ruan authored
There is wayland protocol error when unplugging the external display, because wl_output version is not correct. Bug: 961863 Test: Manual test by unplugging the external display. Wayland service does not reconnect due to protocol error. Change-Id: I9c2ec8c942f4d53a3e750a56f5a55458763561bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699507 Auto-Submit: Cici Ruan <cuicuiruan@google.com> Commit-Queue: Cici Ruan <cuicuiruan@google.com> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#678046}
-
Rose Garcia authored
Added text selection for editable text fields that works in most cases. Note that it does not yet support text selection in Google Docs/Sheets/etc or in the omnibox. Adding this feature includes adding selection start and selection end buttons to the Switch Access menu, calls to Automation API for selection functionalit, and use of the enable-experimental-accessibility-switch-access-text flag to hide the feature. Tested manually via emulating ChromeOS on Linux with the enable-experiemental-accessibility-switch-access and enable-experimental-accessibility-switch-access-text and checking functionality of selection in text fields. Bug: 982004 Change-Id: I32fa1b5d5a53b94e57d2a6a546d4946129429a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699340 Commit-Queue: Rose Garcia <rosalindag@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#678045}
-
Clark DuVall authored
We are in the process of migrating NavigationURLLoaderImpl to the UI thread, which includes migrating all throttles. This makes the safe_browsing::BrowserURLLoaderThrottle able to be created and run on either the UI or IO thread. The main changes are extracting an IOState class, which handles all calls to the safe browsing service on IO, and moving the checks for whether to create the throttle in MaybeCreate and ChromeContentBrowserClient into the throttle. This makes it so we can always create the throttle, and only check if it's needed once it runs. This will unblock migrating NavigationURLLoaderImpl to UI, and we can decide on whether more of safe browsing should be moved to UI in the future. Bug: 824843 Change-Id: I1ee6e36137caba1e392f8bd3bd828503234a79c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686354Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#678044}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8db1a75b2b3ac8b5b1f54e54428dad4dfea06f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704980Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678043}
-
Chris Palmer authored
Don't use a heading for emphasized text. Emphasize the parallel important things: fix time for critical, fix time for high. Add a missing "be". Bug: None TBR: awhalley Change-Id: Ib22ff318794c23e83737116d3fbb7b168ecf724d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696532Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Commit-Queue: Andrew Whalley <awhalley@chromium.org> Cr-Commit-Position: refs/heads/master@{#678042}
-
Matt Falkenhagen authored
For additional test coverage of this feature flag. Bug: 824840 Change-Id: I319a01a426803b178f41da613ecd3f7d2b6c9c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702528Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#678041}
-
Antonio Gomes authored
Driven by CL that paves the way to Onion souping media_stream_constraints_util_audio.cc. This effort is part of phase 4.6.3 in the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ BUG=704136 R=guidou@chromium.org Change-Id: I944851ad08fd2d8fa4d2e1d3550f4ebef7e81f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704361 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#678040}
-
John Lee authored
The mixin was only being used on the Extensions page; all other uses just use the --cr-primary-text-color variable. The line-height of 154% is already set on the body element of the Extensions page [1] so it does not need to be added. https://imgur.com/a/XsOb3jC [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/extensions/extensions.html?type=cs&q=extensions.html&sq=package:chromium&g=0&l=52 Bug: 973674 Change-Id: I7c4f5d22ae6d1a77227247cc5abf654246815f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703093Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#678039}
-
- 16 Jul, 2019 22 commits
-
-
John Emau authored
Because all dialogs already fit the definition of dialog modals and all use-cases of dialogs in the DevTools require a modal dialog. This meets success criteria for WCAG 1.3.1 Info and Relationships https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships See the Dialog (Modal) design pattern for reference https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal Bug: 963183 Change-Id: I9ebfeb8e54f51835351df32214512d8f5f88324b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703029Reviewed-by:
-
Bence Béky authored
Call max_inbound_header_list_size() instead of set_max_uncompressed_header_bytes() in QuicChromiumClientSession::Initialize(), and do so before calling QuicSpdyClientSessionBase::Initialize(). This sets the base class QuicSpdySession's max_uncompressed_header_bytes_ member, which then gets passed to set_max_uncompressed_header_bytes() in QuicSpdySession::Initialize(), making sure that SpdyFramerVisitor still gets the new limit. However, this also makes sure that the limit passed to QpackDecodedHeadersAccumulator constructor in QuicSpdySession::OnHeadersFrameStart() reflects the limit. Also update QuicTestPacketMaker to use the Chromium-specific limit, which is different from the one defined in QUICHE. Change-Id: Id36e7e4998dbf69a07ae390a9bf5d93a88079a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693401 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Paul Irish authored
Bug: 979126, 816849, 984743 Change-Id: I454cee9d75c24b4b703b8dd71cb83be4eff0fb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699018 Commit-Queue: Paul Irish <paulirish@chromium.org> Auto-Submit: Paul Irish <paulirish@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#678036}
-
Tarun Bansal authored
Move resource scheduler to a separate directory in //services/network. services/network/resource_scheduler/resource_scheduler.cc file has become too big and cumbersome with too many internal classes. The plan is to split the internal classes off to separate files. Having resource_scheduler in a separate directory would make that easier to manage. This CL does not make any functional changes. Change-Id: I3b26b5219b8dbe41b01185e901183cd32a7d8dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689786 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#678035}
-
Brian Sheedy authored
Adds an Incognito version of RequestSessionEntersVr. As a side effect, adds the ability for tests to override the Browser instance the test framework uses and a new macro so that it's easy to add Incognito variations of tests. Bug: 909942 Change-Id: If58a53185ed6d15bc4439477ea9bec3f6d13962c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703240Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#678034}
-
dpapad authored
Bug: None Change-Id: Ia53fd213cc5c97283844f1d173cd296b02557dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702901 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#678033}
-
Jack Steinberg authored
Updated the styling to reflect the changes to the explainer in PR https://github.com/jackbsteinberg/std-toast/pull/44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678032}
-
Robbie McElrath authored
Bug: 977415 Change-Id: Ib11e0fbda8e793d2b6b0bde093cfa4bb63f7325d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682559Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#678031}
-
Miguel Casas authored
This CL runs `git cl format media/mojo/services/gpu_mojo_media_client.cc` bc I have another CL that is bugging me all the time when `git cl upload`. No new code whatsoever is intended. Change-Id: Ic6ec995f93640dc67e3254aca06574e71caeed4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704363 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#678030}
-
Akihiro Ota authored
This change implements the AccessKeyAction method for SVG elements to make them clickable by assistive technologies. Bug: 958553 Change-Id: I604379586fe866e666216fe58b703c157457b27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691325 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678029}
-
Vikas Soni authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/1616526 changed the lifetime of SurfaceOwner which was incorrect and causing crashes. This is because VideoFrame can outlive the GpuChannel and hence SurfaceOwner shouldn't be destroyed when GpuChannel is gone since VideoFrame uses SurfaceOwner. Bug: 983595 Change-Id: I25cf066ae76920748a438cf51bd07399eaff3ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703482Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#678028}
-
Yi Gu authored
TBR=smcgruer@chromium.org Bug: None Change-Id: Ied5cf4ceea764577476f966a5af30abc85188d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704976Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678027}
-
Michael Liao (WPT) authored
Reason: - EmptyWidget elements should not be headers as they do not meet the criteria (https://www.w3.org/TR/WCAG20-TECHS/G141.html) - Marking a non-header as a header will impede SR accessibility for the affected tools Changes: - Replacing <h2> tag from UI.EmptyWidget with <div> - Removing <h2> tag from _showPreview(...) function with <div> in BackgroundServiceView.js (supposed to mimic UI.EmptyWidget element) - Adding 'empty-bold-text' css in emptyWidget.css that mimics <h2> styling and adding the class to the <div> tags to retain h2 styling Examples of UI.EmptyWidget use cases: https://imgur.com/a/qpJeB2Y BackgroundServiceView.js unique case: https://imgur.com/cAW8Nu0 Change-Id: Iff3356f12b3dd1906141de4cfe9980b7b1d9c929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693808Reviewed-by:
-
jonross authored
This is a follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/1696189 There a flag was added which prevents Android from using a timer to lock the Browser controls on-screen for a minimum amount of time. This change adds that flag for rendering stories which occur on mobile platforms. Bug: 896264 Change-Id: I5036ab039ab88a6b6e1acfb604f9e92290ccfc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699696Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#678025}
-
Ahmed Fakhry authored
In order to provide a better user experience, we allow cancelling drag-to-close and switch it to normal drag once the drag location enters the desks bar bounds. This way users won't have to drop the item first and start dragging again. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=972371#c3 BUG=866622, 972371 TEST=Manually, Added a new test. Change-Id: I9c5683ed04eff230633d09f81837c1db45883f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703544Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#678024}
-
Matt Simmons authored
This CL adds the following counts: 1. Tabs.TabCountOnStartScreenShown - Logs the number of open tabs (total) when triggering the return to chrome experiment. 2. Tabs.TabCountInSwitcher - Logs the number of open tabs any time the GridTabSwitcher is shown. 3. Tabs.IndependentTabCountInSwitcher - Logs the number of entries in the tab switcher where an entry is either a) an independent tab or b) a tab group. R=yusufo@chromium.org Bug: 979344 Change-Id: Ibdcb7d98efdd85abdc581f6629228c7ac82faffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699371 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#678023}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ef0633a4. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" 1e9c7b68 "[Client hints] Enable ACHL persistence in content shell, refactor tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic8d6da14ae3cefb0a9830d34d407027a63058313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704750Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678022}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ded8bf94b4c3..7438850501ca Created with: gclient setdep -r src-internal@7438850501ca The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=holte@google.com,shimazu@google.com,mohsen@google.com,pmarko@google.com,mamir@google.com Change-Id: I1a357026dc60102e519540f3ab8859616b490662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704753Reviewed-by:
-
Xing Liu authored
Deleted metrics: 1. Android.DownloadManager.NotificationLaunch: The relaunch happens for less than 0.0001%, this metric should be deleted, and we can consider to delete the mitigation for the flicker issue as well, since the occurrence is too low. 2. Android.DownloadManager.NotificationsCount.ForegroundDisabled: This is related to the feature flag, the feature is shipped. 3. Android.DownloadManager.NotificationsCount.ForegroundEnabled: Not actionable, we know users may have multiple download notifications. Other metrics are kept and is treated as important stability metrics. Bug: 975207,975228 Change-Id: I0f841c2e09aa475c8bd66da0ce4e8f0be12cd1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699096 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Matthew Mourgos authored
This will make it easier to change shelf height for dense shelf changes and other shelf changes moving forward. Bug: 973483 Change-Id: Ie4c062d7c9b84c4a97f2c58b66774fa1c48eb87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704856Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#678019}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/72988e40a45e..ef2b7a6d5aed git log 72988e40a45e..ef2b7a6d5aed --date=short --no-merges --format='%ad %ae %s' 2019-07-16 dneto@google.com Avoid C-style cast for constants definitions (#760) 2019-07-16 jbolz@nvidia.com SetBeforeHlslLegalization to use more relaxed validation rules (#676) Created with: gclient setdep -r src/third_party/shaderc/src@ef2b7a6d5aed The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Iad53571ec368a5d8218bd42408d0fad4fa6d7fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704751Reviewed-by:
-
Bret Sepulveda authored
In this patch, TabStripModel::AddWebContents(), which is already documented to alter the target index of a new tab in some cases, will now move a new tab to enforce contiguity in a group if the requested point of insertion would create a gap. Forked from crrev.com/c/1703291, since dfried@ is on vacation. Bug: 984112 Change-Id: I15224efc85c0565db7474cfd7dad7f0b4849cf9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704935 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#678017}
-
