- 05 Nov, 2018 40 commits
-
-
Eugene But authored
According to the code's comments (and caller's expectations), the method should return last committed URL instead of visible URL. "last committed URL" is URL of the page, while "visible URL" is the URL which should be displayed in the omnibox (one that the user has typed for example). Bug: 897506 Change-Id: I13148cc2dee62c707cbceebab0d8d19622f942b8 Reviewed-on: https://chromium-review.googlesource.com/c/1316427Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#605363}
-
Luke Zielinski authored
Maintain a set of resource IDs that should be kept because they are referred to by DOM elements that are being kept. This avoid trimming away resources that are shared between "kept" and "trimmed" DOM elements. Bug: b/118395372 Change-Id: I23489a400f4b9028daf3de50e78f403b816d6446 Reviewed-on: https://chromium-review.googlesource.com/c/1312934 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#605362}
-
Bo Liu authored
Found unused code while looking at code for tab reload after crash. Change-Id: I2073d7038f46df14a4c2bfbdce2ae3c22f175595 Reviewed-on: https://chromium-review.googlesource.com/c/1316358Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605361}
-
Luna Lu authored
This CL renames the following feature policy features: image-compression > unoptimized-images max-downscaling-image > oversized-images Change-Id: I4a4a8e96e4a422087a4ef51f57ff70bc5c3ac745 BUG: 899761, 889185 Change-Id: I4a4a8e96e4a422087a4ef51f57ff70bc5c3ac745 Reviewed-on: https://chromium-review.googlesource.com/c/1308533 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#605360}
-
Philip Rogers authored
This was originally added in an attempt to remove SMIL [1] but that is no longer being pursued. [1] https://chromium.googlesource.com/chromium/src/+/e1ddf6ccc2e25dd02b7e97cc861c8a87fb6eca47 TBR=wangxianzhu@chromium.org Change-Id: Ieb69c21e4848497b25890acac7a2c2125a70b075 Reviewed-on: https://chromium-review.googlesource.com/c/1313116 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#605359}
-
Henrik Boström authored
This CL adds test coverage for closing and garbage collecting peer connections while a setLocal/RemoteDescription's callback has been queued to fire. For more information see the CL that these tests were written for: https://chromium.googlesource.com/chromium/src.git/+/18cb7920ca96d7832ae9fd0276958069bd4ad11c Bug: 897251 Change-Id: Ia3abb09e15b4c4a051bed57f15811f93b44ecd68 Reviewed-on: https://chromium-review.googlesource.com/c/1309792 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#605358}
-
Nicolas Ouellet-payeur authored
As this is work-in-progress, it is behind a new feature flag. Users that are managed (e.g. because they have policies set) will have a message show up at the bottom of Chrome's App Menu. Clicking that message redirects to a help center article, describing how to find out whether your computer is managed. Bug: 893626 Change-Id: Ie073c2f5d21db235736bc3dcf51005a4123d59b0 Reviewed-on: https://chromium-review.googlesource.com/c/1297072Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#605357}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I7a7c5f4c56029da02a0d14c2351115cbdd7fbcc9 Reviewed-on: https://chromium-review.googlesource.com/c/1316101Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605356}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/534e77651190..0909331d958f git log 534e77651190..0909331d958f --date=short --no-merges --format='%ad %ae %s' 2018-11-05 reed@google.com add SkFontTypes.h 2018-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9911aca4f7c6..20622c0194bd (1 commits) 2018-11-05 fmalita@chromium.org [skjson] Unescape strings 2018-11-05 reed@google.com add SkFontPriv.h Created with: gclient setdep -r src/third_party/skia@0909331d958f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Ib8dd0ace665ca79b96945385ed5c9adacd26a0bd Reviewed-on: https://chromium-review.googlesource.com/c/1318052Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605355}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/48bcc1c45295..dd5c8ce56be8 git log 48bcc1c45295..dd5c8ce56be8 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 taylori@google.com Merge "Add signal events to t2t and trace processor" Created with: gclient setdep -r src/third_party/perfetto@dd5c8ce56be8 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I75c679ec2feeb688fefcc5a5e67dbe3b2a51a696 Reviewed-on: https://chromium-review.googlesource.com/c/1318129Reviewed-by:
-
Friedrich Horschig authored
The compositor viewholder relies on a layout change as signal that the keyboard might have changed its state. As the accessory doesn't emit this by default (because the activity remains of the same size), emit this signal when the keyboard would trigger it. Bug: 900510 Change-Id: I9f78661f9835b6d04b202ea8dbd02df77d402b54 Reviewed-on: https://chromium-review.googlesource.com/c/1317913Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#605353}
-
chrome://signin-internalsMihai Sardarescu authored
This CL prints the reason for invalid credentials in a human readable format (instead of an int). Bug: NONE Change-Id: Ie3d622e66638f5940534e89f83588ee545a6e840 Reviewed-on: https://chromium-review.googlesource.com/c/1316772 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#605352}
-
Joe Mason authored
This reverts commit c2c962cc. Reason for revert: The crash being debugged was fixed by https://chromium-review.googlesource.com/c/1310505 Original change's description: > [mojo-core] PCHECK for invalid process handles > > Changes a DCHECK to a PCHECK in an attempt to help sort out some crashes > we see in the wild where the broker process apparently receives handles > but doesn't attempt to duplicate them to itself. This should only be > possible if it doesn't know a valid handle for the remote (sending) > process, which points to potential application raciness in ownership of > the process handles passed into Mojo. > > Bug: 887576 > Change-Id: I1f8786af8170b7db03804a98125365eeb44fc598 > Reviewed-on: https://chromium-review.googlesource.com/1241197 > Commit-Queue: Ken Rockot <rockot@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593733} R=rockot@google.com,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 887576 Change-Id: Ic31379f9a85a20c8c47caccc185180768156eaa4 Reviewed-on: https://chromium-review.googlesource.com/c/1318069Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#605351}
-
Henrik Boström authored
Handlers exists in two flavors, WebRtcSetLocalDescriptionObserverHandler which is used for setLocalDescription(), and WebRtcSetRemoteDescriptionObserverHandler which is used for setRemoteDescription(). They have the same functionality but have to be different classes due to webrtc observer interfaces being different classes. Each handler can operate in two modes: surfacing transceiver states (includes senders and receivers) or only surfacing receiver states. Prior to this CL, only the "remote" handler and "receiver only" mode was tested. With this CL, all four combinations "(local/remote) x (transceivers/receivers)" are tested using parameterized gtests. This improves test coverage and unblocks testing that is needed to solve a bug related to surfacing transceivers (https://crbug.com/897251). Bug: 865006 Change-Id: Iaf40b498b0fef0978c4179c47118f6cff0bcdf66 Reviewed-on: https://chromium-review.googlesource.com/c/1309747 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Emily Hanley authored
This harness contains the APIs necessary for all press benchmarks, but they will remain separate benchmarks. There is just now common functionality that they can gain from this harness. This CL includes: 1) New press benchmark that enables both in test javascript metrics as well as tracing metrics 2) New press pages that implements the new measurement 3) Converted speedometer, speedometer2, and dromaeo benchmarks Bug: 714231 Change-Id: I487612d38f06ecd8a4c8905102972b134497d0c0 Reviewed-on: https://chromium-review.googlesource.com/c/1299739 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#605349}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60dcc070e823..0f6050fb228f Created with: gclient setdep -r src-internal@0f6050fb228f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8c95cee42fd0f61e3780efb103f11889cf7f5cbd Reviewed-on: https://chromium-review.googlesource.com/c/1318050Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605348}
-
Sam Maier authored
This is a reland of 0301a791 I don't think this would have caused a runtime chromeos error, since it's a build time android change. If it pops up again that I broke the test, I will investigate further. TBR=retry Original change's description: > Android: turning on bytecode checker > > This arg was defaulting to false when it should have defaulted to true. > > TBR=turning off bytecode checks for certain dirs > > Bug: 874854 > Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8 > Reviewed-on: https://chromium-review.googlesource.com/c/1309973 > Commit-Queue: Sam Maier <smaier@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605068} Bug: 874854 Change-Id: Idc95750d4465ca53b72db26a98ce74724fe21968 Reviewed-on: https://chromium-review.googlesource.com/c/1318071Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#605347}
-
gogerald authored
Bug: 806868 Change-Id: If457c8ddb194543a5b640bb35dc9025d4140ce99 Reviewed-on: https://chromium-review.googlesource.com/c/1312163Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#605346}
-
Ian Kilpatrick authored
This was two subtle bugs in one. 1) We need to copy back data to the ShapeOutsideInfo side data-structure, even if its an "intermediate" layout, (during the min/max pass). This was causing the incorrect size to be calculated for body, as it thought the shape was "empty" (its size was 0,0). Eventually this should be fixed by moving the shape to the layout result, removing this side data-structure. 2) The static-position for vertical-rl was broken. When accounting for flipped-blocks, we need to use the containing block writing-mode, instead of the direct parent. Static position doesn't really work cross writing modes in the existing layout system, so this isn't perfect, is closer to the old system. Bug: 635619 Change-Id: Ia7f8144cc1c9515b161bf3502c58fee66e59f3c3 Reviewed-on: https://chromium-review.googlesource.com/c/1315390 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#605345}
-
Andrew Grieve authored
Explicit registration is needed only when using the custom linker. Content shell doesn't use the custom linker, so has no need to jump through the extra hoops involved with explicit registration. Change motivated by JNI refactorings, which are made simpler by having fewer targets use manual JNI registration. Bug: 898261 Change-Id: Ia38529c1df92264781ba64235a7aea749ef0356a Reviewed-on: https://chromium-review.googlesource.com/c/1317338Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#605344}
-
James Cook authored
This will give us better protection against use-after-free. I don't think there are any performance concerns about this observer -- it is rarely added and removed. Bug: none Change-Id: Ia1aa911e219dbddde0e40b564a73ca66e34ace5c Reviewed-on: https://chromium-review.googlesource.com/c/1316647Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#605343}
-
Xianzhu Wang authored
SVGRootPainter has the following code: if (PixelSnappedSize(paint_offset).IsEmpty()) return; so when the size changes bigger from near-zero, we need to check the condition during paint. This requires us to repaint the containing layer even if the <svg> object itself paints nothing. Remove LayoutSVGRoot::PaintedOutputOfObjectHasNoEffectRegardlessOfSize (and use the inherited LayoutReplaced version which always returns false) so that we'll always invalidate paint of <svg> on size change even if the object itself paints nothing, as the code above can be treated as a paint effect. Bug: 899227 Change-Id: Icc83c352555c0ae183cdaf0bfb30c1ad99d6f428 Reviewed-on: https://chromium-review.googlesource.com/c/1317011 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: -
Tom McKee authored
We want to expose summary statistics over Memory.TabFootprint events downstream. By adding <aggregation> tags, the UKM infrastructure will know to include these events in the aggregation pipeline. Change-Id: I1fa09aa48fe328287e5c8b087d5406739c475260 Reviewed-on: https://chromium-review.googlesource.com/c/1314611Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#605341}
-
Stephen McGruer authored
These histograms will be used to guide the implementation of the CSS prefers-reduced-motion media feature. The primary goal is to compare usage levels across platforms. This CL starts with the two easiest platforms to measure - Windows and MacOS. Bug: 722548 Change-Id: I8643ec4df206e112f31943de0865b27775f72ce3 Reviewed-on: https://chromium-review.googlesource.com/c/1308104 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#605340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e71e9ef311ba..534e77651190 git log e71e9ef311ba..534e77651190 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 reed@google.com add pathops bench for simplify Created with: gclient setdep -r src/third_party/skia@534e77651190 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I3a602166c1350069663d16e1dc055cc467e801da Reviewed-on: https://chromium-review.googlesource.com/c/1317728Reviewed-by:
-
Daniel Bratell authored
gn has a function not_needed() intended to avoid "Variable is not used" errors in gni files. So far the code has used asserts for the same purpose but it is better to use the function intended for the purpose. Change-Id: I5ec7e50c4089b265e104aaede24d0e4e50452cef Reviewed-on: https://chromium-review.googlesource.com/c/1314588Reviewed-by:
-
Justin Cohen authored
Allows the incognito overlay to appear for system overlays like fullscreen videos. Bug: 847414 Change-Id: I0594535d0e2a1667c77faf01da88d502f19aa67f Reviewed-on: https://chromium-review.googlesource.com/c/1316598Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605337}
-
Alex Clarke authored
Locks are somewhat expensive, and it's possible to avoid the any_thread_lock_ when posting from the main thread. Bug: 897751 Change-Id: I229666b08e6bae89da817f4db4ddea1c10d294e4 Reviewed-on: https://chromium-review.googlesource.com/c/1317629 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605336}
-
Marc Treib authored
This is a minimal implementation that lets tests directly set all desired state. It's intended to eventually replace all the various TestSyncService implementations that many individual tests define. So far, it's used in SyncServiceUtilsTest only. Bug: 859874 Change-Id: Ic5aabce48790c6787c678c3aec8a81cb28634e65 Reviewed-on: https://chromium-review.googlesource.com/c/1314637Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#605335}
-
Leszek Swirski authored
Disable the script streaming task repost when the blocking and non-blocking pools merge flag is enabled. Eventually, we can hopefully remove this hack entirely. Bug: 874080 Change-Id: Ifcf82a4ef95d27cf99d4cbb106f8bed9bb6d7f21 Reviewed-on: https://chromium-review.googlesource.com/c/1293915 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#605334}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a1ead6f2ab75..26341990a1c3 git log a1ead6f2ab75..26341990a1c3 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 ilnik@webrtc.org Move MovingAverage to rtc_base/numerics and update it. Created with: gclient setdep -r src/third_party/webrtc@26341990a1c3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iec179bb8501e6d49cd3037ce61a2dfe74de2e353 Reviewed-on: https://chromium-review.googlesource.com/c/1317768Reviewed-by:
-
Jérôme Lebel authored
In Google services settings, when the user turns off History data type. "Activity and interactions" needs to be turned off and disabled. Adding an EarlGrey test. Bug: 883083 Change-Id: I2b82c513851b94468c671cec81a9a294579d8382 Reviewed-on: https://chromium-review.googlesource.com/c/1305954 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#605332}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c7000ce0e554..48bcc1c45295 git log c7000ce0e554..48bcc1c45295 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 lalitm@google.com Merge "trace_processor: further cleanup span join code" Created with: gclient setdep -r src/third_party/perfetto@48bcc1c45295 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I70f5d860ad8710477211bfc9e53c004e27678811 Reviewed-on: https://chromium-review.googlesource.com/c/1317727Reviewed-by:
-
Richard Knoll authored
This makes sure that the observer registrations are in the correct order. Bug: 901350 Change-Id: I57f45c7e605984928546d85386bdfb8e19f67352 Reviewed-on: https://chromium-review.googlesource.com/c/1314597Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605330}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f48282d63366..60dcc070e823 Created with: gclient setdep -r src-internal@60dcc070e823 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3a94d92bf404271e29ea35c6ef416032414e7e27 Reviewed-on: https://chromium-review.googlesource.com/c/1317767Reviewed-by:
-
Robert Flack authored
This patch implements a helper for defining Xmethods simply and example Xmethod implementations of useful functions on std::vector and std::unique_ptr which are normally inlined and cannot be invoked. This expediates debugging code, you don't have to remember which internal data members represent the vector contents or unique_ptr pointer value. For example, before: (rr) p ignore $1 = std::__1::unique_ptr<base::AutoReset<bool>> = 0x30f6a6b22ac0 => {scoped_variable_ = 0x30f6a6987880, original_value_ = false} (rr) p ignore.get() Cannot evaluate function -- may be inlined (rr) p *ignore Could not find operator*. (rr) p ignore->original_value_ Could not find operator->. (rr) p layers $2 = std::__1::vector (length=8, capacity=8) = {0x30f6a665a3a0} (rr) p layers.size() Cannot evaluate function -- may be inlined (rr) p layers[0] Could not find operator[]. After: (rr) p ignore $1 = std::__1::unique_ptr<base::AutoReset<bool>> = 0x30f6a6b22ac0 => {scoped_variable_ = 0x30f6a6987880, original_value_ = false} (rr) p ignore.get() $2 = (base::AutoReset<bool> *) 0x30f6a6b22ac0 (rr) p *ignore $3 = {scoped_variable_ = 0x30f6a6987880, original_value_ = false} (rr) p ignore->original_value_ $4 = false (rr) p layers $5 = std::__1::vector (length=8, capacity=8) = {0x30f6a665a3a0} (rr) p layers.size() $6 = 1 (rr) p layers[0] $7 = (cc::FakePictureLayerImpl *) 0x30f6a665a3a0 Bug: None Change-Id: Ia4b7495ca29568844d1e1c75ce6bcb3f1d8ba98e Reviewed-on: https://chromium-review.googlesource.com/c/1302697 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605328}
-
David Bokan authored
In https://crrev.com/9f54d240af5d366b1d6a4d9b84438192a9f0a11c we moved ScrollCustomization from using Elements to Node. This allows us to use Nodes in the scrolling code which is much more natural since the viewport scrolls using the LayoutView (document Node)'s scrollable area. The main change in this CL is letting the Document node be part of the scroll chain, instead of using the documentElement in its place. This removes some special-casing all the way through the scrolling pipeline. As a result the Global Root Scroller now sets the viewport scroll callback on the document node. Reland node: This relands the original patch with the fix reviewed in https://crrev.com/c/1302856. Originally landed patch is uploaded in Patchset 1 for easy comparison of changes. TBR=dcheng@chromium.org,kenrb@chromium.org,lfg@chromium.org Bug: 897288,899161 Change-Id: Ib6b61eb3a193877abb61f896a9d1de4747496514 Reviewed-on: https://chromium-review.googlesource.com/c/1307843 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605327}
-
Antonio Gomes authored
BUG=889867 Change-Id: I19a354a427ad67b8f1b8a5357b81f37dabdbb592 Reviewed-on: https://chromium-review.googlesource.com/c/1316934Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#605326}
-
Mike Klein authored
This is a reland of ea1a3ea1 TBR=fmalita@chromium.org Original change's description: > rebaseline SK_LEGACY_OP_COLOR_AS_BYTES > > This flag was repurposed... the real thing we're rebaselining > is https://skia-review.googlesource.com/c/skia/+/167264, which > affects situations with solid colors and unusual blend modes. > > Change-Id: I1da6486ca54d5f6c60bb0b04db05f6dc92487039 > Reviewed-on: https://chromium-review.googlesource.com/c/1316754 > Commit-Queue: Florin Malita <fmalita@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605216} Change-Id: Idefc08686ad0839f985b419b1ba3542e2741b763 Reviewed-on: https://chromium-review.googlesource.com/c/1316763 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#605325}
-
Antonio Gomes authored
BUG=889870,889869 Change-Id: I8cfb5456ec39e0846f5d6dc56bca8a1e73749137 Reviewed-on: https://chromium-review.googlesource.com/c/1316933Reviewed-by:
-
