- 20 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/38688fcdba24..cd74dfa47721 2020-10-20 kjlubick@google.com [canvaskit] Add test harness for running all gms and getting output 2020-10-20 kjlubick@google.com [canvaskit] Make gm test wrapper not omit known pngs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: If53043bb48d9d6e1f70bc424f6cb48806c44feb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818895}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/749daf949871..edbb06059588 2020-10-20 jleconte@google.com Fix query when alert is stored with an empty project_id. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1131908 Tbr: skyostil@google.com Change-Id: Ia5048f86116e975164dff80b0e3eb80e5847d184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487161Reviewed-by:
-
arthursonzogni authored
[android sheriff] Disable the test: NavigationControllerBrowserTest.EnsureFrameNavigationEntriesClearedOnMismatch It was previously disabled on Windows and ChromeOS, however it is flaky on every platforms: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVydgsSBUZsYWtlImtjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BOYXZpZ2F0aW9uQ29udHJvbGxlckJyb3dzZXJUZXN0LkVuc3VyZUZyYW1lTmF2aWdhdGlvbkVudHJpZXNDbGVhcmVkT25NaXNtYXRjaAw TBR=nasko@chromium.org Bug: 765107 Change-Id: Id91c115fe53813dba1efd78f9bf54667260bc7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485165 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818893}
-
Yi Gu authored
This patch adds metrics to record when a prompt is timeout due to unresponsiveness. Currently prompt timeout is not handled. This patch adds necessary functionality to address that issue. Note that it only records when a single pending origin is present to avoid over-counting. If multiple origins are pending in the queue we cannot handle the failed request on a particular origin due to the lack of origin information. This issue is tracked via crbug.com/1138454. Bug: 1127397 Change-Id: I6f888261ec5ea433521d914f2498d20f100cee6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427560Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818892}
-
Boris Sazonov authored
Removes subclassing of ChromeActivityTestRule in SyncTestRule. This subclassing meant that every test using SyncTestRule would start ChromeActivity before starting the test. This was producing several issues: 1. It's hard and confusing to use SyncTestRule in tests that start other activity types: FRE tests, bookmark tests, settings tests. 2. It makes tests longer. 3. It might make tests flaky. Some tests need ChromeActivity to be started, so this CL adds a bunch of explicit ChromeTabbedActivityTestRule fields along with calls to startMainActivityOnBlankPage. This CL also fixes and cleans up FirstRunTest. Tests will be enabled in a separate CL (in case they're still flaky). Bug: 616456, 1135990 Change-Id: I5a3d4a27f051cdfc4df2d4dc12a27899084b91db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450291 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#818891}
-
Alex Rudenko authored
Design doc: https://goo.gle/devtools-flex Bug: 1139945 Change-Id: I5506d17e453e2c36f632ebe580147882a1098d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485268Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#818890}
-
Leo Lai authored
Previously we only check if attestation service is prepared with default ACA. We change to the check against either default or test ACA because this is how cryptohome implements TpmIsAttestationPrepared. Also, we explicitly check the status code returned by attestation service to make the problem flow more robust for future-proof reason. Note that this change doesn't introduce any effective behavioral change; this is because attesataion service always prepares enrollment with both ACA types, and the enrollment preparation table is always empty if the returned status is bad. Admittedly it will become a waste CL right after we switch to platform side attestation flow, which we are aiming at in the near future, but it might be still worth doing it for better history reading in the future because only checking default ACA is confusing. BUG=b:158955123 TEST=build ok. Change-Id: I341c8fc68b476805d700b97cd2fb6afadd30ffba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466003 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#818889}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I873c301e9b2870ddafd2bc13c19629534d10a914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487140Reviewed-by:
-
Andrei Pascovici authored
As part of enabling the flag described in the bug, I realize now that certain Android builds of Chrome use the gn flags listed in Test: which are broken. Bug: 1136105 Test: gn gen //content/test:test_support --check --args='v8_use_external_startup_data=false symbol_level=1 is_component_build=false' actually works with this, broken w/o Relax Cast v8_use_external_startup_data req. In preparation for turning it off on certain platforms Bug: 1136105 Test: on affected device Change-Id: I8cb9f60f45d0d3d8cdbcdf44df10185522932475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483204Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Andrei Pascovici <apascovici@chromium.org> Cr-Commit-Position: refs/heads/master@{#818887}
-
Olga Sharonova authored
Reduce the frequency of dynamic memory allocations in MediaStreamComponent::AudioSourceProviderImpl::ProvideInput() which is running a on realtime audio thread. Bug: 1138927 Change-Id: I73853fd5dcd7e0ab4de42204e81c081d260a3413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485164 Commit-Queue: Olga Sharonova <olka@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#818886}
-
Roman Sorokin authored
This is a reland of 0c9cf96c Original change's description: > oobe a11y: Add a test to verify profile switch during user login. > > Profile switches between signin and user during the login. Accessibility > manager should correctly switch the profile. > > Also reeanbled OobeSpokenFeedbackTest on MSAN. It's already filtered out > by chromeos.msan.browser_tests.oobe_(positive|negative).filter files. > > Bug: 1108996 > Change-Id: Ic586f7172e26bd965c42a9a566005fd872a69697 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474696 > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817861} Bug: 1108996, 1139530 Change-Id: Iee0384a2293f7d62853c22201171b786f8857fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485218 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818885}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9a40f9a8. With Chromium commits locally applied on WPT: c31f15ed "WebMediaPlayerImpl: err if no A/V in ::OnMetadata" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I1ac2c790dc70034ebc7a86356868250f0ee05ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486882Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818884}
-
Elizabeth Popova authored
Street name & house number should be parsed only when both are present. Change-Id: I17f2352588302da5d3c925780e5f344f13c8f5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480567 Commit-Queue: Elizabeth Popova <lizapopova@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#818883}
-
https://reviews.llvm.org/D84362Hans Wennborg authored
Bug: 1140409 Change-Id: I4b0c55fa46c877d4f08c5ffca33af899ef20d2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485222 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#818882}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6f794f1dc5d..5f6b5e4dbaf5 2020-10-20 chinglinyu@google.com traced_probes ftrace: use /sys/kernel/tracing on all platforms. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:147789115 Tbr: perfetto-bugs@google.com Change-Id: I1eddf3fb9d6b992be718318d170fa75375d0487f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485888Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Id3c4b7f8267ab17ebb2e86845b795b93f9299c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485889Reviewed-by:
-
Mohamed Heikal authored
prints a message in diagnose_bloat.py to help users upload a oneoff for sharing. Also updates the oneoff message in libsupersize/console.py to use the new urls for the viewer. Change-Id: I92d16460826488b4a55a9bb56d9200264ab0b476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485772 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#818879}
-
arthursonzogni authored
MHTML document shouldn't be mixed with non MHTML document. This was previously weirdly-blocked by blink. This is now moved to the browser process where a basic error page is being displayed instead. [1/3] of: https://docs.google.com/document/d/13jcj_mATRxKakPEGy72YYHZBTBkkNrAHzaNIIjVsC8I/edit Bug: 1139283 Change-Id: I3618468fdcd2e1e3ba2f6d34cc7391a5a381f0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479365 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#818878}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d273ed0320fc..19640aa61b04 2020-10-20 mbonadei@webrtc.org Switch AppRTCMobile #import headers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2a261e1657396eddfeac1a10b3836b21143ce767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487060 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Corentin Wallez authored
Bug: dawn:445 Change-Id: I3b435dc158bba190b5499da428a1efe7433b4831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446229 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#818876}
-
mlcui authored
As of https://crrev.com/c/2459135, all implementations of the aforementioned function returns a constant true. Change-Id: I69629b16c39a5e759e66e685a9acc62d3796a583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485663 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Sami Kyostila authored
If a tracing session failed to start, stopping it shouldn't do anything either. Bug: 1139845 Change-Id: Ib68f787ff009d2c81fbd928a4cf625f290f65b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487101 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#818874}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I1760532f4659024c29da2b5d271ff7130e775c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485578Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#818873}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/feeda66ef207..2f2ee2383761 2020-10-20 changhaohan@chromium.org TypeScriptify inline_editor/SwatchPopoverHelper.js 2020-10-20 pfaffe@chromium.org Fix caching in emscripten download script If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib70daf90109120b8bd042de3961910104a65faab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485708Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9768e31..f36d15c8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5a3dfe4080f182bb5c5153fac5f747d14281dfa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485723Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818871}
-
Andy Paicu authored
This reverts commit 8bbcdd00. Reason for revert: Causes compilation failure on iOS https://ci.chromium.org/p/chromium/builders/ci/ios-device/170093? Original change's description: > Disabling PasswordsSettingsTestCase/testEditUsernameFails for device iOS > > The test fails iPad 6th on iOS 12.4. > > Bug: 1140400 > Change-Id: Ic4016aee1ad1444af112a4c1ceb34e7829533758 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485934 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Auto-Submit: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com> > Cr-Commit-Position: refs/heads/master@{#818868} TBR=jlebel@chromium.org,vsemeniuk@google.com Change-Id: Ie20ef9089f8da8ba7345ccc99391ea22233d0b5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485938Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818870}
-
Wez authored
Bug: b/171024731, 1140436 Change-Id: I74900eaa038090cb3ec816492d78df261a9f6332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479362 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#818869}
-
Jérôme Lebel authored
The test fails iPad 6th on iOS 12.4. Bug: 1140400 Change-Id: Ic4016aee1ad1444af112a4c1ceb34e7829533758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485934 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#818868}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b3199231953f..0b03fa00934a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1134209 Tbr: andypaicu@google.com Change-Id: I63cbd75d5a42ed5a49ac5dd7dd7a3ccc0b25f1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486819Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818867}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6848ad86bfff03c58aa33f90477df1de013d2286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486579Reviewed-by:
-
Denis Kuznetsov authored
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#comment-style Bug: None Change-Id: If445946f56871e7cf0e5750f3314df6a83a9e10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484659 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#818865}
-
Tim van der Lippe authored
They can be re-enabled as https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2475720 has landed. R=sigurds@chromium.org Bug: 1011811 Change-Id: I5089fa7a59c6f672e1f9db81563ae49f97a6737f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484427 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#818864}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5d9297643221..299fe92af960 2020-10-20 thestig@chromium.org Roll third_party/freetype/src/ 840ce58f9..80389cab7 (1 commit) 2020-10-20 thestig@chromium.org Roll third_party/freetype/src/ 20186d1be..840ce58f9 (14 commits) 2020-10-19 thestig@chromium.org Remove a strlen() call in CFX_FolderFontInfo::FindFont(). 2020-10-19 thestig@chromium.org Simplify CFX_FolderFontInfoTest initialization. 2020-10-19 nigi@chromium.org Improve font family name matching method. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135949 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I33e91a573012ee6c13a18354e7f0e3428ff7c123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487063Reviewed-by:
-
sandromaggi authored
This is a reland of cb51eef7 This changes the test such that the execution will be split up into several steps to avoid hitting the timeout on slower devices. Each text filling now has its own wait and check expectation. Bug: 1139935 Original change's description: > [Autofill Assistant] Add integration test for input actions > > This adds integration tests for our current input actions. > Once we start experimenting, these should ensure that we > are not breaking currently working behaviour. > > Bug: b/168107066 > Bug: b/169924567 > Change-Id: I141f4033e0080e8c99e0b1280e8521d2bc45e837 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484422 > Commit-Queue: Sandro Maggi <sandromaggi@google.com> > Reviewed-by: Luca Hunkeler <hluca@google.com> > Cr-Commit-Position: refs/heads/master@{#818409} Bug: b/168107066 Bug: b/169924567 Change-Id: I1374ada004f960cfa360982eaf5d5e428bb974a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485264Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#818862}
-
Andy Paicu authored
This reverts commit 772dfcc1. Reason for revert: Likely cause of Mac compile failures https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/16391? Original change's description: > Enable "gn check" for //third_party/blink/renderer/core > > Bug: 800764 > Change-Id: I54f490a37baee7f8e98198fa28794aa216f9f33c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469563 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818849} TBR=tkent@chromium.org,thomasanderson@chromium.org,mstensho@chromium.org Change-Id: I4318faf69a2568af92686da13c1a42c2834870b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485065Reviewed-by:
-
Andy Paicu authored
This reverts commit 3786076d. Reason for revert: Likely cause of Mac compilation failure https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/16391? Original change's description: > Enable "gn check" for //third_party/blink/renderer/core/typed_arrays > > Bug: 800764 > Change-Id: I7e09231307f6de1c5457150581438f590b43de85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484596 > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818852} TBR=haraken@chromium.org,tkent@chromium.org,thomasanderson@chromium.org,mstensho@chromium.org Change-Id: I81aaf215378e9827bcb2e63ce81f8ba695cd7732 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485221Reviewed-by:
-
Andy Paicu authored
This reverts commit 9d4eac47. Reason for revert: Likely cause of Mac compile failure https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/16391? Original change's description: > Enable "gn check" for //third_party/blink/renderer/core/probe > > Bug: 800764 > Change-Id: I60bf0ef4e620dfaec14486538886047534230309 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484597 > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818853} TBR=caseq@chromium.org,tkent@chromium.org,thomasanderson@chromium.org,mstensho@chromium.org Change-Id: I587fd1b4ff3fc1780688ccdc73b1a9829a643cdd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485935Reviewed-by:
-
Hazem Ashmawy authored
This is a reland of db9be6c9 The recent flakes are most probably caused by using of UIAutomator APIs to test the developer UI service notification and pressing home button in the tearDown of tests. This reland the CL after removing all UIAutomator code including the test for persistent notification. A separate reland of that test would be done later. Original change's description: > [AW][Dev-UI] Reland "Add some espresso tests for flag UI" > > This relands https://crbug.com/c/2438534 with a couple small changes: > > - android:windowSoftInputMode="adjustPan" attribute was missing in the > test manifest but is used in prod manifest. Adding it to the tests > manifest fixes the problem of auto-showing the keyboard on M devices > which was causing the test flakiness. When the keyboard shows up it > hides the view causing espresso to fail. > > - Merge the small change from https://crrev.com/c/2455687 to > test whether the overrideFlagsMap has the correct entries. > > Fixed: 1135839, 1130599 > Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" on android M emulator > Change-Id: I973e8cd2b7a9c12651d7a6e14f11a368f6e06bad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453564 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Hazem Ashmawy <hazems@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817184} Change-Id: I9089d7e8d9b61b46b412061715abbf981da03706 Bug: 1130599, 1135839 Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" --num_retries=0 --repeat=1000 --break-on-failure Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482142Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#818858}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f0dcaca2c2d8..0c84d564df9f 2020-10-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7501f245 to 72a62c65 (438 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ia09452c80e0e4986840f406c5ef33ac384bd0b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486984Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I506782a17bf29599e9b5cadb59cbd1564c7e1b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485706Reviewed-by:
-
