- 10 Jul, 2019 40 commits
-
-
Min Qin authored
The content setting is confusing as it is "allow multiple downloads". So in case an origin is blocked, we should still allow one download. This CL also fixes an issue that on user gesture, download status from other origins are reset although it should only reset the status on the current page. BUG=981966 Change-Id: I0519aa091446f2a2d81f4dcf074abf34849b9fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693552Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676121}
-
Vladislav Kaznacheev authored
The two tests (SelectionInsideScreen, HighlighterGesturesScaled) were disabled because they stopped working in Mash). SelectionInsideScreen is now passing reliably after Mash removal. HighlighterGesturesScaled required some changes to accommodate the new contract of highlighter selection callback (it is now passing a rectangle in dip instead of px). Bug: 917113 Test: automated Change-Id: I43a2dd9a28ce0efc2748cf208e9c04c470d89026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695657Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#676120}
-
Tommy Steimel authored
This CL updates the global media controls UI to show all media sessions instead of just the most recently active media session. Bug: 973492 Change-Id: Ib0943d4044ee3c036a1b783785695ebba09eb0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695989Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#676119}
-
David Bokan authored
This CL fixes Blink web tests so that they pass when the Fractional Scroll Offsets flag is enabled. This flag enables fractional offsets on the Blink main thread which breaks some tests because they assume that offsets will be floored. I've modernized two tests: fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html fast/events/scale-and-scroll-div.html The first appears to have been an issue with js-test modifying the page while the second was passing but the PASS string in the -exected.txt had changed to include the factional. Both tests now pass with and without the feature enabled. I removed fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html since it was testing the same thing as scale-and-scroll-div.html. The rest of the tests required changing the layout such that it doesn't cause us to land on fractional offsets (and thus the behavior will be unchanged with and without the flag). Where this was difficult I just allowed for approximate equality. Bug: 414283 Change-Id: Ie03fa06b100fb9946675e921357c1eaebfe6a37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690293 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#676118}
-
Luum Habtemariam authored
Originally rolled my own value mojom representation, but have since started maintaining the libCUPS ValueType separately, ergo rewrite. Bug: chromium:945409 Test: unittests still pass Change-Id: Ie8c2009f57b06930aa4d40e50b023aa71fa04e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672488 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#676117}
-
David Grogan authored
If a table is added dynamically as a child of a table cell, the cell might call innerTable->HasSections() before the inner table has calculated its sections. The cell was checking HasSections() because cells change sizing behavior when they have a table with sections as an immediate descendant. This only happened in a very narrow scenario -- when an abspos table with a %height that does not resolve as auto is dynamically added. Bug: 977507 Change-Id: I7856291dc6508624a81e9b65af909fa8a0d8e749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696003Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676116}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/808e9b88cf2e..5fcd7aab39b8 git log 808e9b88cf2e..5fcd7aab39b8 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 tsepez@chromium.org Zero-fill PatternValue::m_Comps 2019-07-10 nigi@chromium.org Add a pixel test for rendering overlapping thin lines. 2019-07-10 thestig@chromium.org Roll build/ 4cebfa34c..5a8b627ed (15 commits) 2019-07-10 thestig@chromium.org Make CLZWDecoder decode in a single pass. 2019-07-09 tsepez@chromium.org Rename GetNativeFont() to GetNaiveFontName() in several places. Created with: gclient setdep -r src/third_party/pdfium@5fcd7aab39b8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:982768 TBR=pdfium-deps-rolls@chromium.org Change-Id: I55d97846276e1c9aaebc903af67fccb64c201273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696201Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676115}
-
Natalie Chouinard authored
This change affects the "Addresses and more" Settings screen preferences. Modify the preference to pick up the themed preference context, rather than the base Activity context. This ensures that the same preference theme is used across device versions. Fixes a bug with excess padding on Android L & M on this settings screen introduced through support library migration. Bug: 980070 Change-Id: I379036773378d8432d70c6e4b27da463d89116f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684869Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#676114}
-
Brian Sheedy authored
Disables the multiple crash minidump test on Mac 10.12 Sierra. It is currently failing 100% of the time on this OS due to only getting the unsymbolized stack trace for the first crash. TBR=crouleau@chromium.org Bug: 634156 Change-Id: I0378b43cd88474156085def292ba35d13ce5680c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695656Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#676113}
-
Jun Cai authored
This is a follow-up CL from the comment at: https://chromium-review.googlesource.com/c/chromium/src/+/1665909/7/chrome/android/java/src/org/chromium/chrome/browser/DeviceItemAdapter.java#240 It looks like the ItemChooserDialog.setEnabled() function is only used in the test code, and is not used in any production code. This CL removes this function and related test code. Bug: None Change-Id: I935b9baf703cc2c6df5331842d91c48e53e65d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682870Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#676112}
-
Esmael El-Moslimany authored
Bug: 870763 Change-Id: Id5582daf0b9d67e3cbdc259a32863ede4bedc309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692340Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#676111}
-
Reilly Grant authored
This patch changes the ownership model of PlatformSensorProvider from a leaky singleton to something owned by the DeviceService instance. The motivating reason is that it means that we can create a new instance of PlatformSensorProvider for each test rather than having them be reused. This can cause various flaky test failures as demonstrated by the associated issue. To simplify this new ownership the PlatformSensorProvider is now used on the UI thread rather than the IO thread. As blocking calls are already posted to background task runners this change should have no practical effect. To prevent SensorImpl instances from leaking after the test exits (but before the Mojo connection errors are handled) they are now explicitly owned by the SensorProviderImpl that created them. This patch also fixes PlatformSensorAndProviderTestWin to use a base::ScopedCOMInitializer rather than calling CoInitialize manually. This removes another place where state leaked between tests. Bug: 939808 Change-Id: Id18926c4254c1a82310693750d84abe931e0f385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693763 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#676110}
-
Michael Thiessen authored
This reverts commit 2c8d5bfc. Reason for revert: Looks like this doesn't do what I hoped it would (The sites I was testing on weren't sufficient). var foo = window.open('foo.html); will set the target to "_blank" implicitly. Original change's description: > Add RuntimeEnabledFeature for retargeting _blank navigations to _top > > See bug for context. > > Notry=true > > Bug: 961035 > Change-Id: Icfb0b2e62dbe7a07321d5fefee4a8cbeec42451f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674677 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#673535} TBR=dcheng@chromium.org,mthiesse@chromium.org,clamy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 961035 Change-Id: I906713ed297ea8894650563db7036d6baf56112c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695697Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#676109}
-
Vladimir Levin authored
This patch ensures that when forcing a layout we force it all the way up to the local frame root, since the dimensions of the frame may have an effect on the properties of the queried element. R=chrishtr@chromium.org, rakina@chromium.org, szager@chromium.org Change-Id: I9cfdb38560e9cd75a45d87d9749c92cac0016a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695660Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676108}
-
Will Cassella authored
The CL uses the new 'conditional modules' feature to auto-install the VR DFM upon updating Chrome on supported devices. This should provide a much better experience when launching Chrome from the DDH for the first time on devices where the cost of having the VR DFM unused is minimal. Bug: 961796 Change-Id: I7fe1bf9ac06397fe37c1e9a099005f20d68aa267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668148Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#676107}
-
Katie D authored
The scroll bubble sticks near the menu bubble until the user explicitly changes the scroll bubble position. Per UX. Bug: 978163 Change-Id: Id3064be03c2b9fde84ca0a96a4fd4f50391a6503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691781 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#676106}
-
Jeffrey Cohen authored
In order to incorporate the last time a shared device was used in a more accepted UX pattern the target device list is being displayed as a Table View with the cells containing the target device's name last active time, and device type. The previous design utilized an action sheet, which does not afford the ability to display more stylized information per cell. Bug: 970284 Change-Id: I056be26ecfdc481fd5fecf447f2d1514981a843e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688442 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#676105}
-
Max Moroz authored
Change-Id: I9501361ac70d0f308446c851c8bc428bf6c8973e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692868Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676104}
-
Kevin Babbitt authored
1. Unref AtkStateSet and AtkRelationSet when we're finished with them. 2. For atk_table_get_column_description and _row_description, we're dynamically generating a value but the API appears to expect us to return a static string. For now I've scoped the existing LSAN disabling down to include just this spot since all remaining leaks are fixed. Bug: 568674 Change-Id: I7174312452ae118eacb706cd7e686bf8649a790f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688317 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#676103}
-
Lutz Justen authored
Adjusts Kerberos UI based on the mocks in go/cros-kerberos-ux, in particular: - Various string tweaks, in particular change wording in strings from 'Kerberos accounts' to 'Kerberos tickets'. - Shows 'Chrome OS' as expiry notification display source, not 'Kerberos ticket expiring'. - Adds a 'Learn more' link. - Changes RemoveAccount webui callback to asynchronous, showing toast 'Ticket removed' when done. - Displays ticket validity duration in account list UI. - Moves 'Kerberos tickets' to the end of the people page. - Shows management indicator next to 'Remove from this device' button. - Moves 'Active' indicator to the right and localizes it. - Uses 'Refresh' instead of 'Add' when refreshing an existing ticket. BUG=952232 TEST=Compare Kerberos UI with UX mocks, see go/cros-kerberos-test and go/cros-kerberos-ux. Change-Id: Iae8da57f9c94ab9e224bafcf8eea1f5350e3e9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684333 Auto-Submit: Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676102}
-
Andrew Grieve authored
Change-Id: I20d7316522446b934583fb23ff34f9212b0fb346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694090 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676101}
-
danakj authored
RenderViewHostImpl checks with SwappedOutMessages to receive IPCs. The list of allowed IPCs include some WidgetHostMsgs. However WidgetHostMsgs have a separate routing id that go to the RenderWidgetHostImpl, which does not use SwappedOutMessages and does not drop any IPCs. So the WidgetHostMsgs do not need to be listed in the SwappedOutMessages allow list, they do nothing there. R=creis@chromium.org TBR=presubmit is broken Bug: 419087, 745091 Change-Id: I7f19af25e97973da7b3d2c6508acb3058f21539e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693802 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#676100}
-
mark a. foltz authored
This converts the design document hosted on sites [1] to Markdown and makes a number of smaller fixes, including: - Line wrapping and fixing Markdown formatting - Updating links and contact information - Adding a document history - Removing sections that are no longer relevant and a few smaller edits to improve accuracy Some sections need more thorough editing or need to be rewritten entirely, and placeholder material inserted for other internal design docs (1-UA mode, Mirroring Service, etc.). Also several screenshots and diagrams need to be updated. All of these sections are marked with TODOs and will be addressed in future patches. Once this is landed the current document will be marked deprecated and a link added to this document. [1] https://www.chromium.org/developers/design-documents/media-router Change-Id: I328fcd0c2fdc2f3c00a909cc700468ee09d2a240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673858Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#676099}
-
Lukasz Anforowicz authored
Bug: 969970 Change-Id: Ie8246c1b02a056124f3e350e39a655451c24a85b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693127 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#676098}
-
danakj authored
This includes the Android CFI and android-asan bots. R=dpranke@chromium.org Bug: 961849 Change-Id: I9bf1faefd45016c9e72358b506837dff2b609b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692487Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#676097}
-
Manuel Rego Casasnovas authored
Multiple select elements with "contain: size" should have the same height than an empty element with no children. To fix this this patch adds a new condition in LayoutListBox::ItemHeight() so it uses the DefaultItemHeight() if the element has size containment. BUG=980380 TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-003.html TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-004.html TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-005.html Change-Id: I37c3de82ee591272f97a0b3db5761d914d17efbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695409 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#676096}
-
David Benjamin authored
This is in preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1687348 which renames it, triggering a clang-format. Bug: 973591 Change-Id: Iadcb37013281583c462d9bacf559cd5c622ccbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695746 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676095}
-
Yi Gu authored
The function WaitForHitTestDataChange() only waits for transform change. The best place to wait for all types of data change in hit test should be HitTestRegionObserver::WaitForHitTestData(). Bug: None Change-Id: I51832e0ac133e59f4e58f09f4061f8d6d45c4241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692191Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#676094}
-
Kush Sinha authored
On Chrome OS, with Mirror account reconciliation enabled, it is possible that an account's session expires server-side without Chrome detecting it. In these cases, Gaia sends us a re-authentication header message with the account's email that needs re-authentication. Currently, Chrome OS displays the Account Manager Settings page for these messages. Fix it to show a re-authentication dialog. Bug: b/136640443 Change-Id: I9a88a3115908a663ac0b9f895656782ff0fb8923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695351Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#676093}
-
Kelvin Jiang authored
use await instead of promise chaining for activity log history browser tests. This should make the tests more readable and it reduces nesting. Bug: 945422 Change-Id: I75ed11a26c952ca72db305f48637d9d2bc7178af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694266Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#676092}
-
Matthew Cary authored
Change-Id: Ic5b0507a794a4d83bdc84bd77386e389def6f1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692171Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#676091}
-
David Valleau authored
The SendDocument function in cups_printer which calls cupsStartDestDocument in CUPS had the logic backwards for passing the "last_document" argument. This was causing CUPS to behave strangely and mishandle printing multiple copies of documents for printers which did not support the copies IPP attribute. Bug: chromium:897275 Test: Tested manually using elm device and virtual USB printer Change-Id: I313965bfe4c281adf071ef8c14a022df4e0c2c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695693 Auto-Submit: David Valleau <valleau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#676090}
-
Hongchan Choi authored
TBR=rtoy Bug: 972733 Change-Id: Iee1148c9d9172378cdf6120a1b2461c1d100e679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693907Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676089}
-
Jun Cai authored
This CL removes unnecessary blank option in site settings on Android when Bluetooth Scanning API is not enabled. Bug: 980075 Change-Id: I70c39634e161cbcc28b805b12d7facfdcf2d5fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693766Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#676088}
-
Alex Cooper authored
This updates the FakeXRDeviceInterface to support newly added methods in the webxr-test-api: * simulateVisibilityChange * setBoundsGeometry * setLocalToFloorLevelTransform * clearLocalToFloorLevelTransform and supports the setting of boundsCoordinates and localToFloorLevelTransform in FakeXRDeviceInit. The Bounds and LocalToFloorLevelTransform functions already existed on internal tests, and as such a few of the tests that were ready were ported to external wpts. Note that simulateInputSourceConnection and disconnect will be implemented by future work. Bug: 979316 Change-Id: Idfb8bb631bfc1f1cb13b571a90b1a41b4a6fe518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692038 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#676087}
-
Dana Fried authored
As a proof of concept for the separation of layout generation and application, this CL reimplements FlexLayout using GetProposedLayout(), with significant code savings. The new layout has almost the same programming interface, and passes all existing unit tests. (Note that this also removes some of the explicit caching in FlexLayout but it can always be added back in later if we determine it's needed.) For more information on the separation, see this upstream CL: https://chromium-review.googlesource.com/c/chromium/src/+/1653898 And this design doc (internal only for now): https://docs.google.com/document/d/1fZOg120fswUdaV7tfZh8cXIlcvAL1Gg70GVrsQVXl3g/edit Next steps: - (optional) Expand FlexLayout with some features that make it friendlier to use, especially in interpolating layouts. - Implement AnimatingLayout (extending LayoutManager) with basic layout animations, analogous to those supported by Cocoa's Core Animation library. - Move toolbar, bookmarks, and tab handles to an animating layout. Follow-ups: - Combine LayoutManager and LayoutManagerBase - Update Box, Grid, and Fill layouts - Ensure other one-off layouts work with the new framework Change-Id: I1bbd739e1b2f5e45d92c8d3a38473319c4b6806f Bug: 898632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656249 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#676086}
-
Manuel Rego Casasnovas authored
There were a few tests related to size containment and select elements marked as failure in TestExpectations, but they're actually passing. Change-Id: I562b63be72ddf192ed78b3995033c8d35ab345fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695546Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#676085}
-
Joe Mason authored
Bug: 969139 Change-Id: I0bf080b7e8e9f461cd3a6da4bc0da9261976ce2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676545 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#676084}
-
liberato@chromium.org authored
DirectSharedImageVideoProvider was in video_frame_factory_impl.cc, mostly so that review of the refactor would be simpler. This CL moves it into separate files. There is very little functional change, except that TextureOwner creation is now moved out of the SharedImageVideoProvider, and into VideoFrameFactoryImpl. It's still somewhat hacky, but at least it's hacky closer to where it should actually be done. This CL also adds more unittests for VideoFrameFactoryImpl, since it's now much easier to inject mocks for everything. It doesn't add any tests for DirectSharedImageVideoProvider, since that depends on a refactor to move codec output buffer management out of CodecImage. Change-Id: I521fec5c9c03d00878bd4ff4844304f5f893a3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646901 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#676083}
-
Jeremy Roman authored
Bug: 982116 Change-Id: Iadb2047405fce29a3b3d4eb3f1e5443732b21dab Tbr: caseq@chromium.org No-Try: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696207Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676082}
-