Commits · a33960a0caeb87e84be0a8e60ebfccbd24f25aaa · eriksson monteiro / tangled

01 Nov, 2017 40 commits

Refactor voice interaction related Shell methods and Shell observers · a33960a0

Yue Li authored Nov 01, 2017

- Add VoiceInteractionController and VoiceInteractionObserver,
  remove the corresponding Shell methods.

- Add VoiceInteractionControllerClient, notifies the controller
  through mojo calls.

- Refactor ArcVIFrameworkService to use the client instead of calling
  Shell.

- Add unittests for VoiceInteractionController, added test cases in
  framework service unittest for VoiceInteractionControllerClient.

- Update usages of the refactored methods(palette_tray_unittest,
  metalayer_mode, app_list_button).

Bug: 757012, 758650
Change-Id: I6b5ff3e0164bb0ebbf7838b79e242533fd863b3b
Reviewed-on: https://chromium-review.googlesource.com/734126
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513295}

a33960a0

Revert "[Chromoting] Set min-bitrate of video channel to 0" · 70febf8c

Zijie He authored Nov 01, 2017

This reverts commit e73f847b.

Reason for revert: WebRTC may also give us a unreasonable low bandwidth estimation.

Original change's description:
> [Chromoting] Set min-bitrate of video channel to 0
> 
> According to SendSideBandwidthEstimation,
> https://cs.chromium.org/chromium/src/third_party/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc?rcl=033ea5f77140eef0c2defd4bd668de5dac9af3ea&l=392
> the bitrate_bps won't be smaller than min_bitrate_configured_, i.e. the field
> set by x-google-min-bitrate. This behavior is wrong or at least not what we have
> expected in WebrtcTransport: when the bandwidth is fully used by video channel,
> returning x-google-min-bitrate as the bitrate from OnTargetBitrateChanged() is
> not expected.
> 
> I have verified this change on my machine, and it partially resolves the laggy
> issue.
> 
> Bug: chromium:769391
> Change-Id: I2c87a78af63b508b5f8b25b77e171c92a10c7426
> Reviewed-on: https://chromium-review.googlesource.com/726312
> Commit-Queue: Zijie He <zijiehe@chromium.org>
> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509960}

TBR=lambroslambrou@chromium.org,zijiehe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:769391
Change-Id: Ie93ec826e653d040cb5ffd741e69077fab2c2eaf
Reviewed-on: https://chromium-review.googlesource.com/749921Reviewed-by: Zijie He <zijiehe@chromium.org>
Commit-Queue: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513294}

70febf8c

Roll src/third_party/pdfium/ a85e5ca5f..1bc5e494b (4 commits) · 44b0ff03

pdfium-deps-roller@chromium.org authored Nov 01, 2017

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I27cb9c5e9273823020c71cce7929f8bc6e0ede80
Reviewed-on: https://chromium-review.googlesource.com/749727
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513293}

44b0ff03

service/device: Add wake locks that allow screen dimming. · 256b4604

Daniel Erat authored Nov 01, 2017

Add WakeLockType::PreventDisplaySleepAllowDimming to the
device service's WakeLock mojo interface. A similar level is
currently exposed by chromeos::PowerPolicyController and
used by ARC. This type is treated identically to
PreventDisplaySleep on non-Chrome-OS platforms.

Bug: 702449
Change-Id: I9810fa69c8472a264a067d34ee92cef0125d41e5
Reviewed-on: https://chromium-review.googlesource.com/749342Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513292}

256b4604

[Chromecast] Don't include field_trial in overrides. · a4f982ca

Mike Bjorge authored Nov 01, 2017

Cast builds always use the webrtc/system_wrappers, but the
webrtc_overrides get pulled in aswell via transient dependencies, which
ends up causing a name collision that lld cannot resolve. (In particular,
field_trial FindFullName was colliding.)

Bug: None
Change-Id: I5c2fc9119c9806f344ee0f599e188ba98e2e5f15
Reviewed-on: https://chromium-review.googlesource.com/744424
Commit-Queue: Mike Bjorge <mbjorge@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513291}

a4f982ca

Roll src/third_party/skia/ d29e0da35..f0a30d71a (7 commits; 1 trivial rolls) · 046aa443

skia-deps-roller@chromium.org authored Nov 01, 2017

https://skia.googlesource.com/skia.git/+log/d29e0da3523e..f0a30d71ad24

$ git log d29e0da35..f0a30d71a --date=short --no-merges --format='%ad %ae %s'
2017-11-01 robertphillips Make matrix flip GM easier to triage
2017-10-31 benjaminwagner Add Win2k8 QuadroP400 jobs.
2017-11-01 csmartdalton Revert "Fold analytic clip FPs into GrReducedClip"
2017-11-01 benjaminwagner Upgrade GT610 to Win 10 Creators Update.
2017-11-01 angle-deps-roller Roll skia/third_party/externals/angle2/ 4751aabb7..25301b603 (1 commit)
2017-10-31 recipe-roller Roll recipe dependencies (nontrivial).

Created with:
roll-dep src/third_party/skia

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I17ceb6701f9502f1012aae84501f8b5c13bca18b
Reviewed-on: https://chromium-review.googlesource.com/749682Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513290}

046aa443

Handle ResourceNotFound in TabbedModeFRA. · 1127bd12

Dmitry Skiba authored Nov 01, 2017

TabbedModeFirstRunActivity introduced in 9c6253e4 doesn't properly
handle Resources.NotFoundException from Resources.getValue(), which
can result in a crash (see the bug).

This CL adds necessary Resources.NotFoundException handling.

Bug: 780459
Change-Id: Ib56c9e7be3ddb6aff6ab84621a089ace004b2eee
Reviewed-on: https://chromium-review.googlesource.com/748707Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513289}

1127bd12

Fetch executable path for Mac in helper · 98b579c1

Ryan Harrison authored Nov 01, 2017

The current implementation for Mac crashes, since /proc/ doesn't exist and thus
the path being searched for. This leads to attempting to create a string of
length 0.

This adds in Mac specific logic for fetching this information.

BUG=chromium:773183

Change-Id: I57bc2530ee79a51c0caad42ec31f640f73c7a7d4
Reviewed-on: https://chromium-review.googlesource.com/740344Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513288}

98b579c1

Watch for TabbedModeFRA in FirstRunIntegrationTest. · d34d4b4c

Dmitry Skiba authored Nov 01, 2017

Since 9c6253e4, TabbedModeFirstRunActivity is sometimes started instead
of FirstRunActivity.

This CL updates FirstRunIntegrationTest to also expect TabbedModeFRA.

Bug: 780429
Change-Id: I74883c7b7719123d0acdee1e4939acf8de22e581
Reviewed-on: https://chromium-review.googlesource.com/749286Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513287}

d34d4b4c

Remove fullscreen_chromeos.cc · 714657ba

Evan Stade authored Nov 01, 2017

Bug: none
Change-Id: Ie03afd866c41c5271a1031ce1f62fe517fed7990
Reviewed-on: https://chromium-review.googlesource.com/746994
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513286}

714657ba

Change Picture: Re-enable motion stills. · 6860ea24

David Reveman authored Nov 01, 2017

This turns motion stills back on. The feature is currently
considered ready to be enabled by default. A command line switch
can be added as a follow up if we determine that this is not
ready yet.

Bug: 769140
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0e180cece59aed3356331be8609616ffaab0d35c
Reviewed-on: https://chromium-review.googlesource.com/749529Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513285}

6860ea24

Reland "[SPv175] Support incremental invalidation on scrolling contents layer" · 0e206468

Xianzhu Wang authored Nov 01, 2017

This reverts commit 4e5cbded.

Reason for reland: It is not the reason of the break.

Original change's description:
> Revert "[SPv175] Support incremental invalidation on scrolling contents layer"
> 
> This reverts commit 7ac572d1.
> 
> Reason for revert: Reverting on suspicion of breaking webkit_layout_tests on many Mac bots. See, e.g.:
> 
> https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/6891
> https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/25624
> 
> -- Chromium sheriff
> 
> Original change's description:
> > [SPv175] Support incremental invalidation on scrolling contents layer
> > 
> > When the scrolling contents layer is resized and it paints the
> > background, we should invalidate the expanded/shrunk part of the
> > background. For SPv1 this is done by calling IncrementallyInvalidatePaint.
> > For SPv175 we need to pass kIncremental reason to PaintController.
> > 
> > Bug: 732611
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: I501ed3e899282b31f4f9d461e23637ab1ca4460d
> > Reviewed-on: https://chromium-review.googlesource.com/749283
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#513221}
> 
> TBR=wangxianzhu@chromium.org,pdr@chromium.org
> 
> Change-Id: I534c53fc28e9d657bbc7759aa80ac84cee065beb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 732611
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/750001
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513278}

TBR=wangxianzhu@chromium.org,pdr@chromium.org,jdonnelly@chromium.org

Change-Id: I2d882d39f99449496b053be9b29f6e4d64deec85
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 732611
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/749922
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513284}

0e206468

Add UMAs for RenderFrameObserver components · b9ced396

Joel Hockey authored Nov 01, 2017

See discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/platform-architecture-dev/JjveNjsfRMI

BUG=755046

Change-Id: I185fd50e7eae81c1c865b1d9e9477c0c596ec69c
Reviewed-on: https://chromium-review.googlesource.com/748482Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513283}

b9ced396

Remove unused member variable from ppb_var_unittest.cc · 7c49d002

Hans Wennborg authored Nov 01, 2017

Recent Clang versions (r317076+) warn about this.

TBR=dmichael

Bug: 780523
Change-Id: Id3c239f109119aec9167096bed87a9b886632739
Reviewed-on: https://chromium-review.googlesource.com/749736Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513282}

7c49d002

Dont show the reload interstitial when muting a website · 97ee2f8b

Tommy Steimel authored Nov 01, 2017

Bug: 776318
Change-Id: I00307ea4f9cf44c71f21a1311e35b5b6a9ea167d
Reviewed-on: https://chromium-review.googlesource.com/731268Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513281}

97ee2f8b

Roll src/third_party/pdfium/ a85e5ca5f..1bc5e494b (4 commits) · 9bb471d0

pdfium-deps-roller@chromium.org authored Nov 01, 2017

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ibe09a39fbdfb9943ec84ac67f4c3a1f0914dd125
Reviewed-on: https://chromium-review.googlesource.com/749724
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513280}

9bb471d0

update passing virtual/layoutng tests · e67f361f

Aleks Totic authored Nov 01, 2017

Bug: 635619
Change-Id: I90f55f60a8d85b0bdf3ba6fa934af3dfd401fc78
Reviewed-on: https://chromium-review.googlesource.com/749450Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513279}

e67f361f

Revert "[SPv175] Support incremental invalidation on scrolling contents layer" · 4e5cbded

Justin Donnelly authored Nov 01, 2017

This reverts commit 7ac572d1.

Reason for revert: Reverting on suspicion of breaking webkit_layout_tests on many Mac bots. See, e.g.:

https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/6891
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/25624

-- Chromium sheriff

Original change's description:
> [SPv175] Support incremental invalidation on scrolling contents layer
> 
> When the scrolling contents layer is resized and it paints the
> background, we should invalidate the expanded/shrunk part of the
> background. For SPv1 this is done by calling IncrementallyInvalidatePaint.
> For SPv175 we need to pass kIncremental reason to PaintController.
> 
> Bug: 732611
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I501ed3e899282b31f4f9d461e23637ab1ca4460d
> Reviewed-on: https://chromium-review.googlesource.com/749283
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513221}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: I534c53fc28e9d657bbc7759aa80ac84cee065beb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 732611
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/750001Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513278}

4e5cbded

Added WARN_UNUSED_RESULT annotation to WaitUntilConditionOrTimeout. · 7fa8f03f

Eugene But authored Nov 01, 2017

Ignoring the result of WaitUntilConditionOrTimeout call is incorrect in
many cases. CL adds WARN_UNUSED_RESULT annotation to
WaitUntilConditionOrTimeout to force callers to do the checks.

Bug: 780062
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I96daa8dfc6ec280d7f622a91f474714fe48fe3bf
Reviewed-on: https://chromium-review.googlesource.com/748108Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513277}

7fa8f03f

Ensure negative z index children are painted in scrollers · 4646c300

Philip Rogers authored Nov 01, 2017

[1] ensured kPaintLayerPaintingOverflowContents was cleared
when painting a new root but failed to clear
kPaintLayerPaintingCompositingScrollingPhase as well. This
caused a regression where negative z index children of a
scrolled and transformed paint layer would not paint.

This patch fixes and tests the regression from [1], as well
as passing one additional test with root layer scrolling.

[1] https://crrev.com/19f7cb8adfd015bef06b08d0c02eb5a528e8c885

Bug: 779885
Change-Id: Id73ae360000efe866fd9c9c7c1dade186d547cac
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/749059Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513276}

4646c300

Send download feedback for UNKNOWN verdicts · fe47ac22

Jialiu Lin authored Nov 01, 2017

Make DownloadItemView to triger download feedback when user press SAVE
button in generic warning.

Bug: 773105
Change-Id: I119d0f9e119115c38ee3a725345105e8ef93866b
Reviewed-on: https://chromium-review.googlesource.com/747879Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513275}

fe47ac22

Remove dead field from multibuffer_data_source · 851bf80b

Eric Lawrence authored Nov 01, 2017

multibuffer_data_source.h contains a GURL field carried over from a
previous refactor. This field isn't used for anything and should be
removed.

Change-Id: I3767482358342fca2414eedb547daf467ea47411
Reviewed-on: https://chromium-review.googlesource.com/749317Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513274}

851bf80b

glx: Disable a test. · 0e57a362

Sadrul Habib Chowdhury authored Nov 01, 2017

The test is failing on intel and amd, but not on nvidia. Disable it
now while I investigate.

TBR=kbr@chromium.org
BUG=780118

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iae399d4079aefdd76facfe08df8280ede8b7327c
Reviewed-on: https://chromium-review.googlesource.com/749784Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513273}

0e57a362

Revert "Move assistant icon animation to CompositorAnimationOberver" · 4698aea3

Justin Donnelly authored Nov 01, 2017

This reverts commit 33fc6c64.

Reason for revert: One or the other of this CL and https://crrev.com/c/748268 (perhaps both in combination?) broke PaletteTrayTestWithVoiceInteraction.StylusBarrelButtonActivatesHighlighter on Linux ChromiumOS Tests (dbg)(1):

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31692

The connection to these voice interaction Cls seems pretty clear. I can't identify which one it is, though, so while I apologize for the trouble, I'm going to revert both to ensure that the bot turns green again.

Original change's description:
> Move assistant icon animation to CompositorAnimationOberver
> 
> BUG=None
> TEST=locally build and see animation running as before.
> 
> Change-Id: I1eb62490108beaaec0795adb4251054c03b364e1
> Reviewed-on: https://chromium-review.googlesource.com/748273
> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513211}

TBR=xiyuan@chromium.org,xiaohuic@chromium.org

Change-Id: I5ef677c189808601f8e357f56a171bf920b10fa0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/749851Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513272}

4698aea3

Revert "Do not play assistant end animation when hiding" · b5762eb8

Justin Donnelly authored Nov 01, 2017

This reverts commit f69055b7.

Reason for revert: One or the other of this CL and https://crrev.com/c/748273 (perhaps both in combination?) broke PaletteTrayTestWithVoiceInteraction.StylusBarrelButtonActivatesHighlighter on Linux ChromiumOS Tests (dbg)(1):

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31692

The connection to these voice interaction Cls seems pretty clear. I can't identify which one it is, though, so while I apologize for the trouble, I'm going to revert both to ensure that the bot turns green again.

-- Chromium Sheriff

Original change's description:
> Do not play assistant end animation when hiding
> 
> When assistant is started and triggered hiding animation, during a very
> short time window if the user lifted their finger, we would try to play
> end animation.  We should avoid doing that.
> 
> BUG=b:67496461
> TEST=build and flash locally, see animation playing normally
> 
> Change-Id: Idf52f692edd9d05b16ad48687384d291b208a42e
> Reviewed-on: https://chromium-review.googlesource.com/748268
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513208}

TBR=xiyuan@chromium.org,xiaohuic@chromium.org

Change-Id: I13b9410f76829ec1491e9191e53519914d57f7cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:67496461
Reviewed-on: https://chromium-review.googlesource.com/749849Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513271}

b5762eb8

Add a ScopedNestableTaskAllower to Fix Tab Navigation · 4383d025

Robert Liao authored Nov 01, 2017

MacOS's alert dialog seems to need allowing nestable tasks for tab
navigation to work.

BUG=778562

Change-Id: Ic8654defa4e6ec1c7089639108e8a937e923b486
Reviewed-on: https://chromium-review.googlesource.com/747849
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513270}

4383d025

[GRC] Replace TabSignalObserver generic APIs with concrete APIs. · 427710a7

Peiyong Lin authored Nov 01, 2017

As part of the progress to make GRC strongly typed, we also lean towards to
making output mojo interface strongly-typed when needed. This patch removes the
current two generic APIs from the mojo interface and creates two APIs that are
used by the current TabSignalObserver implementation.

BUG=775691

Change-Id: I3ddd06fc723dd63982be21ee39e5809305765751
Reviewed-on: https://chromium-review.googlesource.com/747962Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513269}

427710a7

Roll src/tools/swarming_client/ fe94e7274..5da404cf3 (5 commits) · cf7bb4c0

Marc-Antoine Ruel authored Nov 01, 2017

https://chromium.googlesource.com/infra/luci/client-py.git/+log/fe94e7274e40..5da404cf35b6

$ git log fe94e7274..5da404cf3 --date=short --no-merges --format='%ad %ae %s'
2017-10-31 maruel Remove code that should have been deleted 3 years ago.
2017-10-31 maruel run_isolated: ignore relative_cwd if isolated's command is not used.
2017-10-30 maruel client: throw if the response is corrupted.
2017-10-27 maruel Do not run tests (and most tests) on upload anymore
2017-10-27 maruel Print more information in case of failure

Created with:
  roll-dep src/tools/swarming_client

-> Feel free to revert if anything goes wrong <-

TBR=vadimsh@chromium.org

Bug: 779718
Change-Id: Id21c679bdee0cd48af58d96a7558759297a9fa9e
Reviewed-on: https://chromium-review.googlesource.com/749583Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513268}

cf7bb4c0

cr-network-list-item: Only fire 'network-connected' on change · 74741f87

Steven Bennetts authored Nov 01, 2017

Currently 'network-connected' is fired much to often, causing
significant slowdowns on slower devices, especially in
chrome://network (debugging) but potentially to a lesser degree
in oobe and Settings.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I171e2015b7257f9e19b383687ae20282c0eb6c4c
Reviewed-on: https://chromium-review.googlesource.com/747077Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513267}

74741f87

Roll src/third_party/webrtc/ 6063e98dc..464e89c0c (3 commits) · b009a8f9

webrtc-autoroll@chromium.org authored Nov 01, 2017

https://webrtc.googlesource.com/src.git/+log/6063e98dcb50..464e89c0ca66

$ git log 6063e98dc..464e89c0c --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I416418720bdcf621df6722be91451a53514ca092
Reviewed-on: https://chromium-review.googlesource.com/749661Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513266}

b009a8f9

Move CallbackCounter from ios/chrome/browser to base/ios · 6687bb79

mrefaat authored Nov 01, 2017

This is more suitable place for it, as it will be used from different layers.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaa3a11f53730216d7c3794fc5cd771fd936c17be
Reviewed-on: https://chromium-review.googlesource.com/748601Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513265}

6687bb79

Roll src/third_party/pdfium/ a85e5ca5f..1bc5e494b (4 commits) · 80a4c088

pdfium-deps-roller@chromium.org authored Nov 01, 2017

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib1213187bb32b15cc5b6650d341f6d1433bfd77a
Reviewed-on: https://chromium-review.googlesource.com/748891
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513264}

80a4c088

Roll src/third_party/pdfium/ a85e5ca5f..1bc5e494b (4 commits) · 1ec447d4

pdfium-deps-roller@chromium.org authored Nov 01, 2017

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I7d85c312088c71d4cb248ed1e36ed84fc8ebb9ef
Reviewed-on: https://chromium-review.googlesource.com/748976
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513263}

1ec447d4

Fixes an ARC migration error in TabSwitcherLocalSessionCell. · 982612f1

Rohit Rao authored Nov 01, 2017

The migration tools inadvertently replaced autorelease with "= nil" in this
case.

Originally introducted in 9d30c08f.
Surrounding code was fixed in e5a9cd7d, but this
line was overlooked.

BUG=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0872c29999934c04e330cf2e3f20b6d114d2657f
Reviewed-on: https://chromium-review.googlesource.com/749521
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513262}

982612f1

Roll src/third_party/pdfium/ a85e5ca5f..1bc5e494b (4 commits) · 86a29435

pdfium-deps-roller@chromium.org authored Nov 01, 2017

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I12bd2a76480db77acdff4cf37e2778ee3d7c5fc9
Reviewed-on: https://chromium-review.googlesource.com/749050
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513261}

86a29435

Roll src/third_party/pdfium/ a85e5ca5f..1bc5e494b (4 commits) · cc26e6c0

pdfium-deps-roller@chromium.org authored Nov 01, 2017

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ie6ce877aea48b719b1bacbd7825abce107f3c04e
Reviewed-on: https://chromium-review.googlesource.com/748978
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513260}

cc26e6c0

📰

Remove deprecated SiteExploreUI code · 7e95a9a2

Nicolas Dossou-gbete authored Nov 01, 2017

Bug: 740905
Change-Id: I8b052887895bee3038df20517d8cc68f36389962
Reviewed-on: https://chromium-review.googlesource.com/746803Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513259}

7e95a9a2

Move GMB shared_memory Create unittest to template · 75cf986f

Klaus Weidner authored Nov 01, 2017

In preparation for sharing the test, move the Create test to
the test template.

(Split from http://crrev.com/c/680100 for AHardwareBuffer-based
GpuMemoryBuffer)

BUG=761432

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I766f115cde35777a93351a57c7a5fa64d62f2368
Reviewed-on: https://chromium-review.googlesource.com/747604
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513258}

75cf986f

[Autofill] Make the overflow of autofill suggestions preview not wrap. · 0beedbe0

Sebastien SG authored Nov 01, 2017

Bug: 778780
Change-Id: Ie3cc8633cb03e9711a4777c6c884f4fb07a7ab68
Reviewed-on: https://chromium-review.googlesource.com/740301
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513257}

0beedbe0

[MD extensions] shortcuts instructions and feedback · e7a877cd

Dave Schuyler authored Nov 01, 2017

This CL provides a line of instructions for creating extensions shortcuts.
It also adds interactive feedback during shortcut entry.

Bug: 769576
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I419cb1f4e3ee63aa47fc56ca784faa5ec9f2fdb6
Reviewed-on: https://chromium-review.googlesource.com/748082
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513256}

e7a877cd