GitLab

This introduces a new NotificationPlatformBridgeDelegator that is
responsible for selecting the correct platform bridge for notification
events.

Bug: None
Change-Id: I2aaff169887e281ab46fc51b8297a8cdf610ed9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401161Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806945}

This reverts commit 746ea10b.

Reason for revert: Breaks Chrome OS builds as some internal code (tab_search_browsertest) still refer to kOutOfBlinkCors feature.
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8532

See chrome/browser/resources/tab_search/test...

Original change's description:
> Reland "OOR-CORS: Remove BlinkCORS supporting code outside Blink"
> 
> This reverts commit efd0a0a1.
> 
> Reason for revert: The failed internal test was fixed in the internal repos by
> https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3263707
> 
> Original change's description:
> > Revert "OOR-CORS: Remove BlinkCORS supporting code outside Blink"
> >
> > This reverts commit 1047b889.
> >
> > Reason for revert: Build failure on mac-builder-perf: https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/220028
> >
> > Original change's description:
> > > OOR-CORS: Remove BlinkCORS supporting code outside Blink
> > >
> > > As OOR-CORS was fully launched, this patch removes BlinkCORS
> > > supporting code that exists outside Blink.
> > >
> > > We still have some dead code in Blink, and subsequent cleanup
> > > changes will remove them all.
> > >
> > > Bug: 1053866
> > > Change-Id: Ibe9f913d3cc9f183d6e681516996f1bc6cc58b96
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397458
> > > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > > Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> > > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#805644}
> >
> > TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,karandeepb@chromium.org
> >
> > Change-Id: I51b1a274038b33b8db3036fc1a3912c6580c9446
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1053866
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401467
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#805662}
> 
> TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,skyostil@chromium.org,karandeepb@chromium.org
> 
> # Not skipping CQ checks because this is a reland.
> 
> Bug: 1053866, 1126827
> Change-Id: I9251c658414ff98e3fc35e8a110366edb30b2d74
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405728
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806906}

TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,skyostil@chromium.org,karandeepb@chromium.org

Change-Id: I19b61821bb75f486cd549741769a47daad08ea48
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1053866
Bug: 1126827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410125Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806944}

Navigation sheet won't be included in the gesture navigation feature.
This CL removes the option from #overscroll-history-navigation in
chrome://flags.

The sheet is now only used for history popup triggered by long press
on back button.

Bug: 1126341
Change-Id: Ib4739c30fe5fbbd8d56cb1ae990313f579f60bad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400786Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806943}

This CL adds test required for landing top-level-await

- Add more tests for module evaluation order
- Add onunhandledrejection since top-level-await introduces more
  promises


Bug: 1022182
Bug: 1096455c
Bug: 1127215
Bug: v8:9344
Change-Id: Ib5502a47e6c0de6143a00f1ae35cde228e13200f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411927Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806942}

This reverts commit 644bba5a.

Reason for revert: Causes document leaks. See https://crbug.com/1128269.

Original change's description:
> [Shared Highlights] Connect selector generation in renderer to Android frontend.
>
> Connect selector generation in renderer to Android frontend using mojom
> interfaces.
> This CL add producer interface implemented in the renderer.
> When user selects a text, in the renderer side along with saving the
> selection frame and range, TextFragmentSelectorGenerator is registered
> for the producer interface and bound when user chooses 'Link to Text'.
>
> See https://screenshot.googleplex.com/0kb39qFn6JP.png for user flow.
>
> Bug: 1102382
> Change-Id: I4152b07d3058d4109f3919f285b46b9b2dd82f3e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341662
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806875}

TBR=dcheng@chromium.org,flackr@chromium.org,rockot@google.com,gayane@chromium.org

No-Presubmit: true
Bug: 1102382, 1128269
Change-Id: I412553feaa3dba7ecefd6a103c2f7ffda94b7c24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409739
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806941}

base::Singleton is deprecated in favor of base::NoDestructor. The
conversion is straight-forward for this leaky singleton and this
allow removing unnecessary scaffolding code.

Bug: none
Change-Id: I1db6f1fdd00b3532efbaea8367c8563cc5e28740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409495Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806940}

https://webrtc.googlesource.com/src.git/+log/7703f23b60c4..34f5ab82feae

2020-09-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b0398ace..2c970cbe (806731:806885)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I7559e1cea6605c42152bce7d9c9f70cac5e057a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411245Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806939}

Bug: 1127546
Change-Id: Ifc37a278a860a0443bfa961f565de8a074a32af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410071Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Yunke Zhou <yunkez@google.com>
Cr-Commit-Position: refs/heads/master@{#806938}

This reverts commit dc64daa2.

Reason for revert: Consistent failures on ASan/LSan builds:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38493

==7494==ERROR: AddressSanitizer: container-overflow on address 0x60200014be98 at pc 0x55bf547a29f5 bp 0x7ffe684dac20 sp 0x7ffe684dac18
READ of size 8 at 0x60200014be98 thread T0
    #0 0x55bf547a29f4 in ash::WindowCycleList::ReplaceWindows(std::__1::vector<aura::Window*, std::__1::allocator<aura::Window*> > const&) ./../../ash/wm/window_cycle_list.cc:541
    #1 0x55bf547a29f4 in ?? ??:0
    #2 0x55bf5479fb9c in ash::WindowCycleController::MaybeResetCycleList() ./../../ash/wm/window_cycle_controller.cc:126
    #3 0x55bf5479fb9c in ?? ??:0
    #4 0x55bf5467e1a5 in ash::DesksController::ActivateDeskInternal(ash::Desk const*, bool) ./../../ash/wm/desks/desks_controller.cc:553
    #5 0x55bf5467e1a5 in ?? ??:0
    #6 0x55bf54688fb2 in ash::DeskActivationAnimation::PrepareDeskForScreenshot(int) ./../../ash/wm/desks/desk_animation_impl.cc:171
    #7 0x55bf54688fb2 in ?? ??:0
    #8 0x55bf54689402 in ash::DeskActivationAnimation::OnStartingDeskScreenshotTakenInternal(int) ./../../ash/wm/desks/desk_animation_impl.cc:128
    #9 0x55bf54689402 in ?? ??:0
    #10 0x55bf5468722c in ash::DeskAnimationBase::OnStartingDeskScreenshotTaken(int) ./../../ash/wm/desks/desk_animation_base.cc:96

Original change's description:
> cros: Window cycle list (alt-tab) resets if open during desk swap.
> 
> While the flag for limiting windows to the current active desk is
> enabled, if a user swaps desks while the window cycle list is open, the
> contents will not update to the new active desk.
> 
> This CL makes the window cycle list reset if it is open and a desk
> swap occurs while the aforementioned flag is enabled.
> 
> Test: LimitedWindowCycleControllerTest.CycleShowsActiveDeskWindows
> Bug: 1067327
> Change-Id: I9d940ad82a2f05ab1d2fd9e8c5115d5f3eda9826
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398559
> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806749}

TBR=xdai@chromium.org,chinsenj@chromium.org

Change-Id: I60f4c419f33a2c0f5d749b50cfb2eda2ee06cb44
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1067327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410029Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806937}

We draw our own shadows on Windows if aero glass is enabled. Those
shadows are drawn within the MessageView bounds, reducing the inner
available size by GetInsets(). We need to take that into account when
setting the preferred size of the header view, large image view and,
more importantly, when clipping the ink drop ripple for the inline
settings background.

Screenshots: https://imgur.com/2LLCkGj

Bug: None
Change-Id: I8167da9b6881e1f10384044e2035bcb87847b7e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396338Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806936}

Currently OnGattDisconnected() is called every time DeviceRemoved() is
triggered, and will output a warning log if we doesn't hold a GATT
connection for that device, but actually this should be a normal case.
This patch adds an early return to avoid the log in that case.

BUG=None
TEST=Running system for a while, no more "OnGattDisconnected called, but
  no gatt connection was found" in chrome log.

Change-Id: Ia3dcc4e65cbc1e66ef1f7c34d51d2940a28095ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409660
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Auto-Submit: Jie Jiang <jiejiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806935}

There are rare cases when the the Android native UI is recreated but the
native parts remain untouched (e.g. when the theme is changed).

To prevent native classes using stale providers, reset them when the
component is destroyed and recreate them lazily as needed.
(Since this touches the way the native object is created, clean that
up as well to prevent rare crashes.)

Bug: 1094397, 1051030
Change-Id: I9c5cd1e225db1b4ca61c5136571a0e552fe86940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403641Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806934}

Mock: http://go/cros-lang-settings-ux-slide#slide=24
Figma: http://go/cros-lang-settings-figma
Normal view: http://screen/BSw5Hr7mBSADReH
Search view: http://screen/6VKAdL8xeyzJvCS

Note: Input methods names look like duplicate now because they are under
revision. Will add capability to search by language and country later.

Bug: 1113439
Change-Id: Id28cd18db110321048be54ce8c0948ae9a76fa8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397988
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806933}

Change --output-dir flag to --out-dir
Make --out-dir a mandatory flag, but allow it to be set automatically in gpu integration tests.

Bug: 1080854
Change-Id: I2ee9e96edc3d0b0a5514ee8d2cee179400142e49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386430Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Chong Gu <chonggu@google.com>
Auto-Submit: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#806932}

Suggested input method list is similar to the current list shown to user
in current Manage Input Methods page. However, it is less complicated
because we don’t need to group variants of the same base language
together. We only need to display the input methods based on the user's
enabled languages and arc ime that are not yet enabled.

Mock: http://go/cros-lang-settings-ux-slide#slide=25
Current view: http://screen/54wEoVjUWS3GFip

Bug: 1113439
Change-Id: I525fb0ea300c2ac751a8cef56a9476772173e2c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398037
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806931}

This matches the raster image size and fixes blurriness on high DPI displays.

Bug: 1064806
Change-Id: I0262e6fefbe4f09ead87a9c1fbe7cd5b7a5417ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360333
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806930}

Fixed: 1065659
Change-Id: I39f314af200c8256eb31a6ffe20b7210dd9ac5a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392997
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806929}

Before this change, we were considering breaking opportunities before
space runs. This approach allowed us to avoid re-shaping in many cases,
which has an important advantage in terms of performance.

However, the Unicode spec (UAX#14) state that breaking before a space
character is not allowed [1], so we had to implement this logic after
our TextBreakIterator had already determined the best breaking
opportunity. This approach has been working fine so far for regular
spaces (white-space, tabs, ...), but it doesn't work correctly for
other BA [2] class characters; in the CSS Text specification, these are
known as "other space separators" [3].

In order to implement the correct behavior for any kind of space, we
would need to change our TextBreakIterator implementation so that
matches the Unicode rules, considering breaking opportunity after
space runs. This change should also consider the performance impact
of the extra re-shaping operations required to deal with trailing
spaces.

In order to prevent performance regressions, we'll store the position
of the 'end of non-hangable run', which will be used in case of items
with styles dictating rules to collapse trailing spaces.

[1] https://unicode-org.atlassian.net/browse/ICU-20843
[2] https://www.unicode.org/reports/tr14/tr14-39.html#BA
[3] https://drafts.csswg.org/css-text-3/#other-space-separators

Change-Id: Ie4a3890c75a3faff1a0155d4a40bcaa85bc6ac06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047943
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806928}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I2cd8163da19cc8625633ccfff4267cc363d67d79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411238Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806927}

Roll Chrome Linux PGO profile from chrome-linux-master-1600127994-a617f89793652b5fd810a69f7c568f33dff933e7.profdata to chrome-linux-master-1600148958-bab2bda8659b635656decb925279e513cc814d66.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I9062ed807bac0f9ebfed537582225d4be78270a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411244Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806926}

Bug: chromium:980879
Change-Id: Id056c1583e06c0211dda81538f7c263446ea60fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410072Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806925}

If LayoutNGFragmentTraversal is disabled, no one calls
NodeAtPoint() for the rendered legend. This CL fixes it by adding
LayoutNGFieldset::HitTestChildren() override so that it handles the
fieldset's rendered legend.

Bug: 1127743
Change-Id: Idb21c4dc198591509e4172d89dc84e379a12097f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409416Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806924}

This expiring histogram is no longer needed.

BUG=1127952

Change-Id: I23be15e7ed771eea5cd00c8b46b82ba1f79aa7f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410351Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806923}

This CL refactors SyncTestRule#signinAndEnableSync() to
use SigninTestUtil to handle sign-in.

Bug: 1126814
Change-Id: I171e9c59e8616236ede6d2aa247ec826577b7d67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401144Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806922}

Removing the GraphProcessor class and this class unit tests. This is
the last step of migration GraphProcessor from Chrome to Perffeto.
See crbug.com/1095982 for more details.

Bug: 1095982
Change-Id: I10ecbfdbddce2b8a8f6a45bd76efd42b5e375ea0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302698
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806921}

This reverts commit 6cf11459.

Reason for revert: Causes build errors for all official boards:
https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10173

ERROR at //chromeos/components/file_manager/BUILD.gn:8:1: Assertion failed.
assert(!is_official_build, "File Manager is only built for unofficial builds")
^-----
File Manager is only built for unofficial builds
See //chromeos/resources/BUILD.gn:87:5: which caused the file to be included.
    "//chromeos/components/file_manager:file_manager_mojom_js",
    ^---------------------------------------------------------
GN gen failed: 1


Original change's description:
> Reland "Files SWA: Moving to a new directory."
> 
> This is a reland of 4ccb6508
> 
> http://crrev.com/c/2367397 and this CL were prepared without
> the authors being aware of each other's efforts.
> 
> Timeline for 2367397:
> Sep 10, 2020, 6:06:39AM UTC+10 it is submitted to CQ
> Sep 10, 2020, 9:01:21AM UTC+10 it is successfully submitted
> 
> Timeline for 2402560
> Sep 10, 2020, 10:46:31AM UTC+10 dry run is successfully completed
> Sep 10, 2020, 12:19:23PM UTC+10 it is submitted to CQ
> Sep 10, 2020, 12:23:56PM UTC+10 it is successfully submitted
> 
> 
> Original change's description:
> > Files SWA: Moving to a new directory.
> >
> > Bug: 1111229
> > Change-Id: Id0509caf9d1d9de8efa293344e682610cf1a8699
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381330
> > Reviewed-by: Dominick Ng <dominickn@chromium.org>
> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> > Reviewed-by: Jiewei Qian  <qjw@chromium.org>
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Commit-Queue: Bo Majewski <majewski@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#805598}
> 
> Bug: 1111229
> Change-Id: I8894da793702136d5e394b9854993026603c311d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402560
> Commit-Queue: Bo Majewski <majewski@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Jiewei Qian  <qjw@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806865}

TBR=kinuko@chromium.org,khorimoto@chromium.org,yfriedman@chromium.org,thestig@chromium.org,ortuno@chromium.org,dominickn@chromium.org,mkwst@chromium.org,qjw@chromium.org,majewski@chromium.org

Change-Id: Ic9e25bc6bcba0fd199546c0f67eb7c65e36908de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1111229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410076Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806920}

The ListPublicCertificates HTTP GET request has the option of including
the IDs of certificates that the user already has. These certificates
will not be returned by the server.

The certificate ID is a byte field in the proto, and One Platform
requires that byte fields be base64 encoded before being added to the
URL's query parameters
(https://developers.google.com/protocol-buffers/docs/proto3#json).
Otherwise we get "Bad Request" errors in the HTTP response body like
"Invalid value at 'secret_ids' (TYPE_BYTES), Base64 decoding failed
for...".

Fixed: 1128021
Change-Id: Icef3d04456de40a7207aba0ed64eda8f1438c675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410578
Auto-Submit: Josh Nohle <nohle@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#806919}

Correct the values used in the FieldMask |update_mask| field in the
UpdateDeviceRequest proto. With these changes, we manually verified that
the contacts and public certificates fields in the UpdateDevice response
now show the expected changes in the Nearby Share server database. The
values in this CL agree with those in GmsCore [1].

[1]http://google3/java/com/google/android/gmscore/integ/modules/nearby/src/com/google/android/gms/nearby/sharing/rpc/NearbySharingServiceGrpcClient.java?l=59-61&rcl=330996445

Bug: b/157685298
Change-Id: I5c7d669825cc0ff667cdaf17eb09b26f9f999327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411449
Auto-Submit: Josh Nohle <nohle@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#806918}

Currently the drive share action returns an empty icon, however this
will no pass a size DCHECK. The reason we return an empty icon is
because there is some refactoring needed for the GetActionIcon method
and we should not create the icon at this stage (crbug.com/1127750).
However because we don't want to cause a DCHECK failure, and also there
is already another implementation that does the same thing, so I will
add this temp solution and this will be fixted together.

BUG=1097623

Change-Id: Iff4fcaac6aa0d2308d9b9539f861303164346f9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409850Reviewed-by: Melissa Zhang <melzhang@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806917}

Remove redundant virtual/omt-worker-fetch expectations from
TestExpectations.

Bug: 1128252
Change-Id: I65f951923ccfeafa1e212a5ab815b8b0bafbd542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409478Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806916}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ac8edb313ce2..53a7d9430dbb

2020-09-15 soxia@microsoft.com Fix issue where full screen capture captures part of screen.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Id184c4a82aa7015af4ea2ea7ff133459c7fa5e49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411234Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806915}

The bug it's checking for manifests as random timeouts on WPT tests
that use RTCPeerConnection-helper's functions to set up connection.

The bug was fixed in another CL, but these tests exercise interesting
functionality, so worth adding.

The purpose of the helper-test is to ensure that if we introduce more
instabilities by changes to the helper, this test should fail first.

Bug: chromium:1122106
Change-Id: Ic59f76fd36f645cee0e08d6dcd69db0c62cbc903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379193Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806914}

This CL adds:
1 - VideoIPHCreator that takes a ViewStub and inflates into an IPH
2 - A manager class on NTP to manage showing various video tutorial IPHs
3 - Added IPH features for search and download
4 - Moved VideoTutorialServiceFactory package to upper level

TODO:
 - The IPH layout isn't upto spec. Needs one more pass.
 - The IPH configs aren't fully correct. Needs one more pass. I added
 them here for the sake of review clarity and completeness.

Bug: 1117147
Change-Id: Iefdd02da06f8667fbd85a44a821d940277571559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367438
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806913}

Bug: 1108940
Change-Id: I0ad39f0249612c002dc288983c447b86d3e19ea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404278
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806912}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0547fb291708..f57e64e375ef

2020-09-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I43700bcd0d79c86f0018a0f06e9b3dfc8d298862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411235Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806911}

This change provides an interface and implementation of AffiliationFetcherFactory. It modifies the ScopedFakeAffiliationFetcherFactory to extend this interface and changes the creation of Affiliation Fetcher in Affiliation Service.

Bug: 1117447
Change-Id: I900c34e09461e870ea144f20e209cec973976568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409899Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com>
Cr-Commit-Position: refs/heads/master@{#806910}

Though this is a breaking change, it's safe because the API was only
available on dev channel in M86.

Bug: 1108940

Change-Id: I4ee1718c8cdeda2e3fe28fcd810b894e656cc8f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398888
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806909}

Previously, having a row with only 1 element threw an error. However,
in the emoji keyboard there are places where that is the most logical
grouping. Remove that check.

AX-Relnotes: n/a.
Fixed: 1127070
Change-Id: I61aa71ae20fbf3aa0015b12fceb50cf66ba271fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406658
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806908}

Removing DoesSiteRequireDedicatedProcess() and migrating all existing
calls to use DoesSiteInfoRequireDedicatedProcess() to encourage code
to use existing SiteInfo objects when trying to determine this
information.

Bug: 1085275
Change-Id: I3cda5cb7772e27c4b38bd49a4d0ed0731d43875c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406518
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806907}

This reverts commit efd0a0a1.

Reason for revert: The failed internal test was fixed in the internal repos by
https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3263707

Original change's description:
> Revert "OOR-CORS: Remove BlinkCORS supporting code outside Blink"
>
> This reverts commit 1047b889.
>
> Reason for revert: Build failure on mac-builder-perf: https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/220028
>
> Original change's description:
> > OOR-CORS: Remove BlinkCORS supporting code outside Blink
> >
> > As OOR-CORS was fully launched, this patch removes BlinkCORS
> > supporting code that exists outside Blink.
> >
> > We still have some dead code in Blink, and subsequent cleanup
> > changes will remove them all.
> >
> > Bug: 1053866
> > Change-Id: Ibe9f913d3cc9f183d6e681516996f1bc6cc58b96
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397458
> > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#805644}
>
> TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,karandeepb@chromium.org
>
> Change-Id: I51b1a274038b33b8db3036fc1a3912c6580c9446
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1053866
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401467
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805662}

TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,skyostil@chromium.org,karandeepb@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1053866, 1126827
Change-Id: I9251c658414ff98e3fc35e8a110366edb30b2d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405728
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806906}