GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2df2b3e..23bf4d4

TBR=

Review URL: https://codereview.chromium.org/787253007

Cr-Commit-Position: refs/heads/master@{#308293}

It makes the ownership clear and it is a good pratice when transfering
ownership from caller to callee. Passing a scoped_ptr makes it harder to
misuse.

Discussion in chromium-dev mailing-list:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/9rTsfEI1Ux0/discussion

BUG=None
TEST=unit_tests --gtest_filter=ConfirmBubble*
R=pkasting@chromium.org,avi@chromium.org

Review URL: https://codereview.chromium.org/801043003

Cr-Commit-Position: refs/heads/master@{#308292}

Do not use an action when naming an event that will be fired to the
delegate. Instead of saying what the delegate should do or will do, just
say what event happened. So in this case, say to the delegate that the
instructions import link on the Bookmarks Bar was clicked.

BUG=None
TEST=have zero bookmarks in your Bookmarks Bar, so you can see the link there,
click on it to show the import dialog. No regressions should be observed.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/789653004

Cr-Commit-Position: refs/heads/master@{#308291}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c517219..2df2b3e

TBR=

Review URL: https://codereview.chromium.org/787253006

Cr-Commit-Position: refs/heads/master@{#308290}

Blink side here (depends on this CL):
https://codereview.chromium.org/782693003/

BUG=317991

Review URL: https://codereview.chromium.org/789433003

Cr-Commit-Position: refs/heads/master@{#308289}

BUG=428920

R=mfoltz@chromium.org

Review URL: https://codereview.chromium.org/694123002

Cr-Commit-Position: refs/heads/master@{#308288}

Revert of Ensure that the browser’s copy of page id is in sync with the renderer’s. (patchset #1 id:1 of https://codereview.chromium.org/795233002/)

Reason for revert:
Still crashing.

Original issue's description:
> Ensure that the browser’s copy of page id is in sync with the renderer’s.
>
> This might-maybe-hope-not crash, and so has debugging statements.
>
> BUG=407376
> TEST=no crashing, we hope
> TBR=rsesek@chromium.org
>
> Committed: https://crrev.com/0eba5c5e63e52330d3409193f5184aaffac45e90
> Cr-Commit-Position: refs/heads/master@{#308036}

TBR=rsesek@chromium.org,creis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407376

Review URL: https://codereview.chromium.org/803803003

Cr-Commit-Position: refs/heads/master@{#308287}

BUG=302083
R=thakis@chromium.org
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/730983002

Cr-Commit-Position: refs/heads/master@{#308286}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e7e7876..c517219

TBR=

Review URL: https://codereview.chromium.org/806563002

Cr-Commit-Position: refs/heads/master@{#308285}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/43893e4..451e822

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/798233002

Cr-Commit-Position: refs/heads/master@{#308284}

Refactor URLRequestAdapter::Read to fix unbound buffer growth and data corruption in case of synchronous success.

BUG=433348

Review URL: https://codereview.chromium.org/743713002

Cr-Commit-Position: refs/heads/master@{#308283}

BUG=
TBR=robertphilips

Review URL: https://codereview.chromium.org/787123007

Cr-Commit-Position: refs/heads/master@{#308282}

__NR_open, __NR_access are not defined on arm64. So, I just blocked
the syscall to build properly on arm64.

BUG=None

Review URL: https://codereview.chromium.org/784733002

Cr-Commit-Position: refs/heads/master@{#308281}

These entries were found with the following command line:

$ git grep Newtab chrome/

BUG=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/786893007

Cr-Commit-Position: refs/heads/master@{#308280}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/71085d0..e7e7876

TBR=

Review URL: https://codereview.chromium.org/799813003

Cr-Commit-Position: refs/heads/master@{#308279}

They don't seem to be necessary anymore.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/794243004

Cr-Commit-Position: refs/heads/master@{#308278}

chrome://settings and upon HotwordService creation.

Note: This also changes HotwordAudioHistoryHandler to maintain the
previous state of the pref if a successful connection could not be made
with the server. A separate CL will be created for reporting an error in
connection to the user.

Adds a new function to browser_options_handler to be used as a callback
to the call GetAudioHistoryEnabled.

Adds a task_runner to HotwordAudioHistoryHandler to enable testing.
Test added: HotwordServiceTest.AudioHistorySyncOccurs.

Changes to hotword_private_apitest reflect the fact that
hotword_audio_history_handler now takes a task_runner and that the
previous state of the pref is maintained.

Issue 436683 is included in this because the times which we sync (every
24 hrs, profile startup, opening chrome://settings) are considered
sufficient enough to maintain state and close enough to launching for
the purpose of opening the audio_verification_app.

BUG=438451,436683

Review URL: https://codereview.chromium.org/800523002

Cr-Commit-Position: refs/heads/master@{#308277}

BUG=439512

Review URL: https://codereview.chromium.org/805613002

Cr-Commit-Position: refs/heads/master@{#308276}

BUG=439512

Review URL: https://codereview.chromium.org/797133003

Cr-Commit-Position: refs/heads/master@{#308275}

BUG=439512

Review URL: https://codereview.chromium.org/799183002

Cr-Commit-Position: refs/heads/master@{#308274}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/fbaace0..43893e4

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/796333004

Cr-Commit-Position: refs/heads/master@{#308273}

Cr-Commit-Position: refs/heads/master@{#308272}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cb219a0..71085d0

TBR=

Review URL: https://codereview.chromium.org/806523002

Cr-Commit-Position: refs/heads/master@{#308271}

Add OAuth2 authentication for speech recognition requests from the launcher, when audio-history is opted-into.

Audio history allows a user to see the speech recognition result at https://history.google.com/history/audio. This change will attach an auth (OAuth2) token to the recognition request, which is used to associate the request with the user. This only happens when the user opts-in to audio history, and only on speech recognition from the app launcher.

This change adds a helper class that handles retrieving and refreshing the auth token, and plumbs that token into the speech recognition request.

BUG=397019

Review URL: https://codereview.chromium.org/778393002

Cr-Commit-Position: refs/heads/master@{#308270}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/502e869..cb219a0

TBR=

Review URL: https://codereview.chromium.org/797183003

Cr-Commit-Position: refs/heads/master@{#308269}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f2e542d..502e869

TBR=

Review URL: https://codereview.chromium.org/805573005

Cr-Commit-Position: refs/heads/master@{#308268}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b676431..f2e542d

TBR=

Review URL: https://codereview.chromium.org/787923003

Cr-Commit-Position: refs/heads/master@{#308267}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d8c8e9e..b676431

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/789103005

Cr-Commit-Position: refs/heads/master@{#308266}

Review URL: https://codereview.chromium.org/800783003

Cr-Commit-Position: refs/heads/master@{#308265}

Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally using run_tests script).
Fix a failing test from this file.

Found this while fixing unit test for max_failures patch
(https://codereview.chromium.org/790673005/).

BUG=440101

Review URL: https://codereview.chromium.org/805593002

Cr-Commit-Position: refs/heads/master@{#308264}

Pipeline generates OnPipelineSeeked and OnPipelineBufferingStateChanged
events in response to seek operations. There is an event generated already
for OnPipelineBufferingStateChanged but missing one for OnPipelineSeeked.

Follow up fix for https://codereview.chromium.org/740663002/
Required for landing https://codereview.chromium.org/456343002/

Review URL: https://codereview.chromium.org/791233003

Cr-Commit-Position: refs/heads/master@{#308263}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1607156..fbaace0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/804463004

Cr-Commit-Position: refs/heads/master@{#308262}

Editable HTML content is very laggy when it is relatively large. Lag
is caused by creation of WebRange object with given location and offset.
Bigger the editable content and farther the location, the more the lag.

Currently we create WebRange object twice - once for checking presence
of text (plain) and again for fetching actual plain text. It causes the
lag to double the actual value. This patch removes unneccessary double
creation of WebRange.

Sample page and traces showing the lag and improvement with this patch
are attached with the bug.

BUG=396051

R=avi,jochen,yosin

TBR=jochen

TESTS=None

Review URL: https://codereview.chromium.org/795493003

Cr-Commit-Position: refs/heads/master@{#308261}

Cr-Commit-Position: refs/heads/master@{#308260}

Updates cryptotoken to 0.9.10:
 - Implement eTLD+1 checking of appIds
 - Smaller bugfixes

BUG=426358
R=juanlang,xiyuan

Review URL: https://codereview.chromium.org/799923007

Cr-Commit-Position: refs/heads/master@{#308259}

We "white list" some exceptions which user story runner can continue running
the rest of user stories even if they are raised during the test run.

Those exceptions are:
page_test.Failure
util.TimeoutException
exceptions.LoginException
exceptions.ProfilingException
page_action.PageActionNotSupported
exceptions.AppCrashException (except if this is thrown inside
shared_user_story_state.state.TearDownState(), which indicates a failure of
recovering the test state)

BUG=437735

Review URL: https://codereview.chromium.org/755323012

Cr-Commit-Position: refs/heads/master@{#308258}

Revert of Generalize V4L2 HW video codec device names (patchset #3 id:40001 of https://codereview.chromium.org/786993002/)

Reason for revert:
Still hitting crbug.com/439175 on Pit.

Original issue's description:
> Generalize V4L2 HW video codec device names
>
> Switch to more generalized V4L2 video accelerator device names and update
> sandbox rules to reflect that.
>
> After video_ChromeHWDecodeUsed autotest is fixed, this cl is submitted again
> due to crrev.com/730693005 reverted in crrev.com/784553004.
>
> BUG=405861, 437598, 439175
> TEST=passed video_ChromeHWDecodeUsed with h264 and vp8 on peach_pit.
> Media.GpuVideoDecoderInitializeStatus value is 0 when playing a video
> from youtube. DUT only has /dev/video-enc and /dev/video-dec device nodes.
>
> Committed: https://crrev.com/b777ad3f16655a3493a0ecd9975c58a7b84c740d
> Cr-Commit-Position: refs/heads/master@{#307674}

TBR=jorgelo@chromium.org,wuchengli@chromium.org,scherkus@chromium.org,henryhsu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405861, 437598, 439175

Review URL: https://codereview.chromium.org/792123006

Cr-Commit-Position: refs/heads/master@{#308257}

Revert of Omnibox Watcher: Don't Flag Incidents that are Paste+Enter (patchset #5 id:80001 of https://codereview.chromium.org/795343002/)

Reason for revert:
causes crashes in official builders.
../../chrome/browser/rlz/rlz_unittest.cc:240:14:error: no matching constructor for initialization of 'OmniboxLog'
  OmniboxLog dummy(base::string16(), false, metrics::OmniboxInputType::INVALID,
             ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../chrome/browser/omnibox/omnibox_log.h:22:3: note: candidate constructor not viable: requires 13 arguments, but 12 were provided
  OmniboxLog(
  ^
../../chrome/browser/omnibox/omnibox_log.h:21:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 12 were provided
struct OmniboxLog {
       ^
1 error generated.

Original issue's description:
> Omnibox Watcher: Don't Flag Incidents that are Paste+Enter
>
> The code currently excludes paste-and-go operations.  It should probably
> also exclude paste+enter operations; these are effectively equivalent.
>
> TODO before submitting: test interactively
>
> BUG=
> TBR=bauerb@chromium.org
>
> Committed: https://crrev.com/c281fb257d2acdd247b0692380d084863e2dd462
> Cr-Commit-Position: refs/heads/master@{#308233}

TBR=pkasting@chromium.org,grt@chromium.org,bauerb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/800983005

Cr-Commit-Position: refs/heads/master@{#308256}

Keep track of the display configuration callbacks and trigger them when the
GPU process responds.

BUG=429746
NOTRY=true
TBR=kenrb@chromium.org

Review URL: https://codereview.chromium.org/800743002

Cr-Commit-Position: refs/heads/master@{#308255}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1fdbfa4..d8c8e9e

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/797833004

Cr-Commit-Position: refs/heads/master@{#308254}