- 06 Nov, 2019 40 commits
-
-
Javier Fernandez authored
This feature will be implemented as an alias of word-break: break-word, which the CSS Text 3 declared as deprecated in future levels of the spec. There has been a long standing interoperability issues with the 'word-break: break-word' feature, implemented in Blink and WebKit but not in Firefox, since it was declared as deprecated. This feature can't be removed to avoid compatibility issues, but also because it provide a behavior that web authors really need, which is that breaking opportunities are considered in th min-content size of the box. The CSS WG resolved [1] that the best approach is to add a new value to the overflow-wrap CSS property, that provides basically the same behavior than 'overflow-wrap: break-word' but allowing the breaking opportunities to be part of the min-content size computation. This CL will enable the feature by default in next release, since the intent-to-implement-and-ship request [2] has been already approved. [1] https://github.com/w3c/csswg-drafts/issues/2682 [2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ Bug: 905315 Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712867}
-
Gyuyoung Kim authored
This CL converts mojom::CoordinatorConnectorRequest to mojo::PendingReceiver<>. Bug: 955171 Change-Id: I2d14476598074daafae0f45649ace88ce08c14e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895266 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#712866}
-
http://crrev.com/c/1872409Joanmarie Diggs authored
Update the test expectations and re-enable the tests. Bug: 1021499 Change-Id: I84eed7b0fac47ff069ee81c23e1e494a05337da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899926Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#712865}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/db6f5198..c761cf33 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5a7fc34a402eea84c1ee3584fc5c926a1e1420ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899800Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712864}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ce200acafa7a..cdc0c23f1a2e git log ce200acafa7a..cdc0c23f1a2e --date=short --no-merges --format='%ad %ae %s' 2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-05 reed@google.com split out blendmodes for skvm 2019-11-05 reed@google.com split out serial functions for SkFont into separate impl Created with: gclient setdep -r src/third_party/skia@cdc0c23f1a2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I3804115864dafd668ce2b40c554b253011dbfd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712863}
-
Antonio Gomes authored
The public API is not needed any more now that the WebRTC/Peerconnection implementation resides solely in Blink. Hence, this CL uses RtcVoidRequest directly. Note that the CL removes the duplication of some template definitions added temporarily in blink/renderer/modules/peerconnection/rtc_peer_connection_test.cc by https://crrev.com/c/1897772 BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I390f66f470cc4bf7aba7bf6c8b182c0749f8105b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899786Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#712862}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/38f84022167e..e7ebfec8c01c git log 38f84022167e..e7ebfec8c01c --date=short --no-merges --format='%ad %ae %s' 2019-11-05 dburger@chromium.org Make the BinhostTest a noop. Created with: gclient setdep -r src/third_party/chromite@e7ebfec8c01c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I5053aeaf96b3fe4f4bd3a52b6aadf9e25019be98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900103Reviewed-by:
-
Matt Jones authored
The bottom sheet version of the tab grid is obsolete and uses a deprecated API (BottomSheetController#getBottomSheet). This patch removes the unused code and marks the relevant metrics obsolete. Bug: 986310, 1020711 Change-Id: I69f126e2d90139606410cfb0264a5a2c138ae972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895966 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#712860}
-
Eugene But authored
Bug: 1021649 TBR: gambard@chromium.org Change-Id: Iba5edac9846936924de134722594fb7b8efef2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900357Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#712859}
-
Clark DuVall authored
This enables the action mode bar, which has the "Copy", "Select", "Share all" and "Web search" options when text is selected. Change-Id: Id91ce30e7f389d9105626f1f463fa687751dfa65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900570 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712858}
-
Sammie Quon authored
Otherwise destructor which cleans up observers will not be called. Fixed: 1011330 Change-Id: I62927c958757e8411b3a96e565617cb94547edd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900139Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712857}
-
Varun Khaneja authored
Since private URLs can't really be checked for safety, there's no benefit of checking their reputation with the server. R=bdea Bug: 963165 Change-Id: I927fa1fa82dd491cbb2171fa1c9d0ee6a80f0dd7 Fixed: 1021671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900256 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#712856}
-
Matt Menke authored
Bug: 997049 Change-Id: I7b04af65e0a4d8ed3e4c3c527dddad2bb06f6409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898302 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#712855}
-
Alex Cooper authored
This change removes the "is_legacy_webvr" attribute from the mojom files that used it, since this is now always false. Any logic that depended on it has been updated accordingly. Note that the "IsLegacyWebVr" metric is still being logged to prevent incompatiabilities with the data types while it is a value that is needed for filters. Bug: 1017872 Change-Id: Ie43c914a4bbac0c1b7beda02257865ac3e69f5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897857 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#712854}
-
sczs authored
- Adds is_form_navigation member to the NavigationDetails struct. This struct is sent to the InfobarDelegate after each Navigation. - Dismisses the SaveCard Infobar unless the navigation was triggered by a form submission or is a redirect. - Creates kAutofillSaveCardDismissOnNavigation feature flag for the new behaviour. Bug: 1021412 Change-Id: I6cf5973a635586a8f21d65a50bb750a4ea0c4070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890734 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#712853}
-
wutao authored
This patch updates the back button visibility for Assistant web container. Bug: b/141268413 Test: manual Change-Id: I2dfd3209e4954e04295340d48f05516bde37d09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873147 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712852}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1bae56151db3..1d09b983031b git log 1bae56151db3..1d09b983031b --date=short --no-merges --format='%ad %ae %s' 2019-11-05 sugoi@google.com Vulkan: Fix memory corruption crash Created with: gclient setdep -r src/third_party/angle@1d09b983031b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I1549ee3cbb75ed720e83328b4957312b9d1c2611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900102Reviewed-by:
-
Hugo Benichi authored
This patch adds to all active network events sent to ARC++ over mojo the complete IP v4 and v6 configurations of the host if they exist. This relies on the shill Device "IPConfigs" DBUS property which is the only consistent way to get current v4 and v6 configurations from shill. This allows to: - Correctly set DNS inside Android for the default network and all secondary networks. - Track inside Android WiFi roaming over the same prefix to avoid spurious network disconnection. BUG=b:112245108 BUG=b:140812279 BUG=b:143247361 BUG=b:143258259 TEST=Deployed Chrome and ARC++. Connected device to eth and wifi. Manually changed DNS between "Google" and manual entries both both eth (as the default network) and wifi. Observed that ARC++ consistently gets correct DNS settings for active network events. Change-Id: I40b654c5dba0fdf722971b7c12437991b1a5c374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892474 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#712850}
-
Jinsuk Kim authored
Gesture navigation |getTargetOrCurrentState| regarded the state of BottomSheet as NONE if it is not available yet. Previously the widget was eagerly created the returned state was HIDDEN. Now BottomSheet widget is lazily initialized, the method started returning NONE, and it caused a bug not triggering the sheet at all. This CL fixes it by defining the state of non-existing BottomSheet as HIDDEN. Bug: 1020938 Change-Id: I460efcdceed29b5ae70249b7f6ace644afceeba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900506Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712849}
-
Min Qin authored
On Android, NetworkChangeNotifier can be created in 2 situations: 1. In BrowserMainLoop::PostMainMessageLoopStart(), NetworkChangeNotifierAndroid will be created on UI thread. 2. Triggered by the GetNetworkService() call when network service is running in-process, NetworkChangeNotifierPosix will be created on IO thread Because 1 and 2 happens on 2 different threads, there is a race condition that both creation calls could take place. This CL fixes the issue by: 1. Combining NetworkChangeNotifier::HasNetworkChangeNotifier() and NetworkChangeNotifier::Create() into a single method CreateIfNeeded(), so that race condition won't be introduced between Has() and Create(). 2. Use a lock to protect CreateIfNeeded(), so that only one global instance will be created if multiple threads are competing with each other. The original logic of not using a lock is introduce 9 years ago: http://codereview.chromium.org/2802015, but with network service, the situation is more complicated. As a result, the lock usage will provide a safer and more simple approach to solve the issue. 3. Calling SetNetworkChangeNotifierFactory early for Android code. BUG=1009981 Change-Id: I88dd50ca23d08f110f7ac7ffe08d50da65a05fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872414Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712848}
-
Zhongyi Shi authored
Bug: 1014092 Change-Id: I74f4b64b6cb677f05f8ff84e48734c164bcc6b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900397Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#712847}
-
Hugo Benichi authored
This patch changes how arc_net_host_impl tracks shill's default network by directly asking NetworkStateHandler when sending NetworkConfiguration objects over mojo instead of tracking default network changed notifications. In addition, an ActiveNetworksChanged notification is sent from Chrome to ARC when a change in the default network occurs and there is more than one active networks. This allows ARC to observe when shill changes the relative priorities of active networks while no other network property changes and to update Android network scores accordingly. BUG=b:143666023 BUG=b:138351476 TEST=Deployed Chrome and ARC P on atlas, verified with Android NetGrapher and adb shell dumpsys wifi that changing the default network with flimflam/test/reorder-services.sh results in consistent active network event notifications to ARC P. Change-Id: I5b38aa58fa61613d7d61419ff6d8a7ca05f646a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890519Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#712846}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c277c38d9064..f8045a095cc1 git log c277c38d9064..f8045a095cc1 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 rharrison@chromium.org Rolling 4 dependencies 2019-11-05 bryan.bernhart@intel.com Support for small resource placement. Created with: gclient setdep -r src/third_party/dawn@f8045a095cc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Iab0b1d3cf828d65fbca0776e3b45eec404d5581f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900101Reviewed-by:
-
Daniele Castagna authored
In crrev.com/c/1860299 we introduced new UMAs related to external displays configuration. We erroneously used unit="DisplayResolution" instead of enum="DisplayResolution" for internal displays resolutions. This CL fixes that. Bug: None Change-Id: Ia173602e8b48ac7b6acce6321f88efcb5fba5080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899858Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#712844}
-
Toni Barzic authored
When active window is drag from shelf to overview, the hotseat will get into extended state, but we should not mark it as manually extended - the hotseat is extended because that's the state expected in overview, not because of the result of the gesture performed by the user. BUG=1019440 Change-Id: I3724946a5b89a16a574551f23c447cf1d6509859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900349 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#712843}
-
Connie Wan authored
Introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/1866058/16/chrome/browser/ui/views/tabs/tab_strip.cc#683 Not sure how to regression test this given that it's a visual/animation issue. Suggestions welcome! Bug: 1021582 Change-Id: Ie57d4b767b84e6b3a975841538e1eb54e1037d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900206 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#712842}
-
Anand K. Mistry authored
Using base::Passed() with BindOnce() is discouraged. Bug: None Change-Id: I28dd4217a1da4facac7ee19b93b19d8c15a53a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895268Reviewed-by:
-
Jared Saul authored
This reverts commit c85cb465. Reason for revert: The test failure that instigated this CL impacted several tests, not just ours, and was seemingly unrelated to our code area. Additionally, another CL that disabled a test for the same failure report disabled the *wrong* test and was subsequently reverted, further implying that the original failure was only temporary (as its offending test was never actually disabled). Original change's description: > [Sheriff] Disable Logic_CanOfferToSaveDynamicForm on Linux > > TBR=estade@chromium.org > > Bug: 1017819 > Change-Id: I8d5f2acbe8c30c5998e8c5a4ebd83c95a555a8a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879692 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709124} TBR=estade@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1017819 Change-Id: Ie76f07d43b6fd71ecf86b1b6a902d1a7924b2521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900129Reviewed-by:
-
Mike Wasserman authored
Update code to better match the latest Screen Enumeration proposal: https://github.com/spark008/screen-enumeration/blob/master/EXPLAINER.md Use the existing Display mojo struct, instead of a new parallel struct. Add [RuntimeEnabled=ScreenEnumeration] Screen attributes, instead of a new parallel object. Rename requestDisplays to getScreens. Update test expectations. Test with chrome://flags#enable-experimental-web-platform-features or --enable-blink-features=ScreenEnumeration Bug: 994889 Test: Automated; getScreens() works with flag enabled. Change-Id: I54f1594c5b6f1ad2a6532f3ee5f8a0184408c7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842339 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#712839}
-
David Grogan authored
Used when a child of NG is laid out by legacy. 3 Flex tests that have img items now pass. Bug: 845235 Change-Id: I7dece003eaba12453131233256a4e755ef1f93cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900031Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712838}
-
Matt Menke authored
Bug: 997049 Change-Id: I4cb68e2e9a64e84a8fe62fbc5333d0945cb400f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898614 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#712837}
-
Sam McNally authored
When a native application attempts to initiate a native messaging connection with a cooperating extension, that extension may not be installed; in this case, the native app should be informed by launching its native messaging host to notify it of this error. This is also needed if the native app provides invalid input when requesting this communication channel. Add NativeMessagingHostErrorReporter, a self-owning class responsible for starting the native messaging host with flag specific to the error and keeping Chrome alive until either the native messaging host terminates (upon informing the original native app of the error), or a 10 second timeout to avoid Chrome getting stuck due to a misbehaving native messaging host. Add plumbing to the existing native messaging host launch code to handle the additional parameter. Bug: 967262 Change-Id: Ie68cbae094de226fa43244719abda434d6200590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675587Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#712836}
-
Rob Schonberger authored
Adds an inline implementation of NeuralStylusPalmDetectionFilterModel, with a few extra changes: 1. Updates the factory to add a Flag and appropriate instantiation of NeuralStylusPalmDetectionFilter when that flag is turned on. 2. Update the unit test of the factory to appropriately test that the NeuralStylusPalmDetectionFilter is correctly instantiated. 3. Update NeuralStylusPalmDetectionFilter with a few lint updates suggested by git cl lint 4. Move 2 items from private to public in NeuralStylusPalmDetectionFilter . Bug: 1009290 Change-Id: I35c5a5e2c61c436dd2eaaeba439245cc7cc9433a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890376 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712835}
-
Findit authored
This reverts commit cc2f9f85. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 712774 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NjMmY5Zjg1Y2UyM2VjYmM4NGM1MmQwYTI1NjhiMjE0ZGRkNmVhMWIM Sample Failed Build: https://ci.chromium.org/b/8897587343409415744 Sample Failed Step: content_browsertests Original change's description: > Reland "Fix UIA Fragment Root Navigation in Inspect" > > This is a reland of 5e7f2837 > > This was reverted due to flaky tests. I was not able to reproduce the > failures, but I was able to see via the logs that the failed cases > were opening the first popup instead of the third. As a mitigation, I > have switched the logic to find the third popup. Previously, I had > added a count parameter to FindNode, so it would find the third node > with that name. This change adds a name to the parent node (in this > case the <input> node), and updated the logic to search for that node > as a parent. > > Original change's description: > > Fix UIA Fragment Root Navigation in Inspect > > > > We discovered that the fragment root change that was recently submitted > > here: https://chromium-review.googlesource.com/c/chromium/src/+/1823822 > > regressed fragment root navigation in Inspect. This was not the case > > when Kevin had first submitted it. I traced it down to the changes that > > I made for Controller-For elements, so this change undoes those > > modifications. > > > > In order to stabilize the content_browsertest that prompted the changes > > (DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/uia), it > > was discovered that there were several issues in how we were > > handling date-time popups. > > > > The first issue is that we were failing to return the proper parent > > window for the fragment root. In > > RenderWidgetHostViewAura::GetParentNativeViewAccessible, we were > > returning nullptr as the parent of datetime popups, which was > > parenting the popup under the root desktop window in Inspect. This > > change now returns the host's window, which places the popup under > > the correct parent window in Inspect. > > > > The second issue is that there was a cardinality problem with datetime > > popup windows. Since they share a BrowserAccessibilityManager with > > the main window (but are under a different fragment root), > > LegacyRenderWidgetHostHWND::GetOrCreateBrowserAccessibilityRoot would > > always return the main window's root kRootWebArea instead of the > > popup window's kRootWebArea. So we'd have two different fragment roots > > that map to the same gfx::NativeViewAccessible. This would cause > > GetFragmentRootParentOf to return the incorrect parent most of the > > time. This change fixes that issue by adding an extra step for popup > > windows that traverses the root node and searches for the popup web > > root via OneShotAccessibilityTreeSearch. > > > > Bug: 1019016 > > Change-Id: I678425c8417334275727053243a39b1039e6f135 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885102 > > Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711358} > > TBR=sky@chromium.org > > Bug: 1019016 > Change-Id: I73dc98eeb049788b3a7a086f5e6ac2927e2b0473 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894761 > Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#712774} Change-Id: I233bd67fb5c6a392e86ef4f65d65d17d907ab00f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900140 Cr-Commit-Position: refs/heads/master@{#712834}
-
Caroline Rising authored
This is only called in View::SetBoundsRect which then triggers a layout as well. This also prevents crashing when initially laying out the new extensions container. Bug: 995448 Change-Id: Ic066bd12870f4dde2392cbcb85321f5e1420a127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899424Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#712833}
-
Etienne Bergeron authored
This CL is fixing a bug where there is a mismatch index/offset between the text_ and layout_text_. The layout_text_ is a rewritten version of text_. The styles sets in RenderText are in offset of text_. There is a function TextIndexToGivenTextIndex(...) which convert an index (char16 array position) from one text to the other one. The previous implementation was using UTF16IndexToOffset(...) which convert from the initial text index to the position (codepoint offset). But there was a missing UTF16OffsetToIndex(...) to convert back to index. The bug detected was with the obscured(...) feature and obscure reveal. The input sequence was { a, B1, B2, c } where each entry is a 16-bit char, but B1 and B2 are a surrogate pair and make a single code point. The obscure feature create a string with 3x bullet { Bullet, Bullet, Bullet } which are 16-bit characters. When they reveal a character the sequence is becoming { Bullet, B1, B2, Bullet }. The "offset" of the last bullet is 3 but is index is 4. This mismatch is making a DCHECK to fire while trying to ItemizeText since the "end" of style will be reported to be at index 3 insteaad of index 4. The issue was not visible without using obscured(...) feature since the conversion is completely skipped. Bug: 1020814, 1021720 Change-Id: Ie008d3a0ce1b4f87d5d81ee04d9e0841a6a466c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896867 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:Robert Liao <robliao@chromium.org> Reviewed-by:
-
Chris Lu authored
This change will be necessary since the Translate Infobar changes states through the Translate lifecycle, requiring the banner texts to be update. Bug: 1014959 Change-Id: I74e908b33e17529dfa3ebd39a636564ce2df2871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897909Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#712831}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f168baf4df53..edf176c888c1 Created with: gclient setdep -r src-internal@edf176c888c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Ic2fc81c4b2059f4789be8ed63578b32ec5aaf1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900202Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712830}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e2a4d97fd4c..2150a694c71f git log 0e2a4d97fd4c..2150a694c71f --date=short --no-merges --format='%ad %ae %s' 2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@2150a694c71f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I0227933ddc1d45c59be145236398a7f07b5fa0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900203Reviewed-by:
-
Scott Violet authored
NewBrowserCallback is used from window.open (among other things). As part of this BrowserFragmentController now has an API to get the list of BrowserTabControllers and the ability to set a single active one. BUG=none TEST=testNewBrowser.testNewBrowser Change-Id: I55702381c1adee4322a6fc660ce161bcc92c3dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897487Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712828}
-
