Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 05 May, 2017 23 commits
  3. 04 May, 2017 17 commits
    • khmel's avatar
      arc: Fix removing shortcuts on package update. · 99842054
      khmel authored 
      TEST=unit tests extented. Manually, updated test app via adb and
     its shorcuts were left in app launcher
BUG=718625
BUG=b/34749664

Review-Url: https://codereview.chromium.org/2860243002
Cr-Commit-Position: refs/heads/master@{#469529}
      99842054
    • ckrasic's avatar
      Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000 · bf2f59c9
      ckrasic authored 
      There are no flags to be updated

deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state.

It achieved results that were in general comparable to "measuring
aggregation" approach, but it had worse rtx rate, and worse QoE, and did
not actually seem to be better in other regards.

Merge internal change: 154601526

https://codereview.chromium.org/2859913003/

fix packet conservation to remove packets from recovery window when they are lost.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2.

This causes a dramatic reduction in losses compared to the previous patch.

The transfer time is approximately the same.

Merge internal change: 154590929

https://codereview.chromium.org/2857243002/

Fix typo in comments.

Merge internal change: 154539040

https://codereview.chromium.org/2854823004/

QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation.

This CL is in preparation for HTTP stream pairs changes.  A prototype
of the entire HTTP stream pairs work is in progress.  This CL is one
subset of that (2nd in the series).

[ HTTP stream pairs builds upon this, by having new QuicSpdySession
overrides that implicitly create headers streams, and abstracting
stream accounting as needed. ]

Add a new factory like method QuicSession::CreateStream(), that
unconditionally creates a new stream.  It's virtual so subclasses of
QuicSession can create streams that are appropriately specialized from
QuicStream.  There are new versions of Create*DynamicStream() called
MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called
ShouldCreate*DynamicStream2().

Separating this out means that fewer overrides of Create*DynamicStream()
and ShouldCreate*DynamicStream() will necessary, because many of those
were actually only needed to specialize the steam types.  Those will go
away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is
deprecated.

Merge internal changes: 154351257, 154373998.

https://codereview.chromium.org/2861673004/

QUIC - stream id refactor for tests.

// AKA - http stream pairs bikeshed #1.

This CL is in preparation for HTTP stream pairs changes.  A prototype
of the entire HTTP stream pairs work is in progress.  This CL is one
subset of that.

Rework QUIC tests so that they do not hard code the assumption that
all headers are on stream 3.  Also, prepare to calculate stream ids
according to whether stream pairs are enabled, i.e. whether they
increment by 2 or 4.

Merge internal change: 150949425

https://codereview.chromium.org/2854833005/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2862563003
Cr-Original-Commit-Position: refs/heads/master@{#469218}
Committed: https://chromium.googlesource.com/chromium/src/+/d60018e0b72b5708797cebe57780ad559877164f
Review-Url: https://codereview.chromium.org/2862563003
Cr-Commit-Position: refs/heads/master@{#469528}
      bf2f59c9
    • dschuyler's avatar
      [MD settings] split up site settings tests · 3884ab63
      dschuyler authored 
      This CL separates the site settings browser tests.

(Code health)
BUG=None

Review-Url: https://codereview.chromium.org/2862463002
Cr-Commit-Position: refs/heads/master@{#469527}
      3884ab63
    • holte's avatar
      Add an override flag to enable metrics reporting. · 8d28e669
      holte authored 
      This simplifies local testing of metrics collection, particularly in dev builds.

BUG=717792

Review-Url: https://codereview.chromium.org/2861563002
Cr-Commit-Position: refs/heads/master@{#469526}
      8d28e669
    • mthiesse's avatar
      VR: Don't stay in VR when exiting webVR if the activity doesn't support VR browsing. · f05a24a4
      mthiesse authored 
      BUG=718610

Review-Url: https://codereview.chromium.org/2862993002
Cr-Commit-Position: refs/heads/master@{#469525}
      f05a24a4
    • dalecurtis's avatar
      Add support for single sample metrics. · 4a9839a2
      dalecurtis authored 
      Single sample metrics offer a mechanism for clients to modify
a histogram sample repeatedly while having it only reported once;
either upon destruction of a helper class or at process termination.

This is helpful since the fast shutdown path simply kills renderer
processes without going through any destructors. In this case we
lose histogram values that might otherwise be reported at that
time.

In media/ code we've created a cumbersome proxy mechanism which
sends histogram values like this to the browser process and records
them there (see WatchTimeReporter and MediaInternals interactions).

Single sample histograms are implemented through a new mojo service
hosted by the browser process that receives samples and logs the
last received sample upon mojo channel closure.

base:: shims are provided so that these metrics can be created by
anyone in the renderer process. For non-renderer processes a default
implementation is provided without the mojo channel behavior.

Usage looks like the following:
  std::unique_ptr<base::SingleSampleMetric> metric(
      base::SingleSampleMetricsFactory::Get()->CreateCustomCountsMetric(
          "Media.VideoRenderer.CadenceChanges", 1, 10, 10));
  metric->SetSample(1);
  metric->SetSample(2);
  metric->SetSample(3);
  metric.reset();

Only the last sample (3) would end up being reported to the histogram.

BUG=689751
TEST=new tests

Review-Url: https://codereview.chromium.org/2687583002
Cr-Commit-Position: refs/heads/master@{#469524}
      4a9839a2
    • stevenjb's avatar
      MD Settings: Network: Do not call setProperties when setting defaults · b59f96b2
      stevenjb authored 
      In https://codereview.chromium.org/2665913002 we set some default
network properties in currentRouteChanged. This was triggering
networkPropertiesChanged_ which udates autoConnect_ and
preferNetwork_ which triggers calls to setNetworkProperties.

To prevent this sort of error, set networkPropertiesReceived_
once properties are received from Chrome and do not call
networkingPrivate.setProperties until that has been set.

BUG=718389

Review-Url: https://codereview.chromium.org/2863713004
Cr-Commit-Position: refs/heads/master@{#469523}
      b59f96b2
    • wychen's avatar
      Update deps in WebKit/public to reflect actual usage · 06014b12
      wychen authored 
      This is a prerequisite of whitelisting //third_party/WebKit/public
for header checking in GN.

BUG=716359

Review-Url: https://codereview.chromium.org/2851953002
Cr-Commit-Position: refs/heads/master@{#469522}
      06014b12
    • ntfschr's avatar
      WebView: add support for MultiWindow when choosing interstitial · d72c255b
      ntfschr authored 
      This CL changes the logic for choosing the loud vs. quiet interstitial.
Instead of comparing against screen dimensions, we instead use window
dimensions, which makes more sense when Android Multi-Window is enabled.

BUG=718195

Review-Url: https://codereview.chromium.org/2861713005
Cr-Commit-Position: refs/heads/master@{#469521}
      d72c255b
    • rtoy's avatar
      Convert Panner tests to new Audit · 428cd3be
      rtoy authored 
      Manually convert tests to use new Audit

BUG=704967
TEST=
Panner/panner-automation-basic.html
Panner/panner-automation-position.html
Panner/panner-distance-clamping.html
Panner/panner-rolloff-clamping.html
Panner/pannernode-basic.html

Review-Url: https://codereview.chromium.org/2799793003
Cr-Commit-Position: refs/heads/master@{#469520}
      428cd3be
    • hiroshige's avatar
      Fix case issues in a wpt test module/execorder.html · 78cbcd5c
      hiroshige authored 
      The actual filenames are all lowercase, but src attributes in
execorder.html contains uppercase letters. This causes the scripts not
found and thus timeouts on Linux (which runs on a case-sensitive
filesystem).

This CL fixes the timeout by making the src attributes all lowercased.

BUG=594639

Review-Url: https://codereview.chromium.org/2856053005
Cr-Commit-Position: refs/heads/master@{#469519}
      78cbcd5c
    • thomasanderson's avatar
      Sysroots: Remove a hack that adds gcc 4.6 to ld.so.conf · a0ca4a35
      thomasanderson authored 
      This CL removes a hack that adds /usr/lib/gcc/x86_64-linux-gnu/4.6 to
ld.so.conf.d/zz_hack.conf.  The only sysroots that exist currently are
Jessie and Trusty which both use gcc 4.8.

This caused the following flags to be passed to the linker:
-L/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
-Wl,-rpath-link=/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
While harmless, it is confusing and should be removed.

R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2863663003
Cr-Commit-Position: refs/heads/master@{#469518}
      a0ca4a35
    • mthiesse's avatar
      WebVR: Don't crash when receiving null image from rendering context. · a1215009
      mthiesse authored 
      Not sure why/how this happens, but I was seeing this infrequently on  https://with.in/watch/under-neon-lights/

BUG=718501

Review-Url: https://codereview.chromium.org/2862883002
Cr-Commit-Position: refs/heads/master@{#469517}
      a1215009
    • gab's avatar
      Improve usage documentation of scoped task environments. · 1f58e951
      gab authored 
      And improve information provided by out-of-order destruction of task
scheduler and its provided constructs in unit tests.

(comes out of discussion on https://codereview.chromium.org/2852333004/)

BUG=708584, 689520
TBR=avi@chromium.org (documentation update in test_browser_thread_bundle.h)

Review-Url: https://codereview.chromium.org/2860063003
Cr-Commit-Position: refs/heads/master@{#469516}
      1f58e951
    • rjkroege's avatar
      Work-around ASAN problem in profiler · 6fc72bec
      rjkroege authored 
      ASAN wraps the kernel dylib on mac. Special case this to avoid tripping
a DCHECK.

BUG=718628
TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2859303002
Cr-Commit-Position: refs/heads/master@{#469515}
      6fc72bec
    • domlaskowski's avatar
      exo: Confine windows to primary display · 53f36cb4
      domlaskowski authored 
      Multi-display support in ARC was punted to the next milestone. This CL
temporarily prevents windows from being dragged to secondary displays
by using display rather than screen coordinates for window bounds.

BUG=714832
TEST=ARC apps cannot be dragged to secondary displays.

Review-Url: https://codereview.chromium.org/2860863004
Cr-Commit-Position: refs/heads/master@{#469514}
      53f36cb4
    • jbauman's avatar
      Make disabling accelerated VPX decoding a GPU driver bug workaround. · beabb626
      jbauman authored 
      This is currently a blacklist entry, which means that it's calculated in
the browser and the resulting decision could be incorrect if the GPU
process uses a different GPU from what the browser expects. If this is
a GPU driver bug workaround entry then it'll be determined with more
information in the GPU process.

BUG=687004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2682723003
Cr-Commit-Position: refs/heads/master@{#469513}
      beabb626