GitLab

I confirmed with simonhatch@ that this made sense given the way that
the Chromium TracingController works. The agent will be communicating
over a serial connection, which probably shouldn't be done
synchronously.

BUG=542837

Review URL: https://codereview.chromium.org/1407033008

Cr-Commit-Position: refs/heads/master@{#357144}

This CL adds tests for regressions that have been fixed
recently, some of them involving ContentViewCore.

In order to be able to properly instrument the ContentViewCore,
changes in the testing framework have been made. There are now
a couple of wrapper classes: OverlayPanelContentWrapper and
ContentViewCoreWrapper, which allow us to test for example
if the onShow() method was ever called, or if URLs have been
properly removed from local history when not seen.

This CL also introduces a few more helpers to simulate searches
caused by gestures (long press and tap) in a way that it
encapsulates the simulation logic and prevent flakiness. We
were manually doing a search term resolution by calling a
fakeResponse() method. Sometimes we are calling this when
not necessary (on long press) and tests don't call it in the
same order. We are also assuming it completed when the Bar
peeks (which works but under the wrong assumption). There are
now simulateLongPressSearch(id) and simulateTapSearch(id)
methods that simulate the search and handle the resolution
automatically when the system requests one.

There are several helper methods in ContextualSearchManagerTest
that are similar but do slightly different things, and some
assumptions are not quite correct which can and may be causing
falkiness in some tests. A couple of examples are: tests rely
on the change of state of the Panel in order to determine that
animations/actions are done. The closed state was being changed
before destroying the Contents. This is now fixed.

Another example is the tapBasePageToClosePanel() helper method
that wasn't properly working when the Panel was peeking while
a long press selection is present. I believe this is the cause
of the flakiness of 3 of our tests.

The new search simulation method should help making our tests
more robust and a followup CL is required to change existing
tests to use the new methods, once it has been confirmed that
the new methods work properly on existing test bots.

BUG=543319

Review URL: https://codereview.chromium.org/1426683005

Cr-Commit-Position: refs/heads/master@{#357143}

Follow up r355010 and arrange for persisted plugin widget disposal
when the plugin is completely detached and removed from the tree.

r355010 restricted disposal to not happen for persisted widgets
when re-attaching, but also ended up not disposing for the
fully-detached persistent plugin widget case.

Lacking those, widgets would end up being finalized without their
required dispose() having been called first.

R=haraken
BUG=544175

Review URL: https://codereview.chromium.org/1422503009

Cr-Commit-Position: refs/heads/master@{#357142}

BUG=548694
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1425693004

Cr-Commit-Position: refs/heads/master@{#357141}

BUG=none

Review URL: https://codereview.chromium.org/1406973006

Cr-Commit-Position: refs/heads/master@{#357140}

BUG=510485

Review URL: https://codereview.chromium.org/1412013008

Cr-Commit-Position: refs/heads/master@{#357139}

Based on Fredrik Söderquist <fs@opera.com>'s idea.

For <use>-instanced SVGPathElements, reuse the referenced Path object (now
cached in SVGPath).  This ensures that all <path> instances paint using the
same SkPath, which in turn reduces the pressure on internal Skia path caches.

BUG=skia:4527,549242
R=fs@opera.com

Review URL: https://codereview.chromium.org/1425913004

Cr-Commit-Position: refs/heads/master@{#357138}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c2e2977..f93982a

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Commits in this roll:
f93982a bsalomon@google.com Don't run nvpr on TSAN bot
21adcb9 halcanary@google.com DEPS: roll zlib: 20 new commits

Review URL: https://codereview.chromium.org/1423423002

Cr-Commit-Position: refs/heads/master@{#357137}

The error path for dealing with missing VCGT data was failing to free
the loaded profile. Unfortunately due to https://crbug.com/549239 this
error is occuring in the wild. The new unit tests at
https://crrev.com/1430633003 cover this particular use case.

BUG=None
TEST=Inspection of error paths show no more leaks.

Review URL: https://codereview.chromium.org/1430573006

Cr-Commit-Position: refs/heads/master@{#357136}

Drop SVGGraphicsElement.getTransformToElement as on SVG WG F2F:
https://lists.w3.org/Archives/Public/www-svg/2015Aug/att-0009/SVGWG-F2F-minutes-20150824.html#item02

BUG=524432

Review URL: https://codereview.chromium.org/1406303007

Cr-Commit-Position: refs/heads/master@{#357135}

Revert of "webgl: optimize webgl.texSubImage2D(video) path." (patchset #3 id:40001 of https://codereview.chromium.org/1413833006/ )

Reason for revert:
Reverting this due to the security concerns piman raised, also it broke video related texture tests on Android.

Original issue's description:
> Reland of "webgl: optimize webgl.texSubImage2D(video) path."
>
> Original CL: https://codereview.chromium.org/1315323006/
> Revert: https://codereview.chromium.org/1418513016
>
> Reason for revert:
> Reverting to address webgl_conformance_tests break in:
> https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%209%29/builds/3534
>
> Reason for reland:
> There is a bug in glCopySubTextureCHROMIUM extension. GLES2DecoderImpl::DoCopySubTextureCHROMIUM/DoCompressedCopySubTextureCHROMIUM
> uses ValidForTexture to check dimensions of source texture. If the source
> texture is backed by GL Image, the decoder can report false positive error.
> This CL doesn't use Texture::ValidForTexture() for GL Image.
>
> TEST=WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_*
> BUG=349871, 504773, 549531
>
> Committed: https://crrev.com/7c26f04cf12c2c72fdab8e4764faf9305724c7ee
> Cr-Commit-Position: refs/heads/master@{#357100}

TBR=kbr@chromium.org,dalecurtis@chromium.org,philipj@opera.com,zmo@google.com,piman@chromium.org,dongseong.hwang@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=349871, 504773, 549531

Review URL: https://codereview.chromium.org/1420843005

Cr-Commit-Position: refs/heads/master@{#357134}

BUG=546607

Review URL: https://codereview.chromium.org/1430573005

Cr-Commit-Position: refs/heads/master@{#357133}

Normalization is lossy and not called for in the spec. Don't do it.

BUG=487510,545678
R=jww@chromium.org

Review URL: https://codereview.chromium.org/1420483005

Cr-Commit-Position: refs/heads/master@{#357132}

[Cast, Android, PresentationAPI] Show play/pause button when the presentation supports media commands.

Add RemoteMediaPlayer to the CastRouteController.
Notify it of the media namespace messages.
Use it to handle play/pause from the controls.

BUG=541629

Review URL: https://codereview.chromium.org/1412293004

Cr-Commit-Position: refs/heads/master@{#357131}

This change sets Pylint's dummy-variables-rgx variable so that variable names
consisting entirely of underscores will not trigger unused argument warnings.

BUG=475714
R=dtu,aiolos,nednguyen@google.com

Review URL: https://codereview.chromium.org/1114343003

Cr-Commit-Position: refs/heads/master@{#357130}

BUG=549021

Review URL: https://codereview.chromium.org/1407333005

Cr-Commit-Position: refs/heads/master@{#357129}

BUG=538325

Review URL: https://codereview.chromium.org/1417753007

Cr-Commit-Position: refs/heads/master@{#357128}

In WebView we initalize popup windows asynchronously so loading a url
synchronously can result in it being loaded before the WebView
sets its webcontentsdelegate.

BUG=548316, 542548

Review URL: https://codereview.chromium.org/1405333005

Cr-Commit-Position: refs/heads/master@{#357127}

This change moves ownership of an OverlayPanel's scene layer to
the panel itself. The concept of UpdatableSceneLayer has been
introduced as a child class of SceneLayer.

BUG=521773

Review URL: https://codereview.chromium.org/1374603004

Cr-Commit-Position: refs/heads/master@{#357126}

* Fix spacing
* Ellipsize from start as that part is less important
* Apply official formatting

Screenshot: http://imgur.com/bJy8hoH

BUG=541617

Review URL: https://codereview.chromium.org/1426453003

Cr-Commit-Position: refs/heads/master@{#357125}

indicate that other backends need equivalent functions, but they
seem instead to just take an extra parameter to Create().

Review URL: https://codereview.chromium.org/1413993006

Cr-Commit-Position: refs/heads/master@{#357124}

That DCHECK was originally added to:
1.) Prevent issues with WKWebView cookie clearing on iOS8 (not supported
    by WKWebView anymore).
2.) Ensure correct Modal Data Partitioning (postponed work).

BUG=537244

Review URL: https://codereview.chromium.org/1427003003

Cr-Commit-Position: refs/heads/master@{#357123}

Previously we were using the presence of main thread input gestures
(e.g., a mouse drag) as a hint that expensive loading and timer tasks
are non-essential. This patch relaxes the policy to allow loading tasks
in this use case to avoid starving loading work for the entire duration
of the gesture, e.g., for loading new content in an infinite scrolling
scenario.

BUG=548606

Review URL: https://codereview.chromium.org/1420773003

Cr-Commit-Position: refs/heads/master@{#357122}

This was left in http://crrev.com/1421343002 to prevent downstream from
breaking, but downstream has now been converted.

BUG=547973

Review URL: https://codereview.chromium.org/1419073005

Cr-Commit-Position: refs/heads/master@{#357121}

Fixes compile error caused by https://codereview.chromium.org/1425033006.
Although AudioPlayerElement's new property can be resolved by reading element's script directly,
I fixes this in old style (using extern) for now.

BUG=none
TBR=yawano@chromium.org

Review URL: https://codereview.chromium.org/1428983002

Cr-Commit-Position: refs/heads/master@{#357120}

This CL replaces API of user_manager::UserManager, thus modifying API of all
child objects, and all calls to UserManager.

This is part of transition to AccountId.

BUG=468875
TEST=manual

Review URL: https://codereview.chromium.org/1412813003

Cr-Commit-Position: refs/heads/master@{#357119}

clang-cl complains:
..\..\third_party\WebKit\Source\core\html\HTMLSelectElement.cpp(80,23) :
error: declaration requires a global constructor [-Werror,-Wglobal-constructors]
static const unsigned maxListItems = std::numeric_limits<int>::max();
                      ^

See also thread "[chromium-dev] std::numeric_limits vs INTN_MAX"

BUG=82385
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1411323005 .

Cr-Commit-Position: refs/heads/master@{#357118}

BlinkOTSContext::GetTableAction currently uses a custom TABLE_TAG
macro which is almost exactly the same as OTS_TAG, but OTS_TAG is
the blessed way to create tags for use with OTS.

Review URL: https://codereview.chromium.org/1416943004

Cr-Commit-Position: refs/heads/master@{#357117}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/13391dd..c2e2977

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Commits in this roll:
c2e2977 mtklein@chromium.org Dedup SkPaths by gen-ID when going to .skp

Review URL: https://codereview.chromium.org/1415183003

Cr-Commit-Position: refs/heads/master@{#357116}

This CL removes the remaining code related to discarding from TabStripModel to TabManager. It also cleans up the API exposed for discarding.

Note that we still have one pending code in browser.cc that I'll investigate independently, as I'm not even convinced of it's usefulness.

BUG=539504

Review URL: https://codereview.chromium.org/1427613002

Cr-Commit-Position: refs/heads/master@{#357115}

RC4 may still be re-enabled via the RC4Enabled administrative policy, until
sometime around September. Also control it via a field trial so we still have
an escape hatch should something catastrophic happen.

Keep the deprecated cipher suite fallback around (rename the parameter since I
got the naming convention wrong) since it's still got the IIS AES-GCM
workaround in it, and it will be used in not too long for DHE_RSA instead.

BUG=375342
TEST=Loading https://rc4.badssl.com/ fails with ERR_SSL_VERSION_OR_CIPHER_MISMATCH
     Relaunching Chrome with --force-fieldtrials=RC4Ciphers/Enabled/ makes that page succeed.
     Relaunching Chrome after setting the RC4Enabled polcy to true makes that page succeed.
     (Note: press refresh when loading the site to make sure it's not cached.)

Review URL: https://codereview.chromium.org/1422293002

Cr-Commit-Position: refs/heads/master@{#357114}

R=simonhatch
BUG=546193

Review URL: https://codereview.chromium.org/1423133007

Cr-Commit-Position: refs/heads/master@{#357113}

The alwaysWatchForChanges parameter in NetworkChangeNotifierAutoDetect
constructor has been replaced by the more generic RegistrationPolicy
in crrev.com/1358163004.

BUG=520088

Review URL: https://codereview.chromium.org/1411243013

Cr-Commit-Position: refs/heads/master@{#357112}

Originally I used the value 0 for the default touch-action value
(TouchActionAuto).  But as touch-action has expanded, it would be
a lot more convenient if we used a pure bit field (where "auto"
was all flags set, and "none" was 0).  This was hard to change
before the blink merge, but is now pretty easy.

BUG=None

Review URL: https://codereview.chromium.org/1422513006

Cr-Commit-Position: refs/heads/master@{#357111}

This was useful for debugging and early integration efforts in ChromeOS
and is no longer required.

BUG=549558
TEST=On amd64-generic_freon observe that loading from named .icc file
functions correctly.

Review URL: https://codereview.chromium.org/1428963002

Cr-Commit-Position: refs/heads/master@{#357110}

Also, add a test for the UrlResponseInfo API.

R=mef

Review URL: https://codereview.chromium.org/1419033006

Cr-Commit-Position: refs/heads/master@{#357109}

Increase the tab closure timeout for accessibility to
allow enough time for the 'Reopen Closed Tab' text
to be read and the user to take action.

BUG=528386

Review URL: https://codereview.chromium.org/1420433008

Cr-Commit-Position: refs/heads/master@{#357108}

CriteriaHelper seems to be a carry-over from ContentShell testing
code and isn't necessary for Cronet Sample instrumentation tests.

R=xunjieli
TEST=Instrumentation test CronetSampleTest

Review URL: https://codereview.chromium.org/1419033005

Cr-Commit-Position: refs/heads/master@{#357107}

svg/text/text-selection-ws-02-t.svg is now slightly more correct on
OSX10.6. Request rebaseline.

BUG=549594
TBR=pkasting
NOTRY=true

Review URL: https://codereview.chromium.org/1424363002

Cr-Commit-Position: refs/heads/master@{#357106}

cachedImage->imageForLayoutObject() no longer returns
BitmapImages. The surrounding code is still correct since
cachedImage->imageForLayoutObject() may return a SVGImageForContainer
which does not propagate the correct filename extension.

NOTRY=true
BUG=128055

Review URL: https://codereview.chromium.org/1429803002

Cr-Commit-Position: refs/heads/master@{#357105}