- 19 Jan, 2021 40 commits
-
-
Rainhard Findling authored
The test is flaky. TBR=lukasza@chromium.org Bug: 1163630 Change-Id: I63691605c11a1ab5cc0adafaa03544d6fb6a974f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637494Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#844713}
-
Titouan Rigoudy authored
I have promised a few times that I would extract these tests once they reached a critical mass and I had a minute. That time has come. Bug: chromium:1167697 Change-Id: I5808dfa7bfac32190c39354895096c9e0679a398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632681 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844712}
-
Jan Wilken Dörrie authored
This change fixes an issue inside IsContiguousIterator that would fail compilation if it was instantiated with an iterator to a container that has a non-trivial value_type. This was because `IsContiguousIterator<It>` instantiated `std::basic_string<iter_value_t<It>>` to determine whether `It` was an iterator for a `std::basic_string`. This would then trigger a static_assert inside basic_string if `iter_value_t<It>` was not a trivial type. Now IsContiguousIterator<It> only attempts to instantiate a std::basic_string if `iter_value_t<It>` is a trivial type, avoiding this issue. Bug: 828324 Change-Id: I1ab8d10b1847cca09041cc3f2fe623d2a04602fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632958 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#844711}
-
Robbie Gibson authored
The cause of this DCHECK (and resulting broken UI) was that as part of closing the tab grid, the tab strip is snapshotted. As it has changed (new tab added), everything, including the tab grid has to be re-laid out. This causes the tab grid to scroll back to the recent tabs page, causing the bvc to be removed after it was added correctly earlier. This ends up with a broken UI and a black screen. The fix is that the tab grid coordinator should alert the tab grid that its content will disappear before changing the pan handler state. Bug: 1094335 Change-Id: Ie9062766952b6a5957046b472515223010b6c58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632654Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#844710}
-
Yoshisato Yanagisawa authored
Bug: b/168080931 Bug: b/147265909 Change-Id: I6cdcd2fb6a5813b453ef809011d6c09d9ee169a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637302Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#844709}
-
Victor-Gabriel Savu authored
Bug: None Change-Id: I07b8ff33ca484cbc88d369b6ff74fcdeb1e20c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635671 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844708}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1cb592d4efd1..cc7aa8e318bb 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 68635b431b3c to 81430e11c81e (12 revisions) 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 149733cead63 to 8da0f82baf35 (2 revisions) 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1d3066a6 to 00da91bb (227 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I5929eaba68d292c36e7d82879dc40a1353aceeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636995Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844707}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I493389752fdb93e9df006ee63a14eaebd5c650c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637414Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844706}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611024810-f8a51712b469a1b51b3e448822968fd32c8978ae.profdata to chrome-win64-master-1611035655-73de094cb5ff55b60927a0f5adde75a5bce05096.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I86acd36af6ff9f3b19cf62ae0cd2e71c41b2c141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637335Reviewed-by:
-
Kenichi Ishibashi authored
We have a hypothesis that ServiceWorkerRegistration could be destructed between ActivateWaitingVersion() and ContinueActivation(). This CL adds an instrumentation to confirm the hypothesis. Bug: 1159778 Change-Id: Id15e4832e6ce82cc5230dc3f907b3e90036e62de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636007Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844704}
-
Jérémie Boulic authored
Background.m.js replaces background.js and background_scripts.js. Update background.html to load the Image Loader as JS modules. Optimize_webui to run Image Loader as JS modules. Tests: Load image loader and check that there is no additional error in the console. Current integration tests pass. Bug: 1133186 Change-Id: I3cdf9fd2a59bca080b15c3efad51739a15fa93e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635384 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#844703}
-
Yuta Hijikata authored
This is a mechanical change replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and adding BUILDFLAG(IS_CHROMEOS_LACROS) to defined(OS_LINUX) to ensure switching lacros' target_os from linux to chromeos does not affect the lacros binary. More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: Icb4d7b9739b315e74cd9157dda932c1e3e2b02b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628771Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#844702}
-
Ye Kuang authored
Bug: 1141780 Change-Id: Iec73a683433b599f8a226e1b035c01e2f4a7f805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636744Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
-
Heng-Ruey Hsu authored
Chrome camera app enables multiple streams while recording. also pass type checking Bug: b:151047537 Test: Manually test. preview is 640x360 and recording is 1280x720. Change-Id: I8171b0061a94ca8653c044857da2598eece43e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409683 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#844700}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611013939-848f93cc4650c420e66bbec68de10e40d4656b36.profdata to chrome-mac-master-1611035655-254822a7c03cbefbcbdc34527b5136e1083ea204.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9bc425290d545bb217bd83697e265097345536aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637393Reviewed-by:
-
Glen Robertson authored
This allows other code to depend on profile.h (very common as it is a keyed service key) without depending on all of //c/b:browser. This improves modularization of the codebase and will help to break dependency cycles in GN. Bug: 1149277 Fixed: 1149277 Change-Id: Ib8a160dbcd29301490f9826278262980e34dbf9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542933Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844698}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5eda7597b6b7..eddf4e758768 2021-01-19 dberris@chromium.org chromeperf: Support legacy test names If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: skyostil@google.com Change-Id: I73a164a8051a942473b4d061de008de106e4127b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637254Reviewed-by:
-
Jan Krcal authored
This CL adds WebContentsModalDialogManager to the sign-in flow web contents and implements its delegates. This is needed by the webauthn modal dialog which is in turn needed by the Gaia sign-in flow with security keys. Bug: 1167887 Change-Id: Ief107bf16056c5a8ceb3ed7b192b22497957e09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636399 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL adds two accelerators into the profile creation flow to improve accessibility and usability: - the back action for screens that actually show the back button - the reload action for the sign-in flow that happens over the internet and thus loading of the page can fail. Bug: 1126913, 1167675 Change-Id: I3c197dea2859c0136db62249064249e0569a93da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627403 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611013939-1c9af1927a800d0fae0bbc5808e1b1b28e5ab3fe.profdata to chrome-win32-master-1611024810-772a0a2d15ca5658988961a1c7ea3d1b91cdca35.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I04293ea11cd07dae3798b3b26e3b5ce815ab14a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636994Reviewed-by:
-
Eric Willigers authored
We add use counters for - close() - readable - writable - remoteAddress - remotePort Bug: 905818 Change-Id: I02539b29d3c1035642ba9200651ac15135eb58c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636634 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844693}
-
Tal Pressman authored
Following the discussions on platform-architecture-dev[1], this CL expands MojoBindingContext's responsibility to include context lifecycle notifications which were previously in ContextLifecycleNotifier. [1] https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/_7Ybv_RLgic Change-Id: Icdcc2a59bf0580b919d1dbb015a45bfd184583b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596279 Commit-Queue: Tal Pressman <talp@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#844692}
-
Luciano Pacheco authored
When running as JS module which is strict by default, the IF condition was raising an exception because the Polymer variable isn't defined. Fix by checking the variable explicitly in the global scope. Bug: 1133186 Change-Id: If62e8d5fd45a4453e67810c04a6bdf3cf2033fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637097 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844691}
-
Polina Bondarenko authored
Add ArcSnapshotRebootNotification that is shown if inside a snapshot update interval and user is logged in. SnapshotRebootController tries to reboot the device once user consents by pressing a restart button. BUG=b:170187468 TEST=components_unittests TEST=unit_tests Change-Id: I3dcae858e8f889aa4be4fc7d5344359488c9d5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627523Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#844690}
-
Keishi Hattori authored
chrome/install_static/DEPS excludes base/ includes so we cannot include checked_ptr.h Bug: 1080832 Change-Id: I78fa4d1404da39c3539e7619367911e0aa6522e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636817Reviewed-by:
-
Peter Kotwicz authored
This CL rolls: androidx.activity androidx.appcompat androidx.fragment androidx.gridlayout androidx.leanback androidx.preference androidx.slice androidx.savedstate androidx.transition The InputTypestTest.java test changes are needed because the internals of how fragments listen to the result after launching an activity have changed. See implementation of FragmentManager#launchStartActivityForResult() BUG=1064277 Binary-Size: Method count increase is unavoidable due to many libraries. Change-Id: I8ee9bcb199b60e039213975586f2d6022e06311c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602665 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#844688}
-
Wei Lee authored
As a follow-up of https://crrev.com/c/2547856, since we have already changed to use test/test.html instead of views/test.html in test codes, it should be safe to remove views/test.html to avoid confusion. Bug: b/173092399 Test: tast run [DUT] camera.CCAUISmoke.swa Change-Id: I904591b53591a388c729a7857144557dd1b08267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636735 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#844687}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c1912a4fbb17..111e01a4ac13 2021-01-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I20738df292c8dd6a87aa7ed32d4baa788ba8d55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636996Reviewed-by:
-
Yoshisato Yanagisawa authored
Now I heard it looks working. Let me remove the limitation. Bug: b/64390790 Change-Id: Ie36419d538c2a32a4dad98dd93e0574a4c869cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637176 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
-
Thiabaud Engelbrecht authored
See related bug for details. This CL lays the groundwork for further ParkableImage work by encapsulating the RWBuffer in DeferredImageDecoder inside a ParkableImage. This CL does not introduce any changes to functionality. Bug: 1142834 Change-Id: Ic5497b89346f8b2437a41d70381220b72ffed9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519728 Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
When running as JS modules which is strict by default the cr.ui.List fails when trying to set the label here [1]. Fix by adding a no-op setter in the FileGrid.Item. [1] - https://source.chromium.org/chromium/chromium/src/+/master:ui/webui/resources/js/cr/ui/list.js;l=898;drc=d95bb037d381ef68fa70418e2a8dedce62c1127b Bug: 1133186 Change-Id: Idc0a97d8739c029dc1709d8c90bd20aaf786fd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636742 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL replaces blink::mojom::ResourceType with network::mojom::RequestDestination in content/{common,renderer}/service_worker since blink::mojom::ResourceType is deprecated[1]. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: Ia88dc12a3a655d09419a9b9c88c9457b74abdb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635999Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#844682}
-
Luciano Pacheco authored
Now that <bread-crumb> can run as JS modules the <cr-action-menu> works in the unittest and can be shown/hidden. Bug: 1133186 Change-Id: I45fe6eecca50499ac4574f57234bb7af30dc4597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636903 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611013939-db0b1e97bc691be6bf78d3a336cf34d826bfa98b.profdata to chrome-win64-master-1611024810-f8a51712b469a1b51b3e448822968fd32c8978ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4a43c44d0bef83e8bb23f749ab951559bc133694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636717Reviewed-by:
-
Luciano Pacheco authored
This is a preparation to run Files app as JS modules. Bug: 1133186 Change-Id: I0447d7c19950c69aa47ecb33f5df35a0fcb330d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636814 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a27413fde15..1cb592d4efd1 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 04772515a8b6 to e45593cb0876 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I28776299b5605b874dff3282df260bbdcf8f4950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636716Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611003391-e5257fde85260089be74668a059af9daef590c17.profdata to chrome-win32-master-1611013939-1c9af1927a800d0fae0bbc5808e1b1b28e5ab3fe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib5995358cca7df1b57fa4cb90e1e67ccabb6f0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636673Reviewed-by:
-
Kenichi Ishibashi authored
This CL replaces ClearForShutdown() call in the destructor of ServiceWorkerContextCore with AbortAll() to run callbacks. Some callbacks contain mojo response callbacks which need to be executed before being destroyed if their corresponding bindings are still connected. It's a bit hard to disconnect these bindings so run callbacks in destructors. Bug: 1161799 Change-Id: I39ff795f7246d944f26f2814cb60adfd68b17abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635403Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844676}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cf567b6b9616..5eda7597b6b7 2021-01-19 dberris@chromium.org Reland "chromeperf: Anomaly configs in subscriptions" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: skyostil@google.com Change-Id: I91a4e19a9636d5dd2aba469ef2d928f4c45b17dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636267Reviewed-by:
-
Maggie Cai authored
This reverts commit 21a8ee36. Reason for revert: This CL is likely the culprit for the failure of tests: AssistantTimersBrowserTest.ShouldRemoveTimerWhenStoppingViaNotification AssistantTimersBrowserTest.ShouldTickNotificationsAtRegularIntervals on builder linux-chromeos-chrome First occurance: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/11466 Original change's description: > views-posse: Add metadata to notification_view_md > > Bug: 1159562 > Test: build > Change-Id: I5cd5b56c5ef11899bdac3122ed1525a24bbf6fa5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615725 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > Commit-Queue: Sara Kato <sarakato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844496} TBR=yoshiki@chromium.org,kylixrd@chromium.org,sarakato@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I3fe76cb2391afb9ef454f3e3fb8d8c44c6753013 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636737Reviewed-by:
Maggie Cai <mxcai@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#844674}
-
