- 11 Apr, 2019 13 commits
-
-
David Bienvenu authored
Bug: 873414 Change-Id: Iaffc14914d658866e9d1c7e1e794a8754a5ce9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559168 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#649726}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b60f2a72fcb3..dc0c991440db git log b60f2a72fcb3..dc0c991440db --date=short --no-merges --format='%ad %ae %s' 2019-04-10 rmhasan@google.com Reland "Adds optional expectations_files and tags fields to the JSON results" Created with: gclient setdep -r src/third_party/catapult@dc0c991440db The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=skyostil@chromium.org Change-Id: I61f3e4dbee9621776cae3443089c343ed04bbe0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649725}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb5bcca99989..be94a4842692 git log fb5bcca99989..be94a4842692 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@be94a4842692 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ibb8440687d66c8e7888d0aac21e9b113c540f3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561794Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649724}
-
Umesh Patil authored
This was causing the no_NO and sv_SE locales to be combined into no_NOsv_SE. Bug: b/130313218 Change-Id: I679e4568f0aa8b573abf96c7588350101d3f967a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562117Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649723}
-
Abhishek Bhardwaj authored
This change adds a switch that prevents CPU throttling for the ARC container. This is needed for some ARC tests that timeout when the container is throttled. BUG=b:118696077 TEST=Manual testing. Change-Id: Ic78a8f3cc00d2b33ce8d083bfd6b84f9de246ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561050Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649722}
-
Jinsuk Kim authored
Previously Tab constructor was passed the parent tab's ID. This CL changes that by passing the parent Tab instance instead. Main motivation is to get rid of the references to TabModelSelector in Tab, which violates access in hierarchy. TabModelSelector now provides a static method for call sites that used |Tab.getModelSelector|. which is removed in this CL. Bug: 925242 Change-Id: I978d5e18078f3deddccb2b07d8d0efe302387ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516120Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#649721}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0743a1400d8b..4f74c21e2e9f git log 0743a1400d8b..4f74c21e2e9f --date=short --no-merges --format='%ad %ae %s' 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@4f74c21e2e9f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ied4ac41a7b07c9bcf670eb975c1609b5e0cda705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561793Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649720}
-
Min Qin authored
AllDownloadEventNotifier will listen to SimpleDownloadManagerCoordinate. And report all the download events to its observers. BUG=942770 Change-Id: I29b1e573d9c1f0e8b05002499410f296b6873765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560446Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649719}
-
Eric Aleshire authored
This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. I add a new helper which assists in creating NSErrors. Bug: 922813 Change-Id: Ib2fc2bb0b016afc416ccbbdae19c4acbcaf48350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553085 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#649718}
-
David Staessens authored
Currently the video_decode_accelerator_tests return '0' if the test failed to even start because of missing video files or wrong parameters. This CL changes the return value so the tests will be properly marked as 'failed' in these cases. TEST=ran new VDA (perf) tests on nocturne BUG=879065 Change-Id: Ibd7fae645872c02415ee5a8dadf2cd082eb36939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551735 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649717}
-
Min Qin authored
If a download is on external sdcard, FileProvider won't be able to generate a content URI for the file. On some devices this will raise an exception. This CL just catches all exception in case that happens. BUG=893053 Change-Id: I3fdc35a049226970f0027dc7598a274135d9c0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562252Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649716}
-
David Staessens authored
This CL increases the verbosity of error messages when loading a video or its metadata failed when running the video_decode_accelerator_tests or the video_decode_accelerator_perf_tests. This makes debugging failing tests a bit easier. TEST=ran new VDA (perf) tests on nocturne BUG=None Change-Id: I29a437d9ae95e6cd403be6844a89730e99a22dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560873 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649715}
-
Patrick Noland authored
Bug: 943635 Change-Id: Ib8fb4068256dd3b064e46778859bb251714dcfe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562831Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#649714}
-
- 10 Apr, 2019 27 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b4b3ea05ebde..f4c3f4562eee git log b4b3ea05ebde..f4c3f4562eee --date=short --no-merges --format='%ad %ae %s' 2019-04-10 enga@chromium.org Disable RenderPassTest.TwoRenderPassesInOneCommandBuffer on OpenGL and Metal Created with: gclient setdep -r src/third_party/dawn@f4c3f4562eee The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950768 TBR=cwallez@chromium.org Change-Id: I1dd35d2b59762160589fd7fd0fe85c35f5d62720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562068Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649713}
-
chaopeng authored
The crash report shows DirectManipulation may call DirectManipulationEventHandler OnViewportStatusChanged to READY state after DirectManipulationHelper Destroyed then crash because we called Reset to invalidate DMHelper. In this CL, we pass the viewport size to DMEventHandler and use it to reset viewport at gesture end. Also DMEventHandler does not need to store pointer of DMHelper. Bug: 951293 Change-Id: I39a3402659b9ae117ab45288b68dd5d595e58457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562153 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649712}
-
Xing Liu authored
This CL adds impression store that talked to the level database that persists impression types. Bug: 930968 Change-Id: I6e1074901f78a8a4fc23fd33d77507426edc89fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560490 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#649711}
-
Mitsuru Oshima authored
Bug: 947154 Change-Id: If5d8ce33b7c54e0b33e89354ec81c23f92990138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559208 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649710}
-
Scott Violet authored
This makes it easier to correlate changes in ash with that in the browser. BUG=951015 TEST=none Change-Id: I3d0ce9f15a69cd83f837b2ea10f6dc1f1c0f8d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562754Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649709}
-
sczs authored
There's a crash where the containerStack array is being created using a nil Object. Since all 3 the objects are created in the same scope the possible reason is that the reference to this objects is being released before being added to the ViewHierarchy, so no strong reference is ever created. An alternative would be keep the button as weak but create a local variable that holds the button in the meantime. This alternative was chosen to be consistent with the other properties and since there shouldn't be a way the UIButton can have a strong reference to the VC. Bug: 951170 Change-Id: Ib9d172dafc1282d2e08ef75fbc1f1f7a67951016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562750 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#649708}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b9516868546e..bbbacd7c39f2 git log b9516868546e..bbbacd7c39f2 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 thestig@chromium.org Use early returns in CXFA_LayoutPageMgr::CreateViewRecord(). 2019-04-10 thestig@chromium.org Add CXFA_LayoutPageMgr::CreateViewRecordSimple(). Created with: gclient setdep -r src/third_party/pdfium@bbbacd7c39f2 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iabadd6968115251d32c6cdb62acd9e58823d4b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561784Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649707}
-
Min Chen authored
Add the function in InputDeviceManager to get all the uncategorized input devices. The categorized input devices currently includes mouse, keyboard, touchscreen and touchpad. After add this function, we can also get the InputDevice like side volume button. This is an initial change for side volume button control based on screen orientation for convertibles. Bug: 937907 Change-Id: I750e9919d47c11f8e881dc3f3db42bc0b0f1108c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559247Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#649706}
-
Harley Li authored
Before this patch, only the main frame's IndexedDBs are exposed in DevTools>Application>IndexedDB panel. Bug: 943770 Change-Id: Ia8e13e06065ca7ceedb83f8f6edf0dffabf63f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539214Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#649705}
-
Erik Chen authored
This CL adds matching GN configs for all the public iOS master/builders. The feature is not yet enabled, since the implementation of mb.py has a hack that skips reading the config files for public iOS master/builders. This CL makes two slight adjustments to the GN args: 1) All gn configs that use goma now set 'strip_absolute_paths_from_debug_symbols=true'. This matches every other platform. This breaks lldb-debugging, but that's not relevant for bot builds, and increases goma cache hit rates. 2) The WebRTC FYI ios-simulator device now uses code-signing. This matches every other ios-simulator builder. Bug: 951182 Change-Id: I7d6ce92f15b7751ade796156fda31f4235208b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562451 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#649704}
-
Hesen Zhang authored
> Disable OK button when filename edit text is empty, otherwise reset to enabled. Bug: 924751 Change-Id: I8138fe41a65c69f5f9e3ac59c2483fdd6667d09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548371Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hesen Zhang <hesen@google.com> Cr-Commit-Position: refs/heads/master@{#649703}
-
Tanya Gupta authored
Bug: 949233 Change-Id: I2921f58a8d0935d9085ea0c977e23d176b4e33e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552110Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#649702}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1208002548e8..fb5bcca99989 git log 1208002548e8..fb5bcca99989 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 reed@google.com oops, remove the rest of SkMixer 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-10 herb@google.com Return a span from getMetrics 2019-04-10 egdaniel@google.com Add more general flush call to GrContext. 2019-04-10 ethannicholas@google.com removed duplicate GrCircleEffect.cpp 2019-04-10 brianosman@google.com Add Shared library Windows builds 2019-04-10 brianosman@google.com Even more DLL build fixes 2019-04-10 reed@google.com remove SkMixer, since we have explicit lerps/blends in SkShader 2019-04-10 egdaniel@google.com Reland "Remove unnecessary flush in RenderYUVAToRGBA (take 2)" 2019-04-10 fmalita@chromium.org [skottie] Initial "Levels" effect support 2019-04-10 fmalita@chromium.org Reland "[skottie] More snug kTop Shaper alignment" 2019-04-10 jvanverth@google.com Add mipmap generation for Metal 2019-04-10 halcanary@google.com SkPDF: narrow layer bbox Created with: gclient setdep -r src/third_party/skia@fb5bcca99989 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I8699a8a46f7f4bdb7109e3069f690d9f25097c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649701}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77b3499b8809..0743a1400d8b git log 77b3499b8809..0743a1400d8b --date=short --no-merges --format='%ad %ae %s' 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@0743a1400d8b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I58978411558ed1f6807abe99e3043e64dfa445fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561783Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649700}
-
Brandon Jones authored
This value should only be false if the XR compositor is making use of the layer's depth buffer, and since none of them do at the moment this forces it to report true all the time. Bug: 949810 Change-Id: I27e756983aebf4e173bcbf2485db28e06defbfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554181Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649699}
-
Xiaohui Chen authored
This reverts commit a49e194d. Reason for revert: breaks ChromeOS Assistant key Bug: b:130291631 Original change's description: > Chrome OS: Add DOM |code| mappings for new action keys. > > Wilco emits action key codes directly from kernel instead of > function-key codes. This CL adds new Dom codes or fixes existing Dom > codes accordingly. They are: > > key code Dom code > ----------------------------------------------------- > KEY_SCALE SHOW_ALL_WINDOWS (new) > KEY_SWITCHVIDEOMODE DISPLAY_TOGGLE_INT_EXT (new) > KEY_ZOOM ZOOM_TOGGLE (fix evdev/xkb value) > KEY_ASSISTANT LAUNCH_ASSISTANT (fix HID value) > > Also removed invalid dom-code values for ZOOM_TOGGLE and > LAUNCH_ASSISTANT. > > Bug: 949730, 950099 > Change-Id: I3028cdcab82a4f806fc3a84f5b5bd64ffea053ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549725 > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Georges Winkenbach <gwink@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648388} TBR=wez@chromium.org,garykac@chromium.org,dtor@chromium.org,gwink@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 949730, 950099 Change-Id: If1e0fc961eff0a08936d535dde4504542fe64058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562618Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649698}
-
Sean Topping authored
CastWebContentsImpl now has an associated browser test. This allows us to test various content scenarios, such as net errors, content errors, and page crashes. It also tests the standard lifecycle of a CastWebContents, and verifies various state transitions. This new test prompted some modifications to the CastWebContentsImpl class, including some more descriptive comments on CWC's intended behavior. Bug: internal b/67864604 Bug: internal b/130190264 Test: cast_shell_browsertests Change-Id: Ibe24207cf091634cb046898276258579d9234b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560492 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649697}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/76a9a97fb2a1..34cbc5442a11 git log 76a9a97fb2a1..34cbc5442a11 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 jonahr@google.com Use ANGLE's gpu_info_util libraries for test expectations 2019-04-10 ynovikov@chromium.org Skip EGLSurfaceTest.SwapInterval on Nexus 5X and 6P GLES Created with: gclient setdep -r src/third_party/angle@34cbc5442a11 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I5ceab00aac9426b350955a2c062f26ac28024a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562498Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649696}
-
Malay Keshav authored
When the unified system tray is animating it uses a separate layer to to perform blur and animation. This layer does not have a mask applied to it for performance bottlenecks and thus does not have any rounded corner clipping. This patch modifies this and applies the shader rounded corner on the layer. Bug: 898329 Change-Id: I9fed724e4659960710c3daee5e33ec92e2223fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562624Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#649695}
-
Ahmed Mehfooz authored
Test: Manually tested UI Change-Id: Ic92814101b9b8fd25c77ef9fb2f44b1531f7ceac Bug: 951486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562223 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649694}
-
Mustafa Emre Acer authored
This CL adds the ability to compare navigated domain against engaged sites using edit distance. It also moves around some code without making functional changes. Bug: 942160 Change-Id: I8d0de1f6cebfb10fefef2e379a84e3818d759daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555004 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#649693}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c62d4b70f2c7..8ca352dcc024 git log c62d4b70f2c7..8ca352dcc024 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 pprabhu@chromium.org lib: Use a subdirectory of /tmp for UNIX domain sockets Created with: gclient setdep -r src/third_party/chromite@8ca352dcc024 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Icff1d5515cb8ccd7f7dcb76fade519d5c439612b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562065Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649692}
-
Ahmed Mehfooz authored
Test: Manually Tested UI Change-Id: Ia64891de1bceb262e4ad7f9fe5732fb4bcf34109 Bug: 951488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561848 Auto-Submit: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649691}
-
Min Chen authored
Add |source_device_id_| for Accelerator. Then the InputDevice can be gotten from the |source_device_id_| when perform the accelerator. This is added to differentiate the side volume button from all the other volume control input currently. Bug: 937907 Change-Id: Iec90a6b35cef9db6e6eaceb50aef26c07ba1b3ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559434 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649690}
-
Jeremy Klein authored
Just contains a minor comment update. Bug: b/123091364 Change-Id: If3f15b61fd50973cffb0d761e8f8e98171ee7b05 Tested: Just a comment change. Not needed. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552135 Auto-Submit: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#649689}
-
Miyoung Shin authored
This reverts commit e7a24ceb. Reason for revert: Suspected cause of Use-after-poison in blink::ThreadableLoader::Cancel Original change's description: > Move content::ManifestFetcher in blink > > This is a part of moving manifest implementation to blink. > This CL moves content::ManifestFetcher to blink and introduces > WebManifestFetcher in blink/public/web to expose the fetcher to > content::ManifestManager. > > Bug: 704441 > Change-Id: Ia4114390f124973542aca0151d06baec82fdaec1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548972 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#649147} TBR=dgozman@chromium.org,yhirano@chromium.org,haraken@chromium.org,dominickn@chromium.org,myid.shin@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 704441 Change-Id: I719bf26205f0aa1377ad5ab320fcd23f3e187ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562572Reviewed-by:
Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#649688}
-
Adam Langley authored
In crbug.com/946242, the privacy reviewer asked to move the security keys line next to “Manage Certificates”. This change moves it just below that entry. Bug: 870892 Change-Id: I617084d2d640c3bbc54e02a709e327a1e3d79ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562580 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649687}
-