- 25 Nov, 2020 40 commits
-
-
Kenneth Russell authored
Done with: ./gather_swarming_json_results.py \ --step webgl_conformance_gl_passthrough_tests \ --output=../data/gpu/webgl_conformance_tests_output.json ./gather_swarming_json_results.py \ --step webgl2_conformance_gl_passthrough_tests \ --output=../data/gpu/webgl2_conformance_tests_output.json Updated documentation and defaults of gather_swarming_json_results.py. Bug: 1152197 Change-Id: I6f4f2081af03e2be9936c41ee2d97eb02af558f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559316Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#831045}
-
Eric Lawrence authored
When a browsing context is opened with the noopener flag set, do not clone its SessionStorage from the opener's SessionStorage Bug: 771959 Change-Id: I3040d8c0f490198f3414fb9b9108cfccca0da486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809006 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#831044}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/16534e267df0..d4403bdefc66 2020-11-25 alexrudenko@chromium.org Remove a redundant interface for persistent highlighters 2020-11-25 tvanderlippe@chromium.org Reland "Migrate elements/ extensions of type 'view'" 2020-11-25 patrick.brosset@microsoft.com Fix regression where color-picker isn't anchored on the color swatch 2020-11-25 tvanderlippe@chromium.org Cleanup package.json scripts 2020-11-25 tvanderlippe@chromium.org Remove custom Closure Compiler integration 2020-11-25 jacktfranklin@chromium.org [DataGrid] support filter parser input 2020-11-25 tvanderlippe@chromium.org Remove skip_compilation from module.json files 2020-11-25 tvanderlippe@chromium.org Remove Closure type definitions 2020-11-25 tvanderlippe@chromium.org Remove JSDoc validator If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1125968,chromium:1134103,chromium:1152347 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If77bbd3b704d700c8bd1b7a15bc9cc2cc463c09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560870Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831043}
-
Olesia Marukhno authored
When there is a pending request and chip UI is used, after switching to fullscreen mode bubble UI should be used if pending request is new (chip haven't been collapsed yet). This prevents case when permission was requested and shorty after that user switches to fullscreen mode and cannot see pending request anymore. When switching from fullscreen mode, if request should be shown with chip UI, switch back to it with bubble opened. This provides visual consistency and in regular mode with chip UI bubble is easily dismissable. Bug: 1148332 Change-Id: I52886d95842db45ec72997127f25010585d97670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540527 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#831042}
-
David Bienvenu authored
This is a reland of f7713274 Original change's description: > Fix session restore after launching with PWA. > > The underlying issue is that the kProfilesLastActive pref gets > cleared when Chrome is launched with a specific profile, which > prevents Chrome from iterating over the last active profiles > and calling session restore on each of them. This CL stops > clearing the pref when launched with --app-id, and avoids > restoring sessions for the last active profiles > if launched with --app-id. Also, ignore browser opens and > closes if the browser window is for a web app, in order to prevent > kProfilesLastActive pref from getting overwritten. > > Bug: 1022795 > Change-Id: I350a54eaaf167dabb297b9bda9061fe965f0750e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984710 > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827876} Bug: 1022795 Change-Id: Ia09ddd04dcd853f8bc7322ecf7767580f3076ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546841 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#831041}
-
Denis Kuznetsov authored
Also removed unused callback in EncryptionMigrationScreen Bug: 1104120 Change-Id: I490f020fd7ce4ea6a3a9dbb6ef8fefb7796eca02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558237Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#831040}
-
Fergal Daly authored
The only remaining uses are: - blink_test_runner.cc: add a ResetForTesting to replace this usage - web_frame_test.cc: use frame loader directly in a couple of places. Change-Id: Ib0fd7ca413bb2cc2ef77d0e9e9b2c5c399d3b508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198866 Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#831039}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1bb4e5eef6d3..3558df528adf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC etiennep@google.com,pmarko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: etiennep@google.com,pmarko@google.com Change-Id: I53962b196f638635141e3e0a3b6b5746fe4982a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560967Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831038}
-
David Maunder authored
We should tie the deletion of PersistedTabData to the TabLifeCycle rather than rely on the client of PersistedTabData to know where they should call PersistedTabData#delete(). Bug: 1119454 Change-Id: I4bdc3d7b7e9a526647cc13f0974f1ef964b8bbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473359 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#831037}
-
Gauthier Ambard authored
Typo in previous CL. TBR: mahmadi@chromium.org Bug: 1151909 Change-Id: I0405c6837abec94b7abc0c674d9286d2fe6594dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560743 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831036}
-
Sajjad Mirza authored
Some flakiness has been observed on mac-rel after coverage was enabled for that builder. The problems correlate with builds that have no changed source files in Chrome, so we think that forcing coverage for clang_profiling.cc should solve the problem. Also remove an outdated comment. Bug: 1141727 Change-Id: I7ebaeda2ae3a724965e7afa65f20164340c544d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559320 Auto-Submit: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#831035}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c38503fc..08ac8ee5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I832d4eb586b9045a72fd35f59dff230fea51cc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560682Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831034}
-
Ewann authored
This CL adds EG2 the following tests for the page info: - Tests that rotating the device will don't dismiss the page info view. - Tests that opening the page info on a Chromium page displays the correct information. Bug: 1147414 Change-Id: I83f3353934e71dba698909fff0ac419e0a182adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529106 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#831033}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/888c5d3e57eb..3e2e7b28b699 2020-11-25 mtklein@google.com replace SkOpts::hash_fn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I63d6d22ed0b174ca94cf108ec7e7bfd48e707ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560968Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831032}
-
Jan Wilken Dörrie authored
This change removes the member functions `empty()` and `length()` from autofill::LanguageCode and migrates callers to use operator->() instead. Bug: 1142413 Change-Id: Ie19e8b22d1e2c5a91599cfa488874ff75cf4bc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556520Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#831031}
-
dpapad authored
Polymer2 files processed by polymer_modulizer() should not have "// #import " comments. Instead, their JS imports are auto-generated by translating HTML imports from the corresponding HTML file. Note that these comments are no-op currently, as they are not processed by polymer_modulizer(). Bug: 1152687 Change-Id: If908cce6d21f4766590b2c97b354f2ac899d8625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560679 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#831030}
-
Peter Kasting authored
This is a reland of e0e81ba9 Original change's description: > More inclusive terminology for chrome/browser/win/conflicts/. > > Bug: 1097283 > Change-Id: I570f98b1f42487aff2696c50f87fd0832667379b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547620 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830830} Bug: 1097283 TBR: gab, hwd, pmonette, tedchoc, chrisha, waffles Change-Id: I97eacb76ce1009f2534e42d20933fcd6fd9abade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560684Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#831029}
-
Yann Dago authored
BrowserCloudManagementStatusProvider::IsManaged was using policy::BrowserDMTokenStorage::RetrieveDMToken to determine if the browser was managed, and that call was making some blocking I/O, now we look at the existence of a MachineLevelUserCloudPolicyManager. MachineLevelUserCloudPolicyManager will be created only if the browser is managed by CBCM. Bug: 1150377 Change-Id: I3ec4b165577ffac864c5f2a5045d53b21196e3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547327 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#831028}
-
shivanigithub authored
This CL keeps track of the top-frame sites for each resource cached in the blink cache and updates metrics to see the cache hits if the cache was partitioned by top-frame site. These metrics will then be compared with the per-document cache metrics added in https://chromium-review.googlesource.com/c/chromium/src/+/2543684 to help decide between the two design choices. Bug: 1129860 Change-Id: I41a4dc7d3283a2e232df21c87afe9877c0482a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558763Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#831027}
-
Morten Stenshorne authored
When an atomic inline is the closest element, but we're not *inside* it, we shouldn't look for stuff inside it, either. (Note that the change here in LayoutBlock::PositionForPoint() will make us enter PositionForPointIfOutsideAtomicInlineLevel() also for (inline) tables, since the atomic inline check has been moved before the table check. This doesn't make much of a difference, though, since LayoutBox::PositionForPoint() already has special code for tables, which does pretty much exactly the same as PositionForPointIfOutsideAtomicInlineLevel()). The test included here used to fail with LayoutNGFullPositionForPoint enabled, in the inline-flex case, but also in the inline-table case, if LayoutNGTable is enabled in addition. This also fixes GranularityStrategyTest.UpdateExtentWithNullPositionForCharacter and GranularityStrategyTest.UpdateExtentWithNullPositionForDirectional on Android and Windows (when LayoutNGFullPositionForPoint is enabled). Bug: 1150362 Change-Id: Ied71317aaaa8e380600461436ee979a56b5a4584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552866 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831026}
-
Wenbin Zhang authored
Reducing the shard size when we only have 3 devices for this builder. Bug: chromium:1152120 Change-Id: I0188d35af9a249e7356c7d02bc2820c64860cc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559224 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#831025}
-
Christian Dullweber authored
To ensure that all fragments are removed when the PageInfo dialog is closed, the subpage controller needs to be notified when the main controller is dismissed. Bug: 1152724 Change-Id: I075a214223ceee675578615226b958880a103946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560628Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#831024}
-
Stepan Khapugin authored
Connects the auth button, through the dispatcher, to the scene agent, which allows the tab switcher to actually authenticate. Bug: none Change-Id: Ic6c30f74e55bd6f1b143c00e9c41b2154e142531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547680 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#831023}
-
Thomas Guilbert authored
This CL makes sure all videos have produced a video frame before proceeding to the next step of the test, by using the requestVideoFrameCallback API. video-object-fit-change.html still has a risk of flaking, since we cannot use rVFC to be notified on object fits. Bug: 963141 Change-Id: I17903cb9914977d113c8ba3093e2eb298328141a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556497 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#831022}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011250600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/UEDryZf_VuC_LfcEXlTJ_7tEzVfL6qKZIy8qC-wjmbIC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/169287051,b/172278041,b/173974940,b/174114212 Tbr: media-app@grotations.appspotmail.com Change-Id: Ib16ffa1fea3e76ed4289872b1ebc2c378ece8dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560869Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831021}
-
Olivier Robin authored
WebFaviconDriver::DownloadImage has a max size parameter to avoid issue with image decompression bombs. Add a parameter to ImageDataToSkBitmaps to respect this max size. Bug: 1095383 Change-Id: Id52783abae71d27e8c829ac43d9b4ee37220ae6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560742Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831020}
-
Nico Weber authored
This reverts commit a06a6eb7. Reason for revert: Seems to break non-goma builds on macos. Original change's description: > [ios] Always use symbolic links to system Xcode in build_root_dir > > Goma RBE only supports paths that are relative to the source dir > while build not using Goma or using old Goma backend supports both > so always use symbolic link to system Xcode on iOS. > > This fix the compilation for people using Goma as Goma RBE is now > the default backend and without this change, the build would fall > back to local compilation, drastically slowing the build. > > Stop using the ios_enable_relative_sdk_path and ios_use_goma_rbe > gn variables as they are now always expected to be `true`. Keep > the variable ios_use_goma_rbe to avoid breaking the bots that do > override the value but ignore it (bot set it to true anyway). > > Bug: none > Change-Id: I2a3c098304594fb20491ab92100e9a4101a048db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555117 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830616} TBR=thakis@chromium.org,sdefresne@chromium.org Change-Id: I5aed7d701a1d2d04d389cb4d746bc975e80b0f0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561019Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#831019}
-
Igor Tukh authored
PermissionAuditingService is a service which allows to store and audit the basic information about the permissions usage. Bug: 1152769 Change-Id: If22ed0ad189eca8dbdd8502d3a1151d7561aeffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517443 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#831018}
-
Palak Agarwal authored
Rebased on top of https://chromium-review.googlesource.com/c/chromium/src/+/2502628 UI without audio capture: https://drive.google.com/file/d/1SA9vuDOkQjnioBfmAaiOjqoXGBUmVw22/view?usp=sharing UI with audio capture: https://drive.google.com/file/d/1jcncgHsF6L_o3D5Jc3UJ6pkjwQAKtoVl/view?usp=sharing This change relates to the UI code that is added to support the new getCurrentBrowsingContextMedia API. This is an API for capturing the current tab. Design doc: go/get-current-browsing-context-media Intent-to-Prototype: https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ PR against spec: https://github.com/w3c/mediacapture-screen-share/pull/148 Bug: 1136942 Change-Id: I8e72023d944df3d7e996ad3acea7527c34569868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489991 Commit-Queue: Palak Agarwal <agpalak@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#831017}
-
Clemens Arbesser authored
Bug: b/171776026 Change-Id: I061a82a990b60a07952e4c6203b1b6260de97d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554569 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#831016}
-
Janusz Majnert authored
If input file contains non-utf-8 characters, running GetResourceAllowlistFileList in python3 fails with a variation of: "UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 24: invalid start byte" This change makes python3 treat data as bytes, while leaving python2 behavior unchanged. Change-Id: Idb6f4cf8fe3a98551df91b1249a1b74ba2916acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560505Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#831015}
-
Alex Turner authored
Use of base::CancelableCallback is deprecated in favor of the more explicit base::Cancelable{Once,Repeating}Callback. The uses were often missed when converting directories from base::Bind/Callback to the Once/ Repeating versions. This cl completes this conversion for directories already marked as fixed. A follow-up cl (crrev.com/c/2506350) will enforce a presubmit for this deprecation on converted directories. Bug: 1142629 Change-Id: I0453280104339d359b4a9dfa90507104d154b283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505963Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#831014}
-
Gauthier Ambard authored
This CL changes the key used in the error to pass the URL of the failed navigation as it is not the one used in the rest of the navigation code. Fixed: 1140976 Change-Id: I752feef45742477ca38f9e3e89f3921378889f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550674Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#831013}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I1e79537bc8ee341113d56edc4da819c6daeb1326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560863Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831012}
-
Thomas Tellier authored
Bug: 1152041 Change-Id: I040b4d71be130b0a0102e66a13976c3a940123eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560102Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#831011}
-
chrome://flagsViktor Semeniuk authored
This features allows obtaining Change Password URLs from the Affiliation Service. Also UseOfHashAffiliationFetcher enables usage of Affiliation Service for non-synced uses. Bug: 1108279 Change-Id: Iaf9551af033b0636596ba6d3abab156c111c9143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556843Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#831010}
-
Egor Pasko authored
Just a tiny fix to follow the API contract. Bug: None Change-Id: I2ed632b45d802ddc100340121b7e29b37abc5198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560123Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#831009}
-
Wei Lee authored
Bug: b/172344305 Test: Build successfully Change-Id: Ibef322d2c968a844c778baa6d8ca9cd0a2909b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554262Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#831008}
-
Adrian McCarthy authored
The `got_clang_revision` property is no longer available, so point out that the LLVM revision range is available in the `gclient runhooks` log. Change-Id: I5adde8dfc5e0a9ee6da0b852803744497d4c240a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537700 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#831007}
-
Andres Calderon Jaramillo authored
Bug: 1152030 Test: None Change-Id: I24840d83ec6fe3ee14c387943740d606491151a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559445 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#831006}
-