GitLab

R=dpapad@chromium.org
BUG=696910
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2855123004
Cr-Commit-Position: refs/heads/master@{#469555}

Android did not update the docs when multiwindow was implemented. But
essentially Display.getSize/getMetrics no longer refer to the Display
size, but to the window size, in order to be backwards compatible.

Fix and simply DisplayAndroid. Remove the distinction between "size"
and "physical size" by removing the concept of "physical" size. Always
just get the most correct size available.

Went through all use cases getSize. They all either don't care, or
was already trying to get the most correct value.

Review-Url: https://codereview.chromium.org/2859313002
Cr-Commit-Position: refs/heads/master@{#469554}

If ReassociateLocalTab is called with a tab node that is already mapped to a
tab, it's possible to wind up with the synced session tracker holding two
tab objects referring to the same tab id. This can lead to memory corruption.

This CL makes the tracker defensive against that scenario, and adds some more
data verification in the unit tests

BUG=714524, 639009

Review-Url: https://codereview.chromium.org/2856913007
Cr-Commit-Position: refs/heads/master@{#469553}

The PNaCl compiler does not understand -Os.

BUG=660216
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2865573002
Cr-Commit-Position: refs/heads/master@{#469552}

This is a (less ambitious) re-land of http://crrev.com/2852613002 which
was reverted due to content_browsertests crashes on ChromeOS. That CL is
a re-land of http://crrev.com/2779193002 which was reverted due to build
errors on Mac.

Instead of rolling Google Test to 1.8.0, this CL uses the last commit
before a breaking change was introduced. Details about the breakage are
in https://crbug.com/630705#c27 and https://crbug.com/630705#c28. It is
expected that rolling Google Test from there to the next usable version
will be much less disruptive.

GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.

The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.

* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
  been populated with headers that forward into the appropriate locations of
  third_party/googletest

* testing/BUILD.gn has been populated with the targets
  //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which
  depend on the appropriate //third_party/googletest targets.

All Chromium code should keep depending on the targets and headers
in testing/{gtest,gmock} for now.

BUG=630705
TESTED=out/Default/content_browsertests --gtest_filter=MojoTest.Init
TESTED=ninja -C out/Default/ ced_unittests && ninja -C out/Default
TBR=rkc, dpranke

Review-Url: https://codereview.chromium.org/2856383002
Cr-Commit-Position: refs/heads/master@{#469551}

BUG=715859

Review-Url: https://codereview.chromium.org/2855943003
Cr-Commit-Position: refs/heads/master@{#469550}

This moves the views-related dependencies (including chrome/app/theme)
out of the top-level //apps static library.

Some DEPS includes were dropped entirely as they are no longer used in
//apps.

BUG=679971
R=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2820563004
Cr-Commit-Position: refs/heads/master@{#469549}

Sanitizer coverage instrumentation increases linker memory consumption
significantly.

BUG=717552
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2866443003
Cr-Commit-Position: refs/heads/master@{#469548}

https://skia.googlesource.com/skia.git/+log/783c43658d91..02ab8cc2909d

$ git log 783c43658..02ab8cc29 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 mtklein Revert "Factor out common code from sweep and linear."
2017-05-04 amaury.leleyzour CRC32 no longer restricted to ARM64

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ib7a60db4a9ca23c9543f61c3bb0b6b47e8d67f99
Reviewed-on: https://chromium-review.googlesource.com/497007Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469547}

This class forwards user activity from ws to the
pre-servicification activity-handling mechanism, so it needs
to be used for --mus in addition to --mash. Check for
aura::Env::Mode::MUS to handle both modes.

BUG=717681
TEST=put --mus, --mash, and neither in /etc/chrome_dev.conf
     and check that user activity is reported in
     /var/log/power_manager/powerd.LATEST after hitting a
     key

Review-Url: https://codereview.chromium.org/2863623005
Cr-Commit-Position: refs/heads/master@{#469546}

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Also, since crrev.com/2835203002 we no
longer allow empty render pass lists to be sent over IPC. Fix the tests
and remove the checks for empty render pass lists in prod to simplify
code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2855723002
Cr-Commit-Position: refs/heads/master@{#469545}

This allows us to remove the conditional dependency from //media/gpu to
//media/mojo/services, thus allowing future dependencies in the other
direction.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857953006
Cr-Commit-Position: refs/heads/master@{#469544}

The cursor surface is parented to the primary root window, which may
change when using multiple displays. This CL fixes a crash caused by
removing the child from the primary root window when the parent is a
different root window or the child is orphaned.

BUG=714832
TEST=No crashes after changing primary display.

Review-Url: https://codereview.chromium.org/2862953002
Cr-Commit-Position: refs/heads/master@{#469543}

With this we can see how often different workarounds are being hit.

Review-Url: https://codereview.chromium.org/2841273002
Cr-Commit-Position: refs/heads/master@{#469542}

https://chromium.googlesource.com/angle/angle.git/+log/677bb6f..aa7203e

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2862723006
Cr-Commit-Position: refs/heads/master@{#469541}

Whitelisted Linux apps can access chrome.bluetooth. Initialize Bluetooth so
we don't crash on those apps.

BUG=711142
R=rkc@chromium.org,rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2819593003
Cr-Commit-Position: refs/heads/master@{#469540}

Pure code movement.

Review-Url: https://codereview.chromium.org/2857143005
Cr-Commit-Position: refs/heads/master@{#469539}

This CL was generated mechanically with:

$ git grep -l m_callback -- third_party/WebKit/Source | \
      xargs -n 1 sed -i -e 's/\bm_callback\b/callback_/g'

No intended behavior change.

BUG=675877

Review-Url: https://codereview.chromium.org/2858153004
Cr-Commit-Position: refs/heads/master@{#469538}

Map ShelfID to AppLaunchId and use that instead of uint32_t.
ShelfModel no longer assigns int ids, clients supply unique strings.

ShelfID/ShelfItem/ShelfModel:
-Add comparison operators and IsNull() helper function.
-Add a corresponding ShelfID mojo struct with traits and test.
-Allow empty app_id strings (iff the launch_id string is also empty).
-Nix ShelfItem's AppLaunchId, use its ShelfID |id| instead.
-DCHECK unique non-empty ShelfIDs (avoid odd ShelfModel behavior).

Properties:
-Remove aura::client::kAppIdKey, use ash::kShelfIdKey instead.
-Move kShelfIDKey to ash/public/cpp to approve Chrome usage.
-Register kShelfIdKey for mus/mash conversion and mirroring.
-Require a kShelfIDKey property for ShelfWindowWatcher item creation.

Misc/Chrome:
-Set non-empty ShelfIDs for AppList, Task Manager, Settings.
-Apply ExtensionWindow* ShelfIDs for panel windows too.
-Use ShelfID in ExtensionAppWindowLauncherController maps.

TODO: Rename AppLaunchId to ShelfID (can do in this CL if desired)
TODO: Remove ShelfModel id conversion functions; audit users.
(also used to check item presence in ShelfModel, map ARC ids...)

OPTIONAL: Keep kShelfIDKey in ash/wm/window_properties for now?
OPTIONAL: CHECK in ShelfModel for prod/arc? Loosen checks for tests?

BUG=557406
TEST=No Chrome OS shelf or app regressions.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org,reveman@chromium.org

Review-Url: https://codereview.chromium.org/2860503002
Cr-Commit-Position: refs/heads/master@{#469537}

https://pdfium.googlesource.com/pdfium.git/+log/b8a8c43f3942..e8c1d4144e84

$ git log b8a8c43f3..e8c1d4144 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 thestig Give a couple of char to int functions better names.
2017-05-04 thestig Reduce 1D barcode DrawPath calls.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I0f31d35b9bebe501f81431b5bb0a94e9c91c6509
Reviewed-on: https://chromium-review.googlesource.com/497006
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469536}

Bug=712331

Review-Url: https://codereview.chromium.org/2865553002
Cr-Commit-Position: refs/heads/master@{#469535}

Vulcanize removes HTML imports of global style definitions and inlines
those <style> elements directly in a special <div> on the page. Removing
this <div> in tests means those <style>s go away. Without those styles,
elements being tested no longer have access to the CSS variables or
global style rules they expect, which can break things in all sorts
of ways.

This hasn't affected any tests that I know of (besides one WIP), because
we don't normally test the details of our colors and layouts in tests that
call PolymerTest.clearBody. But it's worth fixing regardless in order to
decrease the delta between tests in vulcanized vs. unvulcanized builds.

BUG=714359
R=dpapad@chromium.org

Review-Url: https://codereview.chromium.org/2829383002
Cr-Commit-Position: refs/heads/master@{#469534}

Makes it behave the same as the other iron-lists on the page.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2852413003
Cr-Commit-Position: refs/heads/master@{#469533}

In https://codereview.chromium.org/2835733002 the ReadHistogramValues
method now returns one value instead of 2, but its call in
UpdateHistogramEnum still expect 2 where the 2nd was ignored.

BUG=711205

Review-Url: https://codereview.chromium.org/2866573002
Cr-Commit-Position: refs/heads/master@{#469532}

The gaps have shown to move around, and so the blamed file is likely not
really at fault.

BUG=681694

Review-Url: https://codereview.chromium.org/2860003002
Cr-Commit-Position: refs/heads/master@{#469531}

So that we don't need to use global variables.

BUG=718614

Review-Url: https://codereview.chromium.org/2864543002
Cr-Commit-Position: refs/heads/master@{#469530}

TEST=unit tests extented. Manually, updated test app via adb and
     its shorcuts were left in app launcher
BUG=718625
BUG=b/34749664

Review-Url: https://codereview.chromium.org/2860243002
Cr-Commit-Position: refs/heads/master@{#469529}

There are no flags to be updated

deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state.

It achieved results that were in general comparable to "measuring
aggregation" approach, but it had worse rtx rate, and worse QoE, and did
not actually seem to be better in other regards.

Merge internal change: 154601526

https://codereview.chromium.org/2859913003/

fix packet conservation to remove packets from recovery window when they are lost.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2.

This causes a dramatic reduction in losses compared to the previous patch.

The transfer time is approximately the same.

Merge internal change: 154590929

https://codereview.chromium.org/2857243002/

Fix typo in comments.

Merge internal change: 154539040

https://codereview.chromium.org/2854823004/

QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation.

This CL is in preparation for HTTP stream pairs changes.  A prototype
of the entire HTTP stream pairs work is in progress.  This CL is one
subset of that (2nd in the series).

[ HTTP stream pairs builds upon this, by having new QuicSpdySession
overrides that implicitly create headers streams, and abstracting
stream accounting as needed. ]

Add a new factory like method QuicSession::CreateStream(), that
unconditionally creates a new stream.  It's virtual so subclasses of
QuicSession can create streams that are appropriately specialized from
QuicStream.  There are new versions of Create*DynamicStream() called
MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called
ShouldCreate*DynamicStream2().

Separating this out means that fewer overrides of Create*DynamicStream()
and ShouldCreate*DynamicStream() will necessary, because many of those
were actually only needed to specialize the steam types.  Those will go
away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is
deprecated.

Merge internal changes: 154351257, 154373998.

https://codereview.chromium.org/2861673004/

QUIC - stream id refactor for tests.

// AKA - http stream pairs bikeshed #1.

This CL is in preparation for HTTP stream pairs changes.  A prototype
of the entire HTTP stream pairs work is in progress.  This CL is one
subset of that.

Rework QUIC tests so that they do not hard code the assumption that
all headers are on stream 3.  Also, prepare to calculate stream ids
according to whether stream pairs are enabled, i.e. whether they
increment by 2 or 4.

Merge internal change: 150949425

https://codereview.chromium.org/2854833005/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2862563003
Cr-Original-Commit-Position: refs/heads/master@{#469218}
Committed: https://chromium.googlesource.com/chromium/src/+/d60018e0b72b5708797cebe57780ad559877164f
Review-Url: https://codereview.chromium.org/2862563003
Cr-Commit-Position: refs/heads/master@{#469528}

This CL separates the site settings browser tests.

(Code health)
BUG=None

Review-Url: https://codereview.chromium.org/2862463002
Cr-Commit-Position: refs/heads/master@{#469527}

This simplifies local testing of metrics collection, particularly in dev builds.

BUG=717792

Review-Url: https://codereview.chromium.org/2861563002
Cr-Commit-Position: refs/heads/master@{#469526}

BUG=718610

Review-Url: https://codereview.chromium.org/2862993002
Cr-Commit-Position: refs/heads/master@{#469525}

Single sample metrics offer a mechanism for clients to modify
a histogram sample repeatedly while having it only reported once;
either upon destruction of a helper class or at process termination.

This is helpful since the fast shutdown path simply kills renderer
processes without going through any destructors. In this case we
lose histogram values that might otherwise be reported at that
time.

In media/ code we've created a cumbersome proxy mechanism which
sends histogram values like this to the browser process and records
them there (see WatchTimeReporter and MediaInternals interactions).

Single sample histograms are implemented through a new mojo service
hosted by the browser process that receives samples and logs the
last received sample upon mojo channel closure.

base:: shims are provided so that these metrics can be created by
anyone in the renderer process. For non-renderer processes a default
implementation is provided without the mojo channel behavior.

Usage looks like the following:
  std::unique_ptr<base::SingleSampleMetric> metric(
      base::SingleSampleMetricsFactory::Get()->CreateCustomCountsMetric(
          "Media.VideoRenderer.CadenceChanges", 1, 10, 10));
  metric->SetSample(1);
  metric->SetSample(2);
  metric->SetSample(3);
  metric.reset();

Only the last sample (3) would end up being reported to the histogram.

BUG=689751
TEST=new tests

Review-Url: https://codereview.chromium.org/2687583002
Cr-Commit-Position: refs/heads/master@{#469524}

In https://codereview.chromium.org/2665913002 we set some default
network properties in currentRouteChanged. This was triggering
networkPropertiesChanged_ which udates autoConnect_ and
preferNetwork_ which triggers calls to setNetworkProperties.

To prevent this sort of error, set networkPropertiesReceived_
once properties are received from Chrome and do not call
networkingPrivate.setProperties until that has been set.

BUG=718389

Review-Url: https://codereview.chromium.org/2863713004
Cr-Commit-Position: refs/heads/master@{#469523}

This is a prerequisite of whitelisting //third_party/WebKit/public
for header checking in GN.

BUG=716359

Review-Url: https://codereview.chromium.org/2851953002
Cr-Commit-Position: refs/heads/master@{#469522}

This CL changes the logic for choosing the loud vs. quiet interstitial.
Instead of comparing against screen dimensions, we instead use window
dimensions, which makes more sense when Android Multi-Window is enabled.

BUG=718195

Review-Url: https://codereview.chromium.org/2861713005
Cr-Commit-Position: refs/heads/master@{#469521}

Manually convert tests to use new Audit

BUG=704967
TEST=
Panner/panner-automation-basic.html
Panner/panner-automation-position.html
Panner/panner-distance-clamping.html
Panner/panner-rolloff-clamping.html
Panner/pannernode-basic.html

Review-Url: https://codereview.chromium.org/2799793003
Cr-Commit-Position: refs/heads/master@{#469520}

The actual filenames are all lowercase, but src attributes in
execorder.html contains uppercase letters. This causes the scripts not
found and thus timeouts on Linux (which runs on a case-sensitive
filesystem).

This CL fixes the timeout by making the src attributes all lowercased.

BUG=594639

Review-Url: https://codereview.chromium.org/2856053005
Cr-Commit-Position: refs/heads/master@{#469519}

This CL removes a hack that adds /usr/lib/gcc/x86_64-linux-gnu/4.6 to
ld.so.conf.d/zz_hack.conf.  The only sysroots that exist currently are
Jessie and Trusty which both use gcc 4.8.

This caused the following flags to be passed to the linker:
-L/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
-Wl,-rpath-link=/path/to/chromium/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
While harmless, it is confusing and should be removed.

R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2863663003
Cr-Commit-Position: refs/heads/master@{#469518}

Not sure why/how this happens, but I was seeing this infrequently on  https://with.in/watch/under-neon-lights/

BUG=718501

Review-Url: https://codereview.chromium.org/2862883002
Cr-Commit-Position: refs/heads/master@{#469517}

And improve information provided by out-of-order destruction of task
scheduler and its provided constructs in unit tests.

(comes out of discussion on https://codereview.chromium.org/2852333004/)

BUG=708584, 689520
TBR=avi@chromium.org (documentation update in test_browser_thread_bundle.h)

Review-Url: https://codereview.chromium.org/2860063003
Cr-Commit-Position: refs/heads/master@{#469516}