- 16 Oct, 2020 10 commits
-
-
Mila Green authored
Bug: 1138014 Change-Id: I7e9e73bc1c0d8ce1361ac5469f8e68ae31a4b90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443540 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817760}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63fa6951fb7e..985f6835c900 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pkasting@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099650,chromium:1117577,chromium:1137914 Tbr: pkasting@google.com Change-Id: Ic906b9076b8c85ff4c505662db9401ad1da0d405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477291Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817759}
-
Alexander Surkov authored
Bug: 1133330 Change-Id: I9e52d0154dba2b3b1b5dbe532bb3daba4167a48c AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471880Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#817758}
-
Weilun Shi authored
Support the simplest case of out-of-line patterned histograms migration in suffixes_to_variants script. The script should be able to migrate most of: 1. Histogram suffixes with a single affected histogram to an inline patterned histogram 2. Histogram suffixes with multiple affected histograms but these affected histogram are all present in a single file. Bug: 758782 Change-Id: Id1bf98d74b8e072bdd05f063cdf1884b73f1f86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473561 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#817757}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4244b5f6b438..fa9520e752b4 2020-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9b1cb285..070c3d67 (817475:817632) 2020-10-15 joedow@google.com Fixing the error logging in desktop_capture for Windows 2020-10-15 perkj@webrtc.org VideoStreamEncoder report VideoLayersAllocation for simulcast If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5850e822556a56a9206e3fd0fed5763beb1891ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817756}
-
Ryan Heise authored
See bug for context. Bug: chromium:1139057 Change-Id: I634955a854d11c5dbe1970b23487b4f5c045a955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477237Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#817755}
-
Weilun Shi authored
Users should be able to extend the out-of-line variants by specifying some inline variants under the <token> node. Bug: 758782 Change-Id: I44a91a4b694dee148435f588552c6c91d89ecdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473442 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Yue Ru Sun authored
The macro UMA_HISTOGRAM_PERCENTAGE passes a bucket max value of 101 https://source.chromium.org/chromium/chromium/src/+/master:base/metrics/histogram_macros.h;l=130 https://source.chromium.org/chromium/chromium/src/+/master:base/metrics/histogram_macros_internal.h;l=146 However the supposedly equivalent function base::UmaHistogramPercentage passes a bucket max value of 100 here https://source.chromium.org/chromium/chromium/src/+/master:base/metrics/histogram_functions.cc;l=42 This patch fixes this discrepancy in the histogram function,and rename all existing usages of base::UmaHistogramPercentage to base::UmaHistogramPercentageObsoleteDoNotUse. TBR=mukai@chromium.org,dmazzoni@chromium.org,finnur@chromium.org,engedy@chromium.org,xiaohuic@chromium.org,sophiechang@chromium.org,bmcquade@chromium.org,amoylan@chromium.org,dschinazi@chromium.org Bug: 1121318 Change-Id: I30ddbfd35c6478cf2bf3313b5e6180f92e3bbaae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468465Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#817753}
-
Gang Wu authored
Bug:1139000 Change-Id: I9471941bf822a22ad1405d6f8cf9972d6fcb3ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473500 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#817752}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ui/android. Bug: 1113033 Change-Id: Ifdb5e46c9c8fe0f5417fce2ab797009fe31b477d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477519 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#817751}
-
- 15 Oct, 2020 30 commits
-
-
Steven Bennetts authored
Bug: 1137487 Change-Id: I6164788dc2f84fa670027c41d48f8997c5dbc053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466823 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#817750}
-
Patrick Monette authored
Before this change, the viewport intersection would start empty to represent that it was not known at construction time. Unfortunately, an empty viewport intersection is also a valid value so it was not possible to distinguish the uninitialized state and the empty state. This is now possible with an optional viewport intersection. With this change, it is now possible to fix the race condition that the FrameNodeImplBrowsertest has. So instead of only waiting for the page to be loaded, we also wait for the viewport intersection of the test iframe to be initialized. Bug: 1077217, 1138429 Change-Id: I2b0aa63d1293cfa837c90a6b10e38a5488711b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473440 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#817749}
-
Lambros Lambrou authored
This adds some more logging when WebRTC raises a selected-candidate-pair changed event. Bug: 1128667 Change-Id: I5629885233b2cd201d2f7b80ff1f78bd6b3803f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477476 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#817748}
-
Jinsuk Kim authored
This CL adds a new histogram entry that tells us which gesture navigation UI (among Chrome's own gesture and OS-provided one) is used. It is logged on Chrome startup in the devices that has the Chrome gesture UI is enabled to get an idea on how many devices have OS gesture vs. Chrome's own UI. Bug: 1128629 Change-Id: I8062aa8372a1db9050345fb9bb79e10920cb8a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448713 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#817747}
-
Jeffrey Cohen authored
Bug: 1137985 Change-Id: I9172e311c43f8bf7a8aa8af9b9eed3bcd343ecac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472533Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Ben Reich authored
Adds the use_javascript_coverage flag to the be passed in the $build/code_coverage property which will be used to enable v8 code coverage on the CI builder. Only pass the use_javascript_coverage flag for the linux-chromeos-js-code-coverage chromium.fyi coverage builder. Test: None Bug: 1113941 Change-Id: Ief6929edec4b76e45734e9a6029653f7954f3d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473743 Auto-Submit: Ben Reich <benreich@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#817745}
-
Kelvin Jiang authored
Currently, the install warning message for a host with an invalid scheme explicitly mentions the "permissions" key even if the host is specified inside optional_permissions or host_permissions. This CL un-hardcodes warning's message so it can specify other manifest keys. Bug: 1136993 Change-Id: I52eb1e00fd6d357742018c2f25f256237cd25483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473584 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817744}
-
Brian Sheedy authored
Fixes the functionality of the --repeat flag for tests that use //build/android/test_runner.py, as it was accidentally broken when moving the current try number to LocalDeviceEnvironment, which caused the current try to not be reset to 0 between different test runs. Bug: 1138699 Change-Id: Ifc8865e1b59c3ac172c849c587c8f3a66ab5c6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477516 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#817743}
-
Justin Miron authored
The main frame document intersection was previously reworked to be in the coordinate system of the main frame. BUG=1085175 Change-Id: I9c16b490de39f9a90a0132ba78cdf45f5c5ffca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476496 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817742}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c9206a08c352..0e5e6078c600 2020-10-15 lehoangq@gmail.com Metal: Use MipmapNativeLevel class to store native mip lvl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I49efe9a54d2d1e756871a9c0c4c392e37f5a1dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477353Reviewed-by:
-
David Schinazi authored
The goal of this CL is to help track down a bug which might be caused by outdated Finch configs. It uses a fake crash when it detects this issue to report diagnostics back to us, and saves some relevant information along with it. This will not actually crash, only report current state. It also logs a UMA histogram to get at the Finch seed. Change-Id: I60c3b4704c9dd2916f9e990d97b56b4209c96e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462728 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#817740}
-
Danan S authored
Added functionality: - Pass client id in URL params - Add OAuth access token to Authorization header - Added functionality for local boq server-based testing/development - Added handler for getAccounts() call needed by new Authenticator functionality - Added getFlowOriginHostname() needed by hostnames. - Add TODOs to take care of handling errors reported from the web-based flow. Bug:1136979 Change-Id: I4500543b327808dd376e01122cd039abcc5aacf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463648 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#817739}
-
Tarun Bansal authored
Change-Id: Id6d09819d86e4b9ad258ef7d97fff3c07752c2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477657Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#817738}
-
Jimmy Gong authored
This reverts commit 1dbaf3e8. Reason for revert: Noticing increased flake connections due to this CL Original change's description: > Add connection time outs to ConnectionManager > > If we cannot establish a connection within 15 seconds, we time out > the connection and cancel > > Bug: 1106937 > Test: chromeos_components_unittests > Change-Id: Iad731f6119a900fa411d75a9c53869baabf33498 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470321 > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817371} TBR=khorimoto@chromium.org,jimmyxgong@chromium.org Change-Id: I6377c38944ecbdb028e1697521ec104023909ecc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477658Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Stephanie Kim authored
Bug: 1136565 Change-Id: I45d9a0a43ed35f276842636a5ee87f6360fc6c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476907Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#817736}
-
Michael Checo authored
Bug: 1050533 Test: browser_tests --gtest_filter=OSSettingsUserPageTest.AllJsTests Change-Id: I44955a943af7044adfe97379a8c39cec8fee93ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465488Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1ca16727. With Chromium commits locally applied on WPT: 7c0edf34 "Add test for crbug.com/1138917" 86ae1272 "Read image resolution from EXIF, apply to intrinsic size See https://github.com/whatwg/html/pull/5574" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Iaf79b62b9fcf5f5ceaeb388b2bb3f741a16ccca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477373Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817734}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a7278454b28b..cb055303b5e0 2020-10-15 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 481ecff293db to 95dc655bf8a6 (1 revision) 2020-10-15 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 53380f9ed76f to 481ecff293db (1 revision) 2020-10-15 cwallez@chromium.org Fix a small typo in Format.cpp alwaus -> always 2020-10-15 brandon1.jones@intel.com Change Device::Tick To Return Bool 2020-10-15 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from ff267ca60e14 to 53380f9ed76f (1 revision) 2020-10-15 enga@chromium.org Replace the wire serializer with a no-op impl on disconnect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:951558 Tbr: enga@google.com Change-Id: Id52eaff3a4938c8407d968f5c7e5fe7c3933213b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477290Reviewed-by:
-
John Lee authored
Previously, when a user clicked into a menu item, this would dispatch a focusin event to cr-menu-selector which would then try to focus the first item in the list. However, this does not make sense with a mouse and can cause issues when the menu is scrolled. This CL fixes this bug by only moving focus if the focus event was caused by a keyboard. Bug: 1137698 Change-Id: Ib46566e91814053dd76b419076fe1998a7e30fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469042 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#817732}
-
Kenichi Ishibashi authored
This is a preparation for removing EmbeddedWorkerTestHelper from ServiceWorkerStorageTest as EmbeddedWorkerTestHelper owns ServiceWorkerStorageControl. This CL rewrites some helper functions to read/write resources only using ServiceWorkerStorage. Bug: 1016064 Change-Id: I104d7272dcd2458b19ff98514b7efd9adf4e8ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474218 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817731}
-
Nohemi Fernandez authored
Currently all switches are disabled because the Sync settings have not been confirmed by this stage. This patch ignores Sync settings that are not confirmed since the service will not handle any calls until it is enabled. Bug: 1125631 Change-Id: I8d3781153b5a0f32e70e6cf3965b42cc91e70bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470082 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817730}
-
Chan Li authored
This experiment has been enabled at 100% on fyi builders and it's confirmed working. Bug: 1108016 Change-Id: Ie421701de49116dab4169a6e210d069e01bbba37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476536Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#817729}
-
Rafael Cintron authored
Future fence work for Windows will require ID3D11DeviceContext1-4, ID3D11Device1-5 and ID3D11Fence mocks. This CL adds support for them to d3d11_mocks.h, d3d11_mocks.cc and test_utils.h Bug: 1131616 Change-Id: Ic8492b5962a914146305fb58974c7fac1956e15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476537Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#817728}
-
Devlin Cronin authored
The chrome.test API predates promises, but should still work well with them. This is useful, because promises can greatly increase the readability of certain tests. Add some basic test coverage of common promise-based patterns in API tests. Bug: None Change-Id: I04b279f132e017e5eb81323dc96d9607513b54f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391602 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#817727}
-
Ghazale Hosseinabadi authored
This CL refactors ExtensionContextMenuApiTest. ExtensionContextMenuApiTest's functions and member variables related to visibility testing are moved to ExtensionContextMenuVisibilityApiTest. Furthermore, ExtensionApiTest.ContextMenus is divided to four tests and is moved to ExtensionContextMenuVisibilityApiTest. Bug: 1093066 Change-Id: I6142790b01b583eb6664712d1fb1ab7df08452de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468346Reviewed-by:
-
Jazz Xu authored
This CL fixed the issue where the audio controls' focus ring is seem chopped. Demo video linked in the bug. Rebaseline some of the test since the shrinking height of buttons in audio controls will result in some tiny pixel changes. Bug: 921955 Change-Id: I197cb7c0f29b2bbd5383203f8d7dd8d0b7ee4f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468783Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817725}
-
David Dorwin authored
Update base_unittests.cmx to inject archivist-for-embedding.cmx instead of archivist.cmx, which has been removed in Fuchsia. Bug: 1139075 Change-Id: Id5d30e5c9be7b14e9c5c7f4633ceb5ef4a032ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477423 Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#817724}
-
Wei Li authored
To safely change Button class' default focus behavior, we need to explicitly set all subclasses' focus behavior. To show these changes are preserving the existing behavior, this CL adds DCHECKs to show the current behavior. We will delete all the DCHECKs once Button's default behavior is being flipped. Bug: 1001103 Change-Id: Ic76bc2ffaa3dfb90b7cd93b59c0a6051e9f5d9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473562Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#817723}
-
François Degros authored
No functional change. BUG=chromium:912236 TEST=Manual Change-Id: Ie7a79682726701f2aad255183e0b2d674cf3e26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462991Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#817722}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //extensions. R=mcnee@chromium.org, rdevlin.cronin@chromium.org Bug: 1113033 Change-Id: Ia776ef0322aa315624d11ef7698b6cf049fe2cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473437 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#817721}
-
