GitLab

Bug: 1052460
Change-Id: I0f7ff8213a5a2513dd6c517957db3756526f8e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090351Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@google.com>
Cr-Commit-Position: refs/heads/master@{#747402}

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dbpth-n7LZo

R=chrishtr@chromium.org, vmpstr@chromium.org

Bug: 991096
Change-Id: Idb7ee2c2995841f185977dd12e52d9b62f60d139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090019
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747401}

This CL fixes bug where WebAPKs with adaptive icons would incorrectly
think they need to be updated due to the value of
WebApkInfo#isIconAdaptive() being incorrect. In particular, the
WebApkInfo#create() call in WebappLauncherActivity produces a WebApkInfo
where WebApkInfo#isIconAdaptive() == false if native is not yet loaded.

This CL:
- Only considers OS version when building WebApkInfo object
- Modifies WebApkUpdateManager code to enable downgrading a WebAPK from
an adaptive-primary-icon to a non-adaptive-primary-icon if the
ChromeFeatureList.WEBAPK_ADAPTIVE_ICON feature is disabled.

BUG=1058066
TEST=WebApkInfoTest.*

Change-Id: I6a00a3046bf1f82fb5fd50e171d35a49a7b6ecba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085392
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747400}

This introduces a new FilesystemProxy API into the Storage
Service client library.

FilesystemProxy provides common filesystem operations and can
operate either directly on the filesystem in an unrestricted
mode (which only actually works outside of a sandbox), or it can
operate on a remote implementation of a new
storage.mojom.Directory interface, securely scoped to a single
directory tree within the filesystem.

Bug: 1052045
Change-Id: I7fa391f2d29d9475167613c379dea6653ab22b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080588
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747399}

This means installing the chocolatey core extension package, which is a
requisite of sysinternals, and changing the python2 executable path.

Change-Id: I13e1a0b3c493540017137e70b831d12229fa6f93
Bug: 1058970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080082
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747398}

According to
https://w3c.github.io/webappsec-feature-policy/document-policy.html#reporting,
This CL implements the report-to endpoint mechanism so that each
feature can uniquely identify which endpoint to report to.

This CL also implements the support for Document-Policy-Report-Only header.

Bug: 993790
Change-Id: Ia9588bc6bfaf0b9b0996b45331636ef4f11fe52d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025879
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747397}

This reverts commit 7d6c5197.

Reason for revert: This breaks on device runs for xcodebuild_runner.
This revert will land before the revert of crrev/c/2048851.

Original change's description:
> Enable iOS test runner unit tests as part of presubmit
> 
> Run iOS test runner unit tests as part of presubmit. Keeping scope to
> functional tests, and will have separate CLs for the remaining files
> that require further fixes.
> 
> * PRESUBMIT.py - include unit test execution for ios/build/bots/scripts
> * run.py - unit tests caught logic incorrectness. Running the json
>    parsing first, before validation.
> * wpr_runner_test.py - remove install xcode mock, fixed broken tests
> * test_apps_test.py and xcode_log_parser_test.py - include main call
>    to unittest.
> 
> Bug: 1056457,1058257
> Change-Id: Ifc233695ba8f6120f862586a497df61e96d4954f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076765
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#746102}

TBR=rohitrao@chromium.org,lindsayw@chromium.org,zhaoyangli@chromium.org,jeffyoon@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1056457
Change-Id: Iaa9e1ca8a6ac76c41e067d17e13108aeeb2ac83a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089992Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747396}

This reverts commit be99e7f1.

Reason for revert: compile failure due to v8 in https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/10540, root cause probably https://chromium-review.googlesource.com/c/v8/v8/+/2087452.

Original change's description:
> Update V8 to version 8.2.269.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/fbadeeaf..dd5f5a94
>
> Please follow these instructions for assigning/CC'ing issues:
> https://v8.dev/docs/triage-issues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
>
> TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
>
> Change-Id: Ib2096ee43967fbe0a88356fbccae9b92d15a49a4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089406
> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#747386}

TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2df684ff3969be7fdc44f2dad377420470cabdd8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089997
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747395}

This reverts commit b65bd7c4.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 747384 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I2NWJkN2M0Y2E1N2M3ZTE2NDA1MjRmZmE0MTRlMDAzZjk5MTIxMzYM

Sample Failed Build: https://ci.chromium.org/b/8886638127244438928

Sample Failed Step: compile

Original change's description:
> Reland "Decompose some Blink public mojom targets"
> 
> This is a reland of ae3270a7
> 
> The original CL made it through the CQ without triggering a compile
> step, hence the post-landing breakage.
> 
> This has now been tested locally under a debug configuration and
> will trigger Android compiles in the CQ, so it should be safe to
> re-land if it passes.
> 
> Original change's description:
> > Decompose some Blink public mojom targets
> >
> > This picks some low-hanging fruit in the effort to decompose Blink mojom
> > into smaller targets.
> >
> > Bug: 1058621
> > Change-Id: Iaf1a8efffa43f64ea7e618555262b929235ca2eb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088677
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Commit-Queue: Ken Rockot <rockot@google.com>
> > Cr-Commit-Position: refs/heads/master@{#747044}
> 
> Bug: 1058621
> Change-Id: I11d8c1e996e1cf178616fd6736ba2d0f7b624edb
> Tbr: haraken@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090012
> Reviewed-by: Ken Rockot <rockot@google.com>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#747384}


Change-Id: I518018e9bc2df0cb7a4bad85212c9dc5d8123329
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1058621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090463
Cr-Commit-Position: refs/heads/master@{#747394}

Adds a function to the Unwinder interface that is invoked at the time the
stack is captured, while the target thread is suspended, and wires up the
StackCopiers and StackSamplerImpl to invoke it at the appropriate time.

This function will be overridden in the new V8 unwinder to save off the
active V8 code pages while the thread is suspended.

Bug: 1035855
Change-Id: Ide287443faed211e2e6d205ebe78b8a536caa729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074806
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747393}

Enhanced protection state is only returned behind an
experiment flag.

Bug: 1056473
Change-Id: Ib681029fdffcb2c0bf4ae1a35b3becf2d661bbcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077037Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747392}

(doing //chrome separately to workaround crbug.com/1058382)

These missing includes are preventing removal of unused headers from
task_runner_util.h and consequently migration from task_runner_util.h to
task_runner.h's new PostTaskAndReplyWithResult member method.

The following script was run on every file in the codebase, prioritizing
.h over matching .cc to best enforce the rule of not include a header
included by your .h :

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content)
  if fwd_decls_match:
    print 'fwd_decls_match in %s' % (file_path)
    return False

  bind_helpers_match = re.compile(
      # Doesn't begin with a comment.
      r'\n *[^/\n][^/\n]'
      # Anything else after a non-comment start (and don't allow this to capture a comment start either)
      r'[^/\n]*'
      # Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definiton of Foo.
      r'[^<]'
      # Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed.
      r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content)

  callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content)

  ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content)

  if not bind_helpers_match and not callback_helpers_match and not ptr_util_match:
    return False

  updated_content = content
  if bind_helpers_match:
    updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h")
  if callback_helpers_match:
    updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h")
  if ptr_util_match:
    updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=danakj@chromium.org
(mechanical change for //base API)

Bug: 1026641
Change-Id: I87398ab232511cccb2ecf5893de521be623a08ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087892
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747391}

Bug: 1049193
Change-Id: I735369eef149185a7a7f7b946cce65d536d66bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089902
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747390}

This reverts commit bc36a7c5.

Reason for revert: crbug/1058886

Seems to be causing some instability. Reverting for now...

Original change's description:
> [Paint Preview] Change PaintPreviewClient callback thread
>
> The callbacks passed to PaintPreviewClient were getting run on an
> arbitrary thread via PostTask. This is a problem as they should be run
> on the calling thread such that WeakPtrs bound to them are valid.
>
> Fix
> - Make the callbacks run on the same thread that called capture.
> - Explicitly run CapturePaintPreviewInternal on the UI thread.
>
> Follow-up
> - Make a dedicated SequencedTaskRunner for executing captures.
>
> Bug: 1058079
> Change-Id: I1dfa969de613112b4bd1650051e394094dffda5e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083567
> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
> Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#746517}

TBR=mahmoudi@chromium.org,ckitagawa@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1058079,1058886
Change-Id: I714946368a528d6b2def20813bcf5b073aa2d2d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090292Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747389}

To enable special handling of events generated by a bluetooth stylus
button, add a flag for keyboard events.

Bug: chromium:1027010
Change-Id: I5604422f7d1be3e60bd7ccdf7b0bb6ee4ae21cb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079676
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747388}

The test is very flaky: http://shortn/_LQctbmO2eo
Bug: 1058857

TBR=rayankans@chromium.org

Change-Id: If36695981f90685e2e958361911716b1d42f5480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090014
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Ender <ender@google.com>
Auto-Submit: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#747387}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fbadeeaf..dd5f5a94

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib2096ee43967fbe0a88356fbccae9b92d15a49a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089406Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747386}

Adding a simple smoke test to make sure run_tbmv3_metric does not break
silently.

Change-Id: I54f4d525e221eef403678034efde505ee19cbc1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078736Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Deep Roy <dproy@chromium.org>
Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Commit-Queue: Deep Roy <dproy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747385}

This is a reland of ae3270a7

The original CL made it through the CQ without triggering a compile
step, hence the post-landing breakage.

This has now been tested locally under a debug configuration and
will trigger Android compiles in the CQ, so it should be safe to
re-land if it passes.

Original change's description:
> Decompose some Blink public mojom targets
>
> This picks some low-hanging fruit in the effort to decompose Blink mojom
> into smaller targets.
>
> Bug: 1058621
> Change-Id: Iaf1a8efffa43f64ea7e618555262b929235ca2eb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088677
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#747044}

Bug: 1058621
Change-Id: I11d8c1e996e1cf178616fd6736ba2d0f7b624edb
Tbr: haraken@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090012Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#747384}

This CL moves chromeOS strings for settings Device storage page strings
from settings_strings.grdp to os_settings_strings.grdp. It continues
the process of moving all chromeOS specific strings.

Bug: 967883
Change-Id: I827e7bfba0f31194ef974bbe10c613b780429554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067439
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747383}

https://android.googlesource.com/platform/external/perfetto.git/+log/f365c53a18b1..0c6dfdbceb9e

git log f365c53a18b1..0c6dfdbceb9e --date=short --first-parent --format='%ad %ae %s'
2020-03-05 ddrone@google.com Merge "Reusing one ProtoToArgsTable instance"

Created with:
  gclient setdep -r src/third_party/perfetto@0c6dfdbceb9e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ieff5c397bd14f619342cb0bc10669bd93a970b34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090217Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747382}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca451d58ac8d..59ccb910d003


Created with:
  gclient setdep -r src-internal@59ccb910d003

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1057605,chromium:1057622
Tbr: jbudorick@google.com
Change-Id: If84fa236655483bc3b40aa5f2c29fc51bfd547df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090213Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747381}

This CL creates a Finch flag for separating SafeBrowsingNetworkContexts
and depending on that flag, creates separate network contexts for each
Profile. Future CLs will port users of the SafeBrowsingNetworkContext
to the Profile-scoped contexts. (For example,
https://chromium-review.googlesource.com/c/chromium/src/+/2044716)

Bug: 1049833
Change-Id: I36e9ecd43e3ce5ceb6333850bcde7ea61065bd5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083576
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747380}

DO_NOTHING is supposed to output an empty result,
but it currently reports 100-500 ms.

It seems that setContentView() and Activity seem to cause additional
delays. Posting the measurement task with a delay seems to fix this.

Also, this adds useful comments such as example run and sample results.

Bug: 1055970
Change-Id: I0e458746b1d4051adef9662bddaff2d368493d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080586
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747379}

This new pool will automatically add default CIPD packages that a
variety of different tools currently handle today.

Needs crrev.com/i/2679645 before this can land.

Bug: 812428
Change-Id: Ib9968ab08752021c7afd8ae741187e8e8bb0a57b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088224Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747378}

This removes an extraneous boolean argument. The function does not
accept bools for any of its parameters, so I think this was just a
typo.

This is to unblock CQ.

Bug: 1058637
Test: vpython android_webview/tools/cts_utils.py
Change-Id: I6be0bff28e4a4a4e871725ed4c11be5af8c01d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088356
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747377}

This CL fixes a potential Initialize()-after-Initialize() of the said
service, as described in the bug, following the suggestion in #c11.

Bug: 1056222
Change-Id: Idd951d3f0bee62b94382ffe80e4e6b3cef33e6d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090031
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Miguel Casas <mcasas@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747376}

Previously we tried to reuse the FTL auth token for multiple connection
attempts, and it will only reset if FTL returns an UNAUTHENTICATED
error. This doesn't seem to work since we learnt from the last FTL
outage that FTL servers can return NOT_FOUND for registration that has
been deleted. So it's safer to just re-sign-in every time the signal
strategy is disconnected, which doesn't take too much time.

(Note that stream lifetime exceeded and pong timeout are handled inside
FTLMessageReceptionChannel, which isn't affected by this change.)

Bug: 992722
Change-Id: Iee10f04e4ddeea71317b7859a943098d0f0c38fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088633Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747375}

These are constructions of SendCompleteCallback which is OnceCallback.

Bug: 1007815
Change-Id: I2715155e477d5e807bf3ccf256ebf71ed21ce2a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089815
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747374}

Bug: 1007815
Change-Id: I4f5e6f19402f058bfe11f33018c2d46d4a457920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089774
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747373}

Resizing a Surface is really destroying and reallocating a Surface, and
then sending it to the GPU process and have it re-composite and
re-raster everything. This is a bit expensive and can cause visual
glitches when keyboard gets hidden and the view grows in size instead.
So follow chrome's behavior in weblayer and avoid resizing the Surface.

Note that resizing the web content may also be expensive and can cause
similar glitches. Chrome does not address this, neither does this CL.

The main code change is keep calling WebContents.setSize, but no longer
resize the SurfaceView or call onPhysicalBackingSizeChanged. Do this by
introducing SurfaceParent which is a FrameLayout that sits between
ContentViewRenderView and the SurfaceView in the view hierarchy.
ContentViewRenderView will keep resizing for soft keyboard, and its size
controls WebContents.setSize. The SurfaceParent will attempt to detect
cases where it is being resized for soft keyboard, and not resize in
that case. SurfaceView inherits the size from SurfaceParent, and thus
not recreate the Surface if it's not resized.

Conditions for when to apply this heuristic:
* Only use this for SurfaceView. TextureView is more likely being used
  in embedded use cases where this does not apply.
* ContentViewRenderView is the full width of the window. Again a
  heuristic to check for embedded use cases.
* Soft keyboard is showing.

Bug: 1050415
Change-Id: I9702f9ba06a4ab6c3d72355178bf47abf0d2240b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087972Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747372}

Bug: 1007815
Change-Id: I80541af887b21830a703cd7352b4e01590a99d6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089817Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747371}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/daac106699e1..f5b833c6d2ac

git log daac106699e1..f5b833c6d2ac --date=short --first-parent --format='%ad %ae %s'
2020-03-05 tvanderlippe@chromium.org Remove useless content read
2020-03-05 tvanderlippe@chromium.org Remove unused methods
2020-03-05 tvanderlippe@chromium.org Concatenate all common ts_library into a single target

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@f5b833c6d2ac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811,chromium:1046596
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I016858562da9c465ec38fb68f5854b159c7e847a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090214Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747370}

MemoryPressureListener expects MemoryPressureCallback which is
RepeatingCallback.

Bug: 1007815
Change-Id: Icc64607ac64e55819f14dc9d873c66b5f6c6e240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089735
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747369}

Bug: 2087406
Change-Id: I621bfd19d6e17bf165b3d2e802b9acb14538922e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089893
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747368}

Bug: 1049864
Change-Id: I9c77a8bba5251ed167aef22d2ce7ab7227ffd361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064179Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747367}

Logged when app transitioned from background to foreground.
Used for Breadcrumbs to log steps to reproduce for crashlogs.

Bug: 1046231
Change-Id: I6cc6b7d22fd19ce71347defbfb9246b3788125db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085598
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747366}

Based on early results in dev/canary, this feature is looking promising
and we would like to continue this experiment in Beta.  To unblock that
we are enabling this experiment for the perf bots now to get more data
on the impact.

Bug: 1014273
Change-Id: I0b3c0dbb94075bdb94b3f770bd32f2e761c8f6c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089953Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747365}

In case marking is in progress, first stop concurrent markers and
then cancel compaction.
If marking is not in progress, compaction should not have been
initialized yet, so it suffices to confirm that compaction is disabled.

Bug: 1058777
Change-Id: I8f9c6e2c461a6d933d56a7e39c18cbd09e6a40f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089873
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747364}

This CL prevents media notifications from unfreezing if they are still
waiting on new MediaSessionActions. This prevents an issue where
notifications would change sizes briefly because they had no actions to
show.

Bug: 1055254
Change-Id: I2345188626b332846a7b51c93545a1b40764044e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090291Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747363}