- 22 Nov, 2018 40 commits
-
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: Ibdd3ce5b262be153ba4219e5864e5394323e82b6 Reviewed-on: https://chromium-review.googlesource.com/c/1345092Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#610503}
-
Lucas Furukawa Gadani authored
Bug: 752372 Change-Id: Icc7b51b58168982b0237cd6a3fe06259c8a6f7ac Reviewed-on: https://chromium-review.googlesource.com/c/1348971 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#610502}
-
Peng Huang authored
Original change's description: > Revert "Using PaintCanvas for HUD" > > This reverts commit 25718190. > > Reason for revert: It breaks FPS counter on Mac > https://bugs.chromium.org/p/chromium/issues/detail?id=906570 > > Original change's description: > > Using PaintCanvas for HUD > > > > To support OOPR, we need switch from SkCanvas to PaintCanvas which is for > > OOPR. > > > > Bug: 895568 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I94b5430c7ee8ed2f5140d352214ec43f2ff0f8ad > > Reviewed-on: https://chromium-review.googlesource.com/c/1286950 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: enne <enne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#609033} > > TBR=penghuang@chromium.org,enne@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 895568, 906570 > Change-Id: I935de60977c0374139ae1eb22670d234f85e0df6 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/c/1342049 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609333} TBR=penghuang@chromium.org,enne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 895568, 906570 Change-Id: I65448fa5e72d1aa9bf79aa8513944f2ce953b91f Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1348864 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610501}
-
sebsg authored
The value was so big it was making analysis of other values difficult. It also was not useful anymore. Change-Id: I0163b1d9c6183c4791ca19baf825f9e82311e547 Reviewed-on: https://chromium-review.googlesource.com/c/1348953 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610500}
-
Nicolas Pena authored
This is a reland of 5d945012 Original change's description: > Unify input delay computations > > This CL unifies the timestamp computations for FID as reported to UMA and FID as > exposed in the Web Perf API. It moves the UMA reporting from the > PageWidgetDelegate to the EventTiming class. After this CL, the same types of > events are logged by both the UMA metric and the webexposed metric. In addition, > this CL removes the check that there are default actions or event handlers from > EventTiming, which means that now the webexposed API will expose events even if > they have no associated event handlers. In particular, this means that a click > will now trigger mousedown, click, and mouseup entries, in that order. This is > reflected in changes to the layout tests. > > Bug: 897656 > Change-Id: Ibeee0ffe9ff1fc0df74585da96a8fd3a6f2d17dc > Reviewed-on: https://chromium-review.googlesource.com/c/1334564 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610201} TBR=dtapuska@chromium.org Bug: 897656, 843184 Change-Id: I4d97f2731fe957696c0e908d5ef3493235b52d49 Reviewed-on: https://chromium-review.googlesource.com/c/1348254Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610499}
-
Matt Falkenhagen authored
Before this CL, CanvasRenderingContext remembered which request URLs were CORS same-origin and which were CORS cross-origin. This worked relatively well in a pre-service-worker world. But with service workers, the same request URL can have different response URLs. Also, even if two things have have the same response URL, they could differ in whether they were CORS approved or not. The solution is to remove the caching entirely. This causes more calls to CanvasImageSource::WouldTaintOrigin(), but the implementations of those look relatively lightweight so I don't expect performance to be worse than tracking URLs in two HashSets. Test: fetch-canvas-tainting-double-write.https.html added in https://chromium-review.googlesource.com/c/chromium/src/+/1347952. Bug: 907047 Change-Id: I4cf6289174935dee40ccad0364eb425d717b9f7f Reviewed-on: https://chromium-review.googlesource.com/c/1347953Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610498}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f25907800923..2c977b4cc57d git log f25907800923..2c977b4cc57d --date=short --no-merges --format='%ad %ae %s' 2018-11-22 terelius@webrtc.org Remove RSID from stream configs in new event log format. 2018-11-22 yvesg@webrtc.org [GN] Fix dependency rebasing in BUILD.gn files. 2018-11-22 srte@webrtc.org Routing BitrateAllocationUpdate to audio codec. 2018-11-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1500c78c..f9be7d3d (610314:610432) 2018-11-22 peterhanspers@webrtc.org Metal: Don't render into an empty view. 2018-11-22 gustaf@webrtc.org AEC3: Clockdrift detection Created with: gclient setdep -r src/third_party/webrtc@2c977b4cc57d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic20882afbd8663158dfe2db60496ac5d7c98f874 Reviewed-on: https://chromium-review.googlesource.com/c/1348574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610497}
-
Denis Kuznetsov authored
Remove separate ABE success screen. Replace success text with dedicated polymer element. TBR: alemate@chromium.org Bug: 811556 Change-Id: Id26aae8ec6276d57148cbb2a101094f93d28e11c Reviewed-on: https://chromium-review.googlesource.com/c/1329630 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#610496}
-
Jeremy Roman authored
Change-Id: Ic5f75f1cabac1adecbf0158d3a508eaec876da02 Reviewed-on: https://chromium-review.googlesource.com/c/1348856 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#610495}
-
Robert Flack authored
This relands the commit 4391edc0 from https://chromium-review.googlesource.com/c/chromium/src/+/1297305 The only difference is that the composited-filter-animation test has been made asynchronous and to wait for the actual time when full saturation should be visible. TBR=pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Bug: 896549 Change-Id: Idd597082b7ebd97d277f0e196236a155a4c0351d Reviewed-on: https://chromium-review.googlesource.com/c/1347784Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#610494}
-
Chris Sharp authored
Bug: 907443 Change-Id: I972b20ce4c7f489686b3d5963f4b541ba659b3a6 Reviewed-on: https://chromium-review.googlesource.com/c/1348950Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#610493}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ff7323ad. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id39dcc273f5cb989ebf3d78dc16d8d5bab8d98e6 Reviewed-on: https://chromium-review.googlesource.com/c/1348849 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610492}
-
Jonathan Backer authored
Works with these flags on Linux build with DCHECKs enabled: --use-gl=angle --use-angle=gl --use-cmd-decoder=passthrough --enable-features="VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList" Bug: 892272 Change-Id: I48c2caec780a6243b58e3ed1b2c60240f7a3b213 Reviewed-on: https://chromium-review.googlesource.com/c/1348589Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
-
Peng Huang authored
Bug: 838899 Change-Id: I72edfff6f3d97731b3f09f0bcf39fafa68a4ec50 Reviewed-on: https://chromium-review.googlesource.com/c/1348830 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Liquan(Max) Gu authored
The code base uses PaintTracker as the class to deal with FirstContentfulPaint++ logic. As it's specific for FCP++, we should give it a more specific name. PaintTimingDetector will be more clear about its intention. Bug: 869924 Change-Id: I194eeac2b40d1db3e719332e8a7cfe707a881b0e Reviewed-on: https://chromium-review.googlesource.com/c/1348250 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610489}
-
Robert Ogden authored
Figured out the problem and the best way to address it. Comments document my reasoning. Bug: 874150 Change-Id: Iba4b95fd615137d08836c98ec89bcb36db39327b Reviewed-on: https://chromium-review.googlesource.com/c/1348549Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#610488}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df066e9cded2..823d897350ca git log df066e9cded2..823d897350ca --date=short --no-merges --format='%ad %ae %s' 2018-11-22 syoussefi@chromium.org Vulkan: Internal Compute support Created with: gclient setdep -r src/third_party/angle@823d897350ca The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I276b5e3145f4ab138c06cc64a0a4f2fd9bc4cfe2 Reviewed-on: https://chromium-review.googlesource.com/c/1348576Reviewed-by:
-
Juan Jose Lopez Jaimez authored
RESULT_CODE_JSON_PARSER_SANDBOX_DISCONNECTED_TOO_SOON should be renamed to RESULT_CODE_PARSER_SANDBOX_DISCONNECTED_TOO_SOON Bug: b/117780288 Change-Id: I99d8ac3f178fdef7453ff29cc0f274bae89dbbc4 Reviewed-on: https://chromium-review.googlesource.com/c/1348790 Commit-Queue: Juan José Lopez Jaimez <jjlopezjaimez@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0144caadbe5..26e89c1206c6 Created with: gclient setdep -r src-internal@26e89c1206c6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic23b976866b0222393181727f0592066b1d66215 Reviewed-on: https://chromium-review.googlesource.com/c/1348575Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610485}
-
Roger McFarlane authored
This CL adds rich metadata to Autofill queries for the purpose of testing autofill field-type prediction models on the autofill server. This functionality is limited to non-release channels (i.e., Canary and Dev, but *NOT* Beta or Stable). When enabled, Chrome will augment the autofill queries with the plaintext values of the following form and field metadata: For the form: * id attribute * name attribute For each field * id attribute * name attribute * control type (i.e., text, tel, select, etc) * label * aria label * aria description * class attribute * placeholder attribute This data will be used by the autofill server to predict the types of each of the form's fields, for testing and evaluation purposes. TBR: ellyjones@chromium.org Bug: 898510 Change-Id: I3f7bc9f550e638137b9e2b34c1142932f791e3ef Reviewed-on: https://chromium-review.googlesource.com/c/1334090 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610484}
-
Christopher Cameron authored
Update the lifetime of RenderWidgetHostNSViewBridgeLocal. Previous to this change there were two lifetime modes - for in-process instances, RenderWidgetHostNSViewBridgeLocal was owned by a scoped_ptr - for out-of-process instance, RenderWidgetHostNSViewBridgeLocal would be owned by its mojo connection to its parent Change this so that the out-of-process version creates a RenderWidgetHostNSViewBridgeOwner, which is owned by the mojo connection, and which owns the RenderWidgetHostNSViewBridgeLocal via a scoped_ptr. Move the former ForwardingClientHelper to be part of RenderWidgetHostNSViewBridgeOwner. Note that this now mirrors structure and behavior in views::BridgeFactoryImpl. Change-Id: I1607df48b8e4ef26feaa180b2b46f49857678f66 Reviewed-on: https://chromium-review.googlesource.com/c/1347576 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610483}
-
Tim Volodine authored
Remove some passing android webview instrumentation tests from the filter. The following tests are passing: -AwContentsClientShouldInterceptRequestTest.testOnReceivedErrorCallback -- due to [1] -AwContentsClientShouldOverrideUrlLoadingTest.testWindowOpenHttpUrlInPopup -AwContentsClientShouldOverrideUrlLoadingTest.testWindowOpenHttpUrlInPopupAddsTrailingSlash -- bisected, apparently passing since the beginning [1] https://chromium-review.googlesource.com/c/chromium/src/+/1279171 BUG=841556,893567,893566 TBR=cduvall@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ie8cce35496fcbd292cc03fa37f449302a643bc93 Reviewed-on: https://chromium-review.googlesource.com/c/1348889 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610482}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/981763ec74fc..7a3493e88767 git log 981763ec74fc..7a3493e88767 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 zoddicus@users.noreply.github.com Make sure that initialized variable have correct storage class (#2092) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7a3493e88767 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib3fcb34460ab02f9c8ecf8b49a48ebedaae34b76 Reviewed-on: https://chromium-review.googlesource.com/c/1348296Reviewed-by:
-
Antonio Gomes authored
CL replaces the Use of OAuth2TokenService, OAuth2TokenService::Consumer and SigninManager APIs with the corresponding IdentityManager counterparts. The unittests could not be only minimally adapted, and converted on a follow up pass, given that CL needed to replace the uses of FakeProfileOAuth2TokenService with IdentityTestEnvironment upfront. TBR=blundell@chromium.org,treib@chromium.org (both have already approved the previously incarnation of this CL. The CL was accidentally deleted when being sent to CQ). BUG=907529 Change-Id: If359e0a0728f87281a9f0c6bbe09ee10db2c82d3 Reviewed-on: https://chromium-review.googlesource.com/c/1348670 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#610480}
-
Kevin McNee authored
The flags were removed in https://chromium.googlesource.com/chromium/src/+/e6d81f47c871e49bb60ab45804dcb11e7c801667 Bug: 859171 Change-Id: I09b1d9e4b39e370da2efeb5ef076886cbe38296d Reviewed-on: https://chromium-review.googlesource.com/c/1342657Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610479}
-
Henrique Grandinetti authored
Bug: 907227 Change-Id: Ibf6b14fb8198b5c5878436e4e80e0e48622e458a Reviewed-on: https://chromium-review.googlesource.com/c/1345129Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#610478}
-
Peter Wen authored
Run two compile_java steps in parallel, one without errorprone (~20s) to unblock subsequent build steps (desugar, bytecode rewriting, dexing), and one with errorprone (if enabled) to check the build (~40s). This saves approximately 19 seconds for the overall incremental build of chrome_java. Bug: 906803 Change-Id: I4dee29c246bbc65791088dcc5e38d1030310c466 Reviewed-on: https://chromium-review.googlesource.com/c/1346992 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610477}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a7215287df2..4a3f1fe4eec5 git log 2a7215287df2..4a3f1fe4eec5 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 efe061bd4f9d..df066e9cded2 (1 commits) Created with: gclient setdep -r src/third_party/skia@4a3f1fe4eec5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I70cab1c24b1bef9e399d8eb6db3f95e2a6f764c2 Reviewed-on: https://chromium-review.googlesource.com/c/1348572Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3a12ff5e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ica9bcf2f660389e32f3a8222401068379a59c83d Reviewed-on: https://chromium-review.googlesource.com/c/1348256 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Fredrik Söderquist authored
This function has a very generic name, but not a wide enough use case to match. Move it to FilterOperationResolver, where its only two callers are. Rename to something less generic. Change-Id: Ibe6eaf68fbeddd86464d508cba3d6b235117f780 Reviewed-on: https://chromium-review.googlesource.com/c/1348096Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#610474}
-
Kevin McNee authored
We use NDEBUG for the condition to enable DCHECKs related to scroll event sequence validity, but this doesn't consider that DCHECKs could be enabled in release builds with dcheck_always_on. Bug: 897791 Change-Id: I8bf894b9fcfd56d5c8256bafa4d00b3e1eb37ed2 Reviewed-on: https://chromium-review.googlesource.com/c/1348253Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610473}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e6714e3c66b..f0144caadbe5 Created with: gclient setdep -r src-internal@f0144caadbe5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9d7a3880543da7bcc979a15a0f0bd42926ec51f9 Reviewed-on: https://chromium-review.googlesource.com/c/1348570Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af228ee761e1..f25907800923 git log af228ee761e1..f25907800923 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 magjed@webrtc.org Use cropping aligning in video quality analysis tool 2018-11-22 danilchap@webrtc.org Fix setting max reordering threshold in ReceiveStatistics 2018-11-22 magjed@webrtc.org Add tool for aligning cropped region of video files 2018-11-22 mbonadei@webrtc.org Remove cricket::UdpTransport. 2018-11-22 mbonadei@webrtc.org Remove cricket::BundleFilter. 2018-11-22 terelius@webrtc.org Cleanup AimdRateController and remove RateControlRegion enum. 2018-11-22 artit@webrtc.org Increase test timeouts in TCPChannelClientTest 2018-11-22 hta@webrtc.org Remove superfluous constructor from dltsTransport 2018-11-22 danilchap@webrtc.org Cleanup rtcp StreamStatistician::OnRtpPacket Created with: gclient setdep -r src/third_party/webrtc@f25907800923 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:b/38179459,chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idc2f3e6a1bbd4df155d5e2bc37ff04dba29895d8 Reviewed-on: https://chromium-review.googlesource.com/c/1348295Reviewed-by:
-
Xi Cheng authored
Change-Id: Ie122cdd92aff2bdadddf1106018fc994fae81fdc Reviewed-on: https://chromium-review.googlesource.com/c/1347099Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#610470}
-
Benjamin Shaya authored
Bug: 117433735 Test: On device Change-Id: I2dc2c4aca15640262fc51114910fd77300e03d17 Reviewed-on: https://chromium-review.googlesource.com/c/1311495 Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#610469}
-
Ned Nguyen authored
This also update test expectation linter to error out on lines with mutual exclusive specifiers The Expectation files are updated using the script in https://chromium-review.googlesource.com/c/chromium/src/+/1336387 This is the first part of the plan to migrate WebkitLayout test expectations to the new format. Bug: 807751 Change-Id: Iad2296a99804fb16d9b474229b68c0d47d3fe1eb Reviewed-on: https://chromium-review.googlesource.com/c/1336439 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#610468}
-
Nico Weber authored
Also remove no-longer-needed debug logging. TBR=hans Bug: 899438 Change-Id: I1759e7e2f6ee8ece3fcdddeeb286754c1cf6b60a Reviewed-on: https://chromium-review.googlesource.com/c/1348310Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610467}
-
Nicolás Peña Moreno authored
This reverts commit c19f615e. Reason for revert: looks like the cause of compile failure in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3760 Original change's description: > [Autofill Assistant] Attempt to recover pre-interrupt state. > > When an interrupt script is run, it can modify anything, which makes the > main script with allow_interrupt=true hard to write. This change propose > to reset some state automatically after an interrupt to make this > easier. > > It recovers the status message and attempts to set a reasonable scroll > position. It sets it to either the element WaitForDom was waiting for, > for a successful WaitForDom. For an unsuccessful WaitForDom, it scrolls > to the last element focused on (if it still exists.) > > Change-Id: Ie9c0022eebc10e0711c82d83b943e0de152af1fd > Reviewed-on: https://chromium-review.googlesource.com/c/1346451 > Commit-Queue: Stephane Zermatten <szermatt@chromium.org> > Reviewed-by: Mathias Carlen <mcarlen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610412} TBR=mcarlen@chromium.org,szermatt@chromium.org Change-Id: I035b9b699fda14b5d3a1b87ee84d5715638c0f83 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1348631Reviewed-by:
-
Sergio Villar Senin authored
It was using both SigninManager and ProfileOAuth2TokenService fakes to seed primary&secondary account info and update their refresh tokens. Replaced them by the correspondent identity API calls via an IdentityTestEnvironmentProfileAdaptor which is also used to create the testing profile. Bug: 905247 Change-Id: I8cdca4c9ade423cf9e431fd0420f6db5411935b3 Reviewed-on: https://chromium-review.googlesource.com/c/1346094 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610465}
-
Dave Tapuska authored
Use appropriate types instead of size_t. BUG=879657 Change-Id: I5372e622570dbfed1628e6a1c70882ed85a17b51 Reviewed-on: https://chromium-review.googlesource.com/c/1347431Reviewed-by:
-
