- 02 Jun, 2020 40 commits
-
-
Eric Roman authored
The expected default is false, as that is what is used at other layers: * net::HttpAuthPreferences * prefs::kEnableAuthNegotiatePort * key::kEnableAuthNegotiatePort Using true can cause problems with integrated auth, as it constructs SPNs in the less common way. Bug: 924746 Change-Id: I2d09f0c72aa2ac8d8f60c1e2adfeb92c379d336b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225531 Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774396}
-
Alan Cutter authored
When a user has a web app installed then uninstalled via policy we leave behind some policy install info in their prefs. This info is used by CanCreateWebApp() to determine whether there is an app already installed by policy. This causes a bug where users cannot install web apps after they've been removed from policy. This CL updates the check to also check whether the app is actually installed and not just check for the presence of the pref data. Bug: 1090182 Change-Id: I736118cec4e0b1ff34ae335965dc7b8816c20837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224417 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#774395}
-
Daniel Rubery authored
The histograms show no major regressions on Canary/Dev. We'll need the increased data volume from Beta to validate the model performance improvements. Before doing so, enable the new model version in field trials. This should have no effect, since this parameter chooses a model version in communication with remote SB servers. Bug: 1054056 Change-Id: Ifa10a303d880cb05c5176a8813b2bece06a992f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216389 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774394}
-
Chris Blume authored
Android uses the dynamic color gamut to change gamuts as needed based on the content being displayed. There is a Finch experiment for this which is rolled out to 50% of Canary and Dev channels. This CL adds a field trial for that Finch experiment so bots can test the config. Change-Id: I112a9dc0f8edb99b39f227a81a7785527717db95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225622 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774393}
-
Yi Gu authored
The TODO was introduced in crrev.com/c/548875. Bug: None Change-Id: I03f6061787278b04976c53c79760447a98c03346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227045Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774392}
-
Eric Lawrence authored
Users can easily lose work if they drag/drop a file or URL into a tab that does not consume the dropped data (e.g. as a file upload). Rather than navigating the current tab (blowing away whatever was in it), instead open the dropped URL in a new foreground tab. Bug: 451659 Change-Id: Ic7010a3c933d7747d4b70fefa4d0a5380448c58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213459Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774391}
-
dpapad authored
Some manual edits have been recorded in the form of "NOTE" comments, since the generation script still has some bugs. Bug: 1081815 Change-Id: I2d2fb4cf82d0b1467a0afd335cd61a3c68688990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212998Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#774390}
-
Xianzhu Wang authored
Custom scrollbar parts don't have children. They act more like special replaced elements. Letting LayoutCustomScrollbarPart inherit LayoutReplaced can reduce cost. Change-Id: I496aa9c331485a2ff4a0bbe5c9f2b542abce79ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226924Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774389}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a6c70741e76f..3c9ae1fd8fb7 2020-06-02 hta@webrtc.org Adds fix for closing a prenegotiated DC without sending data. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia3f824210022436e715304a5a149e2b9cc40b69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227158Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774388}
-
Dominic Mazzoni authored
This reverts commit cd9df201. Reason for revert: Failing on Mac, see bug Original change's description: > Main frame's context menu should exclude frame-specific commands. > > If content::ContextMenuParams includes a non-empty |frame_url|, then the > context menu (the menu shown after right clicking in a frame) includes > frame-specific commands like "View frame source" and/or "Reload frame". > Before r749036 / 82.0.4084.0, context menu shown for the main frame > would exclude such frame-specific items. This behavior has regressed > in r749036, because it failed to preserve the following logic from > //third_party/blink/renderer/core/page/context_menu_controller.cc: > > if (selected_frame != page_->MainFrame()) > data.frame_url = WebURL(UrlFromFrame(selected_frame)); > > and instead started to unconditionally populate the |frame_url| field in > RenderFrameHostImpl::OnContextMenu. This CL fixes the regression. > > Bug: 1085040 > Change-Id: I149447654bee858037a4230828e2c4a7b3c7c0bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212995 > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774333} TBR=nasko@chromium.org,lazyboy@chromium.org,lukasza@chromium.org,lazyboy@google.com Change-Id: I39ca90cca707409aede5a46f27f300528b4d5d57 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085040, 1090564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225246Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774387}
-
Ben Joyce authored
Newer library features are required for //clank code. Size regression without resource filters: * 244,995 bytes, 941 methods * https://chromium-review.googlesource.com/c/chromium/src/+/2165449/8 Size regression with just Layouts, Calendar and AlertDialog removed (AlertDialog is referenced by an unused layout): * +134,038 bytes, 344 methods * https://chromium-review.googlesource.com/c/chromium/src/+/2197526 "With this particular widget we rolled our own, then unrolled out own since the savings own since the savings seemed to not quite outweigh the cost on a subsequent update and we'd be rolling our own again." Bug: 1064727 Change-Id: Idd02c3540a6e91e54d2fa5dc9a79bd851162bcfb Binary-Size: Size increase from library. Reduced from 244,955. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165449Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#774386}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6380ab5a1d67..88bc40da7991 2020-06-02 anubmat@microsoft.com Add Serviceworker respondWith Timeline to network panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1066579 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6a7aba9f0ad97b130dad465cff51bbc906943ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227271Reviewed-by:
-
Joel Hockey authored
App browsers can now support tab strips and should be included in some of the calls to IsBrowserTypeNormal. Added function IsTabStripSupported and changed calls relating to tablet mode in BrowserNonClientFrameViewAsh and ImmersiveModeControllerAsh to use it rather than IsBrowserTypeNormal. Bug: 1090208 Change-Id: I158e24debf44cd68b62725d96e8c287944af4dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226236 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#774384}
-
danakj authored
This moves it out of the site isolation error section. This appears to be a bug in the spec for intersection-observer when dealing with a child local root, and not a bug in the implementation of site isolation or the test (since it's testing a bad spec). R=szager@chromium.org Bug: 1007229 Change-Id: I639cb6ddb1d1a82df837fb0ba466922d29151943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222910 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#774383}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5cd744fe49e..76a2918f55cd 2020-06-02 vadimsh@chromium.org [lucicfg] Update to 1.14.5. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1082296,chromium:1085650 Tbr: agable@chromium.org Change-Id: I325049adfcc60828bb7e7dd253b1f5a6db3a0418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227164Reviewed-by:
-
Jun Mukai authored
Sometimes TrayItemView::SetVisible() can be called repeatedly. An example is PowerTrayView() -- its SetVisible() can be called periodically based on the power status. That causes animation and AnimationProgressed(), but that is redundant. Bug: 1082562 Test: manually Change-Id: I45573360edda49572975966d1a84d4d067edbf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223432Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#774381}
-
Dominic Mazzoni authored
Tbr: sandromaggi@chromium.org Bug: 1090215 Change-Id: I381c018c9a0b763dbb39a468754c78c895b8a9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227181Reviewed-by:
-
Miriam Zimmerman authored
BUG=None TEST=None Change-Id: I1d562f0e930b27ab90d814b9ff97c033582e2070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226069Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#774379}
-
Yue Zhang authored
Bug: 1078169 Change-Id: I62bd049309a19ef41bb503fcaff8e1c7ed998847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225533Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#774378}
-
Matt Falkenhagen authored
Bug: 1089495 Change-Id: I8af3f627d076a03a58c61d183f63216ac31add79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226000Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774377}
-
OlivierLi authored
Under critical memory pressure the system is probably already swapping out memory and making heavy use of IO. Adding to that is not desirable. Furthermore, scheduling a task to write files to disk risks paging-in memory that was already committed to disk which compounds the problem. Bug: 1087530 Change-Id: I2f5ba6e703eef0d804e6f4d99dd504c7eadf7740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227029Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#774376}
-
Mitsuru Oshima authored
The targeter can be null and in that case it should use the parents. Bug: b/157910224 Test: covered by unittest. also tested manually. see bug for repro step. Change-Id: I13db092a6ee062ef9547aec70b6f7cd077558e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225854 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#774375}
-
Adam Norberg authored
The file name doesn't match because the intended next CL is to rewrite ScopedXPCUpdateServiceMock as ScopedXPCServiceMock that takes the @protocol for the XPC service as an argument, and modify the existing test to use it in this manner. I figured splitting it into two CLs would simplify the review. Bug: 1055876 Change-Id: I5134d8f29124538441fe1430ed3cacbdf56dd186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225857 Auto-Submit: Adam Norberg <norberg@google.com> Commit-Queue: Adam Norberg <norberg@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774374}
-
Esmael El-Moslimany authored
Third-party search providers may or may not have third-party NTPs. When they do not have a third-party NTP, the local-ntp is used to display the most-visited tiles. Bug: 1087531 Change-Id: I799e252edba04e07601fc43938688cf1d381d183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225625Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#774373}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591113598-81d0db8118cc6885d9786065771de10da2a65ecd.profdata to chrome-mac-master-1591127928-6ca3eedb8c11f1c6551de9c000f330ab07bf1259.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I248eeda08bdd7c40a45bd5a97c40ad833627de26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227167Reviewed-by:
-
Abhijeet Singh authored
For the case when a menu is active, QuickAnswersView currently is unable to obtain the focus because that would require activating its top-level widget, which would cause the menu to disappear like it does on observing any change in the activated window. This CL makes QuickAnswerView's widget a child of the menu's owning widget, as a result of which it can now share the owning widget's FocusManager and successfully request focus. This is needed to incorporate keyboard accessibility for the view. Key or accelerator handling will be added in follow up CLs. Tests are also added. Bug: b:152057976 Test: Tested on Chrome OS VM and ran ash_unittests. Change-Id: I2acbbd5d3f918fffe33d31d8f7764ecf28ffcaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222119Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#774371}
-
Eugene But authored
Currently HeapProfilerController uses 24 hours interval for Desktop and Android. While 24h is good for Desktop, the interval is too big for Android, which likely has median process up time of less than an hour. iOS uses 30 minutes interval, which is equal to median process up time duration. 30m would be more appropriate interval for Android. Bug: 1090017 Change-Id: Ia8dfc09a75e036265298e3d69ad04fb8cc1b1124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225359 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774370}
-
Ben Schwartz authored
This change (1) adds dns_over_https to the tests' fake prefs. (2) makes TestPrivacyPageBrowserProxy usable in its default state. (3) adds a check for undefined prefs to secure_dns.js, to match the other privacy preference UI elements. Bug: 1087444 Change-Id: Ic8fb7e200d515d7a1da541c62ca3e90640e56060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223639Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Ben Schwartz <bemasc@chromium.org> Auto-Submit: Ben Schwartz <bemasc@chromium.org> Cr-Commit-Position: refs/heads/master@{#774369}
-
Matt Menke authored
I believe this was added when investigating some sort of change in logic to close idle sockets, but it's no longer being used. Fixed: 1089020 Change-Id: Iccb2670d9e65b717ceb3763367af3f87a4e2036d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225262Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774368}
-
Rahul Arakeri authored
- Reverted change: crrev.com/c/2174809 - Reverted CL is in PS1. - Reverted because ScrollbarController::StartAutoScrollAnimation tried to dereference a null ScrollbarLayerImplBase. - Relanded CL + fix is in the latest PS. Root cause: When the user rapidly clicks on the scrollbar, a second mousedown can arrive within the same VSync as the first mousedown. When handling the second mousedown, the first thing that happens is that the ScrollbarController schedules an autoscroll task. After this, the InputHandlerProxy notices that this 2nd mousedown occurred in the same VSync and that will lead to LayerTreeHostImpl::ScrollEnd getting called. ScrollbarController::captured_scrollbar_metadata_ then gets cleared by ScrollEnd. Due to this, the scrollbar layer reference that is needed by StartAutoScrollAnimation is null. The previously scheduled autoscroll task then tries to proceed (after 250ms) by using a null ScrollbarLayer and fails. Why didn't this fail before this change: This bug was masked because when the autoscroll task was previously created, a pointer to the scrollbar layer was directly passed from the HandlePointerDown to StartAutoScrollAnimation. This reference always remains valid even though the InputHandlerProxy cancelled the scroll. With the refactor, the scrollbar layer needed for StartAutoScrollAnimation is now queried on demand using captured_scrollbar_metadata_ which gets cleared on ScrollEnd and this is what exposed the bug. The fix is to clear the scheduled autoscroll task as well on ScrollEnd. Original description: This CL gets rid of the several ScrollbarLayerImplBase references in the private methods of ScrollbarController. They need not be passed around because the ScrollbarLayerImplBase can easily be looked up by calling ScrollbarController::ScrollbarLayer (which retrieves the needed scrollber layer by using CapturedScrollbarMetadata::scroll_element_id). Bug: 1077093, 1078765 Change-Id: Ida68e4323e69757a7bfaeab7a7986fb64d07feb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224606 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#774367}
-
Kyle Horimoto authored
Before this change, we arbitrarily returned "true" for search result items which were deemed equal to each other, but this was incorrect because the comparison function is testing whether the first item is less than the second item. This CL updates this function so that it returns false in this case, which induces a strict weak ordering of results. Fixed: 1090184 Change-Id: I763112cef36d68731a88fd8a3696a800292899a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225930 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#774366}
-
Jonathan Ross authored
On Mac10.13 Tests (dbg) form-validation-reportValidity is flaking, adding it back into the expectations. TBR=robertocn@chromium.org TEST=virtual/web-components-v0-disabled/external/wpt/html/semantics/forms/constraints/form-validation-reportValidity.html Bug: 1041973 Change-Id: Ib5b69a0b58c1cc694b4c0e1e09f1bde9ea9edce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227253Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#774365}
-
Clark DuVall authored
I was testing my in-progress popup change, and found a crash when opening multiple popups. Bug: 1090492 Change-Id: I2c3cb3cc655d13ce5476192117c4d863c9d4c044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225626 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ad3dfb46bb6..4af57c9c55fd 2020-06-02 bsalomon@google.com Check for sync extensions only on correct context types 2020-06-02 reed@google.com Revert "Revert "gms for SkParagraph"" 2020-06-02 mtklein@google.com does -fms-compatibility-version=19 still matter? 2020-06-02 herb@google.com Make strike fields private 2020-06-02 nifong@google.com A example of 3D rotation that shows a quotation with all the glyphs rotated. 2020-06-02 michaelludwig@google.com Add localmatrix w/ perspective GM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I9804c0609a41ac050a00d0cffa7e7fc2b932cbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227161Reviewed-by:
-
kylechar authored
Fix NOTIMPLEMENTED() that gets hit with SkiaRenderer+Dawn for max texture size. There is no API to query max texture size but WebGPU needs to support 8k textures so that is a safe placeholder for now. Bug: 1090476 Change-Id: Ia25ab3441b717410f09e21bb3785413c8a3c097a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225624 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#774362}
-
Marijn Kruisselbrink authored
For drag&drop we'll need a different implementation of this mojo interface. This CL factors out the common code into an abstract base class, with the existing implementation as a concrete subclass. Later for drag&drop a different concrete subclass will be added. Bug: 1080811 Change-Id: Ie16836f315918e1f20dde82fc2a7efac40f67c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221432 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib2ce63d55287247b34dd8c3cc89117692b3a8941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227171Reviewed-by:
-
Katie D authored
No translation screenshots as this is not yet UX approved. cursor colors in chromebook a11y settings. AX-Relnotes: Users with cursor color flag enabled can now change their Bug: 1085442 Change-Id: I583f6b28ea69387e598e595b513bf4cf6928bbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220492 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Ian Vollick authored
With this CL, we count the portal's web contents as a single frame in its parent, ensuring that we do not exceed NodeRareData's connected frame count bits. However, we do not yet include frames within the portal in the total. If limit is exceeded, HTMLPortalElement::InsertedInto will early out. Successful insertion and removal of portal elements will impact the subframe count (and, naturally, the consistency check on subframe count must also account for portals as well as frames). In order for the test to run in a reasonable amount of time, I've also made it possible to reduce the frame limit for testing. Bug: 970038 Change-Id: I64d458b640c193c96662b0dd1e2101b6438e2e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187200Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#774358}
-
Lei Zhang authored
For instance, if (ptr != nullptr) can just become if (ptr). Change-Id: I56fc1a8f97d72f46bca8035e3bcb9b4fae199b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227114Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#774357}
-
