- 01 Jul, 2020 40 commits
-
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I88528b1983052c7668818f37431c116ed2a8b7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277968 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#784402}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I54034bd08040e8aba6bd6d21e53a920fe42f3fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277965 Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784401}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fc0dc3a9c734..fba90d6b0a23 2020-06-30 vasniktel@gmail.com spirv-fuzz: Add FuzzerPassAddCopyMemoryInstructions (#3391) 2020-06-30 vasniktel@gmail.com spirv-fuzz: Add one parameter at a time (#3469) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ia4a4fff6d50748759651eb952b6db1d6541f5763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277617Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784400}
-
Leo Lai authored
This CL is part of plan that chromium talks to attestationd and bypass cryptohomed for attestation-related APIs. BUG=b:158955123 Change-Id: I7be67f3420fb114ab11203dd44e73bca4aa11574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249276 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#784399}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I494e828033221636b70c618e46bca99ec9e5aa98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276415 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I4e61fe7c448d138c6a3592f8e04442e73e4ad6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276416 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784397}
-
Noel Gordon authored
Tests that dragging a file over a directory tree item that can accept a drop adds CSS class .accepts to that tree item. Also: check that the drag hover causes the file-list to navigate to the hovered tree item's directory. Bug: 1002394 Change-Id: I4def2bfd5621b9043d615c0706cc273fc9eb16ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275576 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784396}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ib5930991d138a7f53e605e9f21bfd944a4df1129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276663 Commit-Queue: Colin Blundell <blundell@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#784395}
-
Leonard Grey authored
The tabstrip background calculation currently assumes that its origin is relative to the browser view. This is usually true, but its actual parent view is the top container, which can have a different origin in some cases. This change explicitly converts the origin to the browser view. Bug: 968415 Change-Id: Ice3243c275ffce2f2fcc043df6b142392f02db2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276520Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#784394}
-
chrome://versionEdward Trist authored
Currently, the Chrome logo on chrome://version lacks an alt attribute. This change uses the existing IDS_SHORT_PRODUCT_LOGO_ALT_TEXT string to get alt text for the current product logo (i.e. Chrome logo / Chromium logo). Bug: 1082511 Change-Id: Ib601ad747402a482bb13f80a65268855d9a3ba92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234513Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784393}
-
Mansi Awasthi authored
This CL introduces a method PDFiumPage::PopulateButton() which reads button form fields (radio button, checkbox and push button) from the PDF document and stores relevant information in a vector within PDFiumPage. The CL also includes a new test file with sample radio buttons, checkbox and push button. A unit test is also added to validate the new method. Bug: 1030242 Change-Id: I1f5102f8c20027abe785fa1833c2ecc9cbce8734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249285 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#784392} -
Robert Sesek authored
This let the signing scripts work out-of-the-box with Chromium builds. The existing app-entitlements.plist file is split into two: in that file are all the entitlements that work with any signed build of the product, but the entitlements that are bound to the Google Chrome signing identity are moved into a new app-entitlements-chrome.plist. Bug: 1021255 Change-Id: I2aa04d5da1edcaaeeed50f3b70a86400e3aac516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276523Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784391}
-
Marc Treib authored
While we're here, also remove "passwords-account-storage-saving-ui" which doesn't exist anymore. Bug: none Change-Id: I9f202b7c39f8cfaa619ee65f72c11bff2f5e41a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276203 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#784390}
-
Noel Gordon authored
After CL:2262772, when a drag drop operation is active over FilesApp, a CSS .drag-drop-active class is added to the root <html> element, and is removed when the drag drop operation ends. Add html.drag-drop-active tests to test its addition and removal when a drag drop operation begins and ends. There are two end cases to test: drag drop ends with a dragleave event, or with a drop event. Add tests for both cases: transferDragDropActiveLeave, transferDragDropActiveDrop. Note: since file-list can navigate (logically any time on a bot) due to file_transfer_controller's drag target hover time, we use #file-list as the source when calling fakeDragLeaveOrDrop. No-try: true Bug: 1062902, 1002394 Change-Id: I1426e769b33d1d5a72a1321fdc3319ae940cf31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275979 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#784389}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2761f01d68a7..d2ca995f88ba 2020-07-01 ianelliott@google.com Vulkan: Update "fragment_ops" failures on Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I189ab9a3d5addad2e58c0a2a9aa62f5fc1a683be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277601Reviewed-by:
-
Ella Ge authored
Each notification is pushed to the list and then popped to run only once. so, use BindOnce and OnceClosure. Idealy we can use |CallbackList| here, but since we don't want/need the returned |Subscription|, use a list of OnceClosure is sufficient. Bug: 1007635 Change-Id: I8e68ac9ee0fb52931853994104a2559c8b7de563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275462Reviewed-by:
-
Christian Dullweber authored
Tbr: treib@chromium.org Bug: 1100890 Change-Id: If5c4219493f82bf7f43aa004244c8d9fc6fdd93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275888Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#784386}
-
Monica Basta authored
Bug: 1050070 Change-Id: I6f6a3eaf220f9ea7f4993f59eabb02fb91e3a5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276284Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#784385}
-
Ewann authored
Bug: 1063824 Change-Id: I5555ed2ebd6f7a50c8280d1abdbf02be61b16d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275951 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ae6540492fcb..e22dad5763e9 2020-07-01 sigurds@chromium.org Fix stylelint-config-standard issues in front_end/elements/elementsTreeOutline.css 2020-07-01 mathias@chromium.org Simplify prefers-reduced-data feature test 2020-07-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142,chromium:1096068 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0b5bbe9bce3ef1e9bcb225d4d387f571e6faeb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277865Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/47c3c7a55be5..a962afa04fee 2020-07-01 lalitm@google.com Merge "tp: update SQLite to latest version in standalone" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I73cfc95202b42179115c50ecb2b8e0d1755cdd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277864Reviewed-by:
-
Dominic Farolino authored
This CL adds WPTs asserting that in-viewport loading=lazy iframes do not block the outer window load event. The test accompanies the spec change made at: https://github.com/whatwg/html/pull/5579. R=sclittle@chromium.org Bug: 1101175 Change-Id: I5e337f6c87c8198e8e5bae5a32263698fb3daf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277384 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#784381}
-
Luca Hunkeler authored
Currently, the overlay is depending on the current state. In the case of browse mode, the state is set to BROWSE by the prompt action and reset to RUNNING at the end of it. This causes the overlay to flicker between prompt actions when multiple are present. To prevent this we introduce a new action to manually configure the overlay state from the backend. When the the new state is set to HIDDEN the overlay will never be shown. This overrides the current logic that decides the overlay state based on the current AutofillAssistantState. Bug: b/157457059, b/156232664 Change-Id: I38a720ec6a4a6d73ef4bf31f3f5286188942464e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252045Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#784380}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia7b36be727a2c599658d269a932cdcf8be77eb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277862Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593561487-f93d00b844fcb3a1b3a03cdb0ab1966b81282397.profdata to chrome-mac-master-1593582825-995d8e78b6c8ff09ef0a8c1c9fd4830db0669287.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I51b970544a44be805ed962c6374a61c1cc72985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277616Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/268fe254ec50..2ffc55ab385d 2020-07-01 jiajie.hu@intel.com Never try to populate the LASTCHANGE file in non-standalone checkout If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iafb3ccb79f93815104ca5be9569a7e96216f5710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277603Reviewed-by:
-
Oleh Lamzin authored
Add Mahmoud and Roland to Telemetry SWX OWNERS. Change-Id: I538797ecc1dcc75d89e2be93c951c7959a5ae3e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275439Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#784376}
-
Oriol Brufau authored
Lack of support for ::before::marker and ::after::marker, and some problems with legacy markers with 'content: normal'. Bug: 1097992, 1101034, 1101040 Change-Id: Iabd75e6d6e0fb8dd483f7b7415e26d51f9b2335c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274605Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#784375}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I18e3818221e3e2e4d160dfaaebdbe68ae0a1244c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274615 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784374}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3dc5798..fdee3989 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibf1f284256be595b41f534b32e82c54ae8eaf6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277243Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784373}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ib09490abc81fa0988b8e2428b3946edd6f468c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277727 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Xida Chen authored
This CL converts the DeviceOAuth2TokenService::StatusCallback from base::Callback to base::RepeatingCallback. This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: I956bbc22308bcf92be9e971889ccf9d047f9fa00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277097 Auto-Submit: Xida Chen <xidachen@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#784371}
-
Andrey Zaytsev authored
Currently Omaha code for Android is in //chrome/android, while Safety check is in //chrome/browser. In order for Safety check to be able to use Omaha, there is a need to have a delegate Omaha client class with an interface in //chrome/browser and an implementation in //chrome/android. This CL also adds all the associated update logic to Safety check on Clank. Bug: 1070620 Change-Id: I3119cafe23ccb9cbc5b49edbcc7895576e77cefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264442 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#784370}
-
Sergio Villar Senin authored
Both CrossSizeIsDefiniteForPercentageResolution and MainSizeIsDefiniteForPercentageResolution() are only called from UseOverrideLogicalHeightForPerentageResolution(). The former is called whenever MainAxisIsInlineAxis(child) is true and the latter when it's false. However CrossSizeIsDefiniteForPercentageResolution() has a path for MainAxisIsInlineAxis(child)==false which is impossible to reach. Thesame happens to MainSizeIsDefiniteForPercentageResolution() which has a path for MainAxisIsInlineAxis(child)==true which is also impossible to reach. Remove both death paths and replace them by assertions. Change-Id: I7c97ee46e992585ff2ff9b95e23341cc10b70eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275446Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#784369}
-
Jimmy Gong authored
Log entry points for the print management app from settings, notification, browser, and app launcher. Bug: 1053704 Change-Id: I841357a09683d1594954fd0b143bc49265952532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262592Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#784368}
-
Christian Dullweber authored
This reverts commit c92df469. Reason for revert: This CL caused test failures in https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/16175 Original change's description: > Ensure test settings are fully reset between tests > > Javascript can run after BlinkTestRunner::OnResetRendererAfterWebTest, > dirtying TestRunner state for the next test. A navigation to about:blank > is done after every test. This patch resets the TestRunner state after > the navigation to about:blank, when we are sure no test javascript can > change TestRunner state. This fixes a class of flaky bugs. > > This behavior happened with video-overlay-scroll.html which would set a > custom layout dump (setCustomTextOutput) in a fullscreenchange event > handler. This event handler was not removed at the end of the test > (this will be fixed in a followup), and would run a second time, after > the custom text output setting was reset. This caused later tests to > run with custom text output from video-overlay-scroll.html. With this > patch, video-scrolled-iframe.html is no longer flaky. > > Code in WebFrameTestProxy::BeginNavigation to intercept navigations > relied on TestRunner::PolicyDelegateEnabled being reset before it ran. > This patch now skips WebFrameTestProxy::BeginNavigation when the test > is not running. > > Bug: 1048597 > Change-Id: I888f7cc2ae91d7d3cfdd143a7573f62cb052c1cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275348 > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Auto-Submit: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784110} TBR=danakj@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ieb22e1d115bd284aaa942c60ca7c6dc5e8ea71b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276418Reviewed-by:
-
Javier Ernesto Flores Robles authored
Dock the keyboard on tear down when an attempt to undock it was made. Bug: 1092828 Change-Id: I6dc338f8b4b03e3f81d2d36f2f660c491bcffa8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270066 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#784366}
-
Colin Blundell authored
//chrome's InfoBarContainerLayout.java has now been componentized and WebLayer can reuse it. As part of that componentization, the InfoBarAnimationListener interface was pulled out of //chrome's InfoBarContainer.java to live in a standalone //components-level file. This CL changes WebLayer to use the componentized InfoBarContainerLayout and the componentized InfoBarAnimationListener on which the former depends. There are no behavioral changes, as none of the code being deleted was changed from the now-componentized //chrome versions. Bug: 1099169 Change-Id: Ic443dc5cd266da1add574e85caf100a809111e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275895 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#784365}
-
Christian Dullweber authored
This reverts commit 8d6a9454. Reason for revert: All/NavigationControllerBrowserTest.PageStateWithIframeAfterForwardInCompetingFrames/2 is failing on https://ci.chromium.org/p/chromium/builders/ci/android-asan/6791 Original change's description: > Parameterize NavigationControllerBrowserTest etc for RenderDocument. > > These tests are sensitive to RD's type of changes and several of them > needed fixing already. > > Bug: 1100745,1068965 > Change-Id: I1bd93ebac207c502d0dda7f749a4c5f25f4e506b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275459 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784274} TBR=alexmos@chromium.org,fergal@chromium.org Change-Id: I8c7ebc4cb5b0c82d5a2a9e8b01f9abc71918b7e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1100745, 1068965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277804Reviewed-by:
-
Viktor Semeniuk authored
This change adds possibility to cancel Password Check when it's running. Bug: 1075494 Change-Id: If266b44db8b52cae16346d37782cac5cd1a4dbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274881 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
-
