- 28 Feb, 2020 40 commits
-
-
Philip Rogers authored
I was in this code for https://crbug.com/1048384 and noticed these redundant calls. The FakePaintedScrollbarLayer constructor already calls SetScrollElementId. Change-Id: Ieec2762cacc7097603d491e5c644358f2bd0a217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080482 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745531}
-
Tommy Steimel authored
In a refactor, we had accidentally changed the "CanControl" MPRIS property to be false instead of true. This CL changes it back. Bug: 1056629 Change-Id: Ie072f735bf10510f2c231d7d1f33d13f95101c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078974Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#745530}
-
John Chen authored
Fix a couple of issues related to handling of some types of invisible elements: * When element.getClientRects() returns an empty list, the code tries to use getBoundingClientRect, but the Object.assign call doesn't work correctly. * Zero-size elements can't be clicked on. Return appropriate error. These changes fix problems reported in an internal Google discussion (https://groups.google.com/a/google.com/g/webdriver-users/c/CKv3HQCBA4o). Change-Id: I4f9a2c42e6268441b6b3105de23bbef7b370a0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079998 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Auto-Submit: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#745529}
-
Jesse Schettler authored
Since ARC Printing launched in M80, extend the expiration of its histograms to M85. Bug: b:150397290 Change-Id: I38e5a48dd8398d0fa7a70557b414d60748933576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079146Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#745528}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I3dbca517481b6fd854e7055faea9ae6ec7ef73fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080457 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#745527}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f976e0b7. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 98c33104 "[webauthn] WPT: Clean up virtual authenticators" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I255ca7caeb2b41451f00f6f67b26d3f52beec01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079635Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745526}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie08d9cc9c5348951948057d4d2e804afce83897d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080464Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745525}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=ccameron@chromium.org Bug: 1026641 Change-Id: I92713633f2a77205ed1b4f43014fd082f8096e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078664 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#745524}
-
Eric Seckler authored
The deprecated TRACE_EVENT_ASYNC* macros have been superseded by TRACE_EVENT_NESTABLE_ASYNC*. Updating to the new macros is mostly straight-forward, except in cases where STEP_INTO/PAST macros were used extensively: In those cases, the steps have been converted into nested sub-events. For NavigationRequest, we also have to split the StartToCommit event into its own separate event track, so that it doesn't get merged onto the same track as the remaining events in NavigationRequest. We accomplish this with a scoped event id. Also removes duplicate async start/end events in this class. Bug: 1038710 Change-Id: I44fe91e24291751ea06ab447309277d7eef26529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075338 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#745523}
-
Andrew Xu authored
Edge padding of scrollable shelf logically consists of two parts: the minimum gap between scrollable shelf and other components (such as status area widget) and the gap decided by centering strategy (display centering, view centering or overflow). This CL separates the edge padding into those two parts. It improves the code readability. In addition, currently the shelf view does not notify the parent view of the added icon. This CL also fixes it. Change-Id: Id10263b7b532230539cac5d179d7534ca050ef87 Bug: 1041702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052593 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745522}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/82da15f4f07e..9606a5cb9995 git log 82da15f4f07e..9606a5cb9995 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 cepheus@frii.com Fix #1461: set the SPIRV-Tools' optimizer's target environment. Created with: gclient setdep -r src/third_party/glslang/src@9606a5cb9995 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I0b5d9687ec9121a85feb8b4abab9e012abfbe056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080307Reviewed-by:
-
Daniele Castagna authored
|device_scale_factor_| is a float and was incorrectly passed as an int to CanSplitQuad. This would cause rounding down the device scale factor and incorrectly computing the number of fragments we are saving. Bug: 1022544 Test: viz_unittests --gtest_filter="*DrawOcclusionSplitDeviceScaleFactor*" Change-Id: I084cb9ce52116b0d37e18ff74dd06233978cb9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072625 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Reviewed-by:
Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#745520}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=eroman@chromium.org Bug: 1026641 Change-Id: Ia43880f3554e081f04e3835238db6fa792f599e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078662 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#745519}
-
Bo Liu authored
SharedImageBatchAccessManager has a lock, and SharedImageBackingEglImage has a lock. There are cases where one lock is acquired while trying to acquire the other, and the order is not guaranteed, leading to deadlock in under the right circumstances. In particular: * On one thread, SharedImageBatchAccessManager::EndBatchReadAccess calls SharedImageBackingEglImage::SetEndReadFence. This acquires the batch lock first and the backing lock second. * On another thread, SharedImageBackingEglImage::EndRead calls SharedImageBatchAccessManager::IsDoingBatchReads, which acquires the locks in the opposite order. If the same backing is being read on two threads and both managed to acquire the first lock, then this leads to a deadlock. Fix by not holding the backing lock when calling into SharedImageBatchAccessManager. Bug: 1043566,1046101 Change-Id: I6d6f8031443f41f775eb87287fdcebf28c4fc8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078746Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745518}
-
arthursonzogni authored
Test CacheStorage responses entering in a COEP DedicatedWorker are enforced against CORP/CORS. In a follow-up, the implementation: https://chromium-review.googlesource.com/c/chromium/src/+/2080355/2 Bug: 1031542 Change-Id: Ia7b03317eb30727331ff00b49b8d61ad1b06e676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080353 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#745517}
-
Owen Min authored
This is reland for https://chromium-review.googlesource.com/c/chromium/src/+/2039631 The code is updated to match the latest SecureConnect native host update. Check if user has password in security connect API In chrome.enterprise.reportingPrivate.getDeviceInfo API, screen lock > secured flag now check if user has password on Windows. The code behavior matches SecureConnect native host: 291830502 Bug: 1047785 Change-Id: Ib6ce74d4b10b50616057042e0e2c30a2336522d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078674 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#745516}
-
Stephen Chenney authored
The Paint Holding feature revealed that a lot of time is spent committing main thread document update output to the compositor impl thread. Unfortunately, we have no breakdown of the ProxyCommit metric into the time waiting for the compositor thread to begin processing the commit, and the actual commit processing time. This change records the compositor commit start time and passes it back to the layer tree host to then feed back to the local frame UKM recorder. UMA is also updated to record the separate wait and commit times. Bug: 1031702 Change-Id: Ic083a94aa267b4332e402464c2a8b9b00d75aade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076179 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#745515}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=odejesush@chromium.org Bug: 1026641 Change-Id: I6fd3ee2edef8a427eb43444f643b750693e58b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079081 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#745514}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 1026641 Change-Id: Ic1a1d402ae94bee668ddb7f449b0a57f1004f6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079075 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745513}
-
Aaron Gable authored
I mistakenly thought that the "ci" acl_set granted this triggerer permission. It doesn't, so the triggerer permission has to be granted separately. Bug: 1057074 No-Try: True Change-Id: Ie9fb7270ff76eda2ee4b946bd1f79e94fd4f0178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080196 Commit-Queue: Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#745512}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bde9fcce155f..55f681faf391 git log bde9fcce155f..55f681faf391 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 robertphillips@google.com Splitup GrSimpleMeshDrawOpHelper.h 2020-02-28 jvanverth@google.com Initialize D3D format table. Created with: gclient setdep -r src/third_party/skia@55f681faf391 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I6d00c772bdc7100e7d1f281e681aeb1c0a4a6199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080310Reviewed-by:
-
behdad authored
blink_gc is also added to the reruns of representative performance tests. New categories were added earlier in: https://chromium-review.googlesource.com/c/chromium/src/+/2071905 Bug: chromium:1055893 Change-Id: I8553fdb3aa3b6a56fe58f61bf5f561db966067e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078835 Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=avi@chromium.org Bug: 1026641 Change-Id: I6c19f61e4bd125aab58741e0d4a98f8411f9cf0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078428 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#745509}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4eca785b40e3..96c6bce9e4f3 git log 4eca785b40e3..96c6bce9e4f3 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 szuend@chromium.org [utilities] Remove Array#select 2020-02-28 mathias@chromium.org Enable no-else-return lint rule with autofix Created with: gclient setdep -r src/third_party/devtools-frontend/src@96c6bce9e4f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549,chromium:1057042 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I862a67b16b0f7e7d04038c2abadb0c34a18d48d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080309Reviewed-by:
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=hashimoto@chromium.org Bug: 1026641 Change-Id: I6ea3c67e54a44bae1414f39ce1fb343cfb3a2c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079073 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#745507}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=pastarmovj@chromium.org Bug: 1026641 Change-Id: I8d1d6f3c2d6da8d599078e727b0c27587f664017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078661 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Dan Harrington authored
The annotation was changed, but the XML file wasn't updated to correspond. See bug. TBR=msramek@chromium.org Bug: 1057089 Change-Id: Idaec65e76aa95741c45874131c6ca92d52ff37a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080456Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#745505}
-
Gabriel Charette authored
Migrate off base::ThreadPool()-as-a-trait in /chrome/browser/media/webrtc/webrtc_event_log_manager.cc This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=eladalon@chromium.org Bug: 1026641 Change-Id: I1a06918db9cf2e701dfd03e9d6455eecdfdb0d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079085 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#745504}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=steimel@chromium.org Bug: 1026641 Change-Id: I86672714403013e0c9cd53df3b9919b497e72552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078423 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#745503}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=asvitkine@chromium.org Bug: 1026641 Change-Id: I4ec15c2ebfc60e84bc8d8e2d7bdf6dc9f0f783b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079079Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745502}
-
Geoff Lang authored
TBR=zmo@chromium.org BUG=1056984 BUG=1030835 Change-Id: I491b8c1d38f9637d37a92cb6d4b84e7ff2a5d7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079463Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#745501}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3e5fe285a7ef..416d37452275 git log 3e5fe285a7ef..416d37452275 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 jmadill@chromium.org PipelineCache: Handle nullptr mismatch of specialization info. 2020-02-28 sugoi@google.com Implement ASTC support Created with: gclient setdep -r src/third_party/swiftshader@416d37452275 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I365e26cfa261fbdb6f6ec34a9e7d2f982488785d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080452Reviewed-by:
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1026641 Change-Id: I781bcf648308b5583f5d85308ee0383b7f69be02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078420 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#745499}
-
Aaron Leventhal authored
When objects are only programmatically scrollable, e.g. overflow:hidden, as opposed to overflow:auto|scroll, do not mark them as scrollable. Bug: 1055344 Change-Id: Ib5ade11a7a92720d6571acf6d65112696f2a2535 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070232Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#745498}
-
Toni Barzic authored
Updates how animating shelf background's drag handle layer bounds are calculated. Instead of directly using bounds from that the drag handle view has within the opaque shelf widget, calculate the animating drag handle bounds directly by centering the drag handle within the animating background bounds. Opaque background bounds are calculated based on the shelf widget size, which may differ from the animating (in-app) shelf size (e.g. on home screen). Using the opaque background drag handle bounds for animating background would displace the drag handle when that is the case. Change-Id: I51cb9a4d031286329784162193627bb09c608043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079839Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745497}
-
Ahmed Fakhry authored
This CL implements a new responsive layout for the desks bar in overview, which makes its height a function of the display height rather than constant (when the layout is not compact). This will be very useful for large screens, as well as in portrait mode (since will have more room for desks' editable names). Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=1042981#c4 BUG=1042981 TEST=Manually. Change-Id: I7335766d699f081a62819bd77daa9c0a9e6021eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076786Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#745496}
-
Thomas Tellier authored
Bug: 993653 Change-Id: I21dc10859842208b355245137ba5d141e52c9b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080415Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#745495}
-
Thomas Tellier authored
Bug: 993653 Change-Id: I4293b7f09d887a68911bfbf1c4e26cdf82c55304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080248Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#745494}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=rbpotter@chromium.org Bug: 1026641 Change-Id: I17edfca297131ab8f59d9f9391a401ec11b30ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079077 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745493}
-
Lei Zhang authored
The histogram data has been steady over time, so there is no new insight from collecting new data. Bug: 1037199 Change-Id: Ib429623bcc75a807e0fe7107b0f507d49b29c590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076848Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
