- 01 Oct, 2020 40 commits
-
-
John Palmer authored
This reverts commit c39af256. Reason for revert: This will be managed by finch instead. Original change's description: > Enable assistive autocorrect by default > > Bug: 1111135 > Change-Id: I740d8247b9770392cebc48ba434de775bbc9199a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412113 > Commit-Queue: John Palmer <jopalmer@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Auto-Submit: John Palmer <jopalmer@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807285} TBR=shend@chromium.org,jopalmer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111135 Change-Id: Ie3af175cdb992c1a03447681bf60c0035ca4462c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440084 Commit-Queue: John Palmer <jopalmer@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: John Palmer <jopalmer@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#812536}
-
David Black authored
This is a reland of 9a224d53 Original change's description: > Miscellaneous holding space fixes. > > Fix pin toggle bounds in HoldingSpaceItemScreenshotView: > The bounds of the pin toggle button were being stretched to match the > full height of its parent container. > > Fix context menu bounds: > Context menu should be below the associated view (when space allows). > > Fix long press gesture: > When long pressing, the pressed view should become the selection just > prior to showing the context menu. > > Fix crash in HoldingSpaceTrayBubble: > If closing bubble due to ESC, bubble widget should only be closed if it > exists and hasn't already been marked closed. > > Fix drag behavior: > The holding space bubble should be closed during drag events. > > Bug: 1131262, 1131267, 1129981 > Change-Id: I5a1f0536ae6badeed841e0a6106e9c423cbf3781 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436671 > Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> > Commit-Queue: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#812064} Bug: 1131262 Bug: 1131267 Bug: 1129981 Change-Id: I2e7438ac8b46c2bedf0896393e11a52cbf9f26ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441251 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812535}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ife74062292802a61f28605708b4abf323b41e382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441534Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812534}
-
Tibor Goldschwendt authored
Fixed: 1133411 Change-Id: Ib6ad0c6becd6d54ad9be1e1d1fb4a11828e7c214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436655 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812533}
-
Lan Wei authored
I have added wheel input source to testdriver action API, now I am using it to generate wheel scroll action in the wheel scroll WPT tests. Bug: 1040611 Change-Id: Ie359068ae0347591944d80033403205f4437ecd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316405Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#812532}
-
Ken Rockot authored
This is a reland of 18096716 No interesting changes, just updated to resolve a compile-breaking collision with another CL that landed earlier today. (see PS3) Original change's description: > Delete service_manager/embedder/switches.h > > Each switch is either deleted because it's no longer used, or migrated > to a more appropriate layer (generally Content). > > Bug: 977637 > Change-Id: I9c4a74d4d99f4f7e7df8319d95b4ac4f55f11165 > Tbr: caseq@chromium.org > Tbr: dschuff@chromium.org > Tbr: finnur@chromium.org > Tbr: halliwell@chromium.org > Tbr: wez@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440908 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812318} Bug: 977637 Change-Id: Ia33b2999f531e7504456b4b71d3b5e571af3a354 Tbr: caseq@chromium.org Tbr: dschuff@chromium.org Tbr: finnur@chromium.org Tbr: halliwell@chromium.org Tbr: rsesek@chromium.org Tbr: wez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440974 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812531}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f38f54f2f1a3..68377adad5ae 2020-10-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ibd03f0f3e26cf9e947f85d9ffe5a6a561e38c96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440991Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812530}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601488745-3c2b7a3f9b9c6b0806062ba2172ccc5544f62b8d.profdata to chrome-linux-master-1601510378-740bdb3f5f06d5ae4b11a44692e04cf48dbd56ce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I445f1ec1e0eb1a537af3ff54e5e543511705f8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442056Reviewed-by:
-
Rune Lillesveen authored
Not applied appropriately on ::first-line and ::first-letter because we do not implement the highlight cascade as specified. Bug: 1024156, 1133725 Change-Id: Id0ecbbd566e54c9fd1a14423cd209d0029c45162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440530 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812528}
-
Josiah K authored
Fixed: 1129617 AX-Relnotes: Add earcons for when smart sticky mode turns on/off Change-Id: I586e14c17acd614212c34d852c9f69aba976ede5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419751 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#812527}
-
Yue Zhang authored
This CL is gated by Finch parameter "enable_launch_polish" under flag "enable-tab-grid-layout", with gate function TabUiFeatureUtilities#isLaunchPolishEnabled. Bug: 1133908 Change-Id: I90d4576a460303da137bb50ed53552c724628872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441934Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#812526}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601488745-21956df111f44074edeba5bc0b298067a5c332e8.profdata to chrome-mac-master-1601510378-f7e9b1850f70afb6dc30da9584475e1f2dba0196.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia33e1edd6d66eaf840f1a271e228bc2f9d94751e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442058Reviewed-by:
-
Evan Stade authored
These dialogs are shown when starting to cast or controlling the cast session. Since they are DialogFragments, a client-side RemoteFragment is needed to represent them. The implementation is modeled after SiteSettingsFragmentImpl, although one key difference is that there is no new Activity. PassthroughFragmentActivity is not refactored for reuse because it should go away soon, as per crbug.com/1123216 After this change, casting still doesn't work, but the initial route chooser dialog at least appears. Bug: 1057100 Change-Id: I9930c6124ff5162a296dcc74637a8489dbb0d96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432319 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#812524}
-
Dirk Pranke authored
This CL changes the GN blink_web_tests and blink_python_tests targets to use a new script_test() GN template. A script_test is a kind of test target that implements the [test executable API](//docs/testing/test_executable_api.md) via a Python script (rather than being an executable target). :blink_web_tests, :blink_python_tests are examples of this type of test; other targets will be switched over in future CLs as well. Most importantly, using script_test() will ensure that the $root_build_dir/bin/run_$target_name test wrappers are generated with all of the appropriate arguments, simplifying the invocation of the test both for devs and for the bots. Bug: 816629 Change-Id: Ib4bfd2342d762db24cdef75b64ed5dd7fbf3c10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380936 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#812523}
-
Trevor Perrier authored
This CL adds some simple logging in AppLocaleUtils to observe what language splits are available to the application and what the override locale should be. Bug: 1128698 Change-Id: I925cd84d384602e2f0beedd63ecd551f87c24b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440976Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#812522}
-
Leonid Baraz authored
This is a temporary solution for Hotrod to wrap AppInstallReportHandler and use old endpoint, until such time that the new endpoint is ready to be used. Bug: b:169427520 Change-Id: Ie1f68989e526a19ba3725debf531a52ea3d9a2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432140 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#812521}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af8e9f1e8115..ca3683da3ad6 2020-10-01 jalyn@microsoft.com Fix escape to close settings 2020-09-30 michael.liao@microsoft.com [Issues Pane]: Fixing focus when navigating to issues panel via infobar If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131395,chromium:1133476 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I593abf511571421d438532a454fe7037bc0c863f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442110Reviewed-by:
-
Glen Robertson authored
This reverts commit 13771712. Reason for revert: Decided not to move to OT in M87. Delay to M88. Original change's description: > digitalgoods: Add origin_trial_feature_name and _os for DigitalGoods. > > Origin Trial on Android only for now. > > Bug: 1032423,1096428 > Change-Id: I8329c798138d800156bbe3f90de6d05f2d9662b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404284 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Auto-Submit: Glen Robertson <glenrob@chromium.org> > Commit-Queue: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807337} TBR=haraken@chromium.org,peconn@chromium.org,glenrob@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032423 Bug: 1096428 Change-Id: If0f670b5901c8efc3452bb557bc33d2f5f3aecf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437719Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#812519}
-
John Williams authored
This is a reland of f51b93d7 Original change's description: > [Cast MRP] Stop mirroring immediately when a the tab is closed. > > Bug: 1095764, b/159154368 > Change-Id: I36829467e3a6477499c76ae0b15e110acba00c89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346911 > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: John Williams <jrw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803343} Bug: 1095764 Bug: b/159154368 Change-Id: I9d01af31895152afbf13a21b00091f12352131a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402181 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812518}
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We rewrite below tests fast/scroll-behavior/main-frame-interrupted-scroll.html, fast/scroll-behavior/overflow-interrupted-scroll.html and fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests because we cannot guarantee that the scroll arrives before the animation completes. I disable the test when disable_threaded_scrolling_ is false, because we do not know what is the final scrollTop value. TBR=bokan@chromium.org Change-Id: Ia9b68cd2e0c4f198968aa56482698c0c02edf452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441205Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#812517}
-
Tomasz Tylenda authored
This reverts commit a0282608. Reason for revert: b/169804713 Original change's description: > Migrate base::Callback to base::OnceCallback. > > BUG=764795 > TEST=build > > Change-Id: I8afa2fd87eb5cf5d9a8f7ecde9fad95d420c5399 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434405 > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811980} TBR=hidehiko@chromium.org,ttylenda@chromium.org Change-Id: I7de1e3dac102f4c760aef90da690016b020baa3f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 764795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440088Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#812516}
-
Jazz Xu authored
Bug: 1133559 Change-Id: Iae2392302136bc2032df1dca6a388566762eaadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439479 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#812515}
-
Thanh Nguyen authored
This CL adds ClearIndex function to the mojom interface IndexProxy. Bug: 1132170 Change-Id: Iaa1a3c2846bcc8c94bd758fa784e736b953e3a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437835Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812514}
-
Jarryd authored
This feature was set up to be used in a finch trial that has since ended. This change removes the now unused feature. Bug: 1133378 Change-Id: Ic484aa7f72c94f1f3e5924580b39f8f7b783b891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437006Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#812513}
-
James Darpinian authored
EXT_color_buffer_half_float was recently updated to be valid for WebGL 2 contexts because iOS can't support EXT_color_buffer_float. Bug: angleproject:5038 Change-Id: I5e5c6681588b3317d116277481d031b6dc36744e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415433 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#812512}
-
Zach Trudo authored
Bug: chromium:1078512 Change-Id: Ibbb9a3e2a85976bbbc136a053eb10e245a166f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432853 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812511}
-
Melissa Zhang authored
Bug: 1126788 Change-Id: I8c632beddf21fa93740c6a4e76b6d385c940530f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439998Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812510}
-
My Nguyen authored
OOBE is currently using different strings from the normal input method name because it doesn't have the word "keyboard". New naming proposal removes the word "keyboard" and makes the input method name shorter so just use this name directly. Proposal: http://go/cros-input-methods-naming Actual naming: http://go/cros-input-methos Current view: http://screen/4UT5edhYkbXH3yK New view: http://screen/6qGjXzgeMdM42su Bug: 889763 Change-Id: I4a6e54e4f638cf90fccb78b91b30309e855504c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438085Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812509}
-
Omid Tourzan authored
Add SinglePartitionFormat method to cros-disk client. It supposed to remove all existing partition on the disk, create a new one and format it. It tracks pending partitioning disks to prevent auto-mounting when partitioning finished, otherwise there will be conflict between auto-mount (initiated by kernel reread partition table) and format flow. The key to get device path of newly created partition is storage device path that is identical with parent device. Bug: 491043 Change-Id: I026e72dc499a55bb99f2e5f7bf5707f08c4fb393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340347Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812508}
-
Gordon Seto authored
Screenshots: Before: LTE: https://screenshot.googleplex.com/4sww2RRHRW8XxQN.png LTE+: https://screenshot.googleplex.com/8nxVo878HfHDL76.png After: LTE: https://screenshot.googleplex.com/54ow93Nv38bvwVt.png LTE+: https://screenshot.googleplex.com/UTLF9UzawWFjd6m.png Bug: 1099787 Change-Id: I921c7a7a26ee8fb71990f193995898f68e7cd9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441661Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#812507}
-
Yicheng Li authored
The metric is removed in http://crrev/c/2438770. Mark it as obsolete. Bug: b:169082568 Change-Id: I844790fd1139aa101726dfce8e28491fffe140ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438878 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812506}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I72affaa04d0601fcb6e9fea94807e55f29061faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441735Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812505}
-
tby authored
We watch for an app update to the settings SWA that marks it as kReady, and then request the app's icon to use for search results. However when the app is reinstalled, the icon can change but readiness stays at kReady, and so we miss the icon update. This CL adds a check for IconKeyChanged(), and also updates the icon in that case. This CL also disables the provider when the Settings app hasn't been marked as ready, as results won't be very useful before then. Change-Id: I8b5eaa5c5998fd551d3da41f068eb098aac51b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437677Reviewed-by:
-
Akihiro Ota authored
This change implements automatic reading behavior for the ChromeVox tutorial. This change implements the following: 1. When an interactive lesson is shown, read the lesson title. This is needed because we focus the text content for these lessons. 2. When a non-interactive lesson is shown, read the lesson contents. 3. Refactor requestSpeech() to pass queuemode and properties for more control over speech behavior. 4. Add @suppresss statements to a few functions. This allows us to reference the panel window without triggering closure errors. Automated tests are included confirm bullets 1 and 2. Fixed: 1129194 Change-Id: I2ce38fc0228bce749033f4effac4b79846dd696f AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414776 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
-
Charlie Hu authored
Image policies used to be feature poilcy and the only way to specify feature policy is by specifying 'allow' attribute on iframe. The tests were set up with subframes holding the test content while the main frame specifies the policy. With image policies migrated to document policy which uses HTTP header to specify policy, there is no reason to split the test content to subframe right now. This CL moves test content to main frame for image policy tests. Change-Id: Idf95c84d27fafbdb5fa926fefacfbcf1b913b7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414561 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#812502}
-
Daniel Classon authored
Removes UserActionRecorder as an inherited class of the Per Session tracker in preparation for an update to the UserActionRecorder class. Bug: 1133553 Change-Id: I769e1723a107d4a6a0e32698068fa8a7cc34026f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440307 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812501}
-
Karandeep Bhatia authored
Change it to accept a dictionary instead of individual arguments for better future compatibility. Note that this is a breaking change but we'll reach out to the current users to make sure that they update their extensions. Skipping presubmit since this seems to be hitting crbug.com/956368. BUG=1131746 No-Presubmit: True Change-Id: Ia9e26e0f0da1694263b27a0d2aeff26562fce228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428300 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812500}
-
Matt Reynolds authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. BUG=1018739 Change-Id: I1adee96b357e554979214b7d16f50576edcb8152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441659Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#812499}
-
Scott Little authored
The IPH will only be shown after the offline indicator finishes showing if the following conditions are met: - There is at least one item that would show up in Download Home, - The IPH has been shown less than twice already in the last year, - The user has not used Download Home in the last 90 days. Bug: 1068700 Change-Id: I2c5018b5d83b60ee2070902d986e9cacfde224f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411667Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#812498}
-
tby authored
This CL replaces the DriveQuickAccessProvider with the new DriveZeroStateProvider, and adds a deprecation todo to the former. If there are any issues with the new provider, this one CL can be reverted to disable the entire feature. Bug: 1034842 Change-Id: I6a82a948aa41301918d8a80368bfb5cda2303a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437996Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#812497}
-
