- 23 Jul, 2019 24 commits
-
-
Jordan Bayles authored
As part of our work to get Open Screen working in Chromium, this patch adds a simple task runner implementation for integrating Open Screen in Chromium. It wraps base::SequencedTaskRunner as simply as possible. Change-Id: I794f0c3c221804fefb80ba84922a1fc9e1b40496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708998 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#679800}
-
Jack Lynch authored
This change adds more descriptive aria-labels for the add/refresh buttons. Screenshot: https://gyazo.com/6e5092a5b059c9fecb38141a0f9823a5 Bug: 963183 Change-Id: I31b81f1204393b7061c69bfd0a34c16dc564ac07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646644 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#679799}
-
Jimmy Gong authored
- Alphabetically sort PrinterEntries, which applies to both Saved printers and nearby printers. - Updates browser tests. Bug: 965721 Test: end to end manual, browsertest Change-Id: I6ee45d6d91ae51dca0cc4ef5479bbf9490f82fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706880 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#679798}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/496d1cd2da51..79b937fc949d git log 496d1cd2da51..79b937fc949d --date=short --no-merges --format='%ad %ae %s' 2019-07-22 mikenichols@chromium.org Reland "cros tryjob: Add --infra-testing and remove --staging option" 2019-07-22 saklein@chromium.org Build API: Add automatic chroot file extraction mechanism. 2019-07-22 eashanbhatt@google.com cros_test_unittest: Add Start VM Unittest 2019-07-22 evanhernandez@chromium.org test: Pass chroot path to moblab_vm. 2019-07-22 evanhernandez@chromium.org moblab_vm: Accept optional chroot parameter. 2019-07-22 evanhernandez@chromium.org vm: Chroot path is a flag. Created with: gclient setdep -r src/third_party/chromite@79b937fc949d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I013a3ab17de3dbf8ea65aade7f3ff63906067374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713040Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679797}
-
Yi Gu authored
The test started to fail a DCHECK added in crrev.com/c/1696443. See bug for details. TBR=amehfooz@chromium.org Bug: 986571 Change-Id: I158c1677ca85effb61f3a427ec8cc796ce492786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711892Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#679796}
-
Kevin Babbitt authored
Currently, in the renderer, accessibility actions go to a WebAXObject, but plugins such as PDF do not generate WebAXObjects. This CL introduces an AXActionTarget abstraction that allows allow actions to be dispatched without knowing the underlying node type. Bug: 769940 Change-Id: I056d3d2ef325258c2dff5a328fe9958f25cbd77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693772 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#679795}
-
Brian Sheedy authored
Adds an example of how to run the GPU pixel tests locally to the GPU Skia Gold documentation. TBR=ynovikov@chromium.org Bug: 985418 Change-Id: I7610d8e7e37bfa4c40e5c25fa85eb9beb394fec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714186Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#679794}
-
Stephane Zermatten authored
This reverts commit ab14c6bc. Reason for revert: I propose reverting this change as it breaks Autofill Assistant. This causes an assertion in setSheetState to fail if onSizeChanged is called while in SCROLLING state. A simple workaround that skips setSheetState from ensureContentIsWrapped in SCROLLING mode might be more dangerous than reverting. Original change's description: > Android: BottomSheet animation from hidden to peek > > BottomSheet animation from hidden to peek state was not working > due to multiple calls to set the sheet state cancelling the > previous one that enables animation. This CL adds a few more > checks to make the subsequent calls no-op if we're already in the > requested state or in the middle of animation toward the state. > > Bug: 937946 > > Change-Id: I48f3e2ca20746bc1f976ce58de774276cb227998 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701131 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678568} TBR=mdjones@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 937946 Change-Id: I942684d2cbfeb97a503a1c8a5eac367a90862cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710655 Auto-Submit: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#679793}
-
Brian Sheedy authored
Removes the failure expectation for Pixel_CanvasLowLatency2D in Android Webviews, as it was conflicting with the skip expectation for the same test in Webview. TBR=kbr@chromium.org Change-Id: Ib13a753d19cf1bb8cd55d20a2293588fd9b5ec34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713307Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#679792}
-
rajendrant authored
Add adds param for lazyload experiment, enable-lazy-load-images-metadata-fetch is likely to be false when launching TBR=holte@chromium.org Change-Id: Iaaa9977a8834f0e6c9cee02adbba90cd37d01aca Bug: 950645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707176 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#679791}
-
Yi Gu authored
Mark virtual/disable-blink-gen-property-trees/animations/web-animations/animation-state-changes-positive-playback-rate.html as flaky The disable BGPT path was not spiked until July 22 pm. TBR=flackr@chromium.org Bug: 986019 Change-Id: I9a25c3bcbaafb4bb1ad3c776f421baa6cb0d7635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713811Reviewed-by:
-
Andrew Luo authored
Bug: 924194 Change-Id: I200b9147c95f68dd1f9356fa6959ebfab716e2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668709 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#679789}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77950aa0a8d2..b7dad440407e git log 77950aa0a8d2..b7dad440407e --date=short --no-merges --format='%ad %ae %s' 2019-07-22 reed@google.com Reland "hide drawlooper from paint" 2019-07-22 ethannicholas@google.com fixed SkSL handling of constant arrays 2019-07-22 mtklein@google.com move hoist analysis back into Builder 2019-07-22 fmalita@chromium.org [skottie-wasm-perf] Don't redraw unchanged frames 2019-07-22 fmalita@chromium.org [canvaskit] Return damage rect from ManagedAnimation::seek() Created with: gclient setdep -r src/third_party/skia@b7dad440407e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Change-Id: Ia2ce0d7bdb734aa9df944c5716aa7707bc36996b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713585Reviewed-by:
-
Reid Kleckner authored
This reverts commit ffe0185e. Reason for revert: Causes test failures in official builds Original change's description: > Shorten TRAP_SEQUENCE() to one instruction on most platforms. > > Previously, TRAP_SEQUENCE() consisted of: > - an instruction to trigger a debugger breakpoint > - an instruction to ensure fatal termination (usually encoded as an > illegal instruction) > > But all that's really needed is the latter, so eliminate the > instruction to trigger the debugger breakpoint. > > Note: on Intel, the debugger breakpoint instruction (int3) is only one > byte, while the fatal termination instruction (ud2) is two bytes. > Unfortunately, crash reports seem to be indicating that int3 is > non-fatal. Since it's important that TRAP_SEQUENCE() terminates, it > cannot rely on int3. > > Bug: 958675 > Change-Id: I84b3123b07a9871dbd3b062fd73e79137b1ef6dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672227 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678065} TBR=dcheng@chromium.org,alexmos@chromium.org,rsesek@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 958675, 985138 Change-Id: Ib9c3d09f6b2a5dc182cb125f90a7d9130c98e5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713904Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#679787}
-
dpapad authored
Bug: 986428 Change-Id: I6bc6a5fc1fd16269c5316604700f0c4cbf59b918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710007 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#679786}
-
Hwanseung Lee authored
Use enum class instead of enum for MenuDelegate::DropPosition enum class is more type safety. Bug: 940736 Change-Id: I32eaa5bfe71ec288491c6c64db78cfc413841d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708068Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#679785}
-
Eugene But authored
ios/web/public/navigation directory contains API to perform web content navigation (load URLs, go back/forward) and inspect navigation state. Bug: 942244 Change-Id: I94d18150473c615c8aead710dff6a066a5c8358c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710752 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#679784}
-
Antoine Labour authored
PaintCanvasVideoRenderer has legacy code from the time Skia didn't support GL_TEXTURE_EXTERNAL_OES or GL_TEXTURE_RECTANGLE_ARB textures, that adds extra copies. Skia has added support now, so we can remove this logic. Bug: 505026, 882547 Change-Id: Icf1718670bb375634b8d08a3330e6b8207ac8370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711141 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#679783}
-
Michael Giuffrida authored
Adds newly supported languages to the system tray language switcher in Demo Mode. tray menu. Bug: 983278 Test: Start Demo Mode and switch to German and Japanese using the system Change-Id: Ic2fab6848c9679abb5d65fe71ba8c2f45eef4968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713342 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#679782}
-
Gayane Petrosyan authored
Bug: 985002 Change-Id: Ia2d9e86b08c331075df372ba96d2467ade1ace9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707652 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#679781}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a71549b11297..592539fdee80 git log a71549b11297..592539fdee80 --date=short --no-merges --format='%ad %ae %s' 2019-07-22 clemendeng@google.com Implicit conversions for Desktop GL shaders 2019-07-22 ynovikov@chromium.org Skip ProgramBinaryTransformFeedbackTest.GetTransformFeedbackVarying 2019-07-22 jmadill@chromium.org Vulkan: Store VkExtents3D in ImageHelper. 2019-07-22 jmadill@chromium.org Texture: Make ImageIndex store layer counts. 2019-07-22 ynovikov@chromium.org Skip ShaderStorageBufferTest31.ActiveSSBOButNotStaticallyUsed 2019-07-22 syoussefi@chromium.org Vulkan: Atomic counter buffer support 2019-07-22 ynovikov@chromium.org Revert "Reland "Temporarily disable creating D3D debug device."" 2019-07-22 syoussefi@chromium.org Vulkan: Generalize buffers desc set name to include images Created with: gclient setdep -r src/third_party/angle@592539fdee80 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: Ie38c00394c36f969dd63c76c45e5699ecee44d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712609Reviewed-by:
-
chrome://webapksckitagawa authored
The WebAPK server only updates its cache every minute or so. If an update is attempted and re-attempted within this window then the update will fail even if a change to the manifest occurs. To prevent this we will disable the update button for 1 minute after an update attempt is completed. Bug: 984586 Change-Id: I1dece1f0cb7236159b105ebe5e4caaa354645573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704499 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#679779}
-
Brian Sheedy authored
Adds a --local-run flag to the GPU pixel tests. This causes goldctl to run in --dryrun mode (i.e. no uploads) and makes the test runner output file:// URLs to the produced images. This makes it much more suitable for local runs, since Gold's normal usage mode is designed to be used on the bots. Bug: 985418 Change-Id: I70021679e725d619c9dfc38598655c881b2dcb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713588Reviewed-by:
-
Meilin Wang authored
This change enlarges the clickable area of show/hide buttons on the assistant third party oobe page, from a small rectangle area around the buttons to the entire row, in order to: 1) be consistent with the performance of other buttons in the same style, e.g. one in the Languages settings page. 2) have a better user experience. Bug: 981830 Test: manually. Change-Id: I3f8228f8dd19d5491de62d1dc9b6b20fef290565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694089Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#679777}
-
- 22 Jul, 2019 16 commits
-
-
Sadrul Habib Chowdhury authored
The source-id for BeginFrameArgs can change during a sequence (e.g. if the gpu-process restarts). In such cases, ignore the frames from the new source, so that the metrics aren't computed incorrectly. Instead of ignoring the new source, it would be possible to update the trackers to be able to process the begin-frames from new source. But this is a rare event, and would introduce complexity in the code. So instead of processing them, they are ignored. This removes a couple of DCHECK()s previously introduced in crrev.com/c/1710754, and adds a couple more DCHECK()s to catch issues like this earlier in the pipeline. BUG=985847, 985359 Change-Id: Id717e7a19b7099cad8199148160f84a84f8b9ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711052Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#679776}
-
Ryan Hansberry authored
Prevent EasyUnlockServiceRegular from being built with an incognito context (AKA "off-the-record"). My current working theory to explain 969135 is that the same EasyUnlockServiceRegular instance is being handed to two separate Profiles (the on and off the record versions) with assumptions of unique ownership, and when Shutdown occurs, they step on each others' toes. I unfortunately cannot repro this hypothetical situation of EasyUnlockServiceRegular being handed to an OTR Profile, but in any case this change makes explicit our desire that this never happen. Also add temporary CHECK to find source of crash in service: CHECK to ensure that EasyUnlockService is shutdown before it's deleted. This is added because the crash stack trace in 969135 implies that a deleted member variable of EasyUnlockService is being touched during EasyUnlockService::Shutdown(). If my theory above is correct, this temporary CHECK will not trigger, and the original crash of 969135 will no longer be reported. Bug: 969135 Change-Id: Iaab415efdf47ac449539c2f91693e8002d99526d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705014 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#679775}
-
Kyle Milka authored
The selected background was not being applied after the back arrow was pressed. Fix this by storing the data for the selected background separately from the actual tile. Bug: 937570 Change-Id: Ie213ea101519b315618de285fd87360fe59b4157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713039 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#679774}
-
Yuly Novikov authored
TBR=kbr Bug: angleproject:3340 Change-Id: I48cfba989b1b31eb72f731dbad8407306bc47eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617380Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/97273d011a31..8fcf354fa1c8 git log 97273d011a31..8fcf354fa1c8 --date=short --no-merges --format='%ad %ae %s' 2019-07-22 yvesg@webrtc.org [tsan] Suppress all of libpulsecommon*.so, following chromium. 2019-07-22 debrian@google.com Add json output arg to mb gen and analyze. Created with: gclient setdep -r src/third_party/webrtc@8fcf354fa1c8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:244856,chromium:985959 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id07b79a152cdd1361ccfab11d211c754b340c445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713707Reviewed-by:
-
Robbie McElrath authored
Bug: 934152 Change-Id: Idf26b6992efe514e8a540dc5296f36e9f9a6bb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705334Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#679771}
-
Alex Cooper authored
Several updates to xr-test-utils to make it more closely align with webxr_utils: * Each xr_session_promise_test only runs one sessionMode * xr_session_promise_test now sets the baseLayer on the session so that tests don't have to New parameter added to both test functions "sessionObjects", which currently just passes the gl/glLayer down for those tests to access, but which can be expanded for any other objects that the boilerplate creates that need to be passed down. Future work will remove the other helpers from xr-test-utils, though due to paths for imported scripts, unless internal tests are moved to wpt_internal it may not be possible to consolidate to use webxr_test.js Bug: 981003 Change-Id: Ibc36a4eb897d834643a3e604a6e79fc7264b5e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707590 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#679770}
-
Hiroki Nakagawa authored
This CL removes a DCHECK in ServiceWorkerSubresourceLoader::StartRequest() that fails when PlzDedicatedWorker is enabled, static module import is invoked on DedicatedWorkerGlobalScope, and a service worker intercepts it. ServiceWorkerSubresourceLoader::StartRequest() verifies that a given request is not for a main resource using ServiceWorkerUtils::IsMainResourceType() that takes ResourceType as an argument. However, this doesn't work for static module import because a request for static module import has the same resource type with the main resource, that is, ResourceType::kWorker. This behavior is defined in the HTML spec. It's not easy to fix the utility function, so this CL removes the check instead. Note that dedicated-worker-service-worker-interception.https.html checks this behavior. This test is expected to pass only when PlzDedicatedWorker is enabled, that is, under the "omt-worker-fetch" virtual configuration because service worker interception for dedicated workers is broken in non-PlzDedicatedWorker code. Bug: 906991 Change-Id: I42da9dff88796b353d2969471690aaf43097225f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712666Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#679769}
-
Tom Anderson authored
Fixes the following error when generating build files: ERROR Unresolved dependencies. //media/gpu/vaapi:jpeg_decoder_unit_test(//build/toolchain/linux/unbundle:default) needs //media/capture:chromeos_test_utils(//build/toolchain/linux/unbundle:default) BUG=None R=mcasas Change-Id: I2e4237c6b1e26bc97c26d6e5e0b22506d7a4758b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713435 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#679768}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ee7b9dda90e4..73065b2067bc git log ee7b9dda90e4..73065b2067bc --date=short --no-merges --format='%ad %ae %s' 2019-07-22 ehmaldonado@chromium.org depot_tools: Make some changes to make metrics collection compatible with Python 3. 2019-07-22 iannucci@chromium.org Remove WATCHLISTS. Created with: gclient setdep -r src/third_party/depot_tools@73065b2067bc The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:984182 TBR=agable@chromium.org Change-Id: Ie1dca6a8f4c1c960d3ff74f0681b336042f3da0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713586Reviewed-by:
-
Kevin Bailey authored
We are reading at least one of the bools in ClientOAuthResult without initialization. This was due to the default constructor missing it, but this constructor is only used in one place, undesired anyways, so this CL removes it and calls the regular constructor in its place. Change-Id: I3e9478c35be5ebafd7422a80b5c7d274e7ffbdd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708018Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#679766}
-
Sky Malice authored
Bug: 986312 Change-Id: I85aec4e2ecf302b2e39da8a2ab79d242f83261b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711638 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#679765}
-
Jeremy Chinsen authored
Currently |kPageSeparatorThickness| is the name of the constant that stores the size of the bottom separator for pages in PDFiumEngine. Renaming |kPageSeparatorThickness| to |kBottomSeparator| makes the variable name more accurate and reduces confusion in the future when dealing with other page separator constants. Change-Id: Ic1472bf2eb70a2a20e8e68b24a68ba6b7135a9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713035Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#679764}
-
Zhenyao Mo authored
This is simply saving bots data before they are gone. BUG=867155 TEST=none TBR=kbr@chromium.org NOTRY=true Change-Id: Id9d142075cea74340e03fef204ee6607575b70d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711893Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
danakj authored
Last followup for https://chromium-review.googlesource.com/c/chromium/src/+/1706546 R=pdr@chromium.org Bug: 912193 Change-Id: Ibb49f9e502f8a9cd5d42f9e28a77e4aff65f4886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710133Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#679762}
-
Mohsen Izadi authored
Rather than having a separate GetMessageLoopTypeForGpu() function in OzonePlatform, we can have this as a property in PlatformProperties obtained by GetPlatformProperties(). BUG=958387 Change-Id: I3641ee19d58167b943a9efeb11f5bc572adb2fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709629 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#679761}
-
