GitLab

The end goal is to get NavigationSimulator to a state where we can call:
simulator->SetAutoAdvance(false);
simulator->Start();

And have the simulator *not* spin the run loop in the background. This
will help in writing more sophisticated NavigationThrottle tests which
use multiple task runners to execute async tasks.

This particular CL does a few things:
1. Removes base::RunLoop().RunUntilIdle call. This is not great practice
   to have in test infra, since it can cause strange interactions with
   tests and they may start relying on unintentional behavior.

2. Collects various after-throttle checks into closures, to be called
   when the throttle check complete closure is called (rather than
   relying on base::RunLoop to keep everything on the stack). This
   isn't so useful now, but it will if we stop *always* waiting.

3. Slightly modifies checks in various places that relied on some of
   the behavior that we've changed. Two things changed here:
   a. "Complete" code internal to the NavigationThrottle now runs
      directly after throttle checks are complete (when
      complete_callback_for_testing_ is called on the nav handle),
      rather than when the RunLoop quits. This caused us to remove
      one check checking that we've finished the navigation.

   b. Because we no longer RunUntilIdle() in
      WaitForThrottleChecksComplete, code that relies on the nav finishing
      after the post-task in NavigationRequest::OnStartChecksComplete
      will need to either wait or spin the run loop to see the end of the
      navigation. This is a pretty small edge case and it is pretty
      easy to either write a helper to make this explicit or use a WCO.
      The only test impacted by this change is a NavigationSimulator test,
      and a test which incidentally relied on this behavior for unrelated
      reasons.

Bug: 822275

Change-Id: Ice6b215fa285a6a944fdf85108303515d109be77
Reviewed-on: https://chromium-review.googlesource.com/961819Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546184}

When memory pressure reaches critical, SingleTreeTracker clears the
pending_entries_ map. However, if an inclusion check is in progress for
one or more of those pending entries, LogDnsClient will have a pointer to
a MerkleAuditProof held in that map. This results in it trying to access
freed memory.

The fix is to cancel all inclusion checks when this happens. This is done
by changing LogDnsClient to provide a "resource handle" when it starts a
query, which can be deleted in order to abort the query. Storing this
in pending_entries_ assures that all inclusion checks will be aborted
when pending_entries_ is cleared.

Bug: 811566
Change-Id: I86b7ff880c050b790d219fa0cd50b42839bc0d3e
Reviewed-on: https://chromium-review.googlesource.com/939627Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Rob Percival <robpercival@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546183}

This is a reland of 65ae686a

The issue it caused when we originally landed it was fixed
in crrev.com/c/981239

Original change's description:
> viz: Make primary plane transparent
>
> This CL enables alpha blending at scanout for the primary plane.
> In this way chromecast will be able to punch a hole in the primary
> plane and show content underneath.
>
> Note that on platform using legacy pageflip we'll still be
> scanning out without alpha blending (crrev.com/c/964984).
>
> Bug: 821944, b/74997524
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: I654935dc630f7a9f6cb4717cd574a21a2749c442
> Reviewed-on: https://chromium-review.googlesource.com/976961
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545478}

Bug: 821944, b/74997524
Change-Id: Icfff83119231cd9a1e486719dbb0a25786ea71f2
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Tbr: dnicoara@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/980956
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546182}

TBR=elawrence@chromium.org

Change-Id: Ia25d5953c3d36d99df8be6da2f36a7dc49ae25e3
Reviewed-on: https://chromium-review.googlesource.com/981516Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546181}

Using wpt-import in Chromium 8eb4dff9.
With Chromium commits locally applied on WPT:
9236bee6 "[css-typed-om] Stub list-valued tests."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14785

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org:
  external/wpt/payment-handler

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Ia964bcec2c0ae28f843ce5ed3d9a676470a8149e
Reviewed-on: https://chromium-review.googlesource.com/980678
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546180}

This CL
1) Removed an obsolete TODO.
2) Removed MenuDescriptor, we are not taking adavantage of it.

Bug: 825381
Change-Id: Iba22809a0046150165ec4e1c265c00e77b567898
Reviewed-on: https://chromium-review.googlesource.com/978886Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546179}

Add one histogram enum for recording the PDF page or document
composition status. And collect such status information in browser.
This is used for monitoring the execution of PDF compositor service.

BUG=824867

Change-Id: I2f6496195cd4ada40f0f03366997f8aa2c9f942a
Reviewed-on: https://chromium-review.googlesource.com/980900Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546178}

This reverts commit 2cc853c1 and
9b4f3568

Reason for revert: Perf regression in webview start time
Bug: 821425

TBR=mheikal@chromium.org

Original change's description:
> Android: Only rewrite resource ids that start with 0x7f
>
> Some resources listed in R.java start with a 0x01 prefix/package id.
> These resources should not have their package id rewritten when in
> webview mode.
>
> Change-Id: If3957c4bf2b5e34b5ceeb7589f7ca4e960cdd43f
> Reviewed-on: https://chromium-review.googlesource.com/952097
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542152}

Change-Id: I60902726262e14d5d7c08c7e2ebc8a7e85ed658f
Reviewed-on: https://chromium-review.googlesource.com/978562
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546177}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2943c641..bea84ab8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I35970f44835269c3b99cd4c0c462eb59b2f29d2d
Reviewed-on: https://chromium-review.googlesource.com/980675Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546176}

This CL lies out the directory layout for CAF migration. The
migrated code will reside in caf/, in parallel of cast/. The
migrated code is guarded behind a feature flag.

Bug: 711860
Change-Id: Iddfe9e3ce3103fae876c9c151c96aba2ef99354f
Reviewed-on: https://chromium-review.googlesource.com/977232Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546175}

Notifications can be disabled for a number of
reasons. This logs those reasons with UMA.

Bug: 734095
Change-Id: I05e61b287312a42707d78415d2186909fae87fb7
Reviewed-on: https://chromium-review.googlesource.com/980559Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546174}

Bug: b/76458625
Change-Id: I157d04a4b60fb7e206ee6f90d7f344801a7708af
Reviewed-on: https://chromium-review.googlesource.com/982009Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com>
Cr-Commit-Position: refs/heads/master@{#546173}

Bug: 699244
Change-Id: Ia85a44be9d9f7b0d0db382892520f2755523f514
Reviewed-on: https://chromium-review.googlesource.com/980236Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546172}

This test has additional failures when run with the NetworkService flag.

Bug: 782958
Change-Id: Ia331cb3e2f92df49c1fac7a10bac4ddb859feeed
Tbr: bashi@chromium.org
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/981402Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546171}

Should fix webrtc's use of generate_jni after
https://chromium-review.googlesource.com/c/chromium/src/+/979610

Bug: 799759
Change-Id: I838af362d81036afb8bc493a90c4faa3c4c9b467
Reviewed-on: https://chromium-review.googlesource.com/982010Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546170}

Bug: 776495,776496,783000,783001
Change-Id: Ia69e1b225fc4ff6133316921e139ad60a8a92d6a
Reviewed-on: https://chromium-review.googlesource.com/982247Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546169}

This adds the StreamAnalyzer class, which is responsible
for calculating the mean, rms, smr, standard deviation,
variance of roots, and threshold percentiles of a
continuous stream of values.

It owns a Histogram and a WindowedAnalyzer, which it uses
to delegate percentile estimates and to track regions of
time where metrics are worst.

Bug: 807463
Change-Id: I718b06778582d0628b964747f61352ae291452f0
Reviewed-on: https://chromium-review.googlesource.com/972568
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546168}

Both are in cc/OWNERS for animation but these often touch ui/compositor as well.

Bug: None
Change-Id: I7f22b0c27113c1a3ddada05bb69cbde19c8aa619
Reviewed-on: https://chromium-review.googlesource.com/982265Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546167}

Requests served from memory cache don't have the is_ad bit in their newly
minted ResourceRequests. The bit is needed by the AdTracker class that
receives a probe on WillSendRequest. This CL copies the bit over to the
new request and tests it.

Bug: 807640
Change-Id: I9656446be52eb19159a84c26cbdf47905a0e1989
Reviewed-on: https://chromium-review.googlesource.com/980700Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546166}

Most of the overloads could be directly converted to const. The only
exception was HTMLEmbedElement that needed some refactoring in
HTMLPluginElement in order to be const.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I64ea48d7580977d394f927b0653b48f71f496521
Reviewed-on: https://chromium-review.googlesource.com/980591Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546165}

This change removes the ability to directly change the bottom sheet's
state from explore-on-content. The feature now requests that its
content be shown through the BottomSheetController.

Bug: 822949
Change-Id: Ib551c7fe391f7e62ea06a15eafd645e5cff3ab28
Reviewed-on: https://chromium-review.googlesource.com/981453
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546164}

Bug: 818684
Change-Id: I6358926667c913988fab0ca4a39f25cbc4f04734
Reviewed-on: https://chromium-review.googlesource.com/969076
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546163}

> Creates flags for home page button
> Logs preference changes in new histogram
> Sets home page default as NTP if home page was displayed by flag

Bug: 822469
Change-Id: I2c0a00f11de254f663e453f32aaab7d43ad7e761
Reviewed-on: https://chromium-review.googlesource.com/972461
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546162}

This CL modifies linker_map_filter.py to add a filter for object
filenames. This enables Supersize to run for LTO (under LLD) without
crashing -- although some data are missing (to be fixed in follow-ups).

Bug: 723798
Change-Id: I90b7439368cca96921d688b0c9db95a599fa2bca
Reviewed-on: https://chromium-review.googlesource.com/982254Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546161}

R=dpranke

Change-Id: I9f93686d2bab2d3625363142bb05349817e1c5b5
Reviewed-on: https://chromium-review.googlesource.com/982250Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546160}

Since FFmpeg decode of 0-byte audio and video buffers is now disallowed,
and FFmpegDemuxer skips enqueuing such packets into its DemuxerStream,
this change does similar for MSE:

Any 0-byte |data| audio or video buffers are dropped during initial
processing in FrameProcessor::ProcessFrames(). No 0-byte |data| text
buffers are dropped, because:
* We don't use FFmpeg to decode in-band MSE text, and
* In-band MSE text buffers' |side_data| may contain meaningful
  information. (This assumption isn't asserted by this change).

Note, this change takes the simpler route of dropping 0-byte AV buffers
before they're buffered by the coded frame processing algorithm. A more
complex alternative to skip them when reading from SourceBufferStream
was rejected in hopes this simpler change is sufficient.

Includes ability in ChunkDemuxerTest to vary |block_size_| instead of
always using |kBlockSize|. While the product change is closer to
FrameProcessor, FrameProcessorTests always encode the coded frame's
timestamp as the coded frame contents to enable precise verification of
processing results, so the test of this change is done via
ChunkDemuxerTest instead.

BUG=823375,663438
TEST=ChunkDemuxerTest.ZeroLengthFramesDropped

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie6a802ba64a576f0219ca7c400fc7dec3a45fbf6
Reviewed-on: https://chromium-review.googlesource.com/974427
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546159}

Two reasons. One is that these callbacks should not happen if renderer
process crashed. Looks like this (and a few others) are missed because
they are synchronous and called from AwContentsClient instead of
AwContentsClientCallbackHelper.

Second reason which is relevant to the bug is that we should not
callback to the app if webview is already destroyed. This can happen
when a native->java jni call uses a jweak which can resurrect objects
that are effectively destroyed already.

Bug: 824156
Change-Id: I0a8d59e2f36070d7a4c53242ce077bda3c9bfe73
Reviewed-on: https://chromium-review.googlesource.com/981433Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546158}

The 'schemaUtils' and 'json_schema' JS bindings files are no longer
needed with native bindings. Don't include them as resources in
the dispatcher's source map.

Bug: 810487

Change-Id: I7476069311b7ba7d0ffc0a2e37a01dcd43808c66
Reviewed-on: https://chromium-review.googlesource.com/981261Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546157}

git cl format reformats this file, causing superfluous changes in CLs.
To avoid noise, this change makes clang-format happy.

Change-Id: I9b7f0b310be18aadccec5b19870ad8c05df0af4d
Reviewed-on: https://chromium-review.googlesource.com/974295Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546156}

Cover more failing cases in ArcPlayStoreSearchProvider.

Bug: 765757
Change-Id: Idb04ffc4a2b7fbeb40df183b6cefb0a00a0f2841
Reviewed-on: https://chromium-review.googlesource.com/736677
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546155}

Bug: 822987
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7aa275e08846b1ea9b067de343f6a631a56db566
Reviewed-on: https://chromium-review.googlesource.com/972163
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546154}

android_webview/support_library/ contains
1. boundary interfaces (mirrored into the Android support library).
2 the support library glue (gluing the boundary interfaces together
with the rest of chromium).

Bug: 781754
Change-Id: I903c2165ece5192364ab2d257074304317692114
Reviewed-on: https://chromium-review.googlesource.com/980973Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546153}

URL.createObjectURL with media streams is deprecated and will be removed
in M68, around July 2018. Please use HTMLMediaElement.srcObject instead.

Bug: 826088
Change-Id: Ic1793ce689b0dad667ba80065b13bfafb1b84c79
Reviewed-on: https://chromium-review.googlesource.com/981601Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546152}

This utility function makes the bubble stay anchored when fullscreening the
window. Most other chrome bubbles inherit from one of the extension or
location decoration bubble classes and therefore already have this behavior,
but SessionCrashedBubbleView is unusual.

Bug: 825904
Change-Id: Ibc482f9f3f29de9e049b26770463f7e1d2a19c96
Reviewed-on: https://chromium-review.googlesource.com/981234
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546151}

The old UMA hw class API is kept behind a base::Feature in case
we need to revert.

Also updates some comments where we were using ChromeOS instead
of Chrome OS, which is preferred.

Bug: 810872
Change-Id: I6ca101432da58ca36ec0d4a85cca745e7700257b
Reviewed-on: https://chromium-review.googlesource.com/978518Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546150}

This CL allows the chromecast BLE API to be called from a sequenced
context instead of only from a single-threaded context. This CL also
adds the helper function BindToCurrentSequence, which is very similar to
the existing BindToCurrentThread.

BUG=internal b/76227019
TEST=Build. Also built and ran in eureka-internal to confirm this allows
calls from a sequenced context.

Change-Id: I748b14d2910ff683ad3450adc9783d313eb0486b
Reviewed-on: https://chromium-review.googlesource.com/981612Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Kyle Lund <kylelund@google.com>
Cr-Commit-Position: refs/heads/master@{#546149}

Re-enable password export when the activity view disappears, instead of when completionWithItemsHandler is called. This has the potential to be a premature re-enabling, if the user decides to background the app launched from the activity view and come back to Chrome’s password settings. Re-triggering the export in this case might cause a conflict between multiple exported files.

To mitigate this issue, each exported file is stored in its own uniquely identified folder in tmp/passwords/. If completionWithItemsHandler is called, the file and its folder are removed. For the cases in which the completion handler is not called, the rest of the files are deleted at startup.


Bug: 820053
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5683acfe8483876c0aeb81ce25ba83b24f109676
Reviewed-on: https://chromium-review.googlesource.com/974181
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546148}

There's a leak being detected by the Chromium OS ASan LSan bot
when loading the test pdf files. Adding tracing of the filenames
to see which one(s).

Bug: 826055
Change-Id: I9ad1c6a3d67c906e2713492271b68139803d59c4
R: battre@chromium.org
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/980962Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546147}

This reverts commit cb950738.

Reason for revert: suspected of performance regression: crbug.com/825005

Original change's description:
> Fixed more Document leaks in Autofill
> 
> Some Autofill-related code can hold persistent reference to last
> changed or focused <input> element that cause leak of whole Documents
> containing such element after navigation to other page.
> 
> Some leaks fixed in https://chromium-review.googlesource.com/939224
> This CL fixes other related leaks.
> 
> Bug: 734427
> Change-Id: Ic084d0670cccb9d11595d0bde8cf0d605bfa8911
> Reviewed-on: https://chromium-review.googlesource.com/970582
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544404}

TBR=estade@chromium.org,dvadym@chromium.org,atimoxin@yandex-team.ru

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 734427
Change-Id: I57bd57e50af5d8e4f4d97b731a354fd7b0957966
Reviewed-on: https://chromium-review.googlesource.com/981292Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546146}

Previously nullable values in the animations code were tracked by
storing nulls as quiet_NaN() and using std::isnan as a null-detector.
It is much more explicit to store such values using WTF::Optional, which
forces code to consider whether or not the offset exists.

Bug: 791086
Change-Id: Ice80a1d3d686b0ff1f0bc2a1f3eac2eff51a8e38
Reviewed-on: https://chromium-review.googlesource.com/981076Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546145}