GitLab

Revert of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #2 id:20001 of https://codereview.chromium.org/1460063003/ )

Reason for revert:
I'm speculatively reverting this CL as the cause for the failing Mac10.6 Tests nacl_integration test. The whole test fails with this output:
scons: done reading SConscript files.
scons: Building targets ...
Install file: "src/untrusted/pthread/pthread.h" as "scons-out/nacl-x86-64/include/pthread.h"
Install file: "src/untrusted/pthread/semaphore.h" as "scons-out/nacl-x86-64/include/semaphore.h"
Install file: "src/untrusted/stubs/crt1.x" as "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o"
Func(["scons-out/nacl-x86-64/obj/tests/breakpad_crash_test/breakpad_untrusted_crash_test.out.tmp/crash_test.nmf"], [])
Install file: "src/untrusted/nacl/nacl_random.h" as "scons-out/nacl-x86-64/include/nacl/nacl_random.h"
Install file: "src/untrusted/nacl/nacl_dyncode.h" as "scons-out/nacl-x86-64/include/nacl/nacl_dyncode.h"
WriteManifestList(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner_nmf_test_list.js"], [])
Func(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner.out.tmp/random_test.nmf"], [])
Install file: "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o" as "scons-out/nacl-x86-64/lib/crt1.o"
/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang -m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall -Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros -Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -Iscons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o src/untrusted/nacl/sigprocmask.c
dyld: Library not loaded: /usr/lib/libedit.3.dylib
  Referenced from: /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang
  Reason: image not found

I'm thinking this might be caused by "Fix PNaCl toolchain build on Mac" https://codereview.chromium.org/1458713003
that e.g. includes this change:
# Required SDK version and target version for Mac builds.
# See MAC_SDK_FLAGS, below.
MAC_SDK_MIN = '10.10'
MAC_DEPLOYMENT_TARGET = '10.6'

Original issue's description:
> NaCl: Update revision in DEPS, 546ef11 -> b6ec17d
>
> This pulls in the following Native Client changes:
>
> 1a71811: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
> 26a11d1: (stichnot@chromium.org) Update revision for PNaCl
> 3658d8e: (phosek@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
> 7a60f36: (mcgrathr@chromium.org) Remove an unused variable from src/shared/imc/win/nacl_imc.cc
> 1b746e8: (mcgrathr@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
> 0f0cb21: (mcgrathr@chromium.org) pnacl-strip: Handle --strip-unneeded switch
> 9d811a5: (mcgrathr@chromium.org) toolchain_build: Disable gold build for Mac host
> 7f130ff: (erikchen@chromium.org) Suppress Clang warning for dirfd() on OSX.
> 18e2d27: (erikchen@chromium.org) Add code to check for the OS X version.
> bad8503: (erikchen@chromium.org) Fix an invocation to find_sdk.py.
> 079650c: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
> 4dbae34: (mcgrathr@chromium.org) Fix PNaCl toolchain build on Mac
> db88d57: (mcgrathr@chromium.org) Fix build/update_pnacl_tool_revisions.py for @-less user names
> d5112f1: (mcgrathr@chromium.org) Update revision for PNaCl
> b6ec17d: (erikchen@chromium.org) Make a NaCl descriptor for Mach-based shared memory.
>
> Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/546ef11ffcbedf8c33bfa12643408c1182b6839e..b6ec17db8c2958f3455043e29000f17354336fb8
>
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build
>
> Committed: https://crrev.com/910bd999c1fed7f0211b636184072f35a506023f
> Cr-Commit-Position: refs/heads/master@{#360958}

TBR=dpranke@chromium.org,dschuff@chromium.org,mcgrathr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=none

Review URL: https://codereview.chromium.org/1472713003

Cr-Commit-Position: refs/heads/master@{#361096}

On iOS 9, evaluating '' + document always results in [object
HTMLDocument], even for PDFs. This introduces another way of checking
document type on iOS 9. Unfortunately, it doesn't work on iOS 8, so the
old implementation needs to stay too.

BUG=549604

Review URL: https://codereview.chromium.org/1458703004

Cr-Commit-Position: refs/heads/master@{#361095}

While attempting to remove the layoutObject parameter the following
observations were made:

 * The decoding forced by BitmapImage::imageForCurrentFrame will be
   deferred so the comment in the header may be removed.

 * BitmapImage::currentFrameKnownToBeOpaque() conservatively returns
   false for uncached images, not true.

 * Since decoding is deferred, there is no guarantee that the
   opaqueness metadata is available after the imageForCurrentFrame
   call has returned. It may increase the chance though, depending on
   image decoder for the particular image.

NOTRY=true
BUG=559131

Review URL: https://codereview.chromium.org/1454373005

Cr-Commit-Position: refs/heads/master@{#361094}

Review URL: https://codereview.chromium.org/1467143002

Cr-Commit-Position: refs/heads/master@{#361093}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fcdcfb56..e6029096

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1466263002

Cr-Commit-Position: refs/heads/master@{#361092}

BUG=542575
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1467203002

Cr-Commit-Position: refs/heads/master@{#361091}

Revert of The AllUrlsApiTest.WhitelistedExtension test should no longer flake. (patchset #3 id:40001 of https://codereview.chromium.org/1442593002/ )

Reason for revert:
The WhitelistedExtension is still flaky on the XP Tests bot, see e.g. https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/41174
stdio output:
[ RUN      ] AllUrlsApiTest.WhitelistedExtensionRunsOnExtensionPages
[1636:4084:1120/124530:WARNING:raw_channel.cc(208)] Shutting down RawChannel with write buffer nonempty
[139/464] AllUrlsApiTest.WhitelistedExtensionRunsOnExtensionPages (TIMED OUT)

Original issue's description:
> The AllUrlsApiTest.WhitelistedExtension test should no longer flake.
>
> The test had begun to hang after the refactoring that changed the way the extensions are loaded and reloaded. As a result of that refactoring, the test loaded the pages and tried to get some response from the extensions before they had time to reload.
>
> This change introduces waiting for the extensions reload, so the test should no longer flake.
>
> BUG=174341
>
> R=finnur@chromium.org
>
> Committed: https://crrev.com/454083864ede93660c2f08cf7d0e06ca10013c0d
> Cr-Commit-Position: refs/heads/master@{#359537}

TBR=finnur@chromium.org,voodoo@yandex-team.ru
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=174341

Review URL: https://codereview.chromium.org/1469813003

Cr-Commit-Position: refs/heads/master@{#361090}

A hole in a file is an area represented by zeros, which are not stored
physically on disk (aka sparse files). Take 640x360 I420 input as
an example. The padding size for three planes are 5120, 1280, and 1280.
Note 5120 > 4k. That means for every frame, there is one page "hole" in
the file. The hole page causes troubles for some systems.

This CL fills holes with zero bytes.

BUG=chrome-os-partner:41833
TEST=video_encode_accelerator_unittest

Review URL: https://codereview.chromium.org/1324213007

Cr-Commit-Position: refs/heads/master@{#361089}

Revert of Re-enable HTTP/2 over NPN (for OpenSSL). (patchset #3 id:40001 of https://codereview.chromium.org/1453903002/ )

Reason for revert:
The CL has introduced massive MSan and Valgrind reports, see the bug.

BUG=557197

Original issue's description:
> Re-enable HTTP/2 over NPN (for OpenSSL).
>
> BUG=557197
>
> Committed: https://crrev.com/0eb771aa98ba2bd4db0e2b82241afe8f5760c32e
> Cr-Commit-Position: refs/heads/master@{#361053}

TBR=cbentzel@chromium.org,bnc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557197

Review URL: https://codereview.chromium.org/1472743002

Cr-Commit-Position: refs/heads/master@{#361088}

Current Behaviour:
Chrome :
RTCIceCandidate.candidate = null => ""
RTCIceCandidate.sdpMid  = null => ""

Firefox :
RTCIceCandidate.candidate = null => "null"
RTCIceCandidate.sdpMid  = null => "null"

After the change:
Chrome:
RTCIceCandidate.candidate = null => "null"
RTCIceCandidate.sdpMid  = null => "null"

This aligns with the behavior on Firefox nightly

BUG=497307

Review URL: https://codereview.chromium.org/1431793002

Cr-Commit-Position: refs/heads/master@{#361087}

Previously if there were N distinct delayed times for dealyed tasks
posted to the scheduler, there would be N delayed tasks posted on the
chromium run loop.  We only really need to post timers for the next
delayed task.  This patch implements that. Caveat: because it's not
possible to cancel tasks posted to the chromium runloop, we will still
have more than one task outstanding if delayed tasks get posted in
reverse order.

BUG=510398, 546953

Review URL: https://codereview.chromium.org/1468443002

Cr-Commit-Position: refs/heads/master@{#361086}

Based on review feedback, WebNFC specification was modified
and requestAdapter() method was removed from NFC interface.
Methods from NFCAdapter were moved to NFC interface.
This patch adds new methods to NFC interface and aligns
corresponding idl files with latest specification.

https://w3c.github.io/web-nfc/#dom-nfc-push
https://w3c.github.io/web-nfc/#dom-nfc-cancelpush
https://w3c.github.io/web-nfc/#dom-nfc-watch
https://w3c.github.io/web-nfc/#dom-nfc-cancelwatch

BUG=520391

Review URL: https://codereview.chromium.org/1444303002

Cr-Commit-Position: refs/heads/master@{#361085}

Floats' margins need special attention for pagination, because they are not to
be eaten by page or column boundaries.

Clamp strut to >= 0 in LayoutBlockFlow::setPaginationStrutPropagatedFromChild()
instead of doing it (poorly) in calculateStrutForPropagation().

Removed calculateStrutForPropagation(), because there was hardly anything left
there now (and this lets us make marginBeforeIfFloating() private). This
function also turned out not to be universally usable, since we were already
calculating the strut on our own in adjustLinePositionForPagination() in one
case.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1460203003

Cr-Commit-Position: refs/heads/master@{#361084}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/064d82a9..fcdcfb56

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1467113002

Cr-Commit-Position: refs/heads/master@{#361083}

No multicol container should suggest to initially use a column height less than
the height of the tallest piece of unbreakable content inside.

TL;DR some related cleanup.

Introduce the term tallestUnbreakableLogicalHeight in favor of
minimumColumnLogicalHeight, as the latter could easily be confused with initial
column height; the height found by InitialColumnHeightFinder, which is also
sometimes referred to as initial minimal column height. Furthermore, there's
already a concept of *maximum* column logical height in fragmentainer groups,
which is derived from such things as CSS max-height. Since max-height actually
trumps the height of the tallest piece of unbreakable content in multicol
(while in CSS, min-height wins over max-height), it was just too confusing to
keep using "minimum column height" for this.

This change also makes it necessary to modify the containing column set when
calculating the initial column height for fragmentainer groups, so this part
kind of had to be moved from the const method calculateColumnHeight(). There
was already code that walked around that method when calculating the column
height, so being even more of a misnomer than before, it was renamed to
rebalanceColumnHeightIfNeeded().

BUG=447718
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1461923005

Cr-Commit-Position: refs/heads/master@{#361082}

https://chromium.googlesource.com/skia.git/+log/7ea33f5e1ae9..5931922997b8

$ git log 7ea33f5e1..593192299 --date=short --no-merges --format='%ad %ae %s'
2015-11-22 kkinnunen Remove GrContextFactory::getGLContext

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1466223002

Cr-Commit-Position: refs/heads/master@{#361081}

This CL renames the methods so that they are consistently using
"BrowserState" instead of a mix of "BrowserState" and
"ChromeBrowserState".

Review URL: https://codereview.chromium.org/1463833002

Cr-Commit-Position: refs/heads/master@{#361080}

BUG=554289

Review URL: https://codereview.chromium.org/1465803002

Cr-Commit-Position: refs/heads/master@{#361079}

Some scoped_ptrs are made by make_scoped_ptr function because
the bare pointer is also used after putting scoped_ptr to vector.

BUG=554289

Review URL: https://codereview.chromium.org/1459633003

Cr-Commit-Position: refs/heads/master@{#361078}

BUG=554289

Review URL: https://codereview.chromium.org/1459973003

Cr-Commit-Position: refs/heads/master@{#361077}

Specifying uniform values with locations bound with
CHROMIUM_bind_uniform_location should work, regardless whether
the underlying driver optimized the variable away or not.

Fixes the case where updating an inactive uniform would cause
INVALID_OPERATION, because the location was empty.

Fixes the case where updating an uniform would cause wrong
uniform to be updated, if the uniform was inactive and bound
to a location that would be assigned to an unbound uniform.

Makes the Program::uniform_infos_ array linear (non-sparse).  The
location bindings are now handled with Program::uniform_locations_
sparse array.

Simplifies the correction of driver-supplied uniform names and
determining whether an uniform is an array or not.

Fixes a cc bug exposed by the implementation (cc_unittests):
VideoGLRendererPixelTest.YUVAEdgeBleed
VideoGLRendererPixelTest.SimpleYUVARect

BUG=542355
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1419393005

Cr-Commit-Position: refs/heads/master@{#361076}

Cr-Commit-Position: refs/heads/master@{#361075}

BUG=554289

Review URL: https://codereview.chromium.org/1466653002

Cr-Commit-Position: refs/heads/master@{#361074}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/88d3129d..064d82a9

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1464243002

Cr-Commit-Position: refs/heads/master@{#361073}

Verify that deriving from a USING_GARBAGE_COLLECTED_MIXIN() annotated
class is traced as expected.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/1465083002

Cr-Commit-Position: refs/heads/master@{#361072}

Move this !ENABLE(INPUT_MULTIPLE_FIELDS_UI) object to the Oilpan heap,
where it belongs as it derives from the on-heap BaseDateAndTimeInputType
class.

At the same time, turn DateTimeChooserClient into a GC mixin.

R=haraken
BUG=553613

Review URL: https://codereview.chromium.org/1466113002

Cr-Commit-Position: refs/heads/master@{#361071}

This patch fixes a missing check in CalcParser::consumeNumberRaw for the
CalcNumber category. This was causing non-<number> calcs to be accepted
as numbers (which caused problems in flex where <number> and <length>
can be used in the same shorthand, e.g. flex: calc(10px + 50%) 1 2)

BUG=559513,499780

Review URL: https://codereview.chromium.org/1464253002

Cr-Commit-Position: refs/heads/master@{#361070}

Move stroke-dasharray property handling from
LegacyCSSPropertyParser into CSSPropertyParser.

With this change the stroke-dasharray produces UserUnits
CSSPrimitiveValues instead of Pixels. This caused
regressions on interpolation tests, I added UserUnits
to the unitTypeToLengthUnitType switch to fix this.

BUG=499780

Review URL: https://codereview.chromium.org/1442233002

Cr-Commit-Position: refs/heads/master@{#361069}

BUG=554902

TEST=conformance2/renderbuffers/invalidate-framebuffer.html, gpu_unittests

Review URL: https://codereview.chromium.org/1435183002

Cr-Commit-Position: refs/heads/master@{#361068}

This is the source of some confusion; ImageSkia has been abused in the
past for storing different logical image sizes, where an ImageFamily is
the appropriate class. This comment mirrors the comment in ImageFamily
explaining when Image/ImageSkia is appropriate vs ImageFamily.

Review URL: https://codereview.chromium.org/1438603003

Cr-Commit-Position: refs/heads/master@{#361067}

Cr-Commit-Position: refs/heads/master@{#361066}

BUG=559300
TBR=dcheng@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1467933002

Cr-Commit-Position: refs/heads/master@{#361065}

https://chromium.googlesource.com/chromium/src/+/928e603a

BUG=549174
TBR=skobes@chromium.org

Review URL: https://codereview.chromium.org/1466203002 .

Cr-Commit-Position: refs/heads/master@{#361064}

This patch changes the way neutral keyframes are specified in
SVG attribute interpolation tests to be more explicit using an exported
neutralKeyframe object.

BUG=530436

Review URL: https://codereview.chromium.org/1459093002

Cr-Commit-Position: refs/heads/master@{#361063}

BUG=554419

Review URL: https://codereview.chromium.org/1434883002

Cr-Commit-Position: refs/heads/master@{#361062}

Chrome was not applying animateMotion paths that do not actually express
motion.

Similarly, motion-path paths like "M 100 100 L 100 100" were not being
applied.

The SkPathMeasure constructed from such paths is empty, but we can
directly read the starting point from the path.

BUG=321022

Review URL: https://codereview.chromium.org/1418663004

Cr-Commit-Position: refs/heads/master@{#361061}

This cleans up history_ui.cc in preparation for adding a new WebUI for Material
design history.

BUG=425625

Review URL: https://codereview.chromium.org/1462813003

Cr-Commit-Position: refs/heads/master@{#361060}

https://chromium.googlesource.com/skia.git/+log/de3aac8cea8a..7ea33f5e1ae9

$ git log de3aac8ce..7ea33f5e1 --date=short --no-merges --format='%ad %ae %s'
2015-11-22 bsalomon Initial version of external_oes texture support and unit test

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1469753002

Cr-Commit-Position: refs/heads/master@{#361059}

Revert of components/metrics: Add runtime memory leak detector (patchset #52 id:2120001 of https://codereview.chromium.org/986503002/ )

Reason for revert:
This CL has been causing the builder Linux ChromiumOS Tests (dbg)(1) to fail:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/9298

Original issue's description:
> components/metrics: Add runtime memory leak detector
>
> This patch adds heuristic-based memory leak detector.
> Unlike traditional leak detectors like valgrind,
> it doesn't wait until a process terminates to check for
> leftover allocations. Instead, it analyzes allocation
> patterns over time.
>
> This code is not thread-safe. It is up to the caller of this code to ensure thread safety.
>
> BUG=382705
>
> Signed-off-by: Simon Que <sque@chromium.org>
>
> Committed: https://crrev.com/d02b109cb1f41b7ea0584d0910c8bb4cf21cb521
> Cr-Commit-Position: refs/heads/master@{#361012}

TBR=jochen@chromium.org,asvitkine@chromium.org,bjanakiraman@chromium.org,gpike@chromium.org,jar@chromium.org,thakis@chromium.org,wfh@chromium.org,sque@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=382705

Review URL: https://codereview.chromium.org/1472693002

Cr-Commit-Position: refs/heads/master@{#361058}

We are not yet addressing the subframe case so renderer_host is a better
place for this file.

BUG=551250

Review URL: https://codereview.chromium.org/1467083002

Cr-Commit-Position: refs/heads/master@{#361057}