GitLab

Removes dead and unnecessary code.

Bug: 818198
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I468a5018ec794b4c921f569362d37f1da3d1d6a5
Reviewed-on: https://chromium-review.googlesource.com/963319Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543253}

This CL fixes the SecurityIndicatorTest.CheckIndicatorText with the
network service by using a URLLoaderInterceptor.

Bug: 776589
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I25cecf5301b2b963a8c64cb515c45d6cdd74cf31
Reviewed-on: https://chromium-review.googlesource.com/961449Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543252}

Using wpt-import in Chromium 20ce9b76.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13844

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
dgrogan@chromium.org:
  external/wpt/css/css-tables
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
jfernandez@igalia.com:
  external/wpt/css/css-align
jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org:
  external/wpt/payment-handler
jsbell@chromium.org:
  external/wpt/IndexedDB
jsbell@chromium.org, mek@chromium.org:
  external/wpt/FileAPI
mek@chromium.org:
  external/wpt/webmessaging

TBR=leon.han@intel.com

No-Export: true
Change-Id: I54188d8fa4d3b434ea6f8b3ea067f34c2bd98a65
Reviewed-on: https://chromium-review.googlesource.com/963500
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543251}

Bug: 814626
Change-Id: I8d4622c78b6e2404c7012f28319cbe8ca37690d9
Reviewed-on: https://chromium-review.googlesource.com/938543Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543250}

It is possible that a few android.view.View APIs are called
after WebContents gets destroyed. This CL keeps them from
accessing the destroyed instance by safeguarding it at
ContentView where they pass through.

Alternatively this could be done at embedder level (i.e. parent
view of ContentView), but this approach reduces duplicated code.

And re-enabled the disabled test.

Bug: 821750
Change-Id: Ied55e7d36c589e6e7e324d081204c9a1294da7b2
Reviewed-on: https://chromium-review.googlesource.com/963149Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543249}

BrowserNavigatorTest.SingletonProfileLeak fails on browser_tests,
viz_browser_tests, site_per_process_browser_tests, and
network_service_browser_tests.  Failures seen on "Linux Tests (dbg)(1)" and
"Linux Tests (dbg)(1)(32)".

Failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/70940
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/70937
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/70933
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/48775
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/48771
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/48767

BUG=822033
TBR=sky

Change-Id: I90a1c3d76eab9139d70f0b8da0a22cf883e1d32f
Reviewed-on: https://chromium-review.googlesource.com/963090Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543248}

This CL passes BlobDataHandle to client, which contains in memory
download data.

The blob data handle is copied through the pipeline. Internally
BlobDataHanle has thread safe reference counting. When the download is
succeeded, InMemoryDownload will be deleted and the client should be
the only holder of the blob data handle.

TBR=jsbell@chromium.org

Bug: 809676,766299
Change-Id: I1ec15d10b363b306392574269cbc1e2e15f08004
Reviewed-on: https://chromium-review.googlesource.com/956535
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543247}

Although issue 22852008 limited to use skia font cache for Android, we also need
to limit to use the skia font cache for other low-end devices like Android. However,
it's hard to estimate the overall memory usage of the skia font cache per each low-end
device. So it would be good if we give them the power to limit to use the font
cache. This CL introduces a new command line switch to limit the skia font cache
size.

Bug: 274452
Change-Id: Ia6bca318aab9514d5b66290826afda897747256d
Reviewed-on: https://chromium-review.googlesource.com/961745Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#543246}

Previously tapping a link on the help page has no effect because the
links have target="_blank" attribute and we haven't properly set up the
WebViewController to handle that.

This CL makes the app open a target="_blank" link using the default
browser, aka Safari.

Bug: 821955
Change-Id: I1557a37d9b1a341186ee1b59fec1de77f075da1a
Reviewed-on: https://chromium-review.googlesource.com/963690Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543245}

The code to do this was behind an "if (!RLS)" block, which was added by
http://crrev.com/437671, but we need it with RLS also.  Otherwise, non-
composited sticky elements don't force main-thread scrolling, and jitter
as the compositor tries to scroll them.

This fix causes a test to reveal an existing bug in LayoutGeometryMap
(see crbug.com/821216).

Bug: 820921
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0227b994fcabb84b3edbaa4c73943667a88b1ea5
Reviewed-on: https://chromium-review.googlesource.com/959567
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543244}

Moved 2 selection-related APIs from ContentViewCore
to SelectionPopupController:

- preserveSelectionOnNextLossOfFocus
- updateTextSelectionUI

Bug: 598880

Change-Id: I7c944390c2d244902599d7a0c78568e6d512494e
Reviewed-on: https://chromium-review.googlesource.com/956786Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543243}

This is a reland of aa57fe6d

Original change's description:
> [Media Router] Converts integration tests to run on Chromium waterfall.
>
> This updates the Media Router integration tests so they run in the
> Chromium waterfall with the open source Media Router component
> extension and its mock (test) Media Route Provider.
>
> Additional changes:
>
> - Removes extension from top level BUILD.gn as it is only used for
>   browser tests at the moment.
> - Splits the targets for Media Router browser tests into integration tests
>   (part of main browser_tests suite), e2e tests (which require the
>   external component extension), perf tests, and shared support code.
> - Renames the "test" extension to the "telemetry" extension used for perf
>   tests to avoid confusion.
> - Updates README files
> - One test is not compatible with the Chromium component and need
>   to be fixed.  Bugs 818767 filed for follow-up.
>
> Bug: 698796
> Change-Id: I6cc9302ffd72de95630ce33ca3617b3b73b9e722
> Reviewed-on: https://chromium-review.googlesource.com/917214
> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543005}

TBR=cliffordcheng, imcheng, jrw, sky

Bug: 698796,822029, 821717
Change-Id: Ie5c2fdc9a838dec2906a73f7827fa6ceafdcce1b
Reviewed-on: https://chromium-review.googlesource.com/963064
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543242}

This is a reland of 1f31a184

Original change's description:
> Stop using GpuMemoryBufferVideoFramePool when WebMediaPlayerMS is hidden
>
> This CL adds calls to track when WebMediaPlayerMS is hidden or shown, so
> that in the time period we can skip creating GMB backed frames. For that
> time period, frames aren't going to be displayed, so copying them to GMBs
> is extra work which should be avoided.
>
> Bug: 653200
> Change-Id: I67e55c7f1150b434d82321ac90a08c7c3e3e6336
> Reviewed-on: https://chromium-review.googlesource.com/954339
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542950}

Bug: 653200
TBR: sandersd@chromium.org, dcastagna@chromium.org
Change-Id: I277eca14cac19e80b4b00dae75188842d7b49c97
Reviewed-on: https://chromium-review.googlesource.com/963581Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543241}

Change-Id: Ic18a8df18f32710a54bbc67f81a0776b1b22626b
Reviewed-on: https://chromium-review.googlesource.com/962676Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543240}

This reverts commit a8cf1a86.

Reason for revert: added faking test case TCPSocketTest.ReadAndWriteMultiple

BUG: 822058

Original change's description:
> Reland: Add TCP socket API to network service
> 
> This CL adds TCP socket API to network service.
> This is partly based on mandoline implementation
> (https://codereview.chromium.org/1873463003/)
> 
> Two TCP socket interfaces are added.
> - TCPConnectedSocket
> - TCPServerSocket
> 
> Change in reland:
> - adds logging to TCPSocketTest.ReadAndWriteMultiple to investigate
>   the test timeout observed in crbug.com/821232
> - Modifies TestServer slightly to own all client connections instead
>   of only the latest one.
> 
> R=​mmenke@chromium.org
> TBR=miu@chromium.org
> TBR=tsepez@chromium.org
> 
> Bug: 721401
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I0426a7aeda30cce7a2a1e84afae5208958dc4a10
> Reviewed-on: https://chromium-review.googlesource.com/960250
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543064}

TBR=miu@chromium.org,mmenke@chromium.org,tsepez@chromium.org,xunjieli@chromium.org

Change-Id: I078642396307e5eb20853a12596d931e0bb30d88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 721401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/963667Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543239}

Removes UtilityProcessHost from content/public and renames
UtilityprocessHostImpl to UtilityProcessHost.
Now that all use cases of UtilityProcessHost have been replaced by
using services (but for the PowerMonitor browser tests), this will
prevent further forking of process bypassing the service manager.

Bug: 775677
Change-Id: I2107271a54e4ab3141102a5c4fbcce4ea21915dd
Reviewed-on: https://chromium-review.googlesource.com/961496Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543238}

Change-Id: I382c31196514ca276f4ba49cfd0ea21b3697ed73
Reviewed-on: https://chromium-review.googlesource.com/957344
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543237}

Bug: 740993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I88816900bd0b55b6b6d8c5b139a2819ebfa1a9a3
Reviewed-on: https://chromium-review.googlesource.com/963510Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543236}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e0f5ac5d..60b83523

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ic8d24b2f1935de4c558aeef43f9219fbbb59d58d
Reviewed-on: https://chromium-review.googlesource.com/962981Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543235}

WrapUnique was the last thing remaining on PtrUtil.h.

Remove last uses of WTF::WrapUnique converting to std::make_unique or
base::WrapUnique when the ctor is private.

Bug: 781645
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8e04ccd6848bc425ef952a631c1c406ba1399c87
Reviewed-on: https://chromium-review.googlesource.com/961562Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543234}

Document the "Other request to powerd" reason in the Chrome
OS ShutdownReason enum in enums.xml. This enum is defined in
powerd, i.e. outside of the Chromium repository.

Bug: 807509
Change-Id: I7a07fba2770480c207f711580ddd9287ba71bfb3
Reviewed-on: https://chromium-review.googlesource.com/963486
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543233}

With TaskScheduler redirection, the MessageLoop will redirect tasks
only if a TaskScheduler is present. Otherwise, it will handle task
dispatch itself similar to today.

Direct dispatch is only expected to happen in unit tests and some
integration tests.

BUG=749310

Change-Id: Ia35f17a7a15155c8893020e7174573144bf7afb7
Reviewed-on: https://chromium-review.googlesource.com/932827
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543232}

This CL fixes wpt-nits in the two tests remaining in the folder
http/tests/w3c/webperf/submission/Intel/resource-timing

Bug: 498037
Change-Id: Iff5f79ddda48ac7e72988d35a40d6aff6e3c0751
Reviewed-on: https://chromium-review.googlesource.com/961921Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543231}

https://skia.googlesource.com/skia.git/+log/0bf59e459772..a421112ac4a9

$ git log 0bf59e459..a421112ac --date=short --no-merges --format='%ad %ae %s'
2018-03-14 egdaniel Reland "Add back missing unique key checks when creating CachedBitmap/Image Proxies"
2018-02-07 herb Add glyph cache warming - prototype
2018-03-14 rmistry Revert "Scale the GPU when running perf on Pixel(2)"
2018-03-14 ethannicholas fixed SkSL SPIR-V vector comparisons
2018-03-14 herb Add accessor and less for raw glyph ID and WS
2018-03-14 csmartdalton Add incompleteShortIntPrecision to SkSL StandaloneShaderCaps
2018-03-14 kjlubick Scale the GPU when running perf on Pixel(2)
2018-03-14 benjaminwagner Revert "Update clang_win to yesterday's build (from Chromium)."
2018-03-14 egdaniel Revert "Improve handling of GrPixelConfig in GrBackendTex/RT ctors"
2018-03-14 benjaminwagner Revert "Add Win x86 Clang Perf/Test jobs."
2018-03-14 reed hide SkBlurMaskFilter and SkBlurQuality
2018-03-14 herb Experiment: relax 4 byte alignment for glyph images
2018-03-14 egdaniel Revert "Add back missing unique key checks when creating CachedBitmap/Image Proxies"
2018-03-14 benjaminwagner Revert "Switch Win Exceptions Build to Clang."
2018-03-14 benjaminwagner Remove Goma builds and support in gn_flavor.
2018-03-14 angle-skia-autoroll Roll skia/third_party/externals/angle2/ fccebffe6..87db7c524 (4 commits)
2018-03-14 csmartdalton ccpr: Add an attenuation parameter to triangle corners
2018-03-07 csmartdalton Add a shader cap for incomplete short int precision
2018-03-14 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 6cecdee60..2b5c77024 (1 commit)
2018-03-14 kjlubick Cleanup TODO in gen_tasks
2018-03-13 benjaminwagner Switch Win Exceptions Build to Clang.
2018-03-12 benjaminwagner Add Win x86 Clang Perf/Test jobs.
2018-03-14 robertphillips Provide promise images when rendering SKPs w/ DDL
2018-03-14 bsalomon Ensure that GrGpu state tracking is initialized before making a backend RT/Tex in tests
2018-03-14 reed add explicit API to know if the writebuffer is using its external storage
2018-03-13 egdaniel Improve handling of GrPixelConfig in GrBackendTex/RT ctors
2018-03-14 egdaniel Add back missing unique key checks when creating CachedBitmap/Image Proxies

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I4e1e818eb011996e4eabc4dd2f873edb556500ac
Reviewed-on: https://chromium-review.googlesource.com/963305Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543230}

TBR=kbr@chromium.org
TBR=sky@chromium.org

BUG=chromium:815092

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib8f30c702e603c987e0c89203d8d7cd301f6ba77
Reviewed-on: https://chromium-review.googlesource.com/962933Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543229}

https://chromium.googlesource.com/catapult.git/+log/fb4a44ab53c4..6c4a8ca2e9bc

$ git log fb4a44ab5..6c4a8ca2e --date=short --no-merges --format='%ad %ae %s'
2018-03-14 dtu [telemetry] Add results label to benchmark_total_duration histogram.
2018-03-14 nednguyen Make psutil import error tolerable for py_utils.memory_debug module

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I54db2524f10f729810fd374d7b95e5ec98021952
Reviewed-on: https://chromium-review.googlesource.com/963479
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543228}

Revert "Add OnForwardProgressConfirmed() for QuicConnectionVisitorInterface and call it whenever an ACK increases the largest_acked value."

This reverts commit be7cfa94.

Reason for revert: CL accidentally includes changes from a separate CL: https://chromium-review.googlesource.com/c/chromium/src/+/956929

Original change's description:
> Add OnForwardProgressConfirmed() for QuicConnectionVisitorInterface and call it whenever an ACK increases the largest_acked value.
>
> The purpose of this is to have Chromium's QuicChromiumClientSession pass the MSG_CONFIRM flag to the next UDP sendto() call when OnForwardProgressConfirmed() is called for Linux platforms. MSG_CONFIRM is used to signal the Linux kernel of "forward progress" on that path to prevent the kernel from doing unnecessary probing.
> More info: https://bugs.chromium.org/p/chromium/issues/detail?id=488402
>
> This merges internal change 188887862.
>
> Bug:488402
>
> Change-Id: I607f41d293aece5f496547dec7c4d5fd1b24ea5a
> Reviewed-on: https://chromium-review.googlesource.com/961385
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543210}

TBR=rch@chromium.org,sergeyu@chromium.org,wangyix@chromium.org

Change-Id: Ic441da9cb36080ac42b2a442db5dc8431082f1d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 488402
Reviewed-on: https://chromium-review.googlesource.com/963621
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543227}

Simply moving file locations, no functional change

BUG=803135

Change-Id: I994b4080639c54a9f92fc18f726032d4fab159a0
Reviewed-on: https://chromium-review.googlesource.com/959602
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543226}

Fix errorprone ReferenceEquality warnings and make
sure it is treated as error after this CL.

http://errorprone.info/bugpattern/ReferenceEquality

Bug: 802075

Change-Id: Icd9d0ccd0f625b1eef1d92d88600641b67a8587a
Reviewed-on: https://chromium-review.googlesource.com/911609Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#543225}

We got some errors in link stage when using distributed thinlto
renderer_blink_platform_impl.o.thinlto.o:renderer_blink_platform_impl.cc:vtable
for content::DeviceSensorEventPump<blink::WebDeviceMotionListener>: warning:
relocation refers to discarded section
Removing the template instantiation statement fixes this issue.

BUG=820514
TEST=emerge-samus chromeos-chrome

Change-Id: I24a8221d576adac0495ff44c7d8d110aecc586fd
Reviewed-on: https://chromium-review.googlesource.com/946681Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543224}

Test ChromeDriverSiteIsolation.testCanClickOOPIF is failing for Chrome v66
on all desktop platforms.
Disabling OOPIF test.

Bug: chromedriver:2304
Change-Id: I7dbb623a96039981fce9c80cb5972c172a0096af
Reviewed-on: https://chromium-review.googlesource.com/963478Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543223}

This CL adds a demo application to show off how an app might
facilitate communication between a whitelisted extension and
guest content in a <webview>.

Bug: n/a
Change-Id: Ic7d20958c2a36159b9da4b32ec0543945f593b54
Reviewed-on: https://chromium-review.googlesource.com/949522
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543222}

BUG=749295

Change-Id: I916483dfc21b2523c99f8507917cf05ae42ca00a
Reviewed-on: https://chromium-review.googlesource.com/961546Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543221}

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I505e2e4e01ffba761a4c4ea2c699f71b9f3ed639
Reviewed-on: https://chromium-review.googlesource.com/963496Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543220}

Adds logic to display "persistent" error bubble (i.e. error bubble
that remains shown if user clicks, scrolls, types outside of the
bubble) that warns the user when a detachable base change / invalid
detachable base is detected. The warning warns the user that the
detachable base is different than he one they used last, and that
they should proceed with caution as the base might be malicious.

SigninScreenHandler is updated to observer ash::DetachableBaseHandler
state (currently non-mash only), and notify the UI when the error
message should be shown or hidden as the detachable base pairing
status, and the focused user pod change.

BUG=796300

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2813af6ac9473554509308194b3ae04331d013b9
Reviewed-on: https://chromium-review.googlesource.com/956802
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543219}

Create a copy of input buffer as otherwise it will not
catch a 1-byte overflow on write due to use of that byte
for keeping options.

R=rsesek@chromium.org

Change-Id: I15f6695e27951d1079b4e9fca71c55dfd54af870
Reviewed-on: https://chromium-review.googlesource.com/963016
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543218}

This reverts commit 375c6457.

Reason for revert: Breaks Google Chrome Linux x64:
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/28713

Original change's description:
> components/proximity_auth: Make this component CrOS-only.
> 
> This is true in practice.
> 
> R=​khorimoto@chromium.org, sky@chromium.org
> 
> Bug: none
> Test: none
> Change-Id: I14ec85e9b4c34bc0ee94ebae2ca9b9d782c8e5f4
> Reviewed-on: https://chromium-review.googlesource.com/962863
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: James Hawkins <jhawkins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543214}

TBR=jhawkins@chromium.org,sky@chromium.org,khorimoto@chromium.org

Change-Id: Ie10b48da189c3a80900bac3693ed345c5df92258
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/963584Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543217}

ash/detachable_base_handler/ now depends on upstart client to
(re)start detachable base pairing status checks on start up, so the
client should be available to ash.

BUG=818057
TEST=No crash when starting Chrome with --enable-features=Mash

Change-Id: Id2e89b9c0f2fca0e850a05ac20d9d14c616e7923
Reviewed-on: https://chromium-review.googlesource.com/963297Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543216}

This modifies the 'i' note next to the queryObjects result array to
describe how objects may not be collected if they are previewed until
console.clear

Screenshot: https://imgur.com/a/q03rG

Bug: 815263
Change-Id: I872ca733fd4b3ae3f64487e6c969167c26119c62
Reviewed-on: https://chromium-review.googlesource.com/961556
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543215}

This is true in practice.

R=khorimoto@chromium.org, sky@chromium.org

Bug: none
Test: none
Change-Id: I14ec85e9b4c34bc0ee94ebae2ca9b9d782c8e5f4
Reviewed-on: https://chromium-review.googlesource.com/962863Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543214}