- 18 Apr, 2020 40 commits
-
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I53ad6739e0ee384aa3bd13aaaf700dc11a4609a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155617Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760325}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I587b28b49d6fe4da269a8eb160586048081a8fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155360Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760324}
-
Philip Rogers authored
This reverts commit 0410b740. Reason for revert: Causing MediaFeedsWebUIBrowserTest.All failures, see https://crbug.com/1072145. Original change's description: > Add live details, images, duration fields for episodes. > > Bug: 1065986 > Change-Id: I4d3339006bbea2aaf1a6c9566e34a6faa506b04c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148247 > Commit-Queue: Sam Bowen <sgbowen@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760284} TBR=dcheng@chromium.org,beccahughes@chromium.org,sgbowen@google.com Change-Id: I77600047ed412095a253d955770a74e613b4dbb4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1065986, 1072145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155621Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760323}
-
Philip Rogers authored
This reverts commit 1f585617. Reason for revert: This is causing flakes, see: https://crbug.com/1072143. Original change's description: > [Extensions Metrics] Add metrics for action invocation source > > Add a new histogram to track the invocation source for extension > toolbar actions. This can include: > - The main toolbar > - The new extensions menu > - The old overflow menu (in the 3-dot menu) > - A programmatic API call (currently limited to allowlisted > extensions). > > Bug: 1064111 > Change-Id: I373768ba97c67d4b80bdc56585fd5a8e6c5163cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147685 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Caroline Rising <corising@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760154} TBR=rdevlin.cronin@chromium.org,bcwhite@chromium.org,corising@chromium.org Change-Id: I191039916b5f3626bf06196a41eb896c7ed02bc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064111, 1072143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155361Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b1943cb1302d..30b6825fa7b1 git log b1943cb1302d..30b6825fa7b1 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@30b6825fa7b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7fb2bbc51e22600fb322a40d05eeb9809ebbaa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760321}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f09ddec3..171cc405 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2691dd630e5d27e2722a67dadfcebecd92e7baa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155236Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760320}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 92a97b99. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 4de68d38 "fixup! [css-grid] Migrate flex-sizing-columns-min-max-width.html to WPT" f511fde8 "[css-grid] Migrate grid-gutters-and-flex-content.html to WPT" a236d77b "[css-grid] Migrate grid-gutters-and-tracks.html to WPT" d51ce450 "Add a WPT for image being lazy loaded multiple times" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia10512f1942f27b732a085c5b24a73efc343225c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155234Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760319}
-
Istiaque Ahmed authored
ScriptFinishedCallback can/should be a OnceCallback as it would only run (at most) once. This makes internal class Handler take OnceCallbacks too, simplifying the code a bit. Bug: None Change-Id: Id74e83ba255c9507ea778a7ad9fef08f8d7b9dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133659 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760318}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c8fb8b1..f09ddec3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia5ffe3aeb886e21d1ab41afc1e4f6408d9c6b34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155228Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ifd2156c012a7203e4bdb8c9d7bd1fe3c994d142d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155052 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#760316}
-
Mugdha Lakhani authored
Remove CookieControlsBridge dependency from PageInfoController. CookieControlsBridge enables improved Cookie Controls UI. (Context: https://bugs.chromium.org/p/chromium/issues/detail?id=1040091) WebLayer will likely support it in the future and TODOs have been added to componentize it. Bug: 1052375 Change-Id: I3d92e1af94a41cd0e4407cc9d0771a23542f743e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151455 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#760315}
-
Anders Hartvoll Ruud authored
CSSBitset is the same as a std::bitset, except it uses CSSPropertyID in its API, and has substantially (~10x) better performance when traversing the set bits for cases where few bits are set. Previous experiments has shown that the typical number of applied declarations per element is in the 10-20 range (out of a 500+ bitset), which makes this optimization relevant. There are two reasons for adding this. First, there is a need (in the near future) to interact with a CSSPropertyID-based bitset outside of the StyleCascade. Therefore it's nice to have an API which actually accepts/yields CSSPropertyIDs, to avoid noisy casting at every call- site. Second, there will be a need to traverse the bits efficiently in a situation where the common case has very few bits set. This CL replaces std::bitset with CSSBitset in CascadeMap, without using any of the capabilities which make CSSBitset special, but those capabilities will be used in the near future. Change-Id: I7080c97f784f01c4f560e9fb570443dd927b7a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152370Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#760314}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c632aa633792..fb490911a952 git log c632aa633792..fb490911a952 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@fb490911a952 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ibee7a69ed991824c39cb8f3cf9da4f6cafef4349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155552Reviewed-by:
-
Lei Zhang authored
Change-Id: I2a594c53509a303a95aaf3268dfae914b2fff30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154734Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#760312}
-
Greg Thompson authored
Include the contents of directories that unexpectedly exist. This may shed some light into failures on ToTWin64(dbg). BUG=1013720 R=zmin@chromium.org Change-Id: I466528a73e8aee93e70c7af11ccfa2c82b9e1198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152832 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760311}
-
Anders Hartvoll Ruud authored
The 'initial', 'inherit' and 'unset' keywords were handled, but 'revert' was not. This caused crashes when trying to represent certain declaration block serializations using shorthands. Change to use IsCSSWideKeyword instead, which includes 'revert'. (It should also avoid the same problem the next time a new CSS-wide keyword is added). Bug: 1071454 Change-Id: I968a32a5ad5b2a1a1958f60ec19679c6a642df14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152817Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#760310}
-
Roman Sorokin authored
This is a reland of 7d5271d9 Original change's description: > Migrate moar tests to LoginManagerMixin > > Bug: 1067260 > Change-Id: Ic86579fd50c5815c9adadbd3feade22cbd1c37a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144146 > Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760159} TBR=raleksandrov@google.com Bug: 1067260 Change-Id: Ia5689b03885ba68cdd933590d1088090d662f07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153158 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760309}
-
Roman Sorokin authored
Also introduce arc-tos-host-for-tests switch instead of setTosHostNameForTesting function. Needed for CL:2144279 Bug: 1067260 Change-Id: Iff5417eb02338944e07dbe982cc65edf4d18f30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145876 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#760308}
-
Esmael El-Moslimany authored
Change OGB height to 56px to match chrome-search://local-ntp (64px included the bottom margin). Include the customize button in the scroll region using "position: sticky". Shrink customize button when content width is below 550px. Shrink customize button and make background transparent when background image is shown. Set ntp-most-visited height based on number of rows of shortcuts. Shortcuts when dragged use a fixed position which does not contribute to the parent element height. Update the shorcut icons to 24px width and height. Add a 2px top padding to ntp-most-visited so the focus outline is not cutoff. Include text direction in the chrome-untrusted://new-tab-page HTML. Bug: 1070684, 1070668, 1070650, 1067366 Change-Id: Iee5a0055d77d992389d9542c9f9683bb7d2639f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155021 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#760307}
-
Haiyang Pan authored
Bug: 1070264 Change-Id: Ib741b6123633cf58a6b45f44a8154b8dae97f2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155410Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#760306}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91a820098f0c..9283cf0354c5 Created with: gclient setdep -r src-internal@9283cf0354c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586 Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: Iaf42a88b0a723556453f760d04b3e3e5e06c3357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155443Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760305}
-
Chris Lu authored
This will allow the Overlay framework to not create an overlay request when a user navigates to a page that is marked as auto-translate. This is necessary because the initial translate step is TRANSLATING and the Overlay framework responds to Infobar additions by presenting a Banner, which should not happen if the BEFORE_TRANSLTE step is skipped. Bug: 1071914 Change-Id: Ie174702b4e12f91da75d71fbb15850053a97e7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154396 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#760304}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2d5da0298b9b..33b58ebb7ea8 git log 2d5da0298b9b..33b58ebb7ea8 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 timvp@google.com Vulkan: Give unsized arrays at least 1 entry Created with: gclient setdep -r src/third_party/angle@33b58ebb7ea8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I8364941e1818f461755e880ff19cdde4fb9365c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155477Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/39aac148144c..b1943cb1302d git log 39aac148144c..b1943cb1302d --date=short --first-parent --format='%ad %ae %s' 2020-04-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b1943cb1302d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I07cd6276f524f5170d6ed35be39187eb046afc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155438Reviewed-by:
-
Brian Manthos authored
Building api_registration.lib clean directly fails. Repro steps: 1. rmdir /s/q out\default 2. gn gen out\default 3. autoninja.bat -C out\default obj/chrome/browser/apps/platform_apps/api/api_registration.lib153933 Change-Id: Ia4b24b3c9822c0586e93ff4931b18bc2471f7f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153933Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Brian Manthos <brianman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#760301}
-
Mohsen Izadi authored
The breakdowns were added in http://crrev/c/2129215 and http://crrev/c/2132853. Bug: 1054009,1057193 Change-Id: I12fca5354d777704dcecba336c0be35ade9f7e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154599 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#760300}
-
Chris Lu authored
With kInfobarOverlayUI on, Translate will be using the Overlay framework to present and manage the infobar. An intermediate state will still use InfobarTranslateCoordinator as the InfobarUIDelegate created with the Infobar. But the coordinator will essentially do nothing. Thus, it should not register as an observer. Bug: 1071914 Change-Id: Ic1feb30327928f4682993adeeb1cd6cd3ef52c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154729 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#760299}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ff098232588..91a820098f0c Created with: gclient setdep -r src-internal@91a820098f0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588 Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: Ibc457cbfe91e31ff1a83db5253192b907ad139b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155470Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates floating-not-effect-on-grid-items.html from fast/css-grid-layout to external/wpt/css/css-grid/grid-model with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to grid-float-002.html to be aligned with existing tests. Bug: 1063749 Change-Id: I1fe5a1a554ee2e2a15f526c8d1f18b8ba013ce6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153446 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#760297}
-
Nico Weber authored
No behavior change. Bug: 1056290 Change-Id: Ic7c1de0e00f86d3941f65f8856eb1baf66667dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154725 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#760296}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I411dfb3cd95f9533e920f35391f3cd4d229438ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155357Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760295}
-
Gyuyoung Kim authored
This CL migrates grid-container-scroll-accounts-for-sizing.html from fast/css-grid-layout to external/wpt/css/css-grid/grid-model with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to grid-container-scrollbars-sizing-001.html to be aligned with existing tests. Bug: 1063749 Change-Id: I370f3a02a7d5aac8bcfad2544447e1fe046b7a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153453 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates grid-container-scroll-accounts-for-auto-margin.html from fast/css-grid-layout to external/wpt/css/css-grid/alignment with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to grid-container-auto-margin-scrollbars-001.html to be aligned with existing tests. Bug: 1063749 Change-Id: Ib44cdce4fc7c20121efd8cbf0af76cc325a90f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153449 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f25b9eba..3c8fb8b1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibce6d6c732689a092146c72ed09718174ca1c9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153276Reviewed-by:
-
Richard He authored
Fix build break when `enable_feed_in_chrome = false`. Change-Id: I7a3dbb52b47a6cf9ef7081b022ae15db61c26e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154628Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Richard He <linyhe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#760291}
-
David Grogan authored
Absolutely positioned flex items were getting placed wrong when the containing block was legacy. This patch stores the relevant edges in legacy and makes NG pick them up on the other side. The above only works for abspos items controlled by NG. Legacy abspos flex items with a legacy containing block, e.g. position-absolute-009.html in this CL, still don't work. Bug: 845235, 1066859 Change-Id: I3d6beb0bfe80292181b81d2e42bf79bf73ddc834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146133Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#760290}
-
Alex Moshchuk authored
We no longer use process-per-site for WebUI (see crbug.com/982266), so fix a couple of comments that implied that we do. Bug: 1015882, 982266 Change-Id: I639c5b0b159c5e88f15263fdab01dc2dec95b33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151681Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#760289}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4c0fac2e6b05..416bf2e2bf82 git log 4c0fac2e6b05..416bf2e2bf82 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 tsepez@chromium.org Move char/wchar_t vectors to data partition. 2020-04-18 thestig@chromium.org Add third_party/base/immediate_crash.h. 2020-04-17 thestig@chromium.org Use spans in CPDF_TextRenderer. 2020-04-17 thestig@chromium.org Use Chromium-style names in GetCharPosList(). Created with: gclient setdep -r src/third_party/pdfium@416bf2e2bf82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7c0bd27e31bcf94aa2ea77ed93fab0221234852a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155290Reviewed-by:
-
rbpotter authored
Do not check in about_page_browser_proxy as this is still used by OS settings, so needs to be autogenerated. Bug: 1069258 Change-Id: I34fe291d6c1cb71be0a1a94545576829a841e52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154233Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#760287}
-
Todd Sahl authored
This change reverts an unintentional ' ' space added to a string in chrome/app/generated_resources.grd Bug: 1065116 Change-Id: I21e9103fdb8176d07ebbe231bd1a4c795e4fea00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155018 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#760286}
-
