GitLab

It was unprefixed back in Chrome 23.

BUG=330691
TEST=no behavior change

Review URL: https://codereview.chromium.org/121203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243664 0039d316-1c4b-4281-b951-d872f2087c98

Gesture actions can kick off animations on some pages. We want to be able to
measure the interval from the beginning of the gesture to the end of the
animation (without gaps). The 'wait_after' parameter allows the user to specify
a condition on which to wait after performing a gesture. The resulting active
range of the page action covers both the gesture and the condition.

BUG=323275

Review URL: https://codereview.chromium.org/117283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243663 0039d316-1c4b-4281-b951-d872f2087c98

- It now directly accesses DriveServiceInterface instead of JobScheduler
  so that the class can be used outside chromeos/.
- Use of ScopedVector is replaced by std::vector.

BUG=332014,312566

Review URL: https://codereview.chromium.org/127683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243662 0039d316-1c4b-4281-b951-d872f2087c98

This removes the use of skia::LazyPixelRef from the compositor,
which allows us to gather and lock/unlock SkDiscardablePixelRefs
in the instead.

skia::LazyPixelRef will be removed completely when no longer in use
by blink.

BUG=329094

Review URL: https://codereview.chromium.org/111143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243660 0039d316-1c4b-4281-b951-d872f2087c98

Moved description of SDK to top of download page and deleted the
sdk/index.html landing page.

BUG=

TEMPORARY STAGED DOC: http://ypd-ubiq182.dls.corp.google.com:8009/sdk/download.html

R=binji@chromium.org

Review URL: https://codereview.chromium.org/127433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332155
TBR=nkostylev@chromium.org
TEST=With the --new-profile-management flag set, start Chrome. Sign in
a profile, and choose "View all people" from the avatar bubble. With
the user manager window open, lock the profile. The user manager should
update the profile's pod with a lock icon.

Review URL: https://codereview.chromium.org/128553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243658 0039d316-1c4b-4281-b951-d872f2087c98

event 'id'.  The 'this' pointers are not unique since memory is recycled with
repeated alloc & free.  Trace output could appear jumbled in chrome://tracing
as in BUG=331161.

Moved the event 'id' assignment into a TraceOutputter which manages output to
TRACE_EVENT and maintains an incrementing event 'id'.

Added a unit test for the GLARBTimerTrace.

BUG=331161

Review URL: https://codereview.chromium.org/122723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243657 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/121773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243656 0039d316-1c4b-4281-b951-d872f2087c98

- Move sysroot.gni up a directory, as it applies to multiple
platforms now.
- Use existing find_sdk.py script to locate Mac SDK.
- Fix some gtest includes for Mac files.

BUG=
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/116763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243654 0039d316-1c4b-4281-b951-d872f2087c98

Document the old-school types as deprecated, now that we use stdint.h
everywhere.

R=brettw@chromium.org
BUG=138542

Review URL: https://codereview.chromium.org/127293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243653 0039d316-1c4b-4281-b951-d872f2087c98

The last update, 003, was erroneously using a version with separate
resources. This one has everything packaged into index.html per usual.

TBR=tonyg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/129043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331733

Review URL: https://codereview.chromium.org/125863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243651 0039d316-1c4b-4281-b951-d872f2087c98

Use the tall header for restored browser popups. The new header design uses significantly different assets for the headers of browser and non browser windows. Thus it makes sense for popup browser windows to use the tall header like restored tabbed browser windows do.

BUG=297187
TEST=None

Review URL: https://codereview.chromium.org/123043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243650 0039d316-1c4b-4281-b951-d872f2087c98

If an error occurs after Stop() the callback may be destroyed, yet
the callback value was not cleared.  During Close() stop may be called
again, if an error occurs the free'd callback will be notified of the
error...

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/115523010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243649 0039d316-1c4b-4281-b951-d872f2087c98

> Cast:Adding cast_transport_config and cleaning up
> 
> BUG=327482
> 
> Review URL: https://codereview.chromium.org/109413004

TBR=mikhal@chromium.org

Review URL: https://codereview.chromium.org/129113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243648 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327482

Review URL: https://codereview.chromium.org/109413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243647 0039d316-1c4b-4281-b951-d872f2087c98

The public/internal prompt had an unexpanded "%s" replacement.

Also, messages about what was being uploaded referred to the
sha1 file, while the thing actually being uploaded is the .wpr.

R=dtu@chromium.org

Review URL: https://codereview.chromium.org/126543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243645 0039d316-1c4b-4281-b951-d872f2087c98

Even though this isn't hooked up on Mac yet, we need the goma include for all toolchains to avoid throwing errors for Goma on Mac users.

TRB=thakis

Review URL: https://codereview.chromium.org/129323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243644 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330683

Review URL: https://codereview.chromium.org/123453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243643 0039d316-1c4b-4281-b951-d872f2087c98

During the self-destruct flow (user-level Chrome being replaced by system-level Chrome), existing code to retarget shortcuts failed to update icon executables. This CL fixes this. The heuristics are summarized below:

1. Only considering shortcuts with parameters .
2. Shortcuts whose icon file == old target (user-level chrome.exe) gets updated to new target (system-level chrome.exe).
3. Shortcut index is kept same as before.

(1) lets us delete user-level (pure) Chrome shortcut since system-level Chrome shortcut is already present. (2) lets us select migrate App Launcher shortcut (points to chrome.exe), without changing app shortcuts (points to fixed .ico files). (3) prevents App Launcher shortcut from mutating into Chrome shortcut (it assumes icon resources enumeration don't change.

To make (2) and (3) possible, we need to read the icon file and icon index. This is done by generalizing ResolveShortcut() to ResolveShortcutProperties().

The new logic requires a new flow in ShellUtils, and no longer uses the UpdateShortcutsWithArgs() flow.

BUG=326562

Review URL: https://codereview.chromium.org/108193019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243642 0039d316-1c4b-4281-b951-d872f2087c98

If the plugins setting is managed and can't be controlled by the user, then disable the run all plugins link on the plugins settings bubble.

BUG=321772

Review URL: https://codereview.chromium.org/126143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243639 0039d316-1c4b-4281-b951-d872f2087c98

This uses the path service to find the current process' path, removing the platform-specific code nad making it work on Mac.

R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/128693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243638 0039d316-1c4b-4281-b951-d872f2087c98

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/126743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243637 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243636 0039d316-1c4b-4281-b951-d872f2087c98

This change requires rolling the NaCl DEPS to get untrusted libraries to build correctly.

BUG=154400

Review URL: https://codereview.chromium.org/126803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243635 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: ChromeOS bot failures on x86/amd64

TBR=bartfab@chromium.org,benwells@chromium.org,derat@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329930

Review URL: https://codereview.chromium.org/129193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243634 0039d316-1c4b-4281-b951-d872f2087c98

This also resurrects the CookiesTreeModelObserverBridge (now called
CookiesTreeControllerBridge) that I removed in r77477 along with the rest of
the native preferences. The class is used to dynamically update the tree view
in response to model changes.

XIB changes:
* Made the "Blocked" tab buttons use the constrained window style.
* Matched the height of the NSOutlineView between the allowed and blocked tabs.

BUG=168996
TEST=Go to google.com, click on the lock icon, click on "Show cookies", and remove site data from the Allowed pane.

Review URL: https://codereview.chromium.org/128673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243633 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove GetLoaderPath, GetHelperPath, GetIrtBinPath from getos.py.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/118553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243629 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=332440

Review URL: https://codereview.chromium.org/129093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243628 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309720
TEST=covered by test. Also tested manually
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/106673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322682
TEST=covered by existing unit tests

Review URL: https://codereview.chromium.org/102973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243626 0039d316-1c4b-4281-b951-d872f2087c98

This should fix the 100% regression due to
https://src.chromium.org/viewvc/blink?revision=164213&view=revision

TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/129083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332271
R=thestig@chromium.org,joi@chromium.org

Review URL: https://codereview.chromium.org/128413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243624 0039d316-1c4b-4281-b951-d872f2087c98

BUG=310934
TEST=Let's see what the chrome-rel-mac6 bot has to say about this.

Review URL: https://codereview.chromium.org/128413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243623 0039d316-1c4b-4281-b951-d872f2087c98

This gets more to compile.

R=ben@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/128343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243622 0039d316-1c4b-4281-b951-d872f2087c98

For some reason stl for android has problems with these lines,
tweaking for loop makes the compiler happy.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/127043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243621 0039d316-1c4b-4281-b951-d872f2087c98

A contact at ARM mentioned that their recent Mali-T7xx line of GPUs
doesn't guarantee flush ordering either (and there seems little reason
to assume future models will break this trend).

So instead of enabling use_virtualized_gl_contexts for GPUs starting
with "Mali-T6", we should check for e.g. "Mali-T[6-9]", or more simply
just "Mali-T" since older Mali GPUs didn't have a "T".

BUG=154715
TEST=manual

Review URL: https://codereview.chromium.org/128163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243620 0039d316-1c4b-4281-b951-d872f2087c98

Fix QUIC faster stats reporting memory leaks and crashes by changing
lifetime once again.  Now QuicAckNotify::DelegateInterface, one of the
base classes of QuicFasterStatsGatherer, is ref-counted so
QuicFasterStatsGatherer is guanrateed to be around until either faster
stats reporting happens or the last ack is delivered by the
QuicConnection.

Merge internal change: 59228960
https://codereview.chromium.org/126543005/


Add a test requested by rch@ in cr/59053386 to replicate a potential
DCHECK failure.

Merge internal change: 59147972
https://codereview.chromium.org/127563002/


QUIC - Syncing with internal source code. Fixing the include
order. Added missing OVERRIDE.

Merge internal change: 59061118
https://codereview.chromium.org/127553002/


Make TimeWaitListManager use PacketWriter's socket writability state.

Merge internal change: 59058066
https://codereview.chromium.org/127523002/


Make QuicPacketWriter keep track of socket writability; expose the
underlying writer's state instead of keeping a separate variable in
Dispatcher.

Eventually we'll thread this to session/connection as suggested in
a TODO.

Merge internal change: 59055651
https://codereview.chromium.org/127503002/


Fix a QUIC DCHECK flakiness caused by not checking if a packet is
pending before asserting that it's in the sent_packet_map.

Merge internal change: 59053386
https://codereview.chromium.org/127003002/


QUIC Cleanup to remove pending_packets from QuicSentPacketManager and
use a flag in unacked_packets_.

Replaced FindOrNull and FindOrDie with find() call.

Merge internal change: 59015729
https://codereview.chromium.org/126983002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/127633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243619 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally checked this in.

TBR=scottmg

Review URL: https://codereview.chromium.org/129023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243618 0039d316-1c4b-4281-b951-d872f2087c98

Prerender browser tests are currently sensitive to prerenders occurring
synchronously. Already we require an ad-hoc content::RunMessageLoop() in
PrerenderPageNewTab because that one is asynchronous. Instead, introduce
a NavigationOrSwapObserver so NavigateToURL always waits for either the
swap or a normal navigation. This allows removing the
content::RunMessageLoop() call and is necessary for fixing beforeunload
handling.

Also split off DidDisplayPass and DidPrerenderPass into helper functions.

BUG=307592,304932
TEST=PrerenderBrowserTest.*

Review URL: https://codereview.chromium.org/102433010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243616 0039d316-1c4b-4281-b951-d872f2087c98