- 23 Dec, 2019 40 commits
-
-
Sylvain Defresne authored
The CL https://crrev.com/1977655 did not update some code that was only compiled on Official builder. This caused the following error as ios/chrome/test/app/chrome_test_util.h was no longer imported: ..../settings_egtest.mm:315:23: error: no member named 'SetWWANStateTo' in namespace 'chrome_test_util' chrome_test_util::SetWWANStateTo(YES); ~~~~~~~~~~~~~~~~~~^ Add a new method to SettingsAppInterface that wraps the call to chrome_test_util::SetWWANStateTo() thus allowing this code to be built for both EarlGrey and EarlGrey2. Bug: none Change-Id: Icf85d50a8a83603b68cb3eee99ef276a9f4dc042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980614 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727183}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/078af834..08c025c5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id054c8e21463932b5d1971fb545967d7a211a45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980552Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727182}
-
David Tseng authored
A locale as used by ICU and by ISO standards refers to the [language]-[region/country] specifier. This change makes it so the chrome.accessibilityPrivate binding formerly called getDisplayLanguage returns instead the full display name for locale. This means that we can disambiguate between languages from specific regions e.g. English from the United Kingdom (en-GB) vs English from The United States (en-US). Possible clients of the api are ChromeVox and tts. This is mostly a stopgap measure until a more standards based solution comes. Change-Id: I1d0eda2edb28dbb5ee23e035d58ee5e4e46b617a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955100 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#727181}
-
Jordan Bayles authored
This patch adds additional dependencies on Open Screen to enable running unit tests inside of Chrome. This adds a new openscreen_unittests target and adds it to the builders. The following TODO is also added: TODO(crbug.com/1025244): Move Open Screen unit tests from fieldtrial to linux, mac bots once we have ensured the tests are stable. Change-Id: Ia36d5af5136cbf39d5c1582238a0e5a1f69b7ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880544 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727180}
-
Olivier Yiptong authored
This implements a WritableStream-based API. WritableStream methods are fully implemented. Operations are queued and the WritableFileStream can be piped to. tell() queuing tracked at https://crbug.com/1034210 Transferability tracked at https://crbug.com/1035673 More information in the design doc: https://bit.ly/36wfLFA BUG=955189 Change-Id: Ibd2e0a29c230a2fa25b6133fdbaac4f4ad4f1eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913586 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#727179}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6b46fff0feca080816deab9c59df7f7b84e6c01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980792Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727178}
-
Javier Ernesto Flores Robles authored
On iOS 13.2 this test started to fail on EG1. EG evaluates the icon as not visible, even thought it is clearly in the view hierarchy. I wasn't able to fix it after spending some hours on it, removing the second part of the test, since the first part already test the purpose of it. Bug: 1019535 Change-Id: If7da63916e9fe9ea757a129358d101372e3fa032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975159Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#727177}
-
Andrew Grieve authored
* Changes all status messages from print() -> logging.info() * Adds a --quiet flag * Adds a few more lines to output that script was dropping: Tombstone written to:|Abort message:|Revision:|Build fingerprint: Bug: 917452 Change-Id: Id6f572aee3d6ebe9ceb5ce035b032862d24e2ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978904 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#727176}
-
Bret Sepulveda authored
This patch disables ExtensionsToolbarMenu when running the suite BrowserActionsBarBrowserTest, as it mostly relies on behavior specific to ToolbarActionsBar, and adds a new test to ensure coverage of equivalent behavior in ExtensionsToolbarContainer. Bug: 984654 Change-Id: Iac774cc9df2da163c9a066b01bed297fa21c197b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980734 Auto-Submit: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
Bug: 955194 Previously reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/1953626 Change-Id: I4408d126089be1c32710d9f4e564a84ef2f3ec7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980176Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#727174}
-
Michael Crouse authored
This change persists the FCP session statistics used by the prediction manager using a pref so that the first page load of the next session will have a non-zero value for the first page load of the session. This should improve the accuracy of the slow page prediction model in these cases. Bug: 1036026 Change-Id: I015c4ce5d654af614e947ae2352b4c75d6059067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977745Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#727173}
-
Denis Kuznetsov authored
Initially reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/1955728 Bug: 955194, 893934 Change-Id: I453ffb21ce148912ad58fe8ceaa2c6e354872d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980210Reviewed-by:
-
Akihiro Ota authored
This change moves away from the [Search + n/p + l] key combination for list navigation, as I got some feedback from testers that the combinations were awkward to invoke. Instead, list navigation now uses [Search + j + l] for next list and [Search + Shift + j + l] for previous list. This is more consistent with how existing jump commands are structured. This change also removes commands to navigate by paragraph, as movement by paragraph is already covered by group navigation. Lastly, this change renames next_keymap.json to default_keymap.json. Change-Id: If42c94d44f319ef08318575982d8a297d4aa9da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925207Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#727171}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f785fd673b20..3a40e8fef8c7 git log f785fd673b20..3a40e8fef8c7 --date=short --first-parent --format='%ad %ae %s' 2019-12-21 gbiv@google.com build_stages: stop explicitly specifying afdo_use 2019-12-20 wbbradley@chromium.org contrib: add script to show package phase timings 2019-12-20 saklein@chromium.org Build API: Parse known CLI args 2019-12-20 valleau@chromium.org licensing: create exemption for empty printing packages 2019-12-20 valleau@chromium.org licensing: Updating 'entry' template to include id in entry span 2019-12-20 vapier@chromium.org cros_build_lib.run: clean up redirect_std{err,out}->std{err,out} migration 2019-12-20 vapier@chromium.org cros_build_lib: RunCommand: deprecate it 2019-12-20 mmortensen@google.com Generate CPE output file using cros_extract_deps' output flag. 2019-12-20 mmortensen@google.com Update query_build_logs to show substring around the regex match. 2019-12-20 kinaba@google.com Remove veyron_mighty from Android NYC PFQ. Created with: gclient setdep -r src/third_party/chromite@3a40e8fef8c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I64b08e1c0173c4e74215f8bd3ab8af74607497e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980789Reviewed-by:
-
Sasha McIntosh authored
Bug: 1034750 Change-Id: I6fce7cc678c5cbf4fcb03afc9433b4bf8638348f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971971 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#727169}
-
Sadrul Habib Chowdhury authored
. Validate that main frame starts for the same compositor/impl frame. . A 'no damage' response from the main-thread can only happen from the most recently started main-frame. . Move the stream-logging before some early exits. BUG=none Change-Id: I4037070d9b87b3aa424ad14ad5ceb57969113d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980311 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#727168}
-
Sammie Quon authored
Arrow keys cause a double selection movement in tablet mode. This was a regression caused by introducing ctrl + arrow key to move the scrollable grid. This patch fixes that by handling on key presses. Also stops scrolling if ctrl is lifted before arrow key. Test: added regression test Change-Id: I89595a37880e85cbb903b0039785b20e8f7d0f71 Fixed: 1036140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977843 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#727167}
-
Mounir Lamouri authored
This will avoid WebContentsObserver to listen to the observer and footgun themselves thinking that they will be aware of everything while they should only expect updates. WebContentsObserver documentation has been updated accordingly. ContentFaviconDriver no longer exposes this information and the only user is now using WebContents directly. Bug: 1030540 Change-Id: I91ab4c193ef1ccbd3e4568250631029cb711f61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959334Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#727166}
-
Theodore Olsauskas-Warren authored
This change introduces a new settings-security-page polymer element that will be used as part of the M81 Privacy Settings Redesign. This element is only accessible by directly navigating to chrome://settings/security when the privacySettingsRedesign flag is enabled. This CL only intends to introduce the element populated with existing functionality and create associated an test fixture. As such, notable current omissions include: focusConfig updates (blocked on 1030210) Finalized strings Finalized images Secure DNS Toggle (Implementation blocked on this CL) Bug: 1032584 Change-Id: I3156630ed543897ee4c3c1d5c03e7a24ba2dbd71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960311 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#727165}
-
Gabriel Charette authored
Flakily crashes. Can't revert suspect. See bug for details. TBR=caseq@chromium.org Bug: 1036627 Change-Id: Icfc07fb0005854d0bc5270f45fd783472c1a3de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980351Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#727164}
-
Denis Kuznetsov authored
Initially reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/1954017 Bug: 955194, 893934 Change-Id: I46637b5ffd6d8d2fbb226a4663f7e6b9f6f1e945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980577Reviewed-by:
-
Sasha McIntosh authored
Change-Id: I737e94aaec42821c5eab846822218a4e50919416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976330Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727162}
-
Roman Sorokin authored
If oauth_code is missing from the cookie jar - wait for it and then continue authentication. Also not handle missing oauth_code anymore Also ignore web callbacks after authentication completed Bug: 1021297, b/146424936 Change-Id: I1f046124477aef996ff4b87fcb377328104cb866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972837 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#727161}
-
Hans Wennborg authored
It's been disabled upstream, so the flag is not needed anymore. Bug: 1033863 Change-Id: I16f9893256fa06fe8a015d945bc4477c88e48285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980569 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#727160}
-
Gabriel Charette authored
crrev.com/726101 intended to do this it seems but only covered IncognitoSplitContextMenuCount. IncognitoSplit is still flakily timing out on multiple Windows/Mac bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=EventPage/ExtensionContextMenuLazyTest.IncognitoSplit/0 Most often on win-asan and dbg bots, e.g. https://ci.chromium.org/p/chromium/builders/ci/win-asan/9190 suggesting a race (those bots are slower and races resolve differently on average) which results in a hang (hint: awaited notification arriving before the observer is installed is a typical reason for this). The hang is @ ExtensionTestMessageListener::WaitUntilSatisfied @ extension_test_message_listener.cc:48 when invoked from ASSERT_TRUE(onclick.WaitUntilSatisfied()) @ extension_context_menu_browsertest.cc:789 TBR=rdvelin.cronin@chromium.org Bug: 1035062 Change-Id: I29f237b3acd311967d14cdc58d3489ddd5bfd767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980350 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Hans Wennborg authored
The presubmit pointed out this was not formatted correctly in another change. Bug: none Change-Id: I06c3d778d75ef677550a9e6724630d18a0b6481c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980170 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
Now that trace_processor_shell can be built on Android, we can add it to dependencies, and eventually use for proto2json conversion on host. Bug: 1028612 Change-Id: Ia92c8a9a0d70e4a491e657f635d40102b7392993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978003Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#727157}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4d365120..078af834 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7540115100cb799ca6d703298b8d0e69c38722b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980640Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 652fbd92. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Iee687b415261d267f7f48680d0fffe66fd039448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980639Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727155}
-
Sara Kato authored
Bug: None Test: None Change-Id: I7a60ef70621e52670c508b72aaf499d5f787551d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978396Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1dd31b05385e..ea94670809ad Created with: gclient setdep -r src-internal@ea94670809ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I57e3399a2fd8d709a4388b24fc0a140760912926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980157Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727153}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I74e7e0e105fdc37fa73b17eb9ffe58c3b627b023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980156Reviewed-by:
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Change-Id: Ibf1905b30ed6e8af483d218b853a4393061b8875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975717 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ibb8351683cb95481e5e4d293dca499479f7beaaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980656 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#727150}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I9225b87e94f3719e043908bd351a4c8777fd40ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971651Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ac29f1342fd2..df9071f57626 git log ac29f1342fd2..df9071f57626 --date=short --first-parent --format='%ad %ae %s' 2019-12-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 1c1af9fc..bd5c3742 (425 commits) 2019-12-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fe2ed33a56dd..07d3bcf1c443 (10 commits) 2019-12-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6d29348ddb7e..6e3a387c0159 (4 commits) Created with: gclient setdep -r src/third_party/skia@df9071f57626 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I062a358a0a18a5d763aabf95605f593fc7b74122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980453Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/23df143850f9..26762d0425ff git log 23df143850f9..26762d0425ff --date=short --first-parent --format='%ad %ae %s' 2019-12-23 danilchap@webrtc.org Add video codec AV1 to the deprecated android decoder/encoder wrappers 2019-12-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 937a7837..6f7e5e79 (726883:727038) 2019-12-20 yvesg@webrtc.org Roll chromium_revision e4c6d7fe..937a7837 (726742:726883) 2019-12-20 olka@webrtc.org Revert "Reland "Reland "Distinguish between send and receive video codecs""" 2019-12-20 yoklmnprst@ya.ru Fixed crash on iOS13, methods beginGeneratingDeviceOrientationNotifications and endGeneratingDeviceOrientationNotifications. 2019-12-20 kron@webrtc.org Reland "Reland "Distinguish between send and receive video codecs"" Created with: gclient setdep -r src/third_party/webrtc@26762d0425ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4973edc0dfad97b10816f2a7fff36926641ad9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980465Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1030832 Bug: 949490, 990362, 997685, 1004327, 1021191 Bug: 1021594, 1022021, 1025213, 1025926, 1030393 Bug: 1030782, 1030810, 1031275, 1031341 Bug: 1033916, 1035485 Change-Id: Ibd81453c89f408499f5d375e9cc3cc85326288c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978751 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727146}
-
Hiroki Nakagawa authored
This CL stops creating ServiceWorkerProviderHost for service worker clients, and tweaks ownership model of ServiceWorkerProviderHost and ServiceWorkerContainerHost. Notable changes are as follows: - Before this change, ServiceWorkerProviderHost is created for both service worker clients and service worker execution contexts. After this change, it is created only for service worker execution contexts. - Before this change, ServiceWorkerContainerHost is owned by ServiceWorkerProviderHost. After this change, it is owned by ServiceWorkerContextCore for service worker clients or ServiceWorkerProviderHost for service worker execution contexts. - For service worker clients, ServiceWorkerContainerHost is destroyed when connection with blink::mojom::ServiceWorkerContainer is broken. See ServiceWorkerContextCore::UnregisterContainerHostByClientID(). - For service worker execution contexts, ServiceWorkerProviderHost and ServiceWorkerContainerHost are created and owned by ServiceWorkerVersion. It is reset when the corresponding service worker is stopped. See ServiceWorkerVersion::StartWorkerInternal() and ServiceWorkerVersion::OnStoppedInternal(). - Before this change, ServiceWorkerContextCore manages 2 maps: <provider_id, unique_ptr to ServiceWorkerProviderHost> and <client_uuid, raw_ptr to ServiceWorkerContainerHost>. After this change, the context core manages only 1 map: <client_uuid, unique_ptr to ServiceWorkerContainerHost> Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: Ia1f46421f0b0f524391a24b6e2c386c53eada0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945953Reviewed-by:Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#727145}
-
Matt Falkenhagen authored
When ServiceWorkerOnUI is enabled, methods must be called on the UI thread. This adds a test that would crash when run_web_tests.py is run with --additional-driver-flag="--enable-features=ServiceWorkerOnUI" before the fix. Bug: 1030543 Change-Id: Ibdd7cbac3fd92900dc78d538237f5f8b1a3a96f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980252Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#727144}
-
