GitLab

BUG=365663

Review URL: https://codereview.chromium.org/254523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342662
TBR=jiayl@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/252563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266291 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=jschuh@chromium.org, sievers@chromium.org

Review URL: https://codereview.chromium.org/256713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266290 0039d316-1c4b-4281-b951-d872f2087c98

There is now a limit on number of events per proto (AggregatedFrameEvent
and BasePacketEvent). There is also a limit on number of packets per
frame (i.e. number of BasePacketEvent in AggregatedPacketEvent). If
either limit is exceeded, a new proto will be created for that frame.

The underlying implementation of EncodingEventSubscriber is also
changed. When the internal map reaches a certain size, its old entries
will be transferred to a vector for storage. This is done to keep the
map small and lookup fast.

A proto will also be
transferred to storage if adding an event to it would result in
exceeding the limit stated above. The scheme is not perfect, but such
situation rarely happens in practice.

Also changed deserialization to be able to merge protos of the same
frame.

This is done to keep protos size in check. Also, LogSerializer will now
fail DCHECK if the protos exceed the maximum size 2^16 - 1. (Because
we encode size as 16 bits).


BUG=

Review URL: https://codereview.chromium.org/241833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266289 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/258563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266288 0039d316-1c4b-4281-b951-d872f2087c98

doesn't pass a third argument to chrome.send('removeException');

R=thestig@chromium.org
BUG=362362

Review URL: https://codereview.chromium.org/243803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266287 0039d316-1c4b-4281-b951-d872f2087c98

Linux Breakpad: Keep reading from the crash upload progress until a complete crash id has been received.

BUG=363660

Review URL: https://codereview.chromium.org/248653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266286 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266285 0039d316-1c4b-4281-b951-d872f2087c98

Chromium NaCl scripts now uses package_version to extract.

Now that we have split up the toolchain into multiple tars, we should
use the package versioning script to manage which tars to extract.
Unfortunately, currently the SDK uses different directory names compared
to what the NaCl toolchain directories normally use, so we also must map
and move the toolchain directories to the SDK ones.

BUG=365817
TEST= trybots

Review URL: https://codereview.chromium.org/249153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266284 0039d316-1c4b-4281-b951-d872f2087c98

wm.gyp:wm depends on aura.gyp:aura, so this ensures that any gyp
use_aura guards also guard wm.gyp. Also fix some toolkit_views/use_aura
gyp usage, and add mac stubs for ui/base/dragdrop so the gyp conditions
don't explode (they will be needed later).

BUG=366007

Review URL: https://codereview.chromium.org/248893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266283 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/250653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266282 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg@chromium.org
BUG=360204

Review URL: https://codereview.chromium.org/255603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266281 0039d316-1c4b-4281-b951-d872f2087c98

To use:
1) Run gyp with GYP_DEFINES="enable_resource_whitelist_generation=1", build.
2) Pipe the build output into find_used_resources.py to generate a whitelist.
3) Run gy with GYP_DEFINES="enable_resource_whitelist_generation=1  repack_options="--whitelist...", build.
4) Pipe the second build output into list_resources_removed_by_repack.py.

Requires grit-i18n r167 to generate the unused resource list in step 3.

BUG=338759
NOTRY=true

Review URL: https://codereview.chromium.org/248173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/259523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266278 0039d316-1c4b-4281-b951-d872f2087c98

As a preparation of thread migration from UI to a worker,
this CL moves the usage of ExtensionService in SyncWorker to UI thread explicitly.

BUG=347425

Review URL: https://codereview.chromium.org/246163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266277 0039d316-1c4b-4281-b951-d872f2087c98

This exports some functions used by tests to fix the following errors:

../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'

TBR=jsbell@chromium.org
BUG=none
TEST=ninja -C out/Release aura_builder

Review URL: https://codereview.chromium.org/258893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266276 0039d316-1c4b-4281-b951-d872f2087c98

cleaning up : download, omnibox, settings_overrides, spellcheck, stream_private API.

BUG=354046

Review URL: https://codereview.chromium.org/244473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266275 0039d316-1c4b-4281-b951-d872f2087c98

If the App Launcher has already been installed, this change will have no
effect until chrome is run with the flags:
--reset-app-list-install-state --enable-app-list flags.

BUG=366445
TEST=Run chrome --reset-app-list-install-state --enable-app-list. Chrome
App Launcher shortut should be on "Internet" menu on desktop
environments with an applications menu (eg. Gnome Classic or Cinnamon).

Review URL: https://codereview.chromium.org/253403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367349

Review URL: https://codereview.chromium.org/259873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266273 0039d316-1c4b-4281-b951-d872f2087c98

Looks like perf --call-graph now requires an argument
in the most recent perf binary.  That's probably a bug
in perf, but moving back to -g for now.

I tried running the telemetry tests, but gave up
after several minutes of gorilla videos stealing focus from my browser.

I found
src/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py
but it didn't seem to attempt to test this code
(or have a recommended way for instantiating this kind of
PerfProfiler so I could call this instance method) so I
gave up on testing.

BUG=366928

Review URL: https://codereview.chromium.org/257463007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266272 0039d316-1c4b-4281-b951-d872f2087c98

chrome.test.fail cannot be used as ErrorCallback because it throws exception when the number of arguments doesn't match.
This wrong use of chrome.test.fail makes the error output useless when something goes wrong.

BUG=None
TEST=browser_tests

Review URL: https://codereview.chromium.org/258523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266271 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266270 0039d316-1c4b-4281-b951-d872f2087c98

The ui:: cursors constants like ui::kCursorIBeam are gfx::NativeCursors
on aura, but not other platforms.

This change introduces ui/views/native_cursor.h, which provides a set of
functions giving gfx::NativeCursor constants in a platform-independent
way.

BUG=366007

Review URL: https://codereview.chromium.org/248863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266269 0039d316-1c4b-4281-b951-d872f2087c98

In Debug configuration:

$ gn gen out/Debug_gn
$ ninja -C out/Debug_gn strings

In Release configuration:

$ gn gen out/Release_gn --args=is_debug=false
$ ninja -C out/Release_gn strings

BUG=None
TEST=see above
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/246593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266268 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a NavigateFrameToURL method, which will allow browser tests to navigate specific (sub)frames and more precise out-of-process iframes tests can be written. 

It also changes how cross-site transition is done for --site-per-process. It used to depend on the Referer header, but if there is a navigation to data URL, it will be empty and there will always be a transfer to new renderer.
I'm changing it to do the check on the UI thread and for now to be a very simplistic one - is the URL in the same SiteInstance as the current renderer.

BUG=357747

Review URL: https://codereview.chromium.org/248963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266267 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172520:172575&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/259773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266266 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Did not fix OOM, just moved it.

BUG=357326

Original issue's description:
> Remove oilevent from tough layout cases.
> 
> It OOMs on some android devices now and no one has the cycles to debug.
> 
> BUG=357326
> NOTRY=True
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266039

TBR=simonhatch@chromium.org,rschoen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357326

Review URL: https://codereview.chromium.org/252703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266257 0039d316-1c4b-4281-b951-d872f2087c98

Fix parsing order of the stream parameters string to match the
documented order.

TEST=Run
BUG=None
TBR=fischman@chromium.org

Review URL: https://codereview.chromium.org/257713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266256 0039d316-1c4b-4281-b951-d872f2087c98

It hangs for an unknown reason. This patch disables it while we invetigate and
should be reverted once solved.

BUG=353260
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/253573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266254 0039d316-1c4b-4281-b951-d872f2087c98

It fails to scroll on android due to a functional Chrome bug.

Please revert this patch after this bug is fixed.

BUG=366371
TBR=ernstm@chromium.org

Review URL: https://codereview.chromium.org/250773009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266253 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org
BUG=none
TEST=no DCHECK()s about unhandled webui messages fire

Review URL: https://codereview.chromium.org/251623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266246 0039d316-1c4b-4281-b951-d872f2087c98

This happens normally when the display is blanked by powerd.

BUG=333413
TEST=ran chrome on link_freon
NOTRY=true
R=dnicoara@chromium.org

Review URL: https://codereview.chromium.org/251843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266244 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266243 0039d316-1c4b-4281-b951-d872f2087c98

R=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/256633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266242 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367173
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/255903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266240 0039d316-1c4b-4281-b951-d872f2087c98

This CL remember pending user switch and do it as soon as profile
ready. From UI perspective this look very smooth because profile loading
is actually fast so previous desktop is not shown. But if it will be
a problem on slow device we may need to stay on add user screen a bit longer.

BUG=333879
TEST=manual
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/246253009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266239 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334448
R=thestig@chromium.org
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/254773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266238 0039d316-1c4b-4281-b951-d872f2087c98

  /**
   * Some doc comment.
   **/ <-- this

I've had to tell people to change **/ -> */ more times than I can count.

Also make myself an OWNER of a webui testing directory.

R=estade@chromium.org, sky@chromium.org
BUG=366972
TEST=less review comments
NOTRY=true

Review URL: https://codereview.chromium.org/255503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266237 0039d316-1c4b-4281-b951-d872f2087c98

The benchmark is broken there due to a Chrome bug. This patch just papers
over the breakage to get the tree green.

Please revert this patch when chrome is fixed.

BUG=365237
TBR=fmeawad@chromium.org

Review URL: https://codereview.chromium.org/257953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266236 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367199
TBR=dewittj

Review URL: https://codereview.chromium.org/254853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266235 0039d316-1c4b-4281-b951-d872f2087c98