- 02 Oct, 2020 40 commits
-
-
Richard Knoll authored
Extends the following useful metrics for this launched feature: - Sharing.ClickToCallAppsToShow - Sharing.ClickToCallDevicesToShow - Sharing.ClickToCallDialerPresent - Sharing.ClickToCallDialogShown - Sharing.ClickToCallSelectedAppIndex - Sharing.ClickToCallSelectedDeviceIndex Removes collection of these metrics as the data is not used: - Sharing.ClickToCallPhoneNumberPrecompileTime Bug: 1125769 Change-Id: I28fdeff408c4326f13dddaacbf9266b82452761d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440838Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813099}
-
David Roger authored
clearAllCachedAuthTokens() cleans up the Identity API state allowing the extension to implement the sign-out functionality. clearAllCachedAuthTokens() removes the following data associated with the extension: - Gaia id of an account used in getAuthToken() - All entries in the token cache - Cookies in the web auth flow storage partitions Bug: 1125847 Change-Id: I95173b0f264d45c5c1222e709594ebc7062d0ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398919Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#813098}
-
Martynas Sinkievic authored
Add functions which support validating and parsing the JSON matching pattern configuration string into a format supported by |PatternProvider|. Also provide support for versioning and replacing the configuration in |PatternProvider|. Due to the nature of the change, |PatternProvider| was changed to support testing with a synchronously loaded configuration. Change-Id: I662ecb933a4067c0ee6d188defe5e982b85469a7 Bug: 1121990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359990Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Martynas Sinkievič <marsin@google.com> Cr-Commit-Position: refs/heads/master@{#813097}
-
Andrew Shulaev authored
Couple of usages seem to use the callback multiple times, thus base::RepeatingClosure is used in these places. Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit# Bug: 1007635 Change-Id: I3bc08d2a1b9149eeaaa0386f05334b04697be40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440581 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Auto-Submit: Andrew Shulaev <ddrone@google.com> Cr-Commit-Position: refs/heads/master@{#813096}
-
Greg Thompson authored
BUG=1121162 TBR=pastarmovj@chromium.org NOTRY=true Change-Id: I2b19fff83f5a8372504854f93c2fd1221afdbba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444311 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#813095}
-
Adam Rice authored
The recent fix to stop resetting the stream after close probably deflaked this test. It is not flaking on the CQ. Re-enable it. BUG=1064434 Change-Id: Ibdce899968aa144a6acafc2481245c1b2173898f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442913Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#813094}
-
Greg Thompson authored
This reverts commit 2af0583b. Reason for revert: consistent CaptureModeTest.WindowCapture failures in ash_unittests (e.g., https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20786) Original change's description: > capture mode: window capture change. > > In window capture mode, the user should be able to interactively select > a window to capture. when the to-be-captured window's bounds or state is > changed, we should update the capture region to reflect the change as > well. > > Other changes that is worth mentioning in this CL: > - Window stacking order or activation order will not be changed by the > capture window selection change > - If current selected is closed/minimized or becomes invisible, we > automatically select another window under mouse/touch event location. > and if there is no such window, do nothing. > - If another window is activated when a window is selected, if the > activated window is under mouse/touch event location, it will be focused > instead. > - When a mouse moved over a selectable window, change its cursor to > either capture icon or recording icon > > Bug: 1127526 > Change-Id: Icfdbed419dadfe0301b60da693f01010f4a2da2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421090 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812976} TBR=xdai@chromium.org,afakhry@chromium.org,newcomer@chromium.org Change-Id: I4f2f3c21ae546ca1442a29d95b58f11f4da3b43f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444990Reviewed-by:
-
Klaus Weidner authored
This adds the needed changes to use dynamic viewports for the ARCore WebXR device, and opts in to using that. It also changes the texture MAG filter used when enlarging a texture to use LINEAR interpolation. This should also be beneficial when using a custom framebufferScaleFactor independent of dynamic viewport scaling to avoid pixelation artifacts. Bug: 1133381 Change-Id: I442124de1090f971edbc822dd3ba8550301c2e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436683 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#813092}
-
Alexandre Courbot authored
When using DMABUFs, it is preferable to use the same V4L2 buffer with the same underlying buffer, as failure to do so results in memory unmappings/remappings in the driver. Use the newly introduced buffer affinity tracker and V4L2Queue::GetFreeBufferForFrame() method to achieve this transparently in the image processor. BUG=b:159688625 TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I9df69431d0e532c40c0f49ca4e3bb31843b0814b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413946 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#813091}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/eb1df14b18a0..1fd3e5d89a8f 2020-10-02 jmadill@chromium.org Test Runner: Fix race in watchdog timeouts. 2020-10-02 syoussefi@chromium.org Vulkan: Fix UtilsVk clear in non-zero subpass 2020-10-02 jmadill@chromium.org Revert "Vulkan:Add debug labels for OpenGL calls" 2020-10-02 jmadill@chromium.org Add a standalone GN isolate map. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ic0b0bb51921fe169e88ff36c874a3bf4b6116439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813090}
-
Alex Moshchuk authored
The test contained three independent cases, and it looks like the second one has become flaky on all platforms. Break these cases into independent tests in the hope that this might help with flakiness, and also add a couple more expectations to the second test in case it's still flaky. This is also a prerequisite for expanding these tests for issue 1132938. Sheriffs: if ReloadHiddenTabWithCrashedSubframeOutOfView is still flaky after this lands, please disable just that test under issue 1010119, rather than reverting this whole CL. Hopefully we can keep coverage for the other two tests. Bug: 1010119 Change-Id: I949f9c7889beefda309f11eaf8f8643624ae5fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443514 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#813089}
-
Victor Fei authored
Added documentation for IA2 to UIA element runtime look up. This will help ATs to utilize the new feature for looking up an UIA element from an IA2 element. Bug: 1084630 Change-Id: Iec674312c4a7b0c1117402c2e78dffbd4c25c304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267434Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813088}
-
Xianzhu Wang authored
The parameter was for paint (record) benchmarking. Now we have switched to use cc::LayerTreeHost::RunPaintBenchmark() for paint benchmarking in crrev.com/c/2437735. Remove the unused parameter. Bug: 922642 Change-Id: I106f3591bda64e3068b8cb6f0f2aaba0db8aaad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438636 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813087}
-
Robert Ogden authored
Adds an experiment param which will start a spare renderer after all prefetching and NSPs are complete. Change-Id: I102031892b169e9fb2416384c4a5684ed6ac8880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424527 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#813086}
-
Hitoshi Yoshida authored
Fix include paths of IDL dictionaries Bug: 839389 Change-Id: I5021e0a1802fda7ca8866c775483be1fa3b40912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444650 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#813085}
-
Omid Tourzan authored
It adds a new file command (erase) to the foreground. Existing format dialog changed to show both format and erase (SinglePartitionFormat) elements. The dialog marked with single-partition-format attribute for tests. Partition event flow only care about failure to notify user about error as the operation halted, format event will show start/complete notification. Bug: 491043 Change-Id: I5d08d8f28f5e78dcf27cf31dfaf7f587806aa27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379464Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813084}
-
Yao Xiao authored
Chrome launch approval: https://bugs.chromium.org/p/chromium/issues/detail?id=1062736 Bug: 1062736 Change-Id: Ib22c7622b8c4afc93c98190fbacdab3337c4c72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441683 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#813083}
-
Ted Meyer authored
This starts with //media/gpu/test:local_gpu_memory_buffer_manager needing to use the chromeos-specific minigbm library. Also then add a check for use_vaapi to the vaapi jpeg/webp decoder unittests. Change-Id: I3991961746bd6626b772f9143544c238d67b3dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439780 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813082}
-
Jamie Madill authored
We should be calling standard_isolated_script_merge for isolated scripts. This will further enable using the gtest test type for isolated scripts. Bug: 931731 Bug: 1131231 Change-Id: Idf40e1978104b79501700944b30c581159e35341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443936Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#813081}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I4d0e29c87a7aa848b1d551073d05cdb3d797cba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444869 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Zufeng Wang authored
Previous behavior: Clicking the suggestion chip launches the app but the chip stays there. This CL: In addition to launching the app, it stops the suggestion chip from appearing. Note: Does not fix the issue of the chip not disappearing after being viewed three times. Bug: b/169711884 Change-Id: I5760b66c1a086d770728bb1c720806de0333a850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440328 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813079}
-
Alexandre Courbot authored
Add a small tracker that will always return the same V4L2 index when given the same VideoFrame. This ensures that video buffers are always assigned to the same V4L2 buffer, avoiding unmappings/remappings in the kernel. BUG=b:159688625 TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I4c439109891b0c02b607f2b238d21a4cca3a9c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413945 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Joel Fernandes authored
Core scheduling enables securely running untrusted tasks (Chrome renderer and VMs) securely by running on dedicated core, while letting trusted tasks be co-scheduled on both hyper threads. Bug: 152605392 Change-Id: I3db1b1515c5b28e5d42826ec1367b92582ae1a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372582 Commit-Queue: Joel Fernandes <joelaf@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Joel Fernandes <joelaf@google.com> Cr-Commit-Position: refs/heads/master@{#813077}
-
Alexandre Courbot authored
This reverts commit 64b5f971. With https://crrev.com/c/2423085 merged, our tests are not using the "drm" option anymore, so we can remove this temporary map. BUG=b:169115289 BUG=1116466 TEST=video.EncodeAccel.h264_360p_i420 passes on Kukui. Change-Id: Ifc7b8fe6b1b588f18bd26ba38b117ead6f172c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437311Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#813076}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iab96e7575e2c1f93b8276e43186109a31698258d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444730 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Ted Meyer authored
//media/capture:capture_unittests only includes this file on chromeos and so if it is being built on a non-cros machine, then gn will give an error message. //media/gpu/vaapi:common includes only //ui/gfx/ozone only when use_x11 is set to true, so it needs a nogncheck on vaapi_wrapper.h when it includes the x11 header. Change-Id: I09580a36f349f797100c9c8e82d9a063b997afc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436705Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7f0e83e82ba9..5b5abd79106a 2020-10-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fa57522d..9a738068 (812874:813008) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe958a1712681dc3de14a872052dac5d9def2ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444789Reviewed-by:
-
Yuzu Saijo authored
This CL makes a page bfcache-eligible when WakeLock is released. Bug: 1039569 Change-Id: Ie951c5db8eaf0f08c0ff5dd27742c1ac7cf1b8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428504 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#813072}
-
Maggie Chen authored
A new feature switch DirectCompositionUseOverlayDamageList is added to enable the new method that removes the overlay damage from the root damage to get the final optimized damage rect. This CL also adds a new histogram GPU.DirectComposition.DCLayer.OverlayCount which records the total number of overlays we are going to present in the DC overlay processor. Bug:1117235 Change-Id: I1fb97d8b4fd96270ff6447b63ad86785d60c2eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416966 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#813071}
-
Leo Zhang authored
This test failed a few times recently in linux-chromeos-rel, which blocked chromium.chromiumos. Disable it now. TEST=autoninja build content_browsertests successfully Bug: 1134455 Tbr: goto@chromium.org Change-Id: I10b6d7e6648491a9d1b3bc9ebe4724044ee7bb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444610 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#813070}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/444cee2905f5..fbeee8fe0c0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: noel@google.com Change-Id: I2e4731e059f3cfaf123ad2cf43ae56fda367ca72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444733Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813069}
-
Kenichi Ishibashi authored
ServiceWorkerStorage had two PurgeResources() methods but only one is used. Remove unused one. Bug: N/A Change-Id: Ie53a804cde9dac815e93106e7462faa349f337f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444769Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813068}
-
Patrick Noland authored
This CL encapsulates MenuButton animations behind its coordinator. This is accomplished in two different ways. The url focus animation uses new, property model-targeting Animators instead of operating directly on the view. The TabSwitcher animation is effectively just moved to the coordinator, enabled by moving translateCanvasToView to ViewUtils. Bug: 1086676 Change-Id: I0da3feba45aa009ceff9fad1113d90ef314fcc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414768 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#813067}
-
Matt Falkenhagen authored
The comment referred to deprecated_has_html_body_ which was removed in r567510. Change-Id: I62b8c521b70ed1b9121256338a7db5714d84359c Bug: 794073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444630 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#813066}
-
Vincent Boisselle authored
Bug: 1131172 Change-Id: I2dcca0a7dcecabdd3b8a527e6af4de3f1481dae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443691 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#813065}
-
Kent Tamura authored
- 'Layout' in some items were redundant - Remove unused kLayoutObjectLayoutInline and kLayoutObjectLayoutEmbeddedContent - kLayoutObjectTextArea and kLayoutObjectTextField were not matched to C++ class names. This CL has no behavior changes. Change-Id: Iff8c84234cd264340074d474ba069f605b3e657a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444670 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#813064}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I9b20a18690f4cf3c7b0b58cdf88ba798e4800d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444534Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813063}
-
David Bokan authored
This is a big "many-cases-in-one" test that takes several seconds to run. It appears to occasionally timeout when run as part of web tests. This adds the test to SlowTests. Bug: 1133836 Change-Id: I5a6408ac69228f50e35eb6ec63bd84bc95554dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443542Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813062}
-
Hyunjune authored
When image contained mask is loading, it touches a mask flag called |computed_invalidation_mask_|. Because |MarkForLayoutAndParentResourceInvalidation| is called in |ImageChanged| without layout while loading, so this flag would be changed without clear. And this flag is used in the next layout. Actually this mask can not apply to client element in next time. This patch clears the mask flag in pre-paint time. Bug: 1086070 Change-Id: I55a7a16faafe4eeefac88e8e15e6d3b18b097acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432151Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#813061}
-
Alan Cutter authored
This CL updates our preinstalled web app replacement flow to disable the web app if the Chrome app it's meant to replace has been disabled by admin policy. This is to prevent default apps appearing on enterprise devices during web app migration when they were originally being blocked as Chrome apps. Bug: 1131338 Change-Id: I44a5d0c3c9b547c28a5c3b664e53844335ab3da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425549 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
