GitLab

This callback interface will replace the NOTIFICATION_GOOGLE_URL_UPDATED
notification once all clients have been converted. This CL converts
TemplateURLService and SearchProviderInstallData.

BUG=373236,373254,373258,373260,373253
TBR=brettw

Review URL: https://codereview.chromium.org/287103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271257 0039d316-1c4b-4281-b951-d872f2087c98

Instead of requiring every BPF policy to check IsValidSyscallNumber()
and return a fixed value when it's true, provide an alternative entry
point and guarantee that EvaluateSyscall() will only be called for
valid syscall numbers.

Review URL: https://codereview.chromium.org/293463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374349

Review URL: https://codereview.chromium.org/292593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271255 0039d316-1c4b-4281-b951-d872f2087c98

This cl depends on https://codereview.chromium.org/261753008

BUG=358657

Review URL: https://codereview.chromium.org/274743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271254 0039d316-1c4b-4281-b951-d872f2087c98

The resource data is put into an in-memory instance of a net::DiskCache for now. That cache will be used for (some) subsequent starts of the worker in the current browsing session, but will not be used across browser restarts. The next step is to have the registration job store the resource ids with the registration data on disk and to also put the resource data to disk.

BUG=364318

Review URL: https://codereview.chromium.org/269373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:371878
TEST=verified with pepper plugin manually

Review URL: https://codereview.chromium.org/284853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271252 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371039

Review URL: https://codereview.chromium.org/275503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271251 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374011,374011

Review URL: https://codereview.chromium.org/290693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271250 0039d316-1c4b-4281-b951-d872f2087c98

Mimic [Desktop]NativeWidgetAura::OnWindowActivated.
Simplify OnNativeBlur calls and OnNative[Blur|Focus] impls.
(View focus changes update the TextInputClient as needed)
Rewrite and enable related ConstrainedWindowViewTests.

Print GetLastError() in SendInput() error case for tests.
(key presses get 5/ERROR_ACCESS_DENIED on locked desktops?)

BUG=368691,170331,177482,163931
TEST=Automated tests; the focused Views change as expected between the browser, web contents, and web content modal dialogs (print preview, collected cookies, etc.).
R=sky@chromium.org

Review URL: https://codereview.chromium.org/282223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271249 0039d316-1c4b-4281-b951-d872f2087c98

These were missing from http://crrev.com/285343004, which added  two
new fields to AutocompleteMatch.

BUG=370192
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/290693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271248 0039d316-1c4b-4281-b951-d872f2087c98

This is mainly to prove my working env., but the bugs are real.

Thanks!

Review URL: https://codereview.chromium.org/288223006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271247 0039d316-1c4b-4281-b951-d872f2087c98

from disabled to enabled.



BUG=

Review URL: https://codereview.chromium.org/272213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271246 0039d316-1c4b-4281-b951-d872f2087c98

I'm doing this to avoid a gargantuan patch (see
https://codereview.chromium.org/273073002/ for how out of control
everything is right now).

BUG=none
TEST=none
R=piman@chromium.org

Review URL: https://codereview.chromium.org/285373012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271245 0039d316-1c4b-4281-b951-d872f2087c98

This patch in JSON Schema Compiler first generates a vector with
strings of the enum array using the correct ToString() function
of both inline and referenced enums. Then the result is created
from the vector of strings.

R=kalman@chromium.org
BUG=371808,368368

Review URL: https://codereview.chromium.org/276603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374558
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/293523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271243 0039d316-1c4b-4281-b951-d872f2087c98

The icon was not aligned with the location icon decoration, which means that when
the chip was clicked, it would move two pixels to the right, which looked weird.

BUG=364119
R=shess@chromium.org

Review URL: https://codereview.chromium.org/286263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271242 0039d316-1c4b-4281-b951-d872f2087c98

Also update tests to match.

BUG=None
TEST=trybots
R=binji@chromium.org

Review URL: https://codereview.chromium.org/286303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271241 0039d316-1c4b-4281-b951-d872f2087c98

Actually we do not call WebContentsImpl::RenderViewCreated() when we care child window.
It makes many issues such as addJavascriptInterface() is not working well in child window.

BUG=361418
TEST=WebContentsImplBrowserTest.RenderViewCreatedForChildWindow

Review URL: https://codereview.chromium.org/196283013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271240 0039d316-1c4b-4281-b951-d872f2087c98

We already had tests for <ul>, <ol>, and <dl>, but not for
<div role="list">, but it seems simplest to just always return a subrole
of AXContentList by default and AXDescriptionList only for <dl>, since
VoiceOver gets confused if it isn't one of those two.

BUG=373498

Review URL: https://codereview.chromium.org/284113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271239 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374273
R=msw@chromium.org

Review URL: https://codereview.chromium.org/287243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271238 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271237 0039d316-1c4b-4281-b951-d872f2087c98

Pull prototype change for libvpx:
https://codereview.chromium.org/290613006

Fix for webviw builds:
https://codereview.chromium.org/288293002

Re-enable arm64 builds:
https://codereview.chromium.org/290653003

R=tomfinegan@chromium.org, tomfinegan@google.com

Review URL: https://codereview.chromium.org/292503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271236 0039d316-1c4b-4281-b951-d872f2087c98

This is controllable by a command line switch "enable_gdi_user32_renderer_lockdown" at the moment.
Defaults to not being set.

BUG=365160

Review URL: https://codereview.chromium.org/282133007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271235 0039d316-1c4b-4281-b951-d872f2087c98

Remove didActivate/didDeactivateCompositor from everywhere that calls it
as it now does nothing.

BUG=none

Review URL: https://codereview.chromium.org/288633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271234 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370192
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/289043007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271233 0039d316-1c4b-4281-b951-d872f2087c98

Do not prevent accelerator handling by read only textfields.

BUG=374006
TEST=Backspace navigates back on when a popup omnibox or cookies dialog textfield is focused.
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/289183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271232 0039d316-1c4b-4281-b951-d872f2087c98

Tests for UpdateVersionToActive() and UpdateLastCheckTime() are missing.


BUG=n/a
TEST=content_unittest --gtest_filter=ServiceWorkerDatabaseTest.*

Review URL: https://codereview.chromium.org/290133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271231 0039d316-1c4b-4281-b951-d872f2087c98

modemmanager::kModemManager1 has been deprecated and replaced by
modemmanager::kModemManager1ServiceName.

See https://chromium-review.googlesource.com/#/c/199602/ for details.

BUG=None
TEST=Run chromeos_unittests.
TEST=Send a SMS to a 3G falco and check that a SMS notification is shown.
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/287193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271230 0039d316-1c4b-4281-b951-d872f2087c98

Once all pages are force composited by default, this allows these tests
to not explode when trying to create GraphicsLayers because of a lack of
Platform::compositorSupport.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270894

Review URL: https://codereview.chromium.org/287043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271229 0039d316-1c4b-4281-b951-d872f2087c98

Also fix lexer so that it recognizes "0" as an integer decimal constant
rather than octal.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/290693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271228 0039d316-1c4b-4281-b951-d872f2087c98

Previously, GestureStateListener provided a method for listening to unhandled
tap events.  Expand this to include handled taps, useful for logging general
site interaction metrics.

BUG=374335

Review URL: https://codereview.chromium.org/286243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271227 0039d316-1c4b-4281-b951-d872f2087c98

Add more unit tests to the baseline policy.

This is still highly incomplete.

BUG=368092
TBR=mdempsky
NOTRY=true

Review URL: https://codereview.chromium.org/290143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271226 0039d316-1c4b-4281-b951-d872f2087c98

This adds the same check ExtensionSettingsHandler has in its
ExtensionUninstallAccepted handler to the accepted handler for
chrome.management.uninstall.

BUG=371705

Review URL: https://codereview.chromium.org/282133008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374558
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/286323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271224 0039d316-1c4b-4281-b951-d872f2087c98

It doesn't actually give a new backing store to the browser, so it shouldn't unblock the UI thread.

BUG=

Review URL: https://codereview.chromium.org/288463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271223 0039d316-1c4b-4281-b951-d872f2087c98

For a long time (crrev.com/133053) OS==android implies:
gtest_target_type=shared_library
Cleanup the spurious conditions and obsolete TODOs.

BUG=

Review URL: https://codereview.chromium.org/278443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271222 0039d316-1c4b-4281-b951-d872f2087c98

This is because the directory was aura before it was renamed to ash.

BUG=248353
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/282163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271221 0039d316-1c4b-4281-b951-d872f2087c98

It's only tracked to update the previous navigation entry just before update.
Now that HistoryController is tracked in Chromium, just sample before updating
HistoryController.

BUG=none

Review URL: https://codereview.chromium.org/266013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271220 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271219 0039d316-1c4b-4281-b951-d872f2087c98

1) Mixed ssl_server_socket_nss.cc and ssl_client_socket_openssl.cc.
2) Moved common functions into openssl_util.cc.
3) Enabled SslServerSocketTest when USE_OPENSSL is defined.

BUG=

Review URL: https://codereview.chromium.org/274783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271218 0039d316-1c4b-4281-b951-d872f2087c98