- 15 Oct, 2019 40 commits
-
-
Collin Baker authored
This migrates callers to GetTabAlertStatesForContents(), which returns all the applicable TabAlertStates, or none at all. This also removes TabAlertState::NONE since this function will return an empty list instead. Use cases that needed TabAlertState::NONE are replaced with base::Optional<TabAlertState>. Bug: 1004983 Change-Id: I477e029c470f780abd82947ea803357634fd2a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817187 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705990}
-
Tao Bai authored
Bug: 1006418 Change-Id: I9485ecf2586ef1527bc3dbc664ce6603cfb95570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838687Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#705989}
-
Alex Turner authored
If the split cache is enabled, do not attempt to call DoomMainEntryForUrl if the network_isolation_key (NIK) is unpopulated. This previously would occur for requests in HttpCacheLookupManager, but the cache is bypassed for these requests, making the call unnecessary. When the call was made, a DCHECK was hit in GenerateCacheKey given the empty NIK. Bug: 1014077 Change-Id: I566d021d50ea7200d8d99702e382c7db932dfe44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860312Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#705988}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=skyostil@chromium.org Bug: 1007760 Change-Id: I2cc2eb477f0ade0df21c17e967065768537af950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849547 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Evan Stade authored
Use it to remove NotificationService usage from DriveIntegrationService (others to follow). See code comments for usage notes. Bug: 268984 Change-Id: I64f153def34e5d08bc3b247ed0b865037d18af69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853024 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#705986}
-
Alex Turner authored
Cross-origin prefetching is not currently supported when the split cache is enabled. This breaks the SignedExchangePrefetchBrowserTest/ SignedExchangePrefetchBrowserTest.PrefetchMainResourceSXG_CrossOrigin/0 test. We thus bypass the failing checks if split cache is enabled. Bug: 1009607 Change-Id: Iede3c1a2f71e3e4472fb5b91724a984898d5b4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838333Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
danakj authored
RIP PageProperties, we wanted you to work out. R=avi@chromium.org Bug: 419087 Change-Id: I0e38a3aff5c38d742412be1323bc13161abc11b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857159 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705984}
-
Sebastien Marchand authored
This protection should only apply to the proactive discarding scenario. Change-Id: I081422d406dce2eef2a9e56f03bce50c7038a14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857042Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#705983}
-
Friedrich Horschig authored
This CL introduces a RecyclerView and prepares the list of credentials to display more generic items (like the upcoming header element). Bug: 1012219 Change-Id: I20b8361b2a139e89a493c5292f86b7bcece1c920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857127 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#705982}
-
Chris Harrelson authored
Bug: 650768 Change-Id: I729e848121638b23f4d13971f48a5962827f7abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861035Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b7a40213. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." 0583f458 "Fetch Metadata: split up `document` destination." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I536a3ef3e2a05cfb6d8748a68708aa31388867e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862576Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705980}
-
Richard Knoll authored
Right clicking on a link should only show the "Send link" option, even when there is selected text. We only want to show the "Copy to" option when regular text is right clicked. Bug: 1014054 Change-Id: I0c75b8b54de7259884c75edb4ff9709b4381c413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860336Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
-
Sergey Poromov authored
|is_enterprise_reporting_| is always set to 'true' and is redundant. DeviceStatusCollector is used only for enterprise reporting, consumer (child) reporting is extracted to ChildStatusCollector, so it's safe to remove this flag for simplicity and ensure that DeviceStatusCollector is initialized only for enterprise reporting. Test: Run trybots. Change-Id: I87509316e5d3c46fa186b8d322b69e3dadba7a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862679 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#705978}
-
henrika authored
Bug: 1014443 Change-Id: I3ab6f06669484e6c76573cd671f09f10d6e29401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862682Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#705977}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib4b45fca6ae1401697c9cd427e987a0f9d6376d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862697Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705976}
-
Peter Boström authored
Replaces OnBoundsChanged override for ColorPickerElementView. Bug: chromium:1007546 Change-Id: Iefe2e8f035cfbe83778ebd05df562ca5aaf33c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859586 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705975}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8718afb283b7..ac0a4cbbd850 git log 8718afb283b7..ac0a4cbbd850 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 nisse@webrtc.org Reland "Fix GetStats bytesSent/Received, wireup headerBytesSent/Received" 2019-10-15 philipel@webrtc.org Updated VideoStreamEncoder to destroy encoder_queue_ before encoder_switch_experiment_. 2019-10-15 sprang@webrtc.org Revert "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const" Created with: gclient setdep -r src/third_party/webrtc@ac0a4cbbd850 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: I7f40da734ca52ec7e8e244237b80ff24ad3557db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862620Reviewed-by:
-
Peter Boström authored
Removes updates to the highlight path done on every Layout() call. Bug: chromium:1007546 Change-Id: Ia179a182c39ada394e1076eae25f374922a1d2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861125 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Peter Boström authored
Replaces OnBoundsChanged override which resulted in a lot of path generation (per-tab + frame) while opening new tabs or resizing the window. Also removes a ::GetInkDropMask() override which just generated the same path. Bug: chromium:1007546 Change-Id: I0131f9a589c1525e2c0eacd61c9fcd9f6ac05948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861016 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Peter Boström authored
Replaces probably a significant amount of path updates in ::OnBoundsChanged override (which this change also removes). This might reduce some jank in the tab strip while opening tabs or resizing windows, though it's unclear whether it amounts to a significant chunk of work as a fraction of total work here. Bug: chromium:1007546 Change-Id: I5aab0ce9cfcaeea2bec80f994d0586e588ff977e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861044 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Jit Yao Yap authored
Use a SessionStateWaiter instead of checking the SessionState directly as the check might be racy. Bug: 1014239 Change-Id: I521b3ba0c2247603fc7ff5dc2bb31eaa9a2f2a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862676Reviewed-by:
-
dalyk authored
Bug: 1012268, 963480 Change-Id: I3f2d72fdc6748088e6af2da0f4d31c70a89ad891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849992 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#705969}
-
Philip Rogers authored
This patch reverts https://crrev.com/563452 which is causing crashes due to not marking the paint layer as needing repaint (see new testcase). The inline outline painting code was re-designed in https://crrev.com/591748 to not paint from the container, so this invalidation codepath is no longer needed. The original test for https://crrev.com/563452 is no longer crashing. Bug: 1011699 Change-Id: I42af2ffd3a5a3425fc2acaf0771a992f09adde57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859831 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#705968}
-
Christian Biesinger authored
Running git is fairly slow. Removing this call improves gdb attach time from 34 sec to 27 sec (20.5%). It is also completely unnecessary, because we only need to load pretty printers once. R=thomasanderson@chromium.org Change-Id: I47de8cf198040d46dfdcaa22cc6c3f7d661d28ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863069 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#705967}
-
Kevin Ellis authored
PlayStateUpdateScope is problematic for handling timing of finished promises in addition to not conforming with the algorithm outlined in the web-animations spec. This patch removes several uses of PlayStateUpdateScope and refines handling of pending flags. Bug: 960944 Change-Id: I093a3aa86084adfbe128a5aedd36206d67dd12c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851927 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#705966}
-
Raphael Kubo da Costa authored
Follow-up to commit 1b7e6d75 ("ui/display: extend EdidParser for HDR metadata") to fix the build with libstdc++ (and maybe MSVC): ./../../ui/display/util/edid_parser.cc:416:22: error: no template named 'bitset' in namespace 'std' const std::bitset<kMaxNumColorimetryEntries> ~~~~~^ ./../../ui/display/util/edid_parser.cc:430:22: error: no template named 'bitset' in namespace 'std' const std::bitset<kMaxNumHDRStaticMedatataEntries> ~~~~~^ Bug: 957519, 1012846 Change-Id: Ic3c9c9416ac446bde9f190b9575ef1a386aa8e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862917 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#705965}
-
behdad authored
This CL reports the latency in case of no begin main frame. This can happen in any of the scenarios below: 1) WillBeginImplFrame -> DidFinishImplFrame -> DidSubmitCompositorFrame 2) WillBeginImplFrame -> WillBeginMainFrame -> BeginMainFrameAborted -> DidFinishImplFrame -> DidSubmitCompositorFrame 3) WillBeginImplFrame -> WillBeginMainFrame -> DidFinishImplFrame -> BeginMainFrameAborted -> DidSubmitCompositorFrame In these cases there will be no latency to report for stages of: - SendBeginMainFrameToCommit - Commit - EndCommitToActivation But the latency will be reported for the remaining stages. Bug: chromium:1003038 Change-Id: Id0d6a65603b2b15a0ee04a6974a4bd0b2a5a803b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799026 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#705964}
-
Himanshu Jaju authored
All usages of session_name have been renamed to client_name in components/sync_device_info/ for consistency. Bug: 1014439 Change-Id: Ie620281d81a938d83afbe4ede6dc503c4a0a7b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862910 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#705963}
-
Tommy Steimel authored
Bug: 1013757 Change-Id: I433871cd0b57b8c645ad60ac47bc69486b9eea92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857539 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#705962}
-
Peter Kasting authored
Bug: 82078 Change-Id: Ie8c47fe9839e499a6fbd7f91a0791689e6333f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861954 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705961}
-
Francois Doray authored
This experiment enables: - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of background threads. This affects memory and IO priority in addition to CPU priority. - Increase thread priority to "normal" in scopes where background threads load modules. The expectation is that this will improve responsiveness of Chrome (input delay, first contentful paint), without regressing jank. We are adding the testing config in preparation for enabling this via Finch in M79. Bug: 973868 Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#705960}
-
Christian Dullweber authored
Replace shield with an eye. https://screenshot.googleplex.com/MMf2t0rPZ0b.png Bug: 967668 Change-Id: Ic128c96254f4ffe6796f1122e99d12bf753e34d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863012Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#705959}
-
Julie Jeongeun Kim authored
This CL converts ProxyConfigClient to new Mojo types using PendingReceiver, PendingRemote, Remote, Receiver and RemoteSet. Bug: 955171 Change-Id: I7b261526378b4cf834ae480e6a2d1d68ce13ccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849739 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#705958}
-
Sean Harrison authored
Bug: 1014143 Change-Id: I6273867652e71c21d2dfe50b48adead7d200421c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859968Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#705957}
-
arthursonzogni authored
In RenderFrameHostManager, the speculative RenderFrameHost may be deleted by using CleanupNavigation(). The speculative RenderFrameHost may contain multiple pending NavigationRequests. When they are deleted, their matching pending NavigationEntry must be discarded. This is now done automatically in NavigationRequest's destructor by releasing the PendingEntryRef, thanks to patch: https://chromium-review.googlesource.com/c/chromium/src/+/1815129 Bug: None. Change-Id: I5f88e5dafa5188eeab29d5c5a55b8f8306bd83d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860031 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#705956}
-
Himanshu Jaju authored
For full sync we use the PII name, but for transport only mode we use the device's model name as client name. Bug: 1009454 Change-Id: I4a31e012ad81715af91b1dcaf782a4f0466b6f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852092 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#705955}
-
Dave Tapuska authored
The mojo filter allows us to record the debug URL in a crash key. BUG=1008432 Change-Id: Id753793e900763e41fc192bd2c50b21e4e243fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852646Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#705954}
-
Jan Wilken Dörrie authored
This change adds a few list utility methods to base::Value. This change is in preparation for switching the return type of the mutable GetList() from ListStorage& to base::span<base::Value>, at which point it won't be possible anymore to remove Values using std::vector's API. Bug: 646113 Change-Id: Ia10e7f43723722e0a66794466c6ffca0fe221c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857118Reviewed-by:
-
Rodney Ding authored
- Use a mapping between runtime feature and command line switch to control the enable/disable logic for cleaner code Design docs: https://docs.google.com/document/d/1d6_NBVPXh7B2XMk3H9b_qIxeuSXq6MblVSJldN7bTBY/edit?usp=sharing Bug: 832393 Change-Id: I67c944e1d20d5c0d9ab871f87641cb6ea46fb8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822864 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#705952}
-
Christian Dullweber authored
The UI would get updated twice when cookie blocking was enabled for a specific site. Avoid this unnecessary step by not stepping through state updates separately. Bug: 967668 Change-Id: I9d6c836031dc9ef7adf1a4888b6e8c8483c22ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862693 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
