- 13 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc958e0e8703..31e5a5d45d5d 2020-08-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 13f04d59c727 to cda86eff6461 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ibf2dfcc6eae2f3d8e1a511fb1337062c91afaffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797643}
-
Monica Basta authored
This CL adds the 'Customize' button. On click, the user will be directed to manage profile settings sub page for the selected profile. Bug: 1063856 Change-Id: I0b85f01e9efe0a2fb9a2ca20885147d48b83a3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353249Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#797642}
-
Dylan Cutler authored
participation. Bug: 973801 Change-Id: Ic5e2c7f2118c10dc2b277ad032a282f59741e6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353110Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#797641}
-
Matt Wolenetz authored
Improves MediaSourceRegistry code readability by DCHECKing in its URLRegistry overrides and in its LookupMediaSource interface that the KURL |url| in the former, and the wtf::String |url| in the latter are not empty (or null). The former is prevented by the FILE API PublicUrlManager already, and the latter is now (by this change) protected against in MediaSourceAttachment::LookupMediaSource(). This is a follow-up on a review comment in an MSE-in-Worker CL: https://chromium-review.googlesource.com/c/chromium/src/+/2300804/7/third_party/blink/renderer/modules/mediasource/media_source_registry_impl.cc#74 BUG=878133 Change-Id: I2ef93b8d3fc894ee71b1a605acdc58df88e722d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346797 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#797640}
-
Robbie Gibson authored
On iOS 14, using pasteboard.string triggers a notification saying that the app pasted. There is a better property hasStrings that doesn't trigger this notification. It is also the recommended way from Apple to check if the pasteboard contains any strings. Bug: 1110848 Change-Id: Ia892c76ee17d5230582e8907db927ad3a27e82b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351832Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#797639}
-
Eric Sum authored
See internal buganizer bug for context. Bug: internal b/163291366 Test: Build locally. Change-Id: Iac091d9a0cd9d4c39e22b51a1d89a442536e9909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345723Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Eric Sum <esum@chromium.org> Cr-Commit-Position: refs/heads/master@{#797638}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6e1012fcb6bb6c85720af7d0a7a98e60ed3dec82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351764Reviewed-by:
-
Nohemi Fernandez authored
During the EG1 to EG2 migration a duplicate testing class was created to help expose necessary class-specific methods to EarlGrey. Now that the transition is complete we will remove the dependency to SigninEarlGreyAppInterface helper class and only expose SigninEarlGrey to client code. This patch also uses the more canonical 'verify' prefix for EarlGrey assertions. Bug: 1103274 Change-Id: I7cf71df0826068e79c8e0006744907fe36c70be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352931 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#797636}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dbee93ac203d..e1360ddcec9e 2020-08-13 simonmacm@google.com Merge "Fix O(n^2) wakelock merging in android_batt.sql." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8e839835a6eaf2834fe04d53811c47646f65eb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353484Reviewed-by:
-
Bret Sepulveda authored
This reverts commit 1523bb86. Reason for revert: ClipboardTest/TestClipboardTest.TextTest is failing on linux-lacros-tester-rel. See for example https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/944 Original change's description: > [ozone] Improved clipboard tests and de-duplicated string constants. > > This CL pays a bit of technical debt in the clipboard implementation. > > First, it updates a test that verifies that putting text into clipboard > registers the proper set of MIME types, as had been suggested in [1]. > > Second, it enables for Ozone the test that verifies selection buffers. > > Third, it de-duplicates some string constants. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2306252 > > Change-Id: I6beb6b5b3827f0ec09cf19bc1868e7955141f680 > Bug: 911992, 1105892 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346338 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Cr-Commit-Position: refs/heads/master@{#797572} TBR=sky@chromium.org,adunaev@igalia.com Change-Id: I376620331b967c70225b10d67b5e6e467802cf5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911992 Bug: 1105892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352802Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797634}
-
Peng Huang authored
Bug: 1115065 Change-Id: I45873297b649d6b229823bfab100c00fb9fbbe52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351956Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797633}
-
Carlos Caballero authored
Bug: 1111720 Change-Id: I03f07bb982b2f98ab7213cbeb50911c6affe78b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339616 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797632}
-
Hirokazu Honda authored
Bug: b:155054799 Test: video_decode_accelerator_tests test-25fps.vp9_2 --use_vd on rammus Change-Id: I53103feebd9987583eaf029320f3b490d98f7298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350719Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#797631}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Ida05281d3ce64dbafeb186fff3911304eb2e0bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352959 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797630}
-
Jan Wilken Dörrie authored
This change updates the zxcvbn data component and library to support parsing the data dictionaries on the background thread. Fixed: 1112461 Change-Id: I1b553bf448c1baf9b0a1359a853fc5360716e52a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332609Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#797629}
-
Makoto Shimazu authored
This is a follow-up CL for https://crrev.com/c/2114932. This CL lets FetchRespondWithObserver call methods of FetchEvent directly. Bug: 1039558 Change-Id: I332945e4248840cfeddb66ee5599ca18f35394e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352296 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797628}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/652124c372e5..fec8e60ea3e4 2020-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d667ad2f0127 to cc958e0e8703 (4 revisions) 2020-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7a75987d to ffe84295 (455 revisions) 2020-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 13f04d59c727 to cda86eff6461 (4 revisions) 2020-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 37f547456cc6 to 4a486be696b4 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I1c5a883206789adcf795a7f8ff957a285cf9e275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353480Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/13a65b1aee42..df859f77dab3 2020-08-12 andreperezmaselco.developer@gmail.com spirv-fuzz: Check integer and float width capabilities (#3670) 2020-08-12 andreperezmaselco.developer@gmail.com spirv-fuzz: consider additional access chain instructions (#3672) 2020-08-12 andreperezmaselco.developer@gmail.com spirv-fuzz: Ignore specialization constants (#3664) 2020-08-12 vasniktel@gmail.com Fix the bug (#3683) 2020-08-12 vasniktel@gmail.com spirv-fuzz: Fix width in FuzzerPassAddEquationInstructions (#3685) 2020-08-12 jaebaek@google.com Preserve debug info in dead-insert-elim pass (#3652) 2020-08-12 jaebaek@google.com Validate more OpenCL.DebugInfo.100 instructions (#3684) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Id932045ee512891cd5a5e39ce7810c70bc9e7ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353477Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia2e2b9be69d9434a7ea9c1c6255a104e27b522b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354030Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797625}
-
Yuki Shiino authored
This reverts commit d4f833b0. Reason for revert: Due to the revert at https://chromium-review.googlesource.com/c/chromium/src/+/2353115 Original change's description: > bind-gen: Update PerformAttributeSetCEReactionsReflect > > Ports https://crrev.com/c/2351950 to the new bindings generator. > > Bug: 839389 > Change-Id: Ia3bab7ba01b527acb550b40a7178563f70edd88d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352571 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797573} TBR=peria@chromium.org,yukishiino@chromium.org Change-Id: Ia4a96c4a26bfdba31b6b3d38f3b2ba753b95437f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352467Reviewed-by:
-
Ewann authored
Adding: - Edit folder - move folder Bug: 1093302 Change-Id: I76c82a14fdc6956d5412891a2ba7cc575100e653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349305 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#797623}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597275686-7da657e756f53f89a89030a34195741313ee681f.profdata to chrome-mac-master-1597298325-7a1b28e7d249f4f2f87ee413bc832fdaab0b39d9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If40186f00a641f8d68031d52a98b77d8537f0bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353481Reviewed-by:
-
David Roger authored
Bug: 1076880 Change-Id: Icbdb6c50e53321acd30288e0f14c9f788a46cbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352230Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797621}
-
arthursonzogni authored
Those 4 tests are consistently failing on Lollipop: org.chromium.chrome.browser.keyboard_accessory.ManualFillingUiCaptureTest #testCaptureKeyboardAccessoryV2WithPasswords #testCaptureKeyboardAccessoryV2WithPasswordsRTL #testCaptureKeyboardAccessoryWithPasswords #testCaptureKeyboardAccessoryWithPasswordsRTL TBR=fhorschig@chromium.org Bug: 1095672 Change-Id: I4017cc75b4dec74fe91ac7df4bb4ad0aab209c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352915Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#797620}
-
arthursonzogni authored
TBR=wenyufu@chromium.org Bug: 1115870 Change-Id: I7e054c247595b09f3fe83e9063065aff702a80ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352895Reviewed-by:
-
arthursonzogni authored
This test is flaky. In particular on the Marshmallow Tablet Tester: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester/b8872140678652429312 TBR=adithyas@chromium.org Bug: 1115888 Change-Id: I933c0e369d93aa343576f03c3f76af8c0ddbc82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352936Reviewed-by:
-
Antonio Sartori authored
Since the Content-Security-Policy directive `frame-ancestors` is now checked in the browser and no longer in blink, this code should be safe to remove. Bug: 1032139 Change-Id: I25faca527955b374578454ddaf9385e98898bb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351837Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#797617}
-
Arthur Sonzogni authored
This reverts commit ffd982c9. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1115915 Caused several tests to fail. Original change's description: > Move URL to CriticalPersistedTabData > > This supports the effort of moving fields to UserData objects > so Tab doesn't become too big and unwieldy. > > Bug: 1112357 > Change-Id: I6c484d9586ca8ad7d1866fbbc9dac4735ecf1470 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337673 > Commit-Queue: David Maunder <davidjm@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797555} TBR=nyquist@chromium.org,dtrainor@chromium.org,jinsukkim@chromium.org,davidjm@chromium.org Change-Id: I084d6dcb0cef11311a8d9d5f8bc26bffe6309339 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352813Reviewed-by:
-
Matthias Körber authored
Currently, "Apellido Materno" is matched as a middle name although it is actually the second last name. Change-Id: I16086145cc46e29370f313b01bae8bb6c3785203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351917Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#797615}
-
Nohemi Fernandez authored
This patch moves a generic function to the generic EarlGrey testing utilities, ChromeEarlGrey. Bug: 1103274 Change-Id: I2809712839d7cf1860408fa737a661c8e0fc34e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352930 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/62f669be69c5..86c9a7134948 2020-08-13 szuend@chromium.org Revert "Remove the previewed class when pressing Escape in the .cls pane" 2020-08-13 mathias@chromium.org Format decoded X-Client-Data HTTP header values as code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103854,chromium:1114726 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I11a0e6597e281ad1834dc8fc4a5f578c6ae2f7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353470Reviewed-by:
-
Anders Hartvoll Ruud authored
There is a desire to change how this works (again) [1], but since all browsers agree on the current behavior, we have to be careful with changes. Hence this CL adds a detailed use-counter. The behavior we want to change can be illustrated with the current example: <style> #outer { --x: foo; } #inner { --x: var(--unknown); } </style> <div id=outer> <div id=inner></div> <div> Current behavior: the computed value of --x on #inner behaves as 'unset', and hence becomes ' foo'. Desired behavior: the computed value of --x on #inner becomes the guaranteed-invalid value [2]. More generally, any property whose grammar "supports" the guaranteed- invalid value shall become guaranteed-invalid if it's invalid at computed-value time (IACVT) [3]. Properties which currently supports this are: unregistered custom properties, and registered custom properties with universal syntax. This CL avoids counting cases where the new behavior wouldn't make a difference: - If the property doesn't support <guaranteed-invalid> - If the property is non-inherited without an initial value - If the property would anyway inherit <guaranteed-invalid> [1] https://github.com/w3c/csswg-drafts/issues/5370 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value [3] https://drafts.csswg.org/css-variables/#invalid-at-computed-value-time Bug: 1110188 Change-Id: I1a230e03b59ee3490166e92e1e83586a681301a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352871 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797612}
-
Hiroshige Hayashizaki authored
In order to unify script evaluation paths in ScriptController and WorkerOrWorkletScriptController, This CL moves - ReferrerScriptInfo construction, - V8CodeCache::GetCompileOptions(), - V8ScriptRunner::CompileScript(), - V8ScriptRunner::RunCompiledScript(), and - V8CodeCache::ProduceCache() calls from - ScriptController::ExecuteScriptAndReturnValue() and - WorkerOrWorkletScriptController::EvaluateAndReturnValue() to V8ScriptRunner::CompileAndRunScript(). The base URL and ScriptFetchOptions in WorkerOrWorkletScriptController are set so that the existing behavior is preserved. Behavior changes: No changes, except that: probe::ProduceCompilationCache() will be called from WorkerOrWorkletScriptController after this CL. This was only called from ScriptController before this CL. Bug: 1111134, 1114989, 1114994 Change-Id: I989c9a7c3e221f6f2c330849325111e9e209c85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251439Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#797611}
-
Anastasiia N authored
Change-Id: Ibb33df94135add997de9238ded9772d320880b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346571Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#797610}
-
Julie Jeongeun Kim authored
This CL makes the list container handle the active descendant even though the container is not focused if it has the focused node. On the current code, the list container handles the active descendant only when it is focused. But, some web page could have a input node between a list container and list items and the focus is on the input node, not a container. So, this change checks if the focused node is a descendant of a list container and it handles the active descendant node. AX-Relnotes: n/a. Bug: 1052859 Change-Id: Ib408538d35512ea06174dcb8e3f6ef97b6781907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352293Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#797609}
-
Peter E Conn authored
Change-Id: Iac3857bf4dd252d8a97e35e3de21c03046d2e3d9 Bug: 832124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346652Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797608}
-
Andreea Bacanu authored
This patch implements the following functionality: - Adding an entry to the cache - Restoring an entry from the cache - Evicting an entry by SessionID - Getting the time to live in the cache - Getting a pointer to an entry from a given SessionID - Evicting an entry after timeout Design doc: https://docs.google.com/document/d/1SF230MYWgroe4WikDMn82ETd3-HFRzylKtIk0HZRaOU/edit?usp=sharing BUG=1100946 Change-Id: Ic1f137c255a9695df080868d217cd3fec7d18690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322967 Commit-Queue: Andreea Bacanu <aebacanu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#797607}
-
Hajime Hoshi authored
SetFirstPaintAfterBackForwardCacheRestoreSwap is called once when OnRestoredFromBackForwardCache is called once, by registering the callback. When OnRestoredFromBackForwardCache was called twice very quickly, two SetFirstPaintAfterBackForwardCacheRestoreSwap might try to set the same end of the timing vector, which was wrong update. This CL fixes this issue by specifying an index at the callback closure, instead of always updating the end of the timing vector. Bug: 1099395 Change-Id: Ic56d2c600d5f08cd7a71e4c03ac84a82a6925115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346690 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL introduces mojom::PrintManagerHost interface to print.mojom and converts PrintHostMsg_DidGetPrintedPagesCount message to DidGetPrintedPagesCount() in mojom::PrintManagerHost. Since all PrintManagers inherited from printing::PrintManager are created with WebContents, it uses WebContentsFrameReceiverSet. printing::PrintManager inherits mojom::PrintManagerHost and implements DidGetPrintedPagesCount(). PrintRenderFrameHelper in renderer process is communicated with it through Mojo for GetPrintedPagesCount. Bug: 1008939 Change-Id: I57674c2e93f042ec3daf54357e2d20663340189a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326857Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#797605}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/338597ba8c41..af63c44964ad 2020-08-13 jleconte@google.com Chrome Perf Dashboard UI links to Monorail bugs are missing project id. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: sadrul@google.com Change-Id: I02e07e2218b6aa7a806dbf08bb9f0c4f6aa9082f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353852Reviewed-by:
-
