- 11 Jul, 2019 10 commits
-
-
Antonio Gomes authored
This CL is a preparation step to Onion soup webmediaplayer_ms.cc|h and webmediaplayer_ms_compositor.cc|h It adds to blink::Platform a methods that expose SharedMainThreadContextProvider() functionality of RenderThreadImpl needed by WebMediaPlayerMS. It is part of the phase 4.4 in the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I3e6534e1a7e362da905ddd78e7e88d51adb5e6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693241 Commit-Queue: Antonio Gomes (use @igalia instead) <tonikitoo@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#676201}
-
Evan Stade authored
Bug: none Change-Id: I685d189ce5b58e8eb699d8ecece4c8985053b737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693767Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#676200}
-
Dale Curtis authored
Seems we need to repaint always when the first frame is available, not just in lazy load circumstances. This is a speculative fix, since I have not been able to reproduce the issue locally. BUG=982415,980897 R=sandersd Change-Id: I318ebb03f749fab9112a592047d1c45b77ceed12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695829 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#676199}
-
Hector Carmona authored
TBR=csharrison@chromium.org Bug: 972822 Change-Id: I0a681aa4edeffca6bad684de4ededf8e64db91aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696522Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#676198}
-
Ian Barkley-Yeung authored
ChromeOS: If the --crash_loop_before flag is present, pass its value through to crash_reporter if the program crashes. Also, pass flag down to appropriate children. BUG=chromium:857317 TEST=Ran with special session_manager that always set --crash-loop-before Confirmed flag was passed to correct children. Confirmed crash_reporter used crash loop mode if Chrome killed. Change-Id: Ifc2e911c466d1aadf057c66bfbf922d42d56359b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687108Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#676197}
-
Matt Wolenetz authored
Extended indefinitely (for support planning): Media.SRC.VideoCodec.MP4 Media.SRC.VideoCodec.WebM Extended indefinitely (for support planning), with updated owners: Media.MSE.VideoCodec.MP4 Media.MSE.VideoCodec.WebM Extends expiry to M82, with updated owners: Media.MSE.DemuxerDestructionTime Updated owners: Media.MSE.AudioCodec Media.MSE.VideoCodec This change addresses parts and related parts of each of: BUG=975898,975367,975090,974976 Change-Id: I19583d00056fb94fd81c438e157a643e08675547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693384Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676196}
-
Darwin Huang authored
Patchset 1: Tests only (fails without patchset 2) Patchset 2: Fix (tests from patchset 1 succeeds) Bug: 981006 Change-Id: I3e9ba336793334ecc1dab77521189f7695d625fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693733 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676195}
-
Eric Orth authored
Bug: 977441 Change-Id: Ic73acbb0ac0a30736c960e8e9dec813c172e8d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695812 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#676194}
-
yilkal authored
Bug: 977019 Change-Id: I6ee062635834ee34a1e68c037c53c839b63d414f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684509 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676193}
-
Takumi Fujimoto authored
Move logic from MediaRouterDialogControllerImplBase to MediaRouterDialogControllerViews, and delete the former class. Bug: 900246 Change-Id: I5216a4f7bbbbda9ea19fbed1d7dcbbd8aa32727c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691745 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676192}
-
- 10 Jul, 2019 30 commits
-
-
Yun Liu authored
The source path should start with "//": https://cs.chromium.org/chromium/infra/appengine/findit/model/proto/code_coverage.proto?q=code_coverage.pro&sq=package:chromium&g=0&l=91-92 Bug: 981020 Change-Id: I5e0119f6575332ae507652005b2979721ff23b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696446 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#676191}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a9ca4d92eba0..807023d1041b git log a9ca4d92eba0..807023d1041b --date=short --no-merges --format='%ad %ae %s' 2019-07-10 vapier@chromium.org avoid long() builtin 2019-07-10 vapier@chromium.org change xrange() to range() Created with: gclient setdep -r src/third_party/chromite@807023d1041b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ie94a29ce468550f729b1871659e294fb83b84e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676190}
-
Alex Newcomer authored
The AppList assumes that the Shelf Orientation stays the same during its lifetime. Hide the AppList when shelf orientation changes to avoid various corner cases. Bug: 961471 Change-Id: I65283cc29c8047a5af41886ce7dd3b1b644a3dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693170Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#676189}
-
Miyoung Shin authored
This CL replaces the use of std::array of std containers with WTF::Vector in source_keyed_cached_metadata_handler.h. Bug: 952716 Change-Id: Ia345560fef2b6f4546bb7c300f630ac451f9ecd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695142Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#676188}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3b07526aec55..d3f699407f75 git log 3b07526aec55..d3f699407f75 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-10 debrian@google.com Updated error message format Created with: gclient setdep -r src/third_party/depot_tools@d3f699407f75 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia3b9b94b80817ef08aa6d24325cd6bfcd10e02f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695851Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676187}
-
Geoff Lang authored
This test flakes too often for the RetryOnFailure expectation. TBR=kbr@chromium.org NOTRY=true BUG=981579 Change-Id: I1c15d8697e97547b15f5782370a9bffc15aca600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696008 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#676186}
-
Miyoung Shin authored
This CL replaces the use of std::array of std containers with WTF::Vector in css_numeric_value_type.h. Bug: 952716 Change-Id: I1c9b80963301d28d8b3d0be24f423e38cfb8e9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694964Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#676185}
-
Marijn Kruisselbrink authored
Bug: 878585 Change-Id: I3ddef2ffbe1fb4242b57fb20e80549d98a877bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696442 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#676184}
-
Siye Liu authored
TSF on Windows has an assumption that |pcchPlainRet| to be 0 if focused edit control has no text(empty). Failure to satisfy the assumption may cause hung (dead looped) in the application when using some legacy IMEs. Therefore, we should set |pcchPlainRet| to 0 if there is no text in focused edit control (|pcchPlainRet| is 0). Bug: 981667 Change-Id: I0e851e9c82e7716c5434cfd8ca93eb1a091d0b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694408 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#676183}
-
Steven Bennetts authored
Bug: 980951 Change-Id: I355cfbcbc2374ba444c362152298d4fe1d688d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696097Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676182}
-
Dale Curtis authored
This changes a few things about the ByteQueue class: - Growth is now done as std::max(size_needed, 1.25 * size_) in line with how base::circular_deque grows -- in local tests this seems to yield a significant memory savings depending on the content. - In rare cases where there's no used data, the existing allocation is released before a new one is acquired (to reduce total memory pressure). BUG=none TEST=Android bot shows ~1-3% reduction in memory. Change-Id: Iec376d61bff08fa4723129aed9edb03bb220c7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691581 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#676181}
-
Sam Maier authored
Getting rid of the SERIAL_EXECUTOR path for finch trials. Bug: 957735 Change-Id: I04577e3fe61c749b9f3bb634fa7252f2ab299a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689035Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676180}
-
Kevin Babbitt authored
For HTML accessibility testing, we've found it valuable to dump platform accessibility trees and check them against expectation files. This CL brings that capability to PDF by integrating the tree formatter into PdfExtensionTest. Further tuning of the property filters for PDF may be required in the future, but this gives us a starting point. This CL also adds functions to browser_test_utils to find a node in the accessibility tree by name and/or role. For PDF this is used to scope the dumps to the PDF itself, so that changes to the host HTML do not impact the tests. There are other examples of these find functions in content_browsertests today, but none are suitable for export. http://crbug.com/980391 is for future work to consolidate these functions. Bug: 974397 Change-Id: I0cfd2a7b456550a94a3587f36c0ee6f5d8dc4821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674498 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#676179}
-
Wei Li authored
This CL contains the following adjustments: -- Remove Chrome logo from bubble UI; -- Change bubble UI title to "Help us improve Chrome/Chromium"; -- Hide Chrome logo in survey content; -- Add auto dismiss survey dialog after two seconds; -- Change bubble to NOT close on deactivation so it won't be closed by other bubbles such as extension popup; BUG=979530 Change-Id: Ie4020d0b0f07d1cb0aa488e1cd02895542a40dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695162Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#676178}
-
James Cook authored
We decided to share a single language list between OS and browser, and to show the list in both settings pages. For consistency between the two UI surfaces, we're keeping the "Display Chrome OS in this language" item in both places. This CL eliminates pageVisibility.uiDisplayedInThisLanguage because it would always be true. Bug: 974424, 982299 Test: manual, menu item appears in browser settings after flag flip Change-Id: Icc0bf8a344038bcc73059e74e5fdab9c88306cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693388 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#676177}
-
Tommy Steimel authored
This CL relands a fix for a broken DCHECK in the MediaToolbarButtonController. This fix was accidentally removed by a bad rebase in a different CL. Bug: 973486 Change-Id: Idb8cb0a8ceb251c82a81203ac2ef37ebc90fbf50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695928Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#676176}
-
Miyoung Shin authored
This CL replaces the use of std::array of std containers with WTF::Vector in v8_context_snapshot.cc. Bug: 952716 Change-Id: I1c66d018251c06f147f7bb0ecc1f6dc724bb43eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695063Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#676175}
-
Evan Stade authored
Bug: b/136621529 Change-Id: I3c599a207e77fa588109554569b3838cdbdfe66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693035Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#676174}
-
Marijn Kruisselbrink authored
See https://storage.cloud.google.com/chromium-translation-screenshots/a4d4621b4680a1742fd3ca8366e8e1e886dfef27 for what this dialog looks like. Bug: 878585 Change-Id: I31c99e56ac4b69b5373f79992fb8179001b26dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680305 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#676173}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5cc5f6ebf601..edc9d42942af git log 5cc5f6ebf601..edc9d42942af --date=short --no-merges --format='%ad %ae %s' 2019-07-10 bikineev@chromium.org Consider foreground worker threads in V8 metrics 2019-07-10 dberris@google.com Pinpoint: Stop relying on device affinity Created with: gclient setdep -r src/third_party/catapult@edc9d42942af The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967258,chromium:948251 TBR=sadrul@google.com Change-Id: I204d1256d6f709138f06e8a843141c8d9956b5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695850Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676172}
-
Mitsuru Oshima authored
Tablet mode switch can be asynchronous when screenshot is required, hence the test code that expect synchronous change has to wait for completion. * Consolidate TabletModeObserver and TabletModeToggleObserver. TabletModeObserver is now public. * TabletMode::Waiter to wait tablet mode transition. TBR=hidehiko@chromium.org Bug: 981281, b/135956156 Test: CTS test will pass. Change-Id: Ifca472ef4cf1f74aa1e8d65b7960f3fc1b307f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691089Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#676171}
-
Meilin Wang authored
Reused string pairs: IDS_SETTINGS_GOOGLE_ASSISTANT_ENABLE_HOTWORD -> IDS_ASSISTANT_HOTWORD_TITLE IDS_SETTINGS_GOOGLE_ASSISTANT_VOICE_SETTINGS_DESCRIPTION -> IDS_ASSISTANT_VOICE_MATCH_RECORDING IDS_SETTINGS_GOOGLE_ASSISTANT_ENABLE_CONTEXT -> IDS_ASSISTANT_SCREEN_CONTEXT_TITLE IDS_SETTINGS_GOOGLE_ASSISTANT_ENABLE_CONTEXT_DESCRIPTION -> IDS_ASSISTANT_SCREEN_CONTEXT_DESC Bug: b/117182991 Test: local compile and manually test. Change-Id: I1894c6bb9292f01fd8cc72ca1ab59b0b19971d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682620Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#676170}
-
Karandeep Bhatia authored
r672618 added an early return to TestRunnerForSpecificView::SetIsolatedWorldInfo to check for an incorrect world id. This CL corrects that check. This helps prevent a CHECK failure when a fuzzer provides invalid input. BUG=977801 Change-Id: I62e53fdc2854c7e8c5c6500a765af08ba12b1635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688255 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676169}
-
Jack Steinberg authored
This partially implements the action option for showToast(), as outlined in the explainer at https://github.com/jackbsteinberg/std-toast/blob/32237007b068d690f39002d364367f3c097f1a97/README.md#showtoastmessage-options. For now it only handles the string or undefined cases; the Element case will be handled in a follow-up CL once the action setter is implemented. BUG=972945 Change-Id: I82556801a6586c89cd506669f935488e049c47c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684466 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676168}
-
Tim Song authored
Currently, clicking on this notification marks the locale change as accepted, but does not dismiss the notification. When the user interacts with the notification again, it does not work. TEST=manual BUG=937185 Change-Id: Ib510f78d6695bf2916678673a74198df605e5900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693682Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#676167}
-
Matthew Mourgos authored
This change will make it easier to switch the current constants over to the newer dense shelf constants. Bug: 973483 Change-Id: Iac32fe849ab85f2481934089a43b58bd2ef26326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694608 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#676166}
-
Dale Curtis authored
Two issues are fixed: - File was somehow muxed into an invalid configuration. - Not enough was appended to start playback. Also other tests were flaking, so: - Increased append size to 128k - Only start playback after appends complete. - Mark EOS and add ended listener since append size is small. BUG=978045 TEST=test passes Change-Id: I25dc5994044424c53198490d89d3de15f6e5c616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680956 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#676165}
-
Sam Maier authored
Even if a proguard_jar_path is set, someone must manually set use_r8 = false in their GN args to use it. Bug: 908988 Change-Id: I509db915cba46ad694b687eda8a3b0123234847c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689877Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676164}
-
Yi Xu authored
The drawing buffer is not ready when blink::WebGLRenderingContextBase::commit is called. Added additional check for drawing buffer. Bug: 976830 Change-Id: I810d5ad7c847ff5f5aa3ff850f812cfbd3dbc750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692827Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#676163}
-
Avery Musbach authored
If a user-positionable window is activated during the divider snap animation, and if this window is not already snapped in split view, then split view mode shall end. Regardless of whether the window generally can be snapped in split view, the cannot snap toast shall not appear in this workflow. Test: manual Bug: 982859 Change-Id: I743c361f59f123e02f76f35033e719a33b66cf70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695966Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#676162}
-