- 21 Sep, 2018 40 commits
- 
- 
chrome-release-bot authored# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I786751498c62b52c02e17b2eba542b0e5b8705ce Reviewed-on: https://chromium-review.googlesource.com/1237873Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#593063} 
- 
Christian Biesinger authoredAlso mark NGInlineBoxState as not heap allocated. R=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0c605c6123cab202190e9415cc9cb9a81d0cd832 Reviewed-on: https://chromium-review.googlesource.com/1237237 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#593062} 
- 
Aldo Culquicondor authoredThis wrapper allows to use the same macros for GL commands. They will make use of native GL or the command buffer, depending on the platform. Windows is the first platform to use the command buffer. All vr targets build for all platforms, but they fail to run on Windows, due to missing dependencies. These will be added in a followup CL. For now, disable the tests from the trybots. Bug: 884256 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8802ea37a82cd29d4356e7d4601952077d20dd4a Reviewed-on: https://chromium-review.googlesource.com/1226028Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#593061} 
- 
Yiming Zhou authoredBug: 847905 Change-Id: Ic8da3d3d2214a06cf0cc8a180d66a81fbc89ed90 Reviewed-on: https://chromium-review.googlesource.com/1214208 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#593060} 
- 
yoshiki iguchi authoredThere was the bug that a toast didn't get hidden if it was removed just after unlocking the screen. This bug had been introduced by http://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda. Toast changes the window container which it belongs to referring the current device lock status: locked or unlocked, because chrome os has different window containers for locked and unlocked desktop. That commit had changed the timing of changing the window container and that had caused the bug. We had the code not to hide a toast on animation, but that change had added an animation on the changing. This CL removes the code, since it is no longer necessary because the change timing was changed. Bug: 887800 Test: manual Change-Id: I2942227af9bc9eebb8c5881920341f25d68e91d5 Reviewed-on: https://chromium-review.googlesource.com/1235513 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#593059} 
- 
Scott Chen authoredThis CL adds a very basic landing page for the NUX onboarding experience. To test this CL, add --enable-features=NuxOnboardingForceEnabled. Current progress screenshot: https://imgur.com/a/2OBLbyq There will be follow-up CLs to make it look more like the mocks, as well as add other views for NUX. Bug: 874142 Change-Id: Ie643def26d657fadfbbf556dd03df7cddf5976cc Reviewed-on: https://chromium-review.googlesource.com/1235114 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#593058} 
- 
chromium-internal-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c9d5d0fbbbc..38801cf97996 Created with: gclient setdep -r src-internal@38801cf97996 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I984ca0dd421f33bff7622d9c18d9d380bc02c77b Reviewed-on: https://chromium-review.googlesource.com/1237477Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593057} 
- 
Joel Hockey authoredThis will be used at least in tast tests where the UI is used to uninstall crostini, but the test must wait until uninstall completes and receives result. Bug: 849438 Change-Id: Ia44dfa80cae957082bc1641bc5540f69b0ba3b40 Reviewed-on: https://chromium-review.googlesource.com/1236616Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#593056} 
- 
chromium-autoroll authoredhttps://chromium.googlesource.com/angle/angle.git/+log/4ce287e04201..a977acc85769 git log 4ce287e04201..a977acc85769 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 jiawei.shao@intel.com ES31: Support translating textureGather into HLSL - Part I Created with: gclient setdep -r src/third_party/angle@a977acc85769 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ieaabd8a9d295b36b5d49fca6a350576218c5267d Reviewed-on: https://chromium-review.googlesource.com/1237474Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593055} 
- 
Han Leon authoredAfter https://chromium-review.googlesource.com/c/chromium/src/+/1214709, now we send {FocusClient, NavigateClient, OpenPaymentHandlerWindow, OpenWindowForClients} Mojo messages from within Blink, no longer need blink::NavigateClientCallback (subclass of WebServiceWorkerClientCallbacks) to help cross the boundary of Content and Blink. This CL removes blink::NavigateClientCallback then removes the parent class WebServiceWorkerClientCallbacks completely. BUG=879019 Change-Id: I0643b7439d1a07ca2a3296f3327440d306cf0c2f Reviewed-on: https://chromium-review.googlesource.com/1227619Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#593054} 
- 
gogerald authoredBug: 806868 Change-Id: I1325c8eaa46460ff93f2750d9ba600bf7b9fcda8 Reviewed-on: https://chromium-review.googlesource.com/1236923 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593053} 
- 
Matthew Denton authoredAdded EngageNamespaceSandboxIfPossible in order to prevent EngageNamespaceSandbox from failing on systems that don't support unprivileged user namespaces. Also modifies the network sandbox to call this function instead of EngageNamespaceSandbox to prevent crashes in the linked bug. > # build setuid sandbox and make chrome use network service > sudo bash -c "echo 0 > /proc/sys/kernel/unprivileged_userns_clone" > out/Debug/chrome # crashes before patch, not after Bug: 881844 Test: Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I66573d978d67fa65eaec646a4044b50030f20c89 Reviewed-on: https://chromium-review.googlesource.com/1223335 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#593052} 
- 
Tarun Bansal authoredServicify Network Quality Estimator (NQE) in content. This CL replaces NQE APIs by Network Quality Tracker (NQT). The latter works with network servicification enabled as well. The NQE/NQT APIs in content are used to send network quality change notifications to the renderer process. These are eventually consumed by Blink as well as exposed to Web via NetInfo. This CL also adds a Chrome browser test for the NetInfo API. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib8c0f9b1742d3c1eb3dbefe8d891c06c4e986492 Bug: 883010 Reviewed-on: https://chromium-review.googlesource.com/1214603Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593051} 
- 
rbpotter authoredBug: 887632 Change-Id: Id61d1c09b93b7c3e7281edabac71b3c3808286d5 Reviewed-on: https://chromium-review.googlesource.com/1237245 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593050} 
- 
chromium-autoroll authoredhttps://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e301cfffe7f..92df4e63abbe git log 7e301cfffe7f..92df4e63abbe --date=short --no-merges --format='%ad %ae %s' 2018-09-21 nodir@chromium.org Revert "[gclient] Use canonical URLs in solutions" Created with: gclient setdep -r src/third_party/depot_tools@92df4e63abbe The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877161 TBR=agable@chromium.org Change-Id: I3b1defe71f7dadcec0a362b2d4b8cd4b36378896 Reviewed-on: https://chromium-review.googlesource.com/1237475Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593049} 
- 
Jeremy Klein authoredCurrently the feedback dialog offers to let users include HCI logs in feedback when "Bluetooth" or other related keywords are included in the description. This change adds Smart Lock and Tether(ing) to that potential list of related keywords. This should let us get much more useful logs for errors related to these features. R=rkc@chromium.com Bug: None Change-Id: Ie70cdd2f1d29e9f4fa6cb823d2ac806e386d4975 Reviewed-on: https://chromium-review.googlesource.com/1237391Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#593048} 
- 
Kenneth Russell authoredBug: 887751 Change-Id: Ia615c546c4550ac8e5535a6becf3dce1601bef18 Reviewed-on: https://chromium-review.googlesource.com/1237557Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#593047} 
- 
chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/32f12aca36e0..7ea977bc5e41 git log 32f12aca36e0..7ea977bc5e41 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 mtklein@google.com Reland "always optimize third_party code" 2018-09-20 mtklein@google.com Revert "have SkConvertPixels use SkColorSpaceXformSteps" Created with: gclient setdep -r src/third_party/skia@7ea977bc5e41 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I8089b1abe80e2803183cd69fdfcf80920f66f4e1 Reviewed-on: https://chromium-review.googlesource.com/1236471Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593046} 
- 
Joshua Peraza authoredBug: crashpad:30 Change-Id: I433eba2e734244dd80d9becae84789fd406de25d Reviewed-on: https://chromium-review.googlesource.com/1202703Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#593045} 
- 
Chris Hall authoredBefore this change the text of the toast was being read out using IronA11yAnnounce, but the button text ("Undo") was not read out. IronA11yANnounce was also quite low priority, so it would usually be read after the other details on the page. This change will cause the button text to also be read out, as well as increasing the priority of reading the toast message. BUG=856209 Change-Id: If0dfeb757a2bec5b7a96cc09b1d9e7439dbd529c Reviewed-on: https://chromium-review.googlesource.com/1229879Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#593044} 
- 
Adam Rice authoredThe call to PostTask() which is used to make objects created from bindings code traceable before the constructor returns can fail if the runner is in the process of shutting down. Correctly handle failure. In the case of TextEncoderStream and TextDecoderStream, failure is handled by making the constructor throw. In the case of BodyStreamBuffer, the stream is marked as broken. Also consolidate the three copies of the RetainWrapperUntilV8WrapperGetReturnedToV8() method into a single RetainWrapperDuringConstruction() function. BUG=882599 Change-Id: I056b85cc980785c0df3a946a272937c9928f31ee Reviewed-on: https://chromium-review.googlesource.com/1235359Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#593043} 
- 
Jun Mukai authoredThis CL fixes a part of UI tests of TabDragController. - some cases RootWindow is wanted to set/clear/check the window properties when Mash is enabled, those test expectations should be fixed. - some tests expect Ash style organization of window, checking root window pointer to exist in a particular display. Unfortunately some of this isn't fully fixed due to an issue of crbug.com/885312 - BrowserFrameMash's change is needed for IsWindowPositionManaged() which is called on some test cases. This is basically what BrowserFrameAsh does. BUG=885312 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: Ic2e76a7e25d5104b32a3449fb45f047deab4b0dd Reviewed-on: https://chromium-review.googlesource.com/1232685 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593042} 
- 
Tom Anderson authoredAlso fixes a logic error in opaque_browser_frame_view_layout.cc introduced by e831694a. BUG=882854,887598 R=pkasting CC=iclelland Change-Id: I5b1b6eb4d737ecbed3102d046b06cacdef7cddaa Reviewed-on: https://chromium-review.googlesource.com/1236267 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#593041} 
- 
Ben Pastene authoredWe're planning on adding more non-gtest tests. The cleanup here will make that simpler/easier. Bug: 876587 Change-Id: Ie23bd9ed1e38a3dc9df90a087cd8637557683c8a Reviewed-on: https://chromium-review.googlesource.com/1227148Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#593040} 
- 
Tom Anderson authoredRegressed after 9c5131ad. This caused the menu background to always render white even though the text colors would still be styled using the system theme. This caused illegible text when the menu background was supposed to be dark. R=pkasting TBR=sky Change-Id: I39b836e0941cbfc033515fe3891ecd42d89d73a4 Reviewed-on: https://chromium-review.googlesource.com/1237519Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#593039} 
- 
John Abd-El-Malek authoredBug: 887680 Change-Id: I249e640a559e550b879370f2f02d2437e52ac93b Reviewed-on: https://chromium-review.googlesource.com/1236282 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593038} 
- 
Alexey Kozyatinskiy authored..otherwise we ignore connection event when we paused at shared worker initialization. This bug was introduced by workers refactoring [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1205802 R=dgozman@chromium.org Bug: chromium:775132 Change-Id: I1d7c68d0c6339eaae4bd74c7a1953273f5ce8f2b Reviewed-on: https://chromium-review.googlesource.com/1237249 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#593037} 
- 
Doug Turner authoredThis CL protects calling Sign() on a private key that is null. The key can become null in two cases. The first case is if |network_service_client_| is null during OnCertificateRequested(). The second case is if HandleSSLPrivateKeyError() is called. In both cases, after this CL, if |ssl_private_key_| is null, we just call the sign callback with net::ERR_SSL_CLIENT_AUTH_CERT_NO_PRIVATE_KEY. Bug: 887539 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I0e2563f00d73ff0659786e85a041567ceeaaea48 Reviewed-on: https://chromium-review.googlesource.com/1237396Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#593036} 
- 
Josh Nohle authoredBecause DeviceReenroller is a DeviceSyncClient::Observer, it should remove itself as an observer in the destructor. Bug: 887557, 887758 Change-Id: I318ee3a3a9f3b7df6cef1bfb362049a6687b9436 Reviewed-on: https://chromium-review.googlesource.com/1237536 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#593035} 
- 
Miguel Casas authoredThis CL renames the file hosting CanvasResourceDispatcherTest, to comply with the class (and functionality) inside. s/offscreen_canvas_frame_dispatcher_test.cc/canvas_resource_dispatcher_test.cc/ Stumbled upon this mismatch during crrev.com/c/1228859. Bug: 878801 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib653677f7994de4f0e0178df3a7403a70abd1b99 Reviewed-on: https://chromium-review.googlesource.com/1237180Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#593034} 
- 
siyua authoredThis CL changes the layout of local card migration according to the mock: go/autofill-paradise 1) Change title label view layout. 2) Change the width of content_container top / bottom border to 0 3) Adjust image bottom border Uploaded a new screenshot in bug. Bug: 852904 Change-Id: I1bf1a1745ac6cbd579da4f680a9552ac159b4ddc Reviewed-on: https://chromium-review.googlesource.com/1208936Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#593033} 
- 
Clark DuVall authoredSimpleIndex uses an ApplicationStatusListener to know when to write the cache to disk. This is used in the network service, and when network service is run out of process, this causes a crash since ApplicationStatusListener should only be used from the main process. To fix this, I changed ApplicationStatusListener to have a SetCallback interface, that can then have an implementation in the network service. If the cache is being created in the network service, we can pass the network service implementation of ApplicationStatusListener. The NetworkServiceClient will then notify network service of status changes from the main process. Bug: 881572 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1824e8e8c13f4294fd3a500545714c13a90db08b Reviewed-on: https://chromium-review.googlesource.com/1225606Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#593032} 
- 
Kevin Strohbehn authoredDrag closed from FULLSCREEN_SEARCH Drag closed from HALF_SEARCH Drag closed from PEEKING Drag closed from FULLSCREEN_ALL_APPS Bug: 885909 Change-Id: Ia13a5da2fefa408bc440d663f83763c93a80fc80 Test: Manually tested scenarios: Reviewed-on: https://chromium-review.googlesource.com/1237395 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593031} 
- 
Min Qin authoredThis CL makes OfflineItemModel inherit from DownloadUIModel Bug: 881499 Change-Id: Ic7591f5ce7f5f5243cfeb8ff89ad1e77aa1b78db Reviewed-on: https://chromium-review.googlesource.com/1237134 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593030} 
- 
Dmitry Gozman authoredThe main reason is alignment between start and commit navigation paths, so that we can later call CommitNavigation directly from StartNavigation. As a side effect, this patch also ensures that we consume the activation for any navigation attempt, even if is was ignored due to frame detach or some other reason. Bug: 855189 Change-Id: Ib705c0f20d567341d88e0fc3097ebc4246dcfeff Reviewed-on: https://chromium-review.googlesource.com/1232200 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#593029} 
- 
Jun Choi authoredImplement FidoBlePairingDelegate which handles a) Caching BLE Pin code when user inputs the pin code via WebAuthN UI. b) Handling logic of BluetoothDevice::RequestPinCode() and BluetoothDevice::RequestPasskey(). Bug: 877344 Change-Id: I10585c98ad9517b168824119ff2f50a67ff8f0c6 Reviewed-on: https://chromium-review.googlesource.com/1228777 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#593028} 
- 
chromium-autoroll authoredhttps://chromium.googlesource.com/chromiumos/chromite.git/+log/6dd0074561b7..cae258d6b7d4 git log 6dd0074561b7..cae258d6b7d4 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@cae258d6b7d4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I703b62628bc17c4c92c98df2a7f6d0220fec6c92 Reviewed-on: https://chromium-review.googlesource.com/1236470Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593027} 
- 
chromium-internal-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/477dda58e6d7..8c9d5d0fbbbc Created with: gclient setdep -r src-internal@8c9d5d0fbbbc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6498530abdf479756afa6ad1583b60a402c4be65 Reviewed-on: https://chromium-review.googlesource.com/1237473Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593026} 
- 
Christian Fremerey authoredCurrently, failures to obtain a video capture buffer from the buffer pool are logged all in one bucket. This CL splits the failures into out of memory vs. buffer pool max count exceeded. To enable this, the CL changes the interface of media::VideoCaptureBufferPool to return a result code that breaks out failure cases instead of having a single failure path. Bug: 878943 Change-Id: I0a74a8034e936ea02a1ead26a6cb5d916e05e288 Reviewed-on: https://chromium-review.googlesource.com/1220192 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593025} 
- 
Jialiu Lin authoredErase some expired histograms (or update the expiration_date attribute). Bug: 884868,871505 Change-Id: I10241e2baad43c6960c04a7571a0ef8f9e5c68fe Reviewed-on: https://chromium-review.googlesource.com/1229499 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#593024} 
 
-