- 30 Jul, 2019 40 commits
-
-
Yutaka Hirano authored
Reject invalid use found in https://crrev.com/c/chromium/src/+/1695341/. Bug: 862184 Change-Id: I174d90bec44b8f077168a446b671a76ad38f0317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699587 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#682188}
-
rajendrant authored
Bug: 988188, 988186 Change-Id: Ie1a3638d156070ee82a39dd7669d00d64d0e0401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725244Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#682187}
-
Eric Willigers authored
The Launch Service can now be used to open a new application window. The numerous call sites of ::OpenApplication are being migrated to use the Launch Service in subsequent CL https://chromium-review.googlesource.com/c/chromium/src/+/1723794 Still to be implemented: When the BMO flag DesktopPWAsWithoutExtensions is enabled, we currently do not notify SiteEngagementService or AppBannerSettingsHelper about web application launches. Bug: 966288, 966290 Change-Id: Ia122eaa67561e3fa9b6373d4ad9e8692eb2e4f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722953 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#682186}
-
Alexey Baskakov authored
Let WebAppTest be a pure alias for ChromeRenderViewHostTestHarness. Bug: 973324 Change-Id: Ia957fbba1fe04c6f6472357c58e5109559d3b8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724838Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#682185}
-
Sergey Ulanov authored
viz_unittests now pass on Fuchsia (with headless ozone platform), so they can be enabled on the bots. Also added --child-arg argument in the test runner, which makes it easier to pass custom arguments to the test binary. Bug: 961455 Change-Id: I923af4978658b57d4da00a68fab8fdb3449ff47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725157 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682184}
-
Rakina Zata Amni authored
No-Presubmit: true No-Tree-Checks: true No-Try: true TBR: kojii@chromium.org, eae@chromium.org Bug: 626703 Change-Id: I8bab0bfb367f047f5b76bca7cea9a6bbcbd738ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724523Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#682183}
-
Ramin Halavati authored
Annotations.xml was outdated due to some changes that are not affected in it. This spammed the commit queue. Change-Id: Id0c8edbe20614044d19023c48e7581326387a71c TBR: nicolaso@chromium.org Change-Id: Id0c8edbe20614044d19023c48e7581326387a71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724519Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#682182}
-
Shao-Chuan Lee authored
This reverts commit b8dd353f. Reason for revert: parent CL crrev.com/c/1725033 breaks betty-arcnext-chrome-pfq Original change's description: > viz: Use Build Flags to Maintain Single Overlay Candidate Type > > For each platform, we only use one overlay candidate type. Use build > flags to manage that. This also helps unify different platform's > ProcessForOverlay API. > > R=rjkroege > > Bug: 963597 > Change-Id: Icf0de8b30928cb4e7c23a3573eb46591191fb804 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664476 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680522} TBR=rjkroege@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963597, 988114 Change-Id: I0a97ba8e96bdd5abe4f6250ad2f681a23327e282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725434 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#682181}
-
Koji Ishii authored
With this patch, |CaseMap::ToLower, ToUpper| can use existing fast code path algorithms whenever possible, with or without |TextOffsetMap|. Redundant code is unified, all full Unicode case-mapping goes to |icu::CaseMap| API. The dromaeo benchmark looks neutral, noisy from positive 5.4% to negative 5.2%. https://pinpoint-dot-chromeperf.appspot.com/job/123853bf5c0000 https://pinpoint-dot-chromeperf.appspot.com/job/15cfedf0dc0000 The new |TextOffsetMap| is not used in the actual code path yet. Following patch will start using it to fix issue 926003. Bug: 926003, 985201 Change-Id: I7ff0c2335e8dc61b64b629364978ceba6c8fac96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722830 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#682180}
-
Miyoung Shin authored
This CL renames mojo to mojom and *_struct_traits.* to *_mojom_traits.* in //skia/public. *_struct_traits.* => *_mojom_traits.* skia/public/interfaces => skia/public/mojom Bug: 806965 Change-Id: I9b322799a7726149a1d685608b2e417e58107e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722837 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#682179}
-
Ting Shao authored
This fixes a failing browser test: WorkerNetworkIsolationKeyBrowserTest.ServiceWorkerMainScriptRequest when ServiceWorkerImportedScriptUpdateCheck is enabled. It's caused by missing the network isolation key for requests generated during update check. Network isolation key is used to separate requests from different contexts when accessing shared network resources like http cache. It's necessary for service worker update check. Bug: 648295 Change-Id: Id97e1e60ea2ceb7f59211dfcb6b2e32776455487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716391Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Ting Shao <ting.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#682178}
-
Adam Rice authored
In blink::WebSocketChannelImpl, send ArrayBuffer and String WebSocket messages synchronously if they are small enough to fit in the available quota. This avoids async behaviour in the common path, in preparation for running a callback when async message send completes. This is part of the implementation of WebSocketStream. See design doc: https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit#heading=h.7nki9mck5t64 BUG=983030 Change-Id: Iaa92783f2c06826da5341d73c29b968830bb83fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711334 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#682177}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bff2939b6249..105c9d507045 git log bff2939b6249..105c9d507045 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a96b79f90940..cbabea734cbd (6 commits) Created with: gclient setdep -r src/third_party/skia@105c9d507045 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: Iefc2edee086a3099b5d05a1a26e7d7601a75835e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682176}
-
Lutz Justen authored
This reverts commit 98c28cee. Reason for revert: Disabled the wrong test (Disables vs Enables). Original change's description: > [Sheriff] Disable testPaymentsIntegration... test > > Disables > org.chromium.chrome.browser.sync.ManageSyncPreferencesTest > #testPaymentsIntegrationCheckboxEnablesPaymentsIntegration > on Android. It's flaky on Nexus 5 devices. > > TBR=triploblastic@chromium.org,sahel@chromium.org > > BUG=chromium:987827 > TEST=None > > Change-Id: If5bc156d28dc19f34d6bf2cf13e10ddb2d4ff4a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722961 > Commit-Queue: Lutz Justen <ljusten@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681773} TBR=ljusten@chromium.org,sahel@chromium.org,triploblastic@chromium.org Change-Id: I14e5669f2bedfdea6d27eefc2da7c53ba8051da7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:987827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724756Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#682175}
-
Koji Ishii authored
W3C importer added platform conditions to some failures, but they are actually failing on other platfroms too; e.g., crbug.com/988932. These tests failing only on some platforms doesn't make sense, this patch removes all conditions. TBR: eae@chromium.org, futhark@chroium.org, rakina@chromium.org Bug: 988585, 988932 Change-Id: I487e7a0bcb60933d7196d972aab163137534b5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725103Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682174}
-
Christos Froussios authored
Bug: 893553 Change-Id: Ia935b7b07ad16d6b801a809d06d0a518576dc871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700222Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Auto-Submit: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#682173}
-
Alexey Baskakov authored
Move all extension-based tests into web_applications/extensions/. TBR=bsep@chromium.org Bug: 973324 Change-Id: I3a2238ad37f9d540e2970e2d3a5bb4341f3e1ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724520 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#682172}
-
Kenichi Ishibashi authored
Service workers and some worklets don't depend on WorkerClients anymore. Don't create WorkerClients for these workers/worklets. Bug: 988335 Change-Id: Ie556b1ced23c06500d86b55b062b7c4ca26375a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722944 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#682171}
-
Noel Gordon authored
CL:1535465 did not really disable this test in DEBUG, it still runs on CQ bots in DEBUG where it hits the bot time-out limit often. Disabling a test in DEBUG is a little tricky: use !defined(NDEBUG) !! Tbr: adanilo@ Bug: 944697, 936429 Change-Id: I5e6311e91d630d0ec999b624b282dcaf16ff5bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724293Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#682170}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7dec2d1c5689..34f8bd8c4850 git log 7dec2d1c5689..34f8bd8c4850 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 shaobo.yan@intel.com Dynamic Buffer Offset : OpenGL Backend Created with: gclient setdep -r src/third_party/dawn@34f8bd8c4850 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ic96b764411162e7917d99ea1fa82efac7e97a1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682169}
-
Takashi Toyoshima authored
This final patch does following cleanup. - Use uint64_t rather than int64_t in DataSource interface - Be careful for integer overflow - Remove IsValid, and just make consequent Read fail on wrong data sources - Add SetRange to FileDataSource rather than implicitly relying on seek position - FileURLLoaderFactory cleanup to utilize design changes above Bug: 983023 Change-Id: Ic58ca4445555103866187e20aed69f631e866231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712562 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#682168}
-
Ankit Kumar 🌪️ authored
This CL adds a test for validating the paragraph and heading support in PDF accessibility pipeline. A single PDF has been added which has a heading and multiple paragraphs. Bug: 981448 Change-Id: I40fe2b958e29fba2c8e0d98de254c438ad6ea248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723851Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682167} -
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Also adds snippets_interals:closure_compile to the closure_compile target so that type checks are run. Bug: 968369 Change-Id: I1af11449962172036b3f24f16e7fe9570d37ee2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717731Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#682166}
-
Rakina Zata Amni authored
TBR=lukasza@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 988938 Change-Id: Ia5dea649dd8dd15ff4af5abbcd65d60b4d0b1e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724154Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#682165}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces HandleAccessTokenFetch in OAuth2AccessTokenManagerTest to test that StartRequest checks HandleAccessTokenFetch() from |delegate_| before FetchOAuth2Token. Bug: 967598 Change-Id: I48802ef0fd0b2c353040234a2ca105b7b73cda27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722363 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682164}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cbabea734cbd..a79c2440f653 git log cbabea734cbd..a79c2440f653 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 timvp@google.com Make libEGL function pointers hidden in symbol table Created with: gclient setdep -r src/third_party/angle@a79c2440f653 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Iae098c8c0739e469189749f87eada87936f8ea38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725423Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682163}
-
inglorion authored
This reverts commit b58c0181 (crrev.com/c/1715505). Reason for revert: causes crashes in browser_tests (crbug.com/988887). Bug: 988887 Change-Id: Iacb009a129c66c905b15b4f81544d3ad25706de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725323 Auto-Submit: Bob Haarman <inglorion@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#682162}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e68b5bd4e6e9..bff2939b6249 git log e68b5bd4e6e9..bff2939b6249 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3575550a711b..e6092f3bc901 (9 commits) Created with: gclient setdep -r src/third_party/skia@bff2939b6249 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: I71cec5acf40ddc1494b8612e503336647e8edd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725298Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682161}
-
Rakina Zata Amni authored
TBR=arakeri@microsoft.com No-try: true No-presubmit: true No-Tree-Checks: true Bug: 987115 Change-Id: I4a040cb9695d4b41f20417cfb139eab51918459a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725475Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#682160}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces ClearCacheForAccount in O2ATMtest to test that ClearCacheForAccount() clears caches for the specified account and removes ClearCacheForAccount() from PO2TS since it's only used by PO2TS. So, PO2TS calls ClearCacheForAccount() through |token_manager_| instead of having a helper method. Bug: 967598 Change-Id: I0986221195b734693c8370e21f3302578511b28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715071 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682159}
-
Ricky Liang authored
When the system gets busy, it's possible for the video capture buffer pool to run out of buffers temporarily. Instead of raising an exception we should handle the case gracefully, dropping a camera frame in the worst case. Design doc: go/cros-camera:dd:zero-copy Bug: 982201 Change-Id: I23d2e45b8427bd36ea663410817e4361252823c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712844Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#682158}
-
Maksim Sisov authored
In Sway, presentation callbacks may come much earlier than we send submission callbacks. That results in unexpected crashes in GbmSurfacelessWayland, because of early presentation callbacks. Briefly, a submitted frame may not receive the submission callback and not be moved to the list waiting for presentation frames. That means GbmSurfacelessWayland::OnPresentation accesses an invalid pointer to a frame when the presentation feedback comes. Bug: 974456 Change-Id: Iae7ab57a00d06f0dde6057ed05df885239e099bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719013Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#682157}
-
Alexey Baskakov authored
We will get rid of web_applications/bookmark_apps/ directory. Drive-by: Move //chrome/browser/web_applications public_deps into just deps to unveil some GN errors. Bug: 973324 Change-Id: Ia5004f8cfa745c6ebf70f54793c823fc9624768f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725630 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#682156}
-
Rakina Zata Amni authored
TBR=finnur@chromium.org No-try: true No-presubmit: true No-Tree-Checks: true Bug: 988934 Change-Id: I095ad457e98009da560676498d8ca77acc414e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725131Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#682155}
-
Abhijeet Kandalkar authored
The primary goal of this CL is to convert usage of |functions| of interface AudioFocusManager and port dependent files to adopt new implementation. Bug: 955171 Change-Id: I2c8f269b2b36034b9ebc5beb1aef56ee3db691b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715367 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#682154}
-
Yusuke Sato authored
I'm not really working on the IME stuff these days. BUG=None TEST=None Change-Id: I37ac476be426d9f5e5b53ef819989af9976732fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725289Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#682153}
-
Gayane Petrosyan authored
This CL also updates colors in enums.xml. It is ok to update and reuse for new colors because we don't have meaningful data with previous enum anyway. screenshot: https://screenshot.googleplex.com/Ab4bvTyG9Sg.png Bug: 988198 Change-Id: Idd1dfc319f4ff67762a724244990bfe435e9b52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722150 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#682152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0fe3506d1a8..b24e912d9bae Created with: gclient setdep -r src-internal@b24e912d9bae The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id34a0345221d838688d667b73931f1d436048da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725297Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682151}
-
Miyoung Shin authored
This CL renames mojo to mojom and *_struct_traits.* to *_mojom_traits.* in //ui/gfx/range. *_struct_traits.* => *_mojom_traits.* ui/gfx/range/mojo => ui/gfx/range/mojom Bug: 806965 Change-Id: Iba3f3c48cd5bfe48fa2064f29db3c4f4837321a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722364 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#682150}
-
Maksim Sisov authored
PlatformWindow has already had SetTitle API. Thus, just plumb it and make setting a title of platform windows work in ozone builds. Bug: 988397, 988396 Change-Id: I225ff1d3def90bb0eb37b63af4d37353f344906d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722936Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#682149}
-