- 28 Aug, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d2e5f8ebe67..7096a4a9fc5b Created with: gclient setdep -r src-internal@7096a4a9fc5b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3e3e747de03376b52c34c7c3900cc848ee005b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774266Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691073}
-
Yoichi Osato authored
Because we're using mojo data pipe, which has own quota control, to transfer received data, we don't have manual one, or mojom::WebSocket.AddReceiveFlowControlQuota(). This CL does a sort of work removing the function. mojom::WebSocket.AddReceiveFlowControlQuota(quota) did 5 tasks: browser side(mainly on WebSocketChannel) 1. Trigger the first ReadFrame if renderer gets not throttled. For #1, this patch moves the trigger to mojo WebSocket.StartReceiving. 2. Trigger next ReadFrame if there is enough quota. 3. Send pending dataframes based on added quota. This patch moves task #2 and #3 to websocket.cc and datapipe itself. 4. Dropchannel if all pending frames are received by renderer when closed. Because we can care #4 w/o renderer ping back, this patch move RespondToClosingHandshake()to WebSocketChannel::ReadFrames(). renderer side(mainly on WebSocketChannelImpl) 5. Ping browser that backpressure is turned off. For task #5, this patch changes not to call the mojo but throttle datapipe reading with WebSocketHandleImpl::ConsumePendingDataFrames(). receive-arraybuffer-1MBx100.htmll?iteration=100 measurement on local build: ToT: 144 MB/s (stdev: 4.56 MB/s) Patch: 208 MB/s (stdev: 6.15 MB/s) (+44% to ToT, +41% to ReadOnlyBuffer) ReadOnlyBuffer: 147 MB/s Change-Id: I61feab06f0e3719520e6a47eea61e0322e4da01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763507 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#691072}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/568f3984..d190ff4e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad61500b224ac717136bb30467e3f54bd2159a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772211Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691071}
-
Friedrich Horschig authored
The chip view needs to react to certain state changes with changed text colors. Since the secondary label is added lazily, it needs to check for these states explicitly. Once views that are part of the hierarchy they will receive most of the state changes (e.g. a setSelected on ChipView will apply to both TextViews). For some reason, setEnabled wasn't applied to children by default but it is strictly necessary in order to automatically select the correct text appearance. Additional fix: ensure there is an appropriate disabled state color. Screenshots are in the linked bug. Bug: 989960 Change-Id: Ic63d09f22c22af485d060d03d6ba6c20ef233bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771613 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#691070}
-
Michael Starzinger authored
Bug: 244755 Change-Id: Ib1ecb888e82d99393cd15d867cae7c0f0d7ca9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769446Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#691069}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: Ifd4d32cefcc3e3c98720d20a3227a1d42af403b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774262 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#691068}
-
Edvard Thörnros authored
We now first strip the path data and then check if it's an empty string. This allows white space at the end of the string. This follows the spec. https://www.w3.org/TR/SVG11/animate.html#ValuesAttribute Bug: 429301 Change-Id: Ie77731cb0ec17b489b439953e73230650a16bcd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768771Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Edvard Thörnros <edvardt@opera.com> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#691067}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a9da772f0587..04e148570dbb git log a9da772f0587..04e148570dbb --date=short --no-merges --format='%ad %ae %s' 2019-08-28 capn@google.com Make round-robin task enqueue index thread safe 2019-08-27 bclayton@google.com Device: Migrate Renderer to Yarn 2019-08-27 bclayton@google.com Device: Don't use a global for the cluster count. 2019-08-27 bclayton@google.com Some minor code tidying. 2019-08-27 bclayton@google.com Pipeline: Use Yarn to make compute multi-threaded. 2019-08-27 bclayton@google.com Vulkan: Build a yarn::Scheduler and pass it down to the vk::Queue. 2019-08-27 bclayton@google.com vk::Queue: Lazily construct Renderers 2019-08-27 bclayton@google.com Yarn: Don't zero-initialize data in Pool<T>::Item::construct() Created with: gclient setdep -r src/third_party/swiftshader@04e148570dbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139010488,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139010488,chromium:b/139142453 Change-Id: Iceb60a95f44801f390732a1506641ace01c4e131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691066}
-
Niels Möller authored
Bug: chromium:997148 Change-Id: I1d02c0b9d8ba61f0f99457b87b5e65c0efafaad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768637Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#691065}
-
Fergal Daly authored
BUG: The problem was that when the content was entirely contained with the bounds, VisiblilityManager.#findElementBounds would return EMPTY_ELEMENT_BOUNDS (because neither the low nor high bounds intersected the content). FIX: Change the logic so that when any of the content is within the bounds we return a pair of low/high elements, snapping to the lowest/highest when the content doesn't is too small to reach the bound. Re-enabled the failing part.html test. Bug: 998356 Change-Id: I60c4f0a4e49bf9aca0d1671b61d35c1dd1da5922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772785Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#691064}
-
Darren Shen authored
TBR=engedy No-Presubmit: True No-Try: True Bug: 998405 Change-Id: I48efc4b83b9f525f641d4f290930c206c58fca89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772787Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#691063}
-
Hajime Hoshi authored
This CL fixes a known race condition. It can happen when eviction and unfreezing happen at the same time. The race condition can be resolved by reloading the page from the browser side when the page being unfrozen is not in the back-forward cache. This solution is not perfect since the user would see a flashing screen when the page is reloaded. This solution is temporary for experiments. Design Doc: https://docs.google.com/document/d/1E6efB594SqODZX5_PRxmv8eZ9YsmheqhKFg3KoDh3vs/edit?usp=sharing Bug: 980111, 989392 Change-Id: I8f3f85c8d6c87b0f071c4e8f821460cda25bff06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687878 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#691062}
-
David Staessens authored
This CL adds additional devices to the import mode blacklist used by the video_decode_accelerator(_perf)_tests. The blacklist makes sure all tests are run in allocate mode for devices not supporting import mode. The blacklist is expanded with buddy, guado and rikku. These devices support import mode for h264 and VP9, in which case the Vaapi is used. But when decoding a VP8 video V4L2 is used, and only allocate mode is supported. TEST=./video_decode_accelerator_tests test-25fps.vp8 on rikku BUG=chromium:988916 Change-Id: I5e60221b42d4746816665cb87ba8a8190942c9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772902 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#691061}
-
Darren Shen authored
TBR=mlamouri@chromium.org Bug: 520736 Change-Id: I0cb62d0313926cea9728896123b35bb0c52d2cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773006Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c9fdf2610a1d..b6bdad04c621 git log c9fdf2610a1d..b6bdad04c621 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 rmhasan@google.com [Telemetry] Avoid searching for actual browsers in browser test case unit tests Created with: gclient setdep -r src/third_party/catapult@b6bdad04c621 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:992260 Change-Id: Ia299609d6ff2f108f14316ebe596051fc0455858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774251Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iff72fcf2193043c3ce0e953c8c8ba8e854421c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774361Reviewed-by:
-
Darren Shen authored
It was already disabled for flakiness on Mac and Windows. TBR=kelvinjiang@chromium.org Bug: 299393 Change-Id: I2d888b18a24b361891cc6789ca3230c71b9308f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772784Reviewed-by:
-
Kent Tamura authored
This CL reduces estimated pre-processed size of animatable.h from 3.52MB to 1.97MB. This CL avoids unnecessary copy of a UnrestrictedDoubleOrKeyframeAnimationOptions object on animate(). Bug: 242216 Change-Id: I066c1b6e92a0fbbdd1ee141403d134a97258978b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774001 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#691056}
-
Julie Jeongeun Kim authored
This CL converts TrustedURLLoaderHeaderClientRequest, TrustedURLLoaderHeaderClientPtrInfo and TrustedURLLoaderHeaderClientPtr to new Mojo types. Bug: 955171, 978694 Change-Id: I282ceb552522adc42e8b03d64d26b1bf1c2dd5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768841 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e36b85f34d27..cd3216543d0a git log e36b85f34d27..cd3216543d0a --date=short --no-merges --format='%ad %ae %s' 2019-08-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 57ad1e1287dd..886698bc3fdd (7 commits) 2019-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 31c682b2..c96d445d (397 commits) Created with: gclient setdep -r src/third_party/skia@cd3216543d0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:None,chromium:None Change-Id: I06b588baa2feded3bc8b72cf0cf51041bf8728b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774221Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a8dc5068079..7d2e5f8ebe67 Created with: gclient setdep -r src-internal@7d2e5f8ebe67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ieefddf6855fbbaa7c96f45b7af3c5eed515c78e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768653Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f96048c9. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib24c68cae0f3b66364a8b2a05d6237809356c28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774118Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691052}
-
Jinsuk Kim authored
Replaces gesture navigation arrow bubble drawable with a 9-patch one that doesn't need raw color constants. And made the size a little bigger (40dp for bubble, plus drop shadow) as suggested. Bug: 991785, 993506 Binary-Size: Increase needed for binary resources. Change-Id: I36da352899428291ffbbfd8797b3abec581ea9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771638 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Add a new override for InterfaceGetter<> to handle a PendingReceiver<T> and compatible callback, so that we don't need to implement wrappers all around when migrating to the new Mojo types. Additionally, clean up all the instances where such wrappers have been used so far, now that we can use the PendingReceiver<T>-based methods. TBR=mvanouwerkerk@chromium.org Bug: 955171 Change-Id: I028faefc9c50b7d422d4713cdd7c8f87ccded220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769449 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL reduces estimated pre-processed size of css_primitive_value.h from 2.93MB to 2.01MB. Bug: 242216 Change-Id: I3e73fbb893368ec3b2fbe9e4c3445a60f805243e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772781 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Robert Liao authored
This is a refactor change and is preparation for menu text to use STYLE_SECONDARY for minor labels (labels appearing alongside the main label in a menu like for keyboard shortcuts). This also fixes a definition in chrome/browser/ui/views/chrome_typography.h to correctly align CHROME_TEXT_STYLE_START with the beginning of the enum. BUG=865318 Change-Id: I01a12ca482e498d820675e7553e9a3fd92562c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766771 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#691048}
-
Meredith Lane authored
Spec: https://whatpr.org/html/3917/common-dom-interfaces.html#reflecting-content-attributes-in-idl-attributes:element This change: - updates v8 bindings and IDL - Implements (most) of the HTML spec for the three attributes listed above. This change is part of the experimental AOM project, and allows attributes that reflect ARIA relationships to return an element reference corresponding to the ID stored in the content attribute, rather than the string ID itself. These attributes are exposed on the IDL interface AriaAttributes. See https://rawgit.com/w3c/aria/master/#AriaAttributes for more information. Attributes reflecting multiple element references will be implemented using FrozenArray<Element> in a follow up CL. BUG=981423 Change-Id: I35164b436c7e2ffd67a80ebd26e4233189e445b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687013 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#691047}
-
Canon Mukai authored
WebSocketDeflaterTest.WindowBits11 was added by accident in https://chromium-review.googlesource.com/c/chromium/src/+/1767285. Remove it. Bug: 757387 Change-Id: I41e66514eaedf1b76612b2bc4f929f69bf51c979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773883Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0cd38a17..568f3984 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icc1a1ace7116865b24c76e3df09834b6c3f33b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772414Reviewed-by:
-
Darren Shen authored
This reverts commit a50dfe61. Reason for revert: Possible cause of crbug.com/998385. Original change's description: > Add domain joined check to managed device detection for DoH. > > Some devices may be domain joined but not have any active policies. > We should also disable DoH by default for that scenario. > > Bug: 955454 > Change-Id: I50ad015e9e5d072dddcaa72524e5d39ffb2e005c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773397 > Reviewed-by: Eric Orth <ericorth@chromium.org> > Commit-Queue: Katharine Daly <dalyk@google.com> > Cr-Commit-Position: refs/heads/master@{#690809} TBR=ericorth@chromium.org,dalyk@google.com Change-Id: I22da3426da2a759230917f18b3d81d4075ecd9d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772934Reviewed-by:
-
Fergal Daly authored
There were multiple problems: - the tests all passed all the time because displayLocking was disabled, so nothing ever got locked (crbug.com/986574) - the content of the test files was incorrect, they were all executing the same test entry from ref-tests.js (looks like the last patchset overwrote them all, https://chromium-review.googlesource.com/c/chromium/src/+/1680170/35..36 . - the scroller takes several frames to full unlock the correct elements, so this change adds a 1s delay to give it time. - the part.html test is actually failing crbug.com/998356 and so remains disabled for now. BUG=986574 Change-Id: I443ad7a1ce1eb6fd3d8c227e4635ceec0ebcd81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772951Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f0b17d00b98d..7ffd2346f8fa git log f0b17d00b98d..7ffd2346f8fa --date=short --no-merges --format='%ad %ae %s' 2019-08-27 bryan.bernhart@intel.com Resource Management 5: D3D support for resource allocation. Created with: gclient setdep -r src/third_party/dawn@7ffd2346f8fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I183eddfe2a19bff7521b6088ca3a3b80f0ae48f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774253Reviewed-by:
-
Takashi Toyoshima authored
This patch increase the kMaxKeyLength limit, and see how this can improve cache uses by restoring the removed metrics. Bug: 996861 Change-Id: I00be259603b69e5196e7a9729ef1cc509357baeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771367Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7be971fa3a4e..e36b85f34d27 git log 7be971fa3a4e..e36b85f34d27 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 605f863173b6..cde4dd9601ce (9 commits) Created with: gclient setdep -r src/third_party/skia@e36b85f34d27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:None Change-Id: I6ef6e90eb22e0ff4918184227c640afcdc8fc355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774252Reviewed-by:
-
Yang Guo authored
R=luoe@chromium.org Change-Id: Ib6a5ad8ab65d44e7068645b455b786b948324a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768431 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#691039}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1b2f2b335b20..b94afc0b88e6 git log 1b2f2b335b20..b94afc0b88e6 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 vapier@chromium.org lint: fix trailing-comma-tuple warnings/errors 2019-08-28 vapier@chromium.org import configparser from six.moves 2019-08-28 zamorzaev@chromium.org cbuildbot: Fix a keyval bug Created with: gclient setdep -r src/third_party/chromite@b94afc0b88e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7413caf928d599b43a0b1f768b189dd87d851bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774250Reviewed-by:
-
Christopher Cameron authored
AppShimHost repeatedly queries AppShimHandler::Get to call out of itself. In practice, these always go to the ExtensionAppShimHandler that owns the AppShimHost. Remove these functions from AppShimHandler and put them in the AppShimHost::Client interface. Make the AppShimHost take a Client at creation time (which is safe, now that AppShimHost is owned by ExtensionAppShimHandler). Document that this is the interface between AppShimHost and ExtensionAppShimHandler. Bug: 982024 Change-Id: I954ce6f639596c4c930b701ed9770258852d0e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772667 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#691037}
-
Jan Wilken Dörrie authored
This change adds stubs for integrating the native Password Checkup on Android for the Leak Detection feature. Bug: 986317 Change-Id: Idf57d8a812ee11e6d862dbd68ecb54ea58aff738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773221Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#691036}
-
Jan Wilken Dörrie authored
This change adds logic to record user interactions with the leak detection dialog shown when the user submits a compromised credential. Bug: 986317 Change-Id: I49bc3e9fd5d9d63ed3c00775b0d8d24b52d1acb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768330Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Abhishek Bhardwaj authored
This change fixes a bug in ScopedWakeLock that didn't actually make the call to acquire a wake lock when constructed. Also adds a test to catch this case. BUG=924762 TEST=Unit tests. Change-Id: Ife26d3b9ae88f399adc21cd8cb62ba628929094b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757461 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#691034}
-
