- 01 Nov, 2017 40 commits
-
-
Yves Arrouye authored
BUG=chromium:778535 TEST=N/A Change-Id: I709f8928127c5fc7a93404d93ea88ce1a3c38eba Reviewed-on: https://chromium-review.googlesource.com/748890 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#513308}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/464e89c0ca66..449d295d1a4e $ git log 464e89c0c..449d295d1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib86053f0ada2772a640cb4fd1ae0c9ec383ca888 Reviewed-on: https://chromium-review.googlesource.com/749847Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513307}
-
Trent Apted authored
These test harnesses specifically test Cocoa dialogs that are not shown when SecondaryUiMd is enabled. Bug: 780409 Change-Id: Ibdce953bad102464bed17b998c4fcabdf64ace53 Reviewed-on: https://chromium-review.googlesource.com/748487Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#513306}
-
khmel authored
This fixes bug when pressing Enter on learn more or settings link also toggles the parent checkbox. Bug: 779999 Test: Manually on device. Clicking or pressing Enter or Space on the check box itself correctly toggles its state. Set focus on learn more and setting link. Clicking here or pressing the Enter activates help section and leaves current state of the checkbox. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d8aeecd4cf93207cb0251f6ea1088a13d637892 Reviewed-on: https://chromium-review.googlesource.com/749891 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#513305}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/1bc5e494b675..14fe518ae67e $ git log 1bc5e494b..14fe518ae --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Add GetDocument() helper to CJX_Object Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id6cd2b32ac6babb91e35f8e235b27bd54361a162 Reviewed-on: https://chromium-review.googlesource.com/749881 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513304}
-
Michael Thiessen authored
The previous behaviour of MessagePumpForUI::Abort was to prevent delayed tasks from running, but non-delayed tasks would continue to run. This was almost certainly not intentional, and an aborted pump probably shouldn't be running any tasks at all. Bug: 780100 Change-Id: I56ad5b0b5d0621450fc62a35c4d927f4975ae6a4 Reviewed-on: https://chromium-review.googlesource.com/748979Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#513303}
-
Hans Wennborg authored
Recent Clang versions (r317076+) warn about this. Bug: 780523 Change-Id: I6e608b49ef3bd8579165cf831f6b44c67bea3f2a Reviewed-on: https://chromium-review.googlesource.com/749685Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#513302}
-
Xianzhu Wang authored
The tests were written for testing horizontal-bt (crrev.com/128a4df4). Then when we removed horizontal-bt mode, we changed them to test vertical-rl, but the changed tests try to repaint something totally invisible. I'm deleting them because they are actually testing nothing, and I don't know the original intent. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie807413e8ebec50b01ed0c18eef6153ad9114677 Reviewed-on: https://chromium-review.googlesource.com/749626Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513301}
-
Zhongyi Shi authored
to session. Bug: 775593 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If844eb130c63a24d140237498dfba585e665f2e0 Reviewed-on: https://chromium-review.googlesource.com/726940 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#513300}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675 $ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Add CJX_ThisProxy 2017-11-01 dsinclair Convert CScript classes to have CJX objects 2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList 2017-11-01 dsinclair Move the item methods into CXFA_Node propertly Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4b8900ae3eeac0ed5549b54805b9cd0b852b105f Reviewed-on: https://chromium-review.googlesource.com/749051 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513299}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675 $ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Add CJX_ThisProxy 2017-11-01 dsinclair Convert CScript classes to have CJX objects 2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList 2017-11-01 dsinclair Move the item methods into CXFA_Node propertly Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I192c5521d5af89887383ba95e808d240dda95c5b Reviewed-on: https://chromium-review.googlesource.com/749728 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513298}
-
Rick Byers authored
With https://github.com/GoogleChrome/chromium-dashboard/issues/414 now addressed, there's no longer anyone using the old/broken WebCore.FeatureObserver use counters. BUG=676837 Change-Id: I15809cec856275cb4aa499aa06c18b942e4f2b1e Reviewed-on: https://chromium-review.googlesource.com/749761Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#513297}
-
Pavel Kalinnikov authored
Bug: 763303 Change-Id: If6f2549b302b06587c87268d78f4392dbce6aa59 Reviewed-on: https://chromium-review.googlesource.com/684514 Commit-Queue: Pavel Kalinnikov <pkalinnikov@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#513296}
-
Yue Li authored
- Add VoiceInteractionController and VoiceInteractionObserver, remove the corresponding Shell methods. - Add VoiceInteractionControllerClient, notifies the controller through mojo calls. - Refactor ArcVIFrameworkService to use the client instead of calling Shell. - Add unittests for VoiceInteractionController, added test cases in framework service unittest for VoiceInteractionControllerClient. - Update usages of the refactored methods(palette_tray_unittest, metalayer_mode, app_list_button). Bug: 757012, 758650 Change-Id: I6b5ff3e0164bb0ebbf7838b79e242533fd863b3b Reviewed-on: https://chromium-review.googlesource.com/734126 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
-
Zijie He authored
This reverts commit e73f847b. Reason for revert: WebRTC may also give us a unreasonable low bandwidth estimation. Original change's description: > [Chromoting] Set min-bitrate of video channel to 0 > > According to SendSideBandwidthEstimation, > https://cs.chromium.org/chromium/src/third_party/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc?rcl=033ea5f77140eef0c2defd4bd668de5dac9af3ea&l=392 > the bitrate_bps won't be smaller than min_bitrate_configured_, i.e. the field > set by x-google-min-bitrate. This behavior is wrong or at least not what we have > expected in WebrtcTransport: when the bandwidth is fully used by video channel, > returning x-google-min-bitrate as the bitrate from OnTargetBitrateChanged() is > not expected. > > I have verified this change on my machine, and it partially resolves the laggy > issue. > > Bug: chromium:769391 > Change-Id: I2c87a78af63b508b5f8b25b77e171c92a10c7426 > Reviewed-on: https://chromium-review.googlesource.com/726312 > Commit-Queue: Zijie He <zijiehe@chromium.org> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509960} TBR=lambroslambrou@chromium.org,zijiehe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:769391 Change-Id: Ie93ec826e653d040cb5ffd741e69077fab2c2eaf Reviewed-on: https://chromium-review.googlesource.com/749921Reviewed-by:
Zijie He <zijiehe@chromium.org> Commit-Queue: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#513294}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675 $ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Add CJX_ThisProxy 2017-11-01 dsinclair Convert CScript classes to have CJX objects 2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList 2017-11-01 dsinclair Move the item methods into CXFA_Node propertly Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I27cb9c5e9273823020c71cce7929f8bc6e0ede80 Reviewed-on: https://chromium-review.googlesource.com/749727 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513293}
-
Daniel Erat authored
Add WakeLockType::PreventDisplaySleepAllowDimming to the device service's WakeLock mojo interface. A similar level is currently exposed by chromeos::PowerPolicyController and used by ARC. This type is treated identically to PreventDisplaySleep on non-Chrome-OS platforms. Bug: 702449 Change-Id: I9810fa69c8472a264a067d34ee92cef0125d41e5 Reviewed-on: https://chromium-review.googlesource.com/749342Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#513292}
-
Mike Bjorge authored
Cast builds always use the webrtc/system_wrappers, but the webrtc_overrides get pulled in aswell via transient dependencies, which ends up causing a name collision that lld cannot resolve. (In particular, field_trial FindFullName was colliding.) Bug: None Change-Id: I5c2fc9119c9806f344ee0f599e188ba98e2e5f15 Reviewed-on: https://chromium-review.googlesource.com/744424 Commit-Queue: Mike Bjorge <mbjorge@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#513291}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d29e0da3523e..f0a30d71ad24 $ git log d29e0da35..f0a30d71a --date=short --no-merges --format='%ad %ae %s' 2017-11-01 robertphillips Make matrix flip GM easier to triage 2017-10-31 benjaminwagner Add Win2k8 QuadroP400 jobs. 2017-11-01 csmartdalton Revert "Fold analytic clip FPs into GrReducedClip" 2017-11-01 benjaminwagner Upgrade GT610 to Win 10 Creators Update. 2017-11-01 angle-deps-roller Roll skia/third_party/externals/angle2/ 4751aabb7..25301b603 (1 commit) 2017-10-31 recipe-roller Roll recipe dependencies (nontrivial). Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I17ceb6701f9502f1012aae84501f8b5c13bca18b Reviewed-on: https://chromium-review.googlesource.com/749682Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513290}
-
Dmitry Skiba authored
TabbedModeFirstRunActivity introduced in 9c6253e4 doesn't properly handle Resources.NotFoundException from Resources.getValue(), which can result in a crash (see the bug). This CL adds necessary Resources.NotFoundException handling. Bug: 780459 Change-Id: Ib56c9e7be3ddb6aff6ab84621a089ace004b2eee Reviewed-on: https://chromium-review.googlesource.com/748707Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#513289}
-
Ryan Harrison authored
The current implementation for Mac crashes, since /proc/ doesn't exist and thus the path being searched for. This leads to attempting to create a string of length 0. This adds in Mac specific logic for fetching this information. BUG=chromium:773183 Change-Id: I57bc2530ee79a51c0caad42ec31f640f73c7a7d4 Reviewed-on: https://chromium-review.googlesource.com/740344Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#513288}
-
Dmitry Skiba authored
Since 9c6253e4, TabbedModeFirstRunActivity is sometimes started instead of FirstRunActivity. This CL updates FirstRunIntegrationTest to also expect TabbedModeFRA. Bug: 780429 Change-Id: I74883c7b7719123d0acdee1e4939acf8de22e581 Reviewed-on: https://chromium-review.googlesource.com/749286Reviewed-by:
-
Evan Stade authored
Bug: none Change-Id: Ie03afd866c41c5271a1031ce1f62fe517fed7990 Reviewed-on: https://chromium-review.googlesource.com/746994 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#513286}
-
David Reveman authored
This turns motion stills back on. The feature is currently considered ready to be enabled by default. A command line switch can be added as a follow up if we determine that this is not ready yet. Bug: 769140 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0e180cece59aed3356331be8609616ffaab0d35c Reviewed-on: https://chromium-review.googlesource.com/749529Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513285}
-
Xianzhu Wang authored
This reverts commit 4e5cbded. Reason for reland: It is not the reason of the break. Original change's description: > Revert "[SPv175] Support incremental invalidation on scrolling contents layer" > > This reverts commit 7ac572d1. > > Reason for revert: Reverting on suspicion of breaking webkit_layout_tests on many Mac bots. See, e.g.: > > https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/6891 > https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/25624 > > -- Chromium sheriff > > Original change's description: > > [SPv175] Support incremental invalidation on scrolling contents layer > > > > When the scrolling contents layer is resized and it paints the > > background, we should invalidate the expanded/shrunk part of the > > background. For SPv1 this is done by calling IncrementallyInvalidatePaint. > > For SPv175 we need to pass kIncremental reason to PaintController. > > > > Bug: 732611 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: I501ed3e899282b31f4f9d461e23637ab1ca4460d > > Reviewed-on: https://chromium-review.googlesource.com/749283 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#513221} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: I534c53fc28e9d657bbc7759aa80ac84cee065beb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 732611 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/750001 > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513278} TBR=wangxianzhu@chromium.org,pdr@chromium.org,jdonnelly@chromium.org Change-Id: I2d882d39f99449496b053be9b29f6e4d64deec85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732611 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/749922 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513284}
-
Joel Hockey authored
See discussion at https://groups.google.com/a/chromium.org/forum/#!topic/platform-architecture-dev/JjveNjsfRMI BUG=755046 Change-Id: I185fd50e7eae81c1c865b1d9e9477c0c596ec69c Reviewed-on: https://chromium-review.googlesource.com/748482Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#513283}
-
Hans Wennborg authored
Recent Clang versions (r317076+) warn about this. TBR=dmichael Bug: 780523 Change-Id: Id3c239f109119aec9167096bed87a9b886632739 Reviewed-on: https://chromium-review.googlesource.com/749736Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#513282}
-
Tommy Steimel authored
Bug: 776318 Change-Id: I00307ea4f9cf44c71f21a1311e35b5b6a9ea167d Reviewed-on: https://chromium-review.googlesource.com/731268Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#513281}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675 $ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Add CJX_ThisProxy 2017-11-01 dsinclair Convert CScript classes to have CJX objects 2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList 2017-11-01 dsinclair Move the item methods into CXFA_Node propertly Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibe09a39fbdfb9943ec84ac67f4c3a1f0914dd125 Reviewed-on: https://chromium-review.googlesource.com/749724 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513280}
-
Aleks Totic authored
Bug: 635619 Change-Id: I90f55f60a8d85b0bdf3ba6fa934af3dfd401fc78 Reviewed-on: https://chromium-review.googlesource.com/749450Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#513279}
-
Justin Donnelly authored
This reverts commit 7ac572d1. Reason for revert: Reverting on suspicion of breaking webkit_layout_tests on many Mac bots. See, e.g.: https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/6891 https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/25624 -- Chromium sheriff Original change's description: > [SPv175] Support incremental invalidation on scrolling contents layer > > When the scrolling contents layer is resized and it paints the > background, we should invalidate the expanded/shrunk part of the > background. For SPv1 this is done by calling IncrementallyInvalidatePaint. > For SPv175 we need to pass kIncremental reason to PaintController. > > Bug: 732611 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I501ed3e899282b31f4f9d461e23637ab1ca4460d > Reviewed-on: https://chromium-review.googlesource.com/749283 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513221} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I534c53fc28e9d657bbc7759aa80ac84cee065beb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732611 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/750001Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#513278}
-
Eugene But authored
Ignoring the result of WaitUntilConditionOrTimeout call is incorrect in many cases. CL adds WARN_UNUSED_RESULT annotation to WaitUntilConditionOrTimeout to force callers to do the checks. Bug: 780062 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I96daa8dfc6ec280d7f622a91f474714fe48fe3bf Reviewed-on: https://chromium-review.googlesource.com/748108Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513277}
-
Philip Rogers authored
[1] ensured kPaintLayerPaintingOverflowContents was cleared when painting a new root but failed to clear kPaintLayerPaintingCompositingScrollingPhase as well. This caused a regression where negative z index children of a scrolled and transformed paint layer would not paint. This patch fixes and tests the regression from [1], as well as passing one additional test with root layer scrolling. [1] https://crrev.com/19f7cb8adfd015bef06b08d0c02eb5a528e8c885 Bug: 779885 Change-Id: Id73ae360000efe866fd9c9c7c1dade186d547cac Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/749059Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513276}
-
Jialiu Lin authored
Make DownloadItemView to triger download feedback when user press SAVE button in generic warning. Bug: 773105 Change-Id: I119d0f9e119115c38ee3a725345105e8ef93866b Reviewed-on: https://chromium-review.googlesource.com/747879Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#513275}
-
Eric Lawrence authored
multibuffer_data_source.h contains a GURL field carried over from a previous refactor. This field isn't used for anything and should be removed. Change-Id: I3767482358342fca2414eedb547daf467ea47411 Reviewed-on: https://chromium-review.googlesource.com/749317Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#513274}
-
Sadrul Habib Chowdhury authored
The test is failing on intel and amd, but not on nvidia. Disable it now while I investigate. TBR=kbr@chromium.org BUG=780118 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iae399d4079aefdd76facfe08df8280ede8b7327c Reviewed-on: https://chromium-review.googlesource.com/749784Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#513273}
-
Justin Donnelly authored
This reverts commit 33fc6c64. Reason for revert: One or the other of this CL and https://crrev.com/c/748268 (perhaps both in combination?) broke PaletteTrayTestWithVoiceInteraction.StylusBarrelButtonActivatesHighlighter on Linux ChromiumOS Tests (dbg)(1): https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31692 The connection to these voice interaction Cls seems pretty clear. I can't identify which one it is, though, so while I apologize for the trouble, I'm going to revert both to ensure that the bot turns green again. Original change's description: > Move assistant icon animation to CompositorAnimationOberver > > BUG=None > TEST=locally build and see animation running as before. > > Change-Id: I1eb62490108beaaec0795adb4251054c03b364e1 > Reviewed-on: https://chromium-review.googlesource.com/748273 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513211} TBR=xiyuan@chromium.org,xiaohuic@chromium.org Change-Id: I5ef677c189808601f8e357f56a171bf920b10fa0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/749851Reviewed-by:
-
Justin Donnelly authored
This reverts commit f69055b7. Reason for revert: One or the other of this CL and https://crrev.com/c/748273 (perhaps both in combination?) broke PaletteTrayTestWithVoiceInteraction.StylusBarrelButtonActivatesHighlighter on Linux ChromiumOS Tests (dbg)(1): https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31692 The connection to these voice interaction Cls seems pretty clear. I can't identify which one it is, though, so while I apologize for the trouble, I'm going to revert both to ensure that the bot turns green again. -- Chromium Sheriff Original change's description: > Do not play assistant end animation when hiding > > When assistant is started and triggered hiding animation, during a very > short time window if the user lifted their finger, we would try to play > end animation. We should avoid doing that. > > BUG=b:67496461 > TEST=build and flash locally, see animation playing normally > > Change-Id: Idf52f692edd9d05b16ad48687384d291b208a42e > Reviewed-on: https://chromium-review.googlesource.com/748268 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513208} TBR=xiyuan@chromium.org,xiaohuic@chromium.org Change-Id: I13b9410f76829ec1491e9191e53519914d57f7cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:67496461 Reviewed-on: https://chromium-review.googlesource.com/749849Reviewed-by:
-
Robert Liao authored
MacOS's alert dialog seems to need allowing nestable tasks for tab navigation to work. BUG=778562 Change-Id: Ic8654defa4e6ec1c7089639108e8a937e923b486 Reviewed-on: https://chromium-review.googlesource.com/747849 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#513270}
-
Peiyong Lin authored
As part of the progress to make GRC strongly typed, we also lean towards to making output mojo interface strongly-typed when needed. This patch removes the current two generic APIs from the mojo interface and creates two APIs that are used by the current TabSignalObserver implementation. BUG=775691 Change-Id: I3ddd06fc723dd63982be21ee39e5809305765751 Reviewed-on: https://chromium-review.googlesource.com/747962Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
-
