GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251248 0039d316-1c4b-4281-b951-d872f2087c98

R=markusheinz@chromium.org

Review URL: https://codereview.chromium.org/153973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251246 0039d316-1c4b-4281-b951-d872f2087c98

The field accessor functions for the Views test helpers only obtain
values from sections that are actually active. (By virtue of the way
the Views dialog is built). Match OSX to do the same.

NOTRY=true
BUG=none
R=estade@chromium.org

Review URL: https://codereview.chromium.org/162813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251245 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334280
TEST=WorkspaceWindowResizerTestSticky.StickToBothEdgeAndWindow

Review URL: https://codereview.chromium.org/163833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251244 0039d316-1c4b-4281-b951-d872f2087c98

Patch Set 1 here is Lei's original patch:
https://codereview.chromium.org/109623005/
That was reverted for causing http://crbug.com/343042

This performs the same cleanup without the print preview regression.
(keeps ConstrainedWebDialogDelegateViewViews::CreateNonClientFrameView)

BUG=166075
TEST=No behavior/appearance changes; no dialog frame regressions (print preview or otherwise).
TBR=wittman@chromium.org,sky@chromium.org,thestig@chromium.org

Review URL: https://codereview.chromium.org/165073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251243 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176158

Review URL: https://codereview.chromium.org/158983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251242 0039d316-1c4b-4281-b951-d872f2087c98

TextButton will be deprecated soon; use LabelButton.
Use views::Border as the AvatarLabelBorder base class.
Other minor cleanup.

BUG=155363
TEST=No regressions of this Windows/CrOS/LinuxAura supervised user UI.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/163953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251241 0039d316-1c4b-4281-b951-d872f2087c98

(this is a fresh copy of https://codereview.chromium.org/121713002/ with correct BaseURL)

BUG=340702
NOTRY=true

Review URL: https://codereview.chromium.org/149673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317027

Review URL: https://codereview.chromium.org/163393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251239 0039d316-1c4b-4281-b951-d872f2087c98

LayerIterator takes 4 parameters. One is the FrontToBack ordering
but that is now the only option. The other 3 are for the type of layers,
render surfaces, and the render surface layer list. The latter two are
now already available as typedefs off of Layer and LayerImpl, so we
only need Layer/LayerImpl in the template arguments.

R=enne
BUG=YAK

Review URL: https://codereview.chromium.org/156603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251238 0039d316-1c4b-4281-b951-d872f2087c98

R=mangini@chromium.org
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/165353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251237 0039d316-1c4b-4281-b951-d872f2087c98

Moves AddMatchToMap method to the common base class. Adds method parameters
so that both SearchProvider and ZeroSuggestProvider can use this method.

For SearchProvider this is a pure refactoring. I added some helper classes
in SearchProvider to avoid duplicating code.

For ZeroSuggestProvider, this introduces some additional functionality on
top of what it used to have. Mainly the method may record additional metadata on
the AutocompleteMatch. This metadata is not currently used by zero suggest
provider and as far as I can tell will not in any way affect the operation
of zero suggest provider today. In the future, some of the metadata
recorded will actually be useful (e.g. I am planning to take advantage of
deletion_url).

BUG=338955
TBR=mpearson

Review URL: https://codereview.chromium.org/158053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251236 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/164693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251235 0039d316-1c4b-4281-b951-d872f2087c98

Creates a new helper function to extract search terms from the URL irrespective of the availability of InstantExtendedEnabledParam. 

Previously, InstantSearchPrerenderer invoked chrome::GetSearchTermsFromURL() to extract search terms from the search page url. chrome::GetSearchTermsFromURL() returns a valid non-empty string iff the url has an InstantExtendedEnabledParam("&espv"). If the query extraction is turned off, the search request url will not have an InstantExtendedEnabledParam. In those cases, chrome::GetSearchTermsFromURL() returns an empty string to the InstantSearchPrerenderer.

To extract search terms for InstantSearchPrerenderer, we should not depend on the query extraction flag or the Instant support state of the page.

Follow up of crrev.com/151813002.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/141893009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251234 0039d316-1c4b-4281-b951-d872f2087c98

BUG=256870

Review URL: https://codereview.chromium.org/165063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341941,94925
TBR=vclarke@chromium.org

Review URL: https://codereview.chromium.org/165803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251232 0039d316-1c4b-4281-b951-d872f2087c98

This file is being added to the Chromium repo and removed from the NaCl repo.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3787
TEST=NaCl SDK trybots
R=binji@chromium.org, bradnelson@google.com

Review URL: https://codereview.chromium.org/164323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251230 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId. (https://codereview.chromium.org/150003004/)

Reason for revert:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GTK%20Builder/builds/497

Original issue's description:
> Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId.
> 
> The functionality is the same, just moving the code to a new place.
> 
> NOTRY=True
> BUG=333995
> R=bauerb@chromium.org, brettw@chromium.org, joaodasilva@chromium.org, nhiroki@chromium.org, noms@chromium.org, rlarocque@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251221

TBR=joaodasilva@chromium.org,noms@chromium.org,bauerb@chromium.org,rlarocque@chromium.org,sky@chromium.org,nhiroki@chromium.org,brettw@chromium.org,rogerta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=333995

Review URL: https://codereview.chromium.org/165543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251228 0039d316-1c4b-4281-b951-d872f2087c98

Test that the expected languages and keyboard layouts are available in the
OOBE network screen.

BUG=327034
R=nkostylev@chromium.org, achuith@chromium.org

Review URL: https://codereview.chromium.org/153473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251227 0039d316-1c4b-4281-b951-d872f2087c98

Add a missing break statement in developer_private_api.cc (I'm actually shocked
this didn't cause runtime errors).

TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/163863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251226 0039d316-1c4b-4281-b951-d872f2087c98

We guard all calls to AppendNativeEventMask with X11 platform checks.
It appends native masks and are defined only on X11 platform. This CL
adds the missing check in AppendNativeEventMask.

Review URL: https://codereview.chromium.org/164223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343580
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/163233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251224 0039d316-1c4b-4281-b951-d872f2087c98

It is an unused class from back when we thought we may want to have
multi-account support in the devices page.

BUG=

Review URL: https://codereview.chromium.org/163943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251223 0039d316-1c4b-4281-b951-d872f2087c98

R=benwells@chromium.org
BUG=332115

Review URL: https://codereview.chromium.org/152143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251222 0039d316-1c4b-4281-b951-d872f2087c98

The functionality is the same, just moving the code to a new place.

NOTRY=True
BUG=333995
R=bauerb@chromium.org, brettw@chromium.org, joaodasilva@chromium.org, nhiroki@chromium.org, noms@chromium.org, rlarocque@chromium.org

Review URL: https://codereview.chromium.org/150003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251221 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/165593002/)

Reason for revert:
https://chromium-review.googlesource.com/#/c/185937/ just got landed and this CL can go in now. 

Original issue's description:
> Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163793004/)
> 
> Reason for revert:
> https://chromium-review.googlesource.com/#/c/185937/ has to go in first. 
> 
> 
> Original issue's description:
> > Turn on icu_use_data_file_flag on CrOS
> > 
> > See also https://chromium-review.googlesource.com/#/c/185937/
> > 
> > The switch has to be turned on in two places (chromeos-chrome.ebuild and
> > build/common.gypi). One or the other can get landed separately, though.
> > 
> > BUG=72633
> > TEST=net_unittests:*IDN* and base_unittests:*String*
> > TBR=mark
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213
> 
> TBR=mark@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=72633
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251214

TBR=mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633

Review URL: https://codereview.chromium.org/164333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251220 0039d316-1c4b-4281-b951-d872f2087c98

1. Log IP address of the receiver in every message to help with debugging
2. Remove dependency on cast_channel_api.pb.h from cast_socket.h to avoid
   flaky build issue
3. Log lower priority messages at level 2

Review URL: https://codereview.chromium.org/160973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251219 0039d316-1c4b-4281-b951-d872f2087c98

Device enumeration code has been lifted from
src/chrome/browser/extensions/api/serial and moved into src/device/serial.

The enumeration impl for Linux now uses udev to enumerate devices matching the
"tty" subsystem, rather than matching /dev node name patterns.

The Windows implementation remains effectively unchanged, and the Mac
implementation has had its /dev pattern filter relaxed to catch devices of the
more generic forms "/dev/tty.*" and "/dev/cu.*".

BUG=334698

Review URL: https://codereview.chromium.org/158063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251218 0039d316-1c4b-4281-b951-d872f2087c98

> Fixes crashes wrt to the maximize button when:
> - A user hovers the minimize button with the mouse then taps the snap left / snap right button
> - When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment #6 in bug)
> 
> BUG=342867
> TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch
> 
> Review URL: https://codereview.chromium.org/160493004

Reverting as broke compile on windows:

[2431/3743] CXX
obj\chrome\browser\extensions\api\cast_channel\browser_extensions.cast_auth_util_nss.obj
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.maximize_bubble_controller.obj.rsp /c
..\..\ash\wm\caption_buttons\maximize_bubble_controller.cc
/Foobj\ash\wm\caption_buttons\ash.maximize_bubble_controller.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\ash.custom_frame_view_ash.obj.rsp /c
..\..\ash\wm\custom_frame_view_ash.cc
/Foobj\ash\wm\ash.custom_frame_view_ash.obj /Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.frame_caption_button_container_view.obj.rsp
/c ..\..\ash\wm\caption_buttons\frame_caption_button_container_view.cc
/Foobj\ash\wm\caption_buttons\ash.frame_caption_button_container_view.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.maximize_bubble_controller_bubble.obj.rsp
/c ..\..\ash\wm\caption_buttons\maximize_bubble_controller_bubble.cc
/Foobj\ash\wm\caption_buttons\ash.maximize_bubble_controller_bubble.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.frame_maximize_button.obj.rsp /c
..\..\ash\wm\caption_buttons\frame_maximize_button.cc
/Foobj\ash\wm\caption_buttons\ash.frame_maximize_button.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
ninja: build stopped: subcommand failed.

from: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/14916/steps/compile/logs/stdio#error1

TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/165283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251217 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
https://chromium-review.googlesource.com/#/c/185937/ has to go in first. 


Original issue's description:
> Turn on icu_use_data_file_flag on CrOS
> 
> See also https://chromium-review.googlesource.com/#/c/185937/
> 
> The switch has to be turned on in two places (chromeos-chrome.ebuild and
> build/common.gypi). One or the other can get landed separately, though.
> 
> BUG=72633
> TEST=net_unittests:*IDN* and base_unittests:*String*
> TBR=mark
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213

TBR=mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633

Review URL: https://codereview.chromium.org/165593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251214 0039d316-1c4b-4281-b951-d872f2087c98

See also https://chromium-review.googlesource.com/#/c/185937/

The switch has to be turned on in two places (chromeos-chrome.ebuild and
build/common.gypi). One or the other can get landed separately, though.

BUG=72633
TEST=net_unittests:*IDN* and base_unittests:*String*
TBR=mark

Review URL: https://codereview.chromium.org/163793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251213 0039d316-1c4b-4281-b951-d872f2087c98

This removes the global constructor call for std::string kEmptyString.

This is roughly an application of b/7549760 from the internal
version of protobuf.

Upstream patch here https://codereview.appspot.com/63480043/.

R=fischman@chromium.org
TBR=darin@chromium.org
BUG=341941,94925

Review URL: https://codereview.chromium.org/164743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155363
TEST=none
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/164653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251211 0039d316-1c4b-4281-b951-d872f2087c98

When running in single-process mode, e.g. during unit tests, the utility
process cannot terminate the process and instead closes its channel to trigger
cleanup.  Ending batchmode triggers process termination for the multi-process
mode, but does nothing during single-process mode, leading to test timeout.
This can be fixed by adding the single-process mode logic to the EndBatchMode
code path.

BUG=341935

Review URL: https://codereview.chromium.org/157783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251209 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/163833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251208 0039d316-1c4b-4281-b951-d872f2087c98

- easier to read
- safer since gpu::Mailbox is constant size and checked in the ParamTraits

BUG=None

Review URL: https://codereview.chromium.org/148003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251207 0039d316-1c4b-4281-b951-d872f2087c98

- A user hovers the minimize button with the mouse then taps the snap left / snap right button
- When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment #6 in bug)

BUG=342867
TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch

Review URL: https://codereview.chromium.org/160493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251206 0039d316-1c4b-4281-b951-d872f2087c98

This means no file can be opened for write during the test run.

R=csharp@chromium.org
NOTRY=true
BUG=116251

Review URL: https://codereview.chromium.org/163553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251205 0039d316-1c4b-4281-b951-d872f2087c98

QuicConnection never calls visitor_->OnConfigNegotiated.
OnConfigNegotiated is only called by QuicCryptoStream on QuicSession.

Merge internal CL: 61467714

Remove the unused server_config_id_ member from
QuicCryptoClientConfig::CachedState.

Merge internal CL: 61394953

R=rch@chromium.org,rtenneti@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/162493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251204 0039d316-1c4b-4281-b951-d872f2087c98

I think this got borked during a merge. Adding back.

TBR as this is same code as you reviewed.

BUG=341787
TEST=none
R=sadrul@chromium.org
TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/165473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251203 0039d316-1c4b-4281-b951-d872f2087c98