- 01 Feb, 2015 4 commits
-
-
brettw authored
Minor related GYP cleanup and added some missing dependencies and related targets to the GN build. Support for compiling unit_tests with no ENABLE_WEBRTC. Remove browser_action_drag_data_unittest.cc which is not compiled on any currently supported platform. BUG= Review URL: https://codereview.chromium.org/880873003 Cr-Commit-Position: refs/heads/master@{#314078}
-
jfb authored
Redo DEPS roll from: https://codereview.chromium.org/867463008/ Reverted in: https://codereview.chromium.org/889163003/ Because the hash was improperly abbreviated. This roll has the proper hash. I'm mildly troubled that all tests passed. This pulls in the following Native Client changes: f02226b: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug... 6bc00f6: (dschuff@chromium.org) Update upstream compiler_rt to HEAD and use official git mirror 55d212c: (phosek@chromium.org) Updates the tools Makefile to work with Git ccc9c66: (shyamsundarr@chromium.org) Add all remaining avx2 instructions except vgather. 9595661: (jfb@chromium.org) Enable -Werror for LLVM build aa51c35: (pcc@google.com) Disable -flto when compiling nacl_bootstrap_lib. 476c662: (jfb@chromium.org) PNaCl: Update Subzero and LLVM revision in pnacl/COMPONENT_REVISIONS 2f388a0: (dschuff@chromium.org) Enable SCons testing of arm-nacl-clang on the bots fea15c4: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug... BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build R= mseaborn@chromium.org, bradnelson@chromium.org Review URL: https://codereview.chromium.org/890173002 Cr-Commit-Position: refs/heads/master@{#314077}
-
rdsmith authored
Suggested from review in CL https://codereview.chromium.org/864923002/. BUG=None R=mmenke@chromium.org Review URL: https://codereview.chromium.org/877443002 Cr-Commit-Position: refs/heads/master@{#314076}
-
kalman authored
working (also By Google) Calendar extension. BUG=435290 R=aboxhall@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/890173003 Cr-Commit-Position: refs/heads/master@{#314075}
-
- 31 Jan, 2015 36 commits
-
-
v8-autoroll authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/887283002 Cr-Commit-Position: refs/heads/master@{#314074}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/477efb1..fb47e17 TBR= Review URL: https://codereview.chromium.org/892813002 Cr-Commit-Position: refs/heads/master@{#314073}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/6bfef2d..0b737c5 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=fmalita@google.com Review URL: https://codereview.chromium.org/884753004 Cr-Commit-Position: refs/heads/master@{#314072}
-
amineer authored
Revert of NaCl: Update revision in DEPS, 58c9abe -> fea15c4 (patchset #1 id:1 of https://codereview.chromium.org/867463008/) Reason for revert: This is causing official builds to fail, as the DEPS hash is not valid Original issue's description: > NaCl: Update revision in DEPS, 58c9abe -> fea15c4 > > This pulls in the following Native Client changes: > > f02226b: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug... > 6bc00f6: (dschuff@chromium.org) Update upstream compiler_rt to HEAD and use official git mirror > 55d212c: (phosek@chromium.org) Updates the tools Makefile to work with Git > ccc9c66: (shyamsundarr@chromium.org) Add all remaining avx2 instructions except vgather. > 9595661: (jfb@chromium.org) Enable -Werror for LLVM build > aa51c35: (pcc@google.com) Disable -flto when compiling nacl_bootstrap_lib. > 476c662: (jfb@chromium.org) PNaCl: Update Subzero and LLVM revision in pnacl/COMPONENT_REVISIONS > 2f388a0: (dschuff@chromium.org) Enable SCons testing of arm-nacl-clang on the bots > fea15c4: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug... > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build > > Committed: https://crrev.com/cebaf8cb5f60a5e3f3ecbfd65ebb338c90dba400 > Cr-Commit-Position: refs/heads/master@{#314020} TBR=jfb@chromium.org,mseaborn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/889163003 Cr-Commit-Position: refs/heads/master@{#314071}
-
xiyuan authored
BUG=453994 Review URL: https://codereview.chromium.org/888173002 Cr-Commit-Position: refs/heads/master@{#314070}
-
jvoung authored
Previous PNaCl translators depended on the SRPC "init_done" call, but newer ones do not. Bumping the min version will help ensure that folks do not load the older copy which relies on init_done, after we remove the implementation of init_done. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4055 Review URL: https://codereview.chromium.org/871373013 Cr-Commit-Position: refs/heads/master@{#314069}
-
thakis authored
Looks like it got added back when I mishandled a merge conflict between https://codereview.chromium.org/854643004/ and https://codereview.chromium.org/850253002 BUG=446368 TBR=timurrrr@chromium.org Review URL: https://codereview.chromium.org/882223008 Cr-Commit-Position: refs/heads/master@{#314068}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/234f749..477efb1 TBR= Review URL: https://codereview.chromium.org/886443005 Cr-Commit-Position: refs/heads/master@{#314067}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/1872ad0..6bfef2d CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=fmalita@google.com Review URL: https://codereview.chromium.org/890153002 Cr-Commit-Position: refs/heads/master@{#314066}
-
brettw authored
The bots don't have the capacity to link these targets. TBR=dpranke Review URL: https://codereview.chromium.org/891893002 Cr-Commit-Position: refs/heads/master@{#314065}
-
gab authored
All we care about is the size of the file per user, logging it on write was wrong as it would generate WAY too many reports as indicated by issue 453454. Also changed the distribution to be logarithmic rather than linear to give better insights (with a linear distribution all we could see was that most people were below 209KB but we didn't have finer buckets below that). BUG=453454, 355722 Review URL: https://codereview.chromium.org/891663003 Cr-Commit-Position: refs/heads/master@{#314064}
-
https://codereview.chromium.org/795773002/davidben authored
Per post-commit comments. BUG=439134 Review URL: https://codereview.chromium.org/873723003 Cr-Commit-Position: refs/heads/master@{#314063}
-
primiano authored
This is just a mechanical rename of tracing includes. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=danakj@chromium.org Review URL: https://codereview.chromium.org/893593002 Cr-Commit-Position: refs/heads/master@{#314062}
-
estade authored
BUG=437116 Review URL: https://codereview.chromium.org/889043003 Cr-Commit-Position: refs/heads/master@{#314061}
-
primiano authored
This is just a mechanical rename of tracing includes. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=tomhudson@google.com Review URL: https://codereview.chromium.org/893533005 Cr-Commit-Position: refs/heads/master@{#314060}
-
Charlie Kehoe authored
BUG=451598 Re-uploading this CL under my @chromium identity: https://codereview.chromium.org/888203002 TBR=rkc@chromium.org Review URL: https://codereview.chromium.org/875843003 Cr-Commit-Position: refs/heads/master@{#314059}
-
alito authored
Currently, an RLZ machine-specific ID is used to protect and verify a subset of user preferences. A new function was added that returns the machine SID and can be used instead of the RLZ ID. Currently available only on Windows. BUG=453825 Review URL: https://codereview.chromium.org/836703005 Cr-Commit-Position: refs/heads/master@{#314058}
-
simonhong authored
So far, EarlyOut_DeferCommits is controlled by Proxy. Because Scheduler doesn't know about this deferring, it triggers next BeginMainFrame when main thread want to defer a commit. This CL moves the EarlyOut_DeferCommits logic from Proxy to Scheduler so Scheduler can stop next BeginMainFrame until defer commit is off. R=brianderson@chromium.org, danakj@chromium.org, skyostil@chromium.org BUG=382572, 453787 TEST=cc_unittests Committed: https://crrev.com/1625b74468e4dd55f54ba209f8e91d05493875b9 Cr-Commit-Position: refs/heads/master@{#313816} Review URL: https://codereview.chromium.org/337693005 Cr-Commit-Position: refs/heads/master@{#314057}
-
Martin Barbella authored
R=inferno@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/888163002 Patch from Martin Barbella <mbarbella@chromium.org>. Cr-Commit-Position: refs/heads/master@{#314056}
-
v8-autoroll authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/867163004 Cr-Commit-Position: refs/heads/master@{#314055}
-
Abhishek Arya authored
TBR=morrita@chromium.org,tsepez@chromium.org BUG=453571 Review URL: https://codereview.chromium.org/872673008 Cr-Commit-Position: refs/heads/master@{#314054}
-
aelias authored
This contains the logic used to synchronize scroll deltas between the main, pending and active tree into the generic SyncedProperty class. Each LayerImpl has a refptr to one, which is shared between the pending and active version of that layer. This removes the need for the logic to backsync deltas to the pending tree, reduces code duplication with analogous properties like page scale factor, and clarifies the principles behind CC's synchronization approach. This should be a no-op change. BUG= Review URL: https://codereview.chromium.org/800613009 Cr-Commit-Position: refs/heads/master@{#314053}
-
horo authored
Revert of Gather the ServiceWorker client information in the browser process. (patchset #8 id:140001 of https://codereview.chromium.org/871013003/) Reason for revert: This patch is causing http/tests/serviceworker/clients-getall.html to fail on the mac bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fserviceworker%2Fclients-getall.html&showLargeExpectations=true Original issue's description: > Gather the ServiceWorker client information in the browser process. > > This is also adding some logic about empty and invalid > ServiceWorkerClientInfo. > > BUG=450634 > > Committed: https://crrev.com/5d6924925a291a7cf394a685772251c83a63f99f > Cr-Commit-Position: refs/heads/master@{#313982} TBR=jochen@chromium.org,michaeln@chromium.org,tsepez@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450634 Review URL: https://codereview.chromium.org/893783002 Cr-Commit-Position: refs/heads/master@{#314052}
-
dmazzoni authored
BUG=440579 TBR=nasko NOTRY=true Review URL: https://codereview.chromium.org/893773002 Cr-Commit-Position: refs/heads/master@{#314051}
-
Brett Wilson authored
The proto is used by some headers and the lack of dependency is causing some build flakiness. TBR=dpranke Review URL: https://codereview.chromium.org/887193003 Cr-Commit-Position: refs/heads/master@{#314050}
-
bruening authored
TBR=zhaoqin@chromium.org BUG=223255 NOTRY=true Review URL: https://codereview.chromium.org/894503002 Cr-Commit-Position: refs/heads/master@{#314049}
-
gcasto authored
This is because currently the forms we are comparing are saved at slightly different times and so may be modified in between. This change brings PasswordGenerationAgent in line with AutofillAgent. BUG=452741 Review URL: https://codereview.chromium.org/877193004 Cr-Commit-Position: refs/heads/master@{#314048}
-
morrita authored
This change: * Gets rid of MessageAttachmentSet::owning_descriptors_ by moving the responsibility to PlatformFileAttachment, where owning_ member variable is used to track the lifetime * Replaces MessageAttachmetnSet::Add*File() and TakePlatformFile() with platform agnostic AddAttachment() and GetAttachmentAt() * Repalces Message::ReadFile(), Write*File() with ReadAttachment() and WriteAttachmente(), which are also platform agnostic. This also adds MessageAttachment::TakePlatformFile() virtual function, which will be implemented by upcoming MojoHandleAttachment as well. This is another preparation for introducing MojoHandleAttachment, but it also simplifies Message and MessageAttachmentSet. R=agl@chromium.org TBR=mtomasz@chromium.org BUG=448190 Review URL: https://codereview.chromium.org/883093003 Cr-Commit-Position: refs/heads/master@{#314047}
-
isherman authored
The setup notification title does not have a placeholder string, so don't try to substitute one. BUG=453147 TEST=none R=tengs@chromium.org Review URL: https://codereview.chromium.org/884783004 Cr-Commit-Position: refs/heads/master@{#314046}
-
Nico Weber authored
See https://codereview.chromium.org/887093002/ for context. BUG=448790 TBR=timurrrr@chromium.org Review URL: https://codereview.chromium.org/893683002 Cr-Commit-Position: refs/heads/master@{#314045}
-
rouslan authored
Revert of Ensure WebView notifies desktop automation on creation, destruction, and change (patchset #20 id:510001 of https://codereview.chromium.org/880063002/) Reason for revert: Broke interactive_ui_tests on Linux Chromium OS ASan LSan Tests bot. TestAsNormalAndGuestUser/SpokenFeedbackTest.EnableSpokenFeedback/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.EnableSpokenFeedback/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.TouchExploreStatusTray/0 GuestSpokenFeedbackTest.FocusToolbar TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNavigateAndSelect/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.VolumeSlider/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.VolumeSlider/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNavigateAndSelect/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.TouchExploreStatusTray/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.TypeInOmnibox/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.TypeInOmnibox/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateAppLauncher/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateAppLauncher/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1 Example test output: TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0 (run #1): [ RUN ] TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0 [5662:5662:0130/162946:ERROR:browser_main_loop.cc(171)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. [5662:5662:0130/162946:WARNING:chrome_browser_main_chromeos.cc(290)] Running as stub user with profile dir: test-user [5662:5662:0130/162946:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context. Error: Connection refused Xlib: extension "RANDR" missing on display ":9". [5662:5691:0130/162946:ERROR:owner_key_util_impl.cc(27)] Could not get size of /tmp/.org.chromium.Chromium.2P0kWj/dmjRgRA/stub_owner.key [5662:5691:0130/162946:WARNING:local_extension_cache.cc(199)] Extensions will not be installed from update URLs until /var/cache/external_cache/.initialized exists. [5662:5662:0130/162946:WARNING:data_reduction_proxy_settings.cc(345)] SPDY proxy OFF at startup [5662:5673:0130/162946:WARNING:freezer_cgroup_process_manager.cc(58)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [5698:5698:0130/162946:ERROR:renderer_main.cc(205)] Running without renderer sandbox [5708:5708:0130/162947:ERROR:renderer_main.cc(205)] Running without renderer sandbox [5662:5662:0130/162948:INFO:CONSOLE(0)] "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.", source: (0) [5662:5662:0130/162949:INFO:CONSOLE(2069)] "Uncaught TypeError: Cannot read property 'appendChild' of null", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (2069) [5708:5708:0130/162949:WARNING:logging_native_handler.cc(62)] 43 is not in the cache and not the new root. [5708:5708:0130/162949:WARNING:logging_native_handler.cc(62)] unserialization failed [5662:5662:0130/162950:INFO:CONSOLE(2020)] "Starting ChromeVox.", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromePageScript.js (2020) [5662:5662:0130/162950:INFO:CONSOLE(1235)] "Uncaught TypeError: Cannot read property 'query' of undefined", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromePageScript.js (1235) [5662:5662:0130/162950:INFO:CONSOLE(0)] "calling getTree() callback", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/cvox2/background/background.html (0) [5662:5662:0130/162950:INFO:CONSOLE(1453)] "Speak (Q) "ChromeVox spoken feedback is ready"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453) [5662:5662:0130/162950:INFO:CONSOLE(2197)] "Injecting into 2", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (2197) [5662:5662:0130/162950:INFO:CONSOLE(0)] "calling getTree() callback", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/cvox2/background/background.html (0) [5662:5662:0130/162951:INFO:CONSOLE(2020)] "Starting ChromeVox.", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (2020) [5662:5662:0130/162951:INFO:CONSOLE(0)] "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.", source: (0) [5662:5662:0130/162951:INFO:CONSOLE(1252)] "Warning: ChromeVox external script loading for data:text/html;charset=utf-8,\u003Cscript>window.setInterval(function() { try { cvox.Api.speak('ready'); } catch (e) {}}, 100);\u003C/script> stopped after failing to install https://ssl.gstatic.com/accessibility/javascript/ext/loader.js", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1252) [5662:5662:0130/162951:INFO:CONSOLE(1453)] "Speak (Q) "ready"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453) [5662:5662:0130/162951:INFO:CONSOLE(1454)] " using endCallback", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1454) ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4720:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2217:(snd_pcm_open_noupdate) Unknown PCM default [5662:5667:0130/162951:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4241:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4720:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2217:(snd_pcm_open_noupdate) Unknown PCM default [5662:5667:0130/162951:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [5662:5662:0130/162951:INFO:CONSOLE(2189)] "Earcon TASK_SUCCESS", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (2189) [5662:5662:0130/162951:INFO:CONSOLE(2020)] "Starting ChromeVox.", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromePageScript.js (2020) [5662:5662:0130/162951:INFO:CONSOLE(0)] "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.", source: (0) [5662:5662:0130/162951:INFO:CONSOLE(2303)] "processing load complete!", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (2303) [5662:5662:0130/162951:INFO:CONSOLE(1453)] "Speak (Q) category=nav "Click me"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453) [5662:5662:0130/162951:INFO:CONSOLE(1453)] " using startCallback", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453) [5662:5662:0130/162951:INFO:CONSOLE(1453)] "Speak (Q) category=nav "Button"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453) [5662:5662:0130/162951:INFO:CONSOLE(1454)] " using endCallback", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1454) [5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)] Keyboard event: ET_KEY_PRESSED Key code: 17, Flags: 1048580, Is char: 0 [5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)] Keyboard event: ET_KEY_PRESSED Key code: 186, Flags: 1048580, Is char: 0 [5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)] Keyboard event: ET_KEY_RELEASED Key code: 186, Flags: 1048580, Is char: 0 [5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)] Keyboard event: ET_KEY_RELEASED Key code: 17, Flags: 1048576, Is char: 0 [5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)] Keyboard event: ET_KEY_PRESSED Key code: 191, Flags: 1048576, Is char: 0 [5662:5662:0130/162951:INFO:touch_exploration_controller.cc(62)] Keyboard event: ET_KEY_RELEASED Key code: 191, Flags: 1048576, Is char: 0 [5662:5662:0130/162951:INFO:CONSOLE(1252)] "Warning: ChromeVox external script loading for data:text/html;charset=utf-8,\u003Cbutton autofocus>Click me\u003C/button> stopped after failing to install https://ssl.gstatic.com/accessibility/javascript/ext/loader.js", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxChromePageScript.js (1252) [5662:5662:0130/162952:INFO:CONSOLE(1455)] "Stop", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1455) [5662:5662:0130/162952:INFO:CONSOLE(1455)] "Stop", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1455) [5662:5662:0130/162952:INFO:CONSOLE(1455)] "Stop", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1455) [5662:5662:0130/162952:INFO:CONSOLE(1453)] "Speak (I) "Find in page."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453) [5662:5662:0130/162952:INFO:CONSOLE(1453)] "Speak (Q) ", "", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453) [5662:5662:0130/162952:INFO:CONSOLE(1453)] "Speak (Q) "Enter a search query."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1453) [5662:5662:0130/162952:INFO:CONSOLE(2189)] "Earcon OBJECT_OPEN", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (2189) ================================================================= ==5662==ERROR: LeakSanitizer: detected memory leaks Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x4d9e69 in operator new(unsigned long) (/tmp/run_tha_testJgo5Vp/out/Release/interactive_ui_tests+0x4d9e69) #1 0x2bf0069 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:449:7 #2 0x2be4653 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChanges(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:329:3 #3 0x2be2def in AutomationManagerAsh::SendEvent(content::BrowserContext*, views::AXAuraObjWrapper*, ui::AXEvent) chrome/browser/ui/ash/accessibility/automation_manager_ash.cc:114:3 #4 0x2be3314 in AutomationManagerAsh::HandleEvent(content::BrowserContext*, views::View*, ui::AXEvent) chrome/browser/ui/ash/accessibility/automation_manager_ash.cc:63:3 #5 0x21b9486 in views::View::NotifyAccessibilityEvent(ui::AXEvent, bool) ui/views/view.cc:1277:5 #6 0x92bc0de8 in views::WebView::GetWebContents() ui/views/controls/webview/webview.cc:52:5 #7 0x2bf55c9 in AXTreeSourceAsh::SerializeNode(views::AXAuraObjWrapper*, ui::AXNodeData*) const chrome/browser/ui/ash/accessibility/ax_tree_source_ash.cc:104:9 #8 0x2befa22 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:419:3 #9 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5 #10 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5 #11 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5 #12 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5 #13 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5 #14 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5 #15 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5 #16 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5 #17 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5 #18 0x2bf08f9 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:460:5 #19 0x2be4653 in ui::AXTreeSerializer\u003Cviews::AXAuraObjWrapper*>::SerializeChanges(views::AXAuraObjWrapper*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:329:3 #20 0x2be2def in AutomationManagerAsh::SendEvent(content::BrowserContext*, views::AXAuraObjWrapper*, ui::AXEvent) chrome/browser/ui/ash/accessibility/automation_manager_ash.cc:114:3 #21 0x2be2acf in AutomationManagerAsh::Enable(content::BrowserContext*) chrome/browser/ui/ash/accessibility/automation_manager_ash.cc:33:3 #22 0xd275b4b in extensions::AutomationInternalEnableDesktopFunction::Run() chrome/browser/extensions/api/automation_internal/automation_internal_api.cc:357:3 #23 0xaaeae8d in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback\u003Cvoid (ExtensionFunction::ResponseType, base::ListValue const&, std::string const&)> const&) extensions/browser/extension_function_dispatcher.cc:400:5 #24 0xaaea20f in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:314:3 #25 0xaada7c4 in OnRequest extensions/browser/extension_host.cc:353:3 #26 0xaada7c4 in DispatchToMethodImpl\u003Cextensions::ExtensionHost, void (extensions::ExtensionHost::*)(const ExtensionHostMsg_Request_Params &), ExtensionHostMsg_Request_Params, 0> base/tuple.h:246 #27 0xaada7c4 in DispatchToMethod\u003Cextensions::ExtensionHost, void (extensions::ExtensionHost::*)(const ExtensionHostMsg_Request_Params &), ExtensionHostMsg_Request_Params> base/tuple.h:253 #28 0xaada7c4 in Dispatch\u003Cextensions::ExtensionHost, extensions::ExtensionHost, void, void (extensions::ExtensionHost::*)(const ExtensionHostMsg_Request_Params &)> extensions/common/extension_messages.h:582 #29 0xaada7c4 in extensions::ExtensionHost::OnMessageReceived(IPC::Message const&) extensions/browser/extension_host.cc:341 #30 0x44246c4 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:491:11 #31 0x42d099d in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:878:7 #32 0x42b2f8a in content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_process_host_impl.cc:1529:10 #33 0x3ff6060 in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) ipc/ipc_channel_proxy.cc:282:3 ----------------------------------------------------- Suppressions used: count bytes template 9 736 libfontconfig 1 24 libnssutil3 ----------------------------------------------------- SUMMARY: AddressSanitizer: 48 byte(s) leaked in 1 allocation(s) http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 Original issue's description: > Ensure WebView notifies desktop automation on creation, destruction, and change > > Currently, when a caller requests a desktop tree and then opens a new windowthe new WebViewmight have an unloaded child root web area because the tree id sent on construction may be stale by the time automation gets it. Adding a notification in WebView::RenderViewHostChanged appears to work properly. > > This also allows ChromeVox to add one set of listeners on the desktop node. > > TEST=With ChromeVox Next set to use automation, > - navigate within a tab > - switch to several tabs and navigate > - open new windows and navigate > Result should be that events fire properly when tabbing within the new page. > > Committed: https://crrev.com/3475be275ec7342907a64e3e66cad085b9be8c33 > Cr-Commit-Position: refs/heads/master@{#314017} TBR=dmazzoni@chromium.org,aboxhall@chromium.org,sadrul@chromium.org,sky@chromium.org,dtseng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/887203002 Cr-Commit-Position: refs/heads/master@{#314044}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/395f4d8..234f749 TBR=junov@chromium.org,vsevik@chromium.org Review URL: https://codereview.chromium.org/891073002 Cr-Commit-Position: refs/heads/master@{#314043}
-
derekjchow authored
Check interface for wireless extensions to determine if it is a wifi connection. Check SIOCETHTOOL for ethernet. GetCurrentConnectionType will return the CONNECTION_UNKNOWN unless all connections are the same type. R=pauljensen@chromium.org BUG=160537 Review URL: https://codereview.chromium.org/739983005 Cr-Commit-Position: refs/heads/master@{#314042}
-
asanka authored
This change: - Re-introduces U+200C and U+200D as illegal characters since these are ignored on HFS+ and can interfere with filename sanitization. All code points in the Cf general category are now considered illegal in a filename. - Leading and trailing WSpace and '.' characters are now considered illegal. - Due to being confused for short names on VFAT filesystems, the tilde ('~') is now considered illegal. - Prior to this change, only ASCII whitespace were trimmed from filenames on Mac OSX. All UTF-8 encoded WSpace characters are now handled on Mac OSX. - Instead of trimming leading and trailing whitespace, they are now replaced by the replacement character. Trimming could cause a previously hidden extension or basename to be exposed. BUG=444102 BUG=446538 Review URL: https://codereview.chromium.org/869823003 Cr-Commit-Position: refs/heads/master@{#314041} -
sudarsana.nagineni authored
This CL allows app_shell to use chrome.alarms. Also it includes the following changes related to unit tests: - Moved chrome.alarms tests to extensions/ - Moved a helper function CreateEmptyExtensionWithLocation() from extension_function_test_utils.h to api_test_utils.h. - Moved CreateBackgroundPage() from extension_api_unittest.h to api_unittest.h. - Creates WebContents for the extension that can be used to associate a RenderViewHost in extension unit tests. BUG=443622 Review URL: https://codereview.chromium.org/789643004 Cr-Commit-Position: refs/heads/master@{#314040}
-
tfarina authored
Not in gcl, which probably these days nobody working on Chromium uses. BUG=None R=maruel@chromium.org TBR=maruel@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/887033002 Cr-Commit-Position: refs/heads/master@{#314039}
-
