- 22 Jan, 2021 40 commits
-
-
Andres Pico authored
The NativeThemeGtk instance is able to detect high contrast changes in the system by reading the GTK theme name. NativeThemeAura is not capable of doing this however, and is never aware of the true state of high contrast in the system. With this change, NativeThemeGtk will update NativeThemeAura when high contrast changes. Bug: 1157686 Change-Id: I6f0407dd639a1d61d1d7f99fccd2122cb0fdc669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586068 Commit-Queue: Andres Pico <anpico@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#846188}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/21b394fcfab2..170343fcf165 2021-01-22 vapier@chromium.org cros_update: convert to python3 only 2021-01-21 yueherngl@google.com octopus: add firmware-octopus-11297.196.B branch builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0d730b3b9c9333068985f57e384ed86722674342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846187}
-
Abigail Klein authored
This reverts commit 9a823ced. Reason for revert: Need to make another modification to the string. Original change's description: > [Live Caption] Update Live Caption subtitle string based on UX feedback. > > Bug: 1055150, 1167349 > Change-Id: I4c321cdfa6e00c3a8002cbea02e89fc2689e3ecd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633375 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Abigail Klein <abigailbklein@google.com> > Cr-Commit-Position: refs/heads/master@{#844972} TBR=avi@chromium.org,abigailbklein@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1055150 Bug: 1167349 Change-Id: If426b45462ab0b25bbe9cd68e51c42d22cda2358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643491Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#846186}
-
Allen Bauer authored
For a nested class use BEGIN_NESTED_METADATA(outer_class, class_name, parent_class_name) The use of the other macros remain the same. Bug: 1166802 Change-Id: I125dce952969d529e0277559ab739ef89bae9afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631607Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#846185}
-
Roman Aleksandrov authored
Create separate CSS module which will hold specific vars to change style of oobe elements. Bug: 1151292 Change-Id: Ic9afa104672325d2330fcf08550f0b5b0d251623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580884 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#846184}
-
Richard Knoll authored
A macOS notification is identified with the tuple {notificationId, profileId, incognito} and we have to pass these down to the XPC service to close the correct notification. The same applies to the notification id used in the UNNotification API where we need to include the incognito flag in the id. Also updates some method names to be more consistent. Bug: None Change-Id: Ie45cb74eab182e0b495560110d8e6e32367c4bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642275Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#846183}
-
David Bertoni authored
This reverts commit bbc76b3b. Reason for revert: This flakiness was caused by crrev.com/b53ca149, which was reverted in crrev.com/7cf9ce83. Original change's description: > Disable ExtensionServiceTest.ExternalInstallClickToRemove on Win > > It is flaky > > Change-Id: I0a1f011768ddef79c16bd0945231fe3b96dd7146 > BUG: 1168464 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640037 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846046} TBR=rdevlin.cronin@chromium.org,cfroussios@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,cfroussios@google.com Change-Id: Id3941aa4683d0fd7f54b734faa0d60f472a344b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644379Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#846182}
-
Michele Mancina authored
Bug: b/175311081 Change-Id: Ibfce2d6df8033426fe54afee3ca511bcca13e948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642373 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846181}
-
Takuto Ikuta authored
The flag is nop now. Bug: 1142713 Change-Id: Iff9287d2d317fce85c06ba43cfaabf2fc66efbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643000 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#846180}
-
Dan Clark authored
We've decided to remove V8's behavior of filtering the import assertions to only those expected by the embedder. The interop guarantees provided by doing the filtering in V8 are probably not worth the added complexity. Going forward, hosts will no longer need to provide a list of supported assertions, and they will be expected to ignore unknown assertions received from V8. The Blink code is already written such that unexpected assertions are ignored, so the only thing that needs to be done on this side is to remove the DCHECK that expects at most one assertion. Once the V8-side changes are made to remove the filtering, Blink can then stop setting v8::Isolate::CreateParams::supported_import_assertions. Change-Id: I40578c40ff4c97cd64b6bb0840b72163e9c5a2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643059Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846179}
-
Charlie Hu authored
As PRESUBMIT check on code generation is added in previous CL( https://chromium-review.googlesource.com/c/chromium/src/+/2633734), we can now remove the feature for test in document policy features. Change-Id: I51e104cc9d77ad0339bcdd8c6c09dbb88af5e705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636942Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#846178}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/372791761157..cc6961b9ac5e 2021-01-22 johnstiles@google.com Add checkpointing functionality to SkSL Lexer. 2021-01-22 egdaniel@google.com Remove preferring cached memory for vulkan cpu write, gpu read memory. 2021-01-22 ethannicholas@google.com SkSL vars now track their declaration instead of their initial value 2021-01-22 brianosman@google.com SkSL: Remove ByteCode interpreter, generator, etc. 2021-01-22 bsalomon@google.com Revert "Revert "Reland "asyncRescaleAndRead supports unpremul results on GPU""" 2021-01-22 johnstiles@google.com Factor out modifier-token parsing into helper function. 2021-01-22 reed@google.com More hiding of legacy drawImage calls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: If1a364c60712e3328fd0c3b1b50ba711419a8c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846177}
-
Richard Knoll authored
Starting Activities from BroadcastReceivers is no longer supported. Bug: 1169595 Change-Id: I820d888a6adc37b73d0315df9a9b3a598e771d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643509 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#846176}
-
Wei Lee authored
The information printed by CAMERA_LOG is visible in feedback report. Therefore, migrating some VLOG to CAMERA_LOG in VCD should be helpful for debug camera issues. Bug: b/172344305 Test: Build successfully Change-Id: I6398e8a47714417b50fe8225a3fbc443eb860223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641689 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#846175}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fbab010f..bef4c393 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I12e3f36f131b3b2acebc2a11b56180c5e24c60f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644921Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846174}
-
Ben Pastene authored
Devil's bundletool.py expects a java binary on PATH. That's OK today since all the bots have a system installation of java. But when rolling the bots' images forward past the point where install-build-deps-android no longer installs a jre/jdk, that assumption is broken, leading to failing tests. So this CL causes most/all of chrome's android tests to run with the hermetic java SDK under third_party on PATH. This should cause tests that invoke the `java` binary at runtime (like chrome_modern_public_bundle_fake_modules_smoke_test) to use the hermetic java toolchain rather than a system installation of java. Bug: 1169403 Change-Id: I133d6613347704bc505431e04ac1f0e6bfef6a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643983Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#846173}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611304267-88ef864b2fcc457a2d5ceb59f34a94c5685188fd.profdata to chrome-win32-master-1611316382-261a271ac3191d9a6f726d2f754b45ee0d0f178e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I945cb5eacc7d4771e0dd872cd19935befa3a8385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846172}
-
Curt Clemens authored
The data usage setting was showing the current value and a description. Now it shows the name of the setting and the current value to match the way other settings are shown. E.g. instead of Mobile data May incur mobile data charges show Data Usage Mobile data https://screenshot.googleplex.com/AaDrHHDc7hMZnTs.png In the data usage dialog, change the confirm button from "Update" to "Done". Fixed: 1168289, 1168287 Change-Id: I7bec6416909a4f4e3b95a76026e242eccf430e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643568Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#846171}
-
Michael van Ouwerkerk authored
Bug: 1169122 Change-Id: If401cb17cf9b5443f9892eca45eb45d39ea46f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642147Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#846170}
-
Luke Zielinski authored
A WPT import ran into trouble on Mac11 and wasn't able to get results for that platform. It thus added duplicate expectations for all other platforms for these tests, and on a subsequent import also added a Mac11 expectation. So each test had 7 distinct and identical expectations, one for each platform. These can be collapsed into a platform-agnostic expectation which will cover all platforms anyway. Change-Id: Ib9810f4d42ac6420290170ac306045862253990e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644562Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846169}
-
Curt Clemens authored
If the body of a success notification is clicked, then the primary action should be taken instead of doing nothing. Fixed: 1168293 Change-Id: I494bcf53ec1bb1cd615a30e417c95e01877c9431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643856Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#846168}
-
Jesse McKenna authored
This change adds a metric to measure how often a navigation occurs where the target URL matches a RenderProcessHost that was destroyed in the past few seconds. The new metric, "SiteIsolation.ReusePendingOrCommittedSite. TimeSinceReusableProcessDestroyed", emits on every navigation. It records the time (in ms) since a RenderProcessHost with a matching process lock was destroyed, up to 7 seconds. If no matching host was destroyed within the past 7 seconds, it records a sentinel value of 10 seconds. Knowing the most common times since reusable processes were destroyed will inform a broader experiment to potentially delay subframe process shutdown by a few seconds to reduce process churn. Including the sentinel value adds information around how frequently reusable processes are destroyed, i.e., how much opportunity for process reuse exists. Test plan (see "Metrics" section for details on this metric): https://docs.google.com/document/d/11XruVZzYLSkt4se6IV2O4jFOkKs-QbkRB5NMf4mH_hE Bug: 894253 Change-Id: Ic15089d1e3b086480942b6afe32525b3c6461895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575945Reviewed-by:
Oliver Li <olivierli@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#846167}
-
Scott Violet authored
SessionService(FilePath) constructor was only used in one place, and can easily be converted to use the Profile* constructor. This converts to the Profile* constructor and cleans up conditional code. BUG=none TEST=none Change-Id: I3f486ee48db97b8e825df31a66bf276737b76c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644070Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#846166}
-
Adam Ettenberger authored
This CL addresses a Blink Accessibility invalidation gap, when a node's aria-hidden state changes, its blink accessibility subtree must also be invalidated so that the accessibility ignored and invisible states are serialized to the browser process. This is important because we rely on these states being accurate in the browser process, and we need need to receive the state changes through AXEventGenerator in order to send appropriate platform accessibility events, such as structure change events (add/remove child, hide/show, or 'children-changed'). Adding AXObjectCacheImpl::HandleAriaHiddenChangedWithCleanLayout which handles this invalidation, and immediately handles ChildrenChangedWithCleanLayout on the parent of the modified node, and increments |modification_count_| to invalidate AXObject cached values. e.g. AccessibilityIsIgnored(), and IsInertOrAriaHidden(). I needed to also modify BrowserAccessibilityWin::CanFireEvents to allow events to process for the corner case outlined in Bug:1159660. Because the node becoming ignored was the only child, the parent became a leaf node, and the node removed would return false for CanFireEvents because now it "IsChildOfLeaf()". I added a condition to check if the ignored state changed this frame, and if so, allow events to process. BrowserAccessibilityManagerWin filters platform events appropriately for nodes that are ignored. Bug: 1159660 Change-Id: I82e2368c09d4855fdb834600aed7ac61d1883c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612365 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846165}
-
Eugene But authored
Made zhaoyangli and stkhapugin the owners of EG infra. Made zhaoyangli and olivierrobin the owners of test infra. Bug: None Change-Id: Ieedec52a5798353ed3bcf622302fb1ea279b2113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643262 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846164}
-
Luke Zielinski authored
These two tests were recently blocking wpt import because they have different results for linux-rel vs linux_layout_tests_layout_ng_disabled. Quick fix was to mark these as flaky via TestExpectations, but this CL updates the layout-ng-disabled baselines instead. Bug: 1168130 Change-Id: Ib8f1d05cf53d62486bde4689e05c4c1e70d46118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643359 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#846163}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101220600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/pNxnip2F8wICOrBjoNUbN_PM0CdfAwj4mNlQSwyP7dgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/178042652,b/178140249 Tbr: help-app@grotations.appspotmail.com Change-Id: Icfc01440f84af395005efe78961ae28c75c6cd54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643254Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846162}
-
Etienne Bergeron authored
This CL is fixing an inconsistent state that can happen in the TtsPlatformImplWin class. TtsPlatformImplWin has a background worker TtsPlatformImplBackgroundWorkerthat processes asynchronously tasks and sending back notifications. There was a corner case where Pause is called TtsPlatformImplWin::Pause(...) and there was a notification in transit to notify the completion of the current spoke utterance. This was leading to that state: TtsPlatformImplWin::is_speaking_ = false TtsPlatformImplWin::paused_ = true This CL is changing the TtsPlatformImplWin class to handle properly the notifications sent back by the worker. If the notifications clear/stop the utterance and the current state is paused_, a Resume(...) is performed to ensure a valid state. R=dmazzoni@chromium.org Bug: 1167103 Change-Id: I719dca37e08094afc214d469432c7e2541d155f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640753Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#846161}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5093ccefbf2c..28c13893f937 2021-01-22 tvanderlippe@chromium.org Disable flaky Debugger Language Plugins test 2021-01-22 andoli@chromium.org [module.json extensions] web_audio 2021-01-22 tvanderlippe@chromium.org Force add the tooltips for the emulation buttons If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1169688 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iab1d24cd7c426151d8d31a6fa732023c790fc90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643075Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846160}
-
Igor Ruvinov authored
The metrics reporting policy is automatically downgraded to "recommended" level due to privacy reasons. This change modifies the corresponding policy table message from type Error to type to Info, as it is an informative message to make admins aware of the automatic downgrade. Bug: 1155602 Change-Id: Iebd13bb2d6363cf40daa792f2dcdbe0a023eff33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643061Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Cr-Commit-Position: refs/heads/master@{#846159}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c827ccbb58b8..b745f6df8801 2021-01-22 jmadill@chromium.org Capture/Replay tests: Fixes for goma & depot tools. 2021-01-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 22be66d40712 to 9441aea16221 (10 revisions) 2021-01-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f646afdb8929 to a0047c0f6ec8 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I462825347e55a8764979e6bea29ab81d8da44a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846158}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ia82a0793178ff84bb2e0432ce8755bcf5ff696f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644925Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846157}
-
Eugene But authored
Change-Id: I4137602532a9cf92b02bcb762951764f8b375310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643301Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#846156}
-
Ravjit Singh Uppal authored
Bug: 1165795 Change-Id: Iaf59a0dab7da5c7578a79e54d0a3cea9140e2b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624788 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#846155}
-
Dan McArdle authored
Change-Id: I8bf824819ea496cd3fa50d9b6b82c6085948c3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625993Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#846154}
-
Rouslan Solomakhin authored
Before this patch, secure payment confirmation was available only on Mac as an origin trial. This patch enables the renderer origin trial on Windows and enables by default the browser feature on Windows, too. After this patch, websites that are running the secure payment confirmation origin trial can enroll and exercise payment credentials on Windows with Windows Hello in addition to the existing support for TouchID on MacOS. The current origin trial runs to M-89, so enabling the origin trial on Windows in M-90 will have no effect until a new origin trial is started. Intent to experiment on MacOS until M-89: https://groups.google.com/a/chromium.org/g/blink-dev/c/9cgsOW3XNw4/m/bBgGYUwACQAJ Bug: 1169045 Change-Id: Ic6f37257571c4b162035c200f6eaa36919215c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642404 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#846153}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a3545e46d238..9c81656e14af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nsatragno@google.com,snijhara@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1148764 Tbr: nsatragno@google.com,snijhara@google.com Change-Id: Id2d30358dfc6d8e021fdb28f616c6fd9f14276e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645024Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846152}
-
Tim Volodine authored
Add "WebViewJavaJsBridgeMojo" feature to enums.xml in order to enable metrics regarding its usage. BUG=1164434 Change-Id: I5ed07a9c81b946c37c0e74cc83a39ec3cc28c0fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644877Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#846151}
-
Stefan Zager authored
Change-Id: I7e169b86c66e8c3ab5f4fd3b96ceed1d01c5a309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643055 Auto-Submit: Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#846150}
-
Yutaka Hirano authored
With this CL, WritableStreamTransferringOptimizer is actually used when transferring a WritableStream. Bug: 1146396 Change-Id: Ia82176b23e9de6b4e8e54fd1332ade2decabb2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642640Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#846149}
-