- 07 Nov, 2019 40 commits
-
-
Ryo Hashimoto authored
Vsock proxy depends on /run/vm which is created by pre-start script in vm_concierge.conf. BUG=b:143997789 TEST=Launch Play Store Change-Id: I46ccb49cd19df98001f4a3937e7ab1c7e40d06c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901009Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#713342}
-
Josh Horwich authored
Bug: b/143923749 Change-Id: I178257708c0eb2e0268368a03de11c9c6dfaacaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900431Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#713341}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/361d1c3e5ab4..0d65febb94a9 git log 361d1c3e5ab4..0d65febb94a9 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 33f41173..47e9a612 (713078:713182) Created with: gclient setdep -r src/third_party/webrtc@0d65febb94a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I073ca11e0aa3fd8649ba1451873249c19ff0986f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713340}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/13adddb32ef0..76ee91e12642 git log 13adddb32ef0..76ee91e12642 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 9856269+sarahM0@users.noreply.github.com Fix spvc test machanism and adds unit tests for OpSource (#868) Created with: gclient setdep -r src/third_party/shaderc/src@76ee91e12642 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I062b82a03dff981e50050137169846b7fecc33d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903006Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713339}
-
Yoshifumi Inoue authored
This patch moves implementation of |PreviousLineOf()| to |NGInlineCursor| from |NGPaintFragmentTraversal| for preparation of migrating |NGFragmentItem|. Bug: 982194 Change-Id: I92d17fcd7381d54f8616cef79f131d9cdfb0589d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900791 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713338}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/322220a0b205..cc0919dcb64b git log 322220a0b205..cc0919dcb64b --date=short --no-merges --format='%ad %ae %s' 2019-11-07 jmadill@chromium.org Capture/Replay: Fix VertexAttribType BYTE output. 2019-11-06 tobine@google.com Vulkan:ImageHelper read combined DS textures Created with: gclient setdep -r src/third_party/angle@cc0919dcb64b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I571b360322f7e7e7b2c4bc0a6096e4b725133e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902923Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713337}
-
Nigel Tao authored
The gif-animated-partial-load.html web test examines the intermediate rendering of loading a GIF image over a simulated slow network connection - an incomplete image. The GIF spec (https://www.w3.org/Graphics/GIF/spec-gif89a.txt) describes how to decode a complete GIF file, but does not mention intermediate on-screen state. Different decoders have leeway to present different partial decodings. Specifically, Chromium's old decoder only output complete rows of pixels and consumed only complete blocks of data. Chromium's new decoder can output partial rows and consume partial blocks. (A GIF image's compressed pixel data is framed into a sequence of blocks. Each block has a length byte, then up to 255 bytes of payload.) For interlaced GIFs, the old and new decoders also take different approaches as to how to expand 'tall' rows: whether the explicit row is the center or the top of the strip of implied rows. To repeat, different (spec-compliant) GIF decoders can produce different partial decodings. The Blink web test does a pixel-exact comparison to a golden screenshot, so this commit also updates that screenshot. https://bugs.chromium.org/p/chromium/issues/detail?id=1014044#c3 shows the old and new screenshots. This commit isn't about performance per se, it is about tracking upstream Skia. Nonetheless, here are some before-vs-after total times for Chromium's "image_decode_bench -i 10" program for x86_64, on a selection of GIF images that noel@chromium.org collects: old_time new_time ratio file_name file_size 0.000143 0.000391 0.37 bar.gif 265 0.000282 0.000401 0.70 radient.gif 1034 0.001328 0.001290 1.03 mondrian.gif 3792 0.002619 0.001893 1.38 rain.gif 10272 0.009508 0.005642 1.69 flag.gif 41738 0.021562 0.013780 1.56 warp.gif 106420 0.390664 0.301473 1.30 hex.gif 1072114 A ratio higher is better: more than 1.00 means that the new GIF decoder is faster than the old one. The ratios are consistent with the hypothesis that the new decoder has a higher fixed cost but lower per-pixel cost (cost in terms of time taken). Overall, it is arguably a net improvement in absolute time taken. The same relative difference (ratio) means larger absolute differences for larger images. Bug: 1014044 Change-Id: I20e2d6281945b8219778d049c3d09a52f456aed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898151Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713336}
-
Toni Barzic authored
The reporter was used to record app list transition animation smoothness when transitioning to/from home screen from/to overview. (using histogram Apps.StateTransition.AnimationSmoothness.*Overview). It was passed to the animation optionally created by HomeScreenDelegate::UpdateYPositionAndOpacityForHomeLauncher and HomeScreenDelegate::UpdateScaleAndOpacityForHomeLauncher. The former is already setting up metrics recorder for the same animation - the one owned by AppListView, but using different histograms (Apps.HomeLauncherTransition.AnimationSmoothness.*Overview). Given that we don't need two equivalent histograms, remove the recorder owned by HomeScreenPresenter, for two reasons: * it wasn't getting reset when the animation was interrupted * the tracked animation might outlive the recorder during shutdown (AppListView widget is destroyed after HomeScreenPresenter), so it might cause use after free - see linked bug. Also, remove HomeScreenDelegate::NotifyHomeLauncherAnimationTransition, which was used to set up app list view's state animation recorder before starting animation. Instead move the recorder setup into the methods that actually initiate animations (to make the API less prone to misuse). BUG=1021936,1022124 Change-Id: I7324826afb081f9bea6246cbb938cf8d7baa6688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901356 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713335}
-
Lin Sun authored
Added more platform tags to some expected failures to restrict the scenario. Also added some new failures on Linux and Intel graphics card. Bug: 832238, 849572, 928530, 950552 Bug: 1014429, 1021428 Bug: angleproject:2672 Change-Id: I9eec7fe7e08a3b6fcc17166e9e14e02eae8115ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899406Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#713334}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLTableElement> and DynamicTo<HTMLTableElement> as new downcast helper 2. Use IsA<HTMLTableElement>(element) in place of IsHTMLTableElement(element) Bug: 891908 Change-Id: If226fd115ed87225caa5396d770a8ecbc2b9987f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899639Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#713333}
-
Ryan Sturm authored
Add an entry for NavigationPredictorMultiplePrerenders in field trial testing config. This maps to the 5 prerender arm in the experiment (the most aggressive). We are not sure which arm will launch if any, so we might as well test the most aggressive behavior against the bots. Bug: 1016213 Change-Id: Ie8e930790b9a4438a32df76496bd7a6a183156ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900469Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#713332}
-
Varun Khaneja authored
This flag has been enabled for all Stable M78+ users. R=bdea Bug: 963165 Change-Id: Ic5b3f5236f66bae4bd6a87ba2ff98c5ff5193144 Fixed: 966646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892293 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#713331}
-
Hiroki Nakagawa authored
ServiceWorkerStorage::FindRegistrationForDocument() is used not only for window clients but also for worker clients (dedicated workers and shared workers). This CL renames the function to clarify that. Bug: 906991 Change-Id: Ic2bfd2a1b5581caf8fd623db1d03a6fc5106cf11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900515 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#713330}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/762f11932e24..636832d9a666 git log 762f11932e24..636832d9a666 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 tsepez@chromium.org Introduce CPDF_Page::RenderContextClearer. 2019-11-07 thestig@chromium.org Update README.md to mention V8 and XFA requires C++14. Created with: gclient setdep -r src/third_party/pdfium@636832d9a666 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Id2ff64a8b1af3b736baaad9d3067c62062018140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902473Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713329}
-
Jacques Newman authored
selectedIndex does not give the correct item when used with GetListItems. This caused the popUpButton to have an incorrect value. Bug: 1019418 Change-Id: I72948b2ec28629b628d2687b31a9b5cf3eebc64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887721Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713328}
-
Nick Diego Yamane authored
After crrev.com/c/1789603, KeyEvent ctor for X11 assumes keyboard group (which is used to determine which keyboard layout is in use), can be extracted from XKeyEvent using XkbGroupForCoreState function [1], which stored, along with other bit fields, in XKeyEvent::state field. In order to be able support IME engines like IBus, GtkUi implementation intercepts Gdk Events, translates them into XKeyEvents and inject them into X11 Event Source. Such conversion was not including 'group' field, which causes issues such as the one described in crbug.com/1021732. [1] https://code.woboq.org/qt5/include/X11/extensions/XKB.h.html#_M/XkbGroupForCoreState Bug: 1021732 Change-Id: Iec0246e4ccae2cb22a384e30b33b86b8b17588bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902426Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#713327}
-
Moe Ahmadi authored
- Calls stopAutocomplete(/*clearResult=*/ true) when results are cleared so that the state of results in JS matches that of the Autocomplete backend. - Queries the autocomplete on pressing the arrow up/down keys when the matches are hidden rather than simply showing the old matches because there are now no autocomplete results to back them. Bug: 1021312 Change-Id: I8aa24f9c40a5076f55c40846ba43298a3b144a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900652Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713326}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I24e7aa987aa629ec0b54c82056e56d9f96449bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902291Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713325}
-
Yutaka Hirano authored
In preparation to remove process association from KeepaliveStatistics, remove KeepaliveStatisticsRecorder::HasRecordForProcess. Bug: 1018050 Change-Id: I5d9f9dc762de5a7f6ce3de5c863de9b9d98808b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883471 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#713324}
-
David Grogan authored
We'd already been setting SetIsFixedBlockSizeIndefinite properly, but children weren't paying attention because we weren't setting their percentage resolution sizes with CalculateChildPercentageSize. Bug: 845235 Change-Id: I09a6a0414e4fde8ee6cdd146e056c50d718dbc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895746 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#713323}
-
Miyoung Shin authored
This change converts PrerenderCanceler mojom interface client in components to use BrowserInterfaceBroker. Since PrerenderContents is a WebContentsObserver, a static helper function is used to register its binder. Bug: 936482 Change-Id: I9e8e72a5802dce3cb4a3b88bfdcacdea6e10bf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895108 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#713322}
-
Maksim Sisov authored
We accidentally forgot to pass background_color and prefer_dark_mode settings to X11 when converting PlatformInitProperties to ui::XWindow::Configuration. This lead to a visual bug when windows are created with white background color and stay white until a very first frame is sent. Bug: 1018474 Change-Id: Ic16a41381b8b57ec4e0f59a4cf4a0820743c61b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900003Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#713321}
-
Maksim Sisov authored
The app id is an identifier that the compositor can use to group multiple surfaces together. Also, the app id is used to match with the application's .desktop file that also sets an icon of the application, its name if set and other useful information [1] [1] https://github.com/wayland-project/wayland-protocols/blob/master/unstable/xdg-shell/xdg-shell-unstable-v6.xml#L559 Bug: 1021874 Change-Id: Ic6607a7f2272da4bf8ae3cea81706ac0e56ab6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901066Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#713320}
-
Ahmed Fakhry authored
This CL remove the "--enable-virtual-desks-gestures" flag entirely and enables the 4-finger swipes to switch desks on M-80 going forward. BUG=1005340 TEST=Tested manually on device, updated existing tests. Change-Id: Ic5cd4a4042433ef3828038e2675df2838ea31d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902080 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#713319}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/64036088..80def79b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3cb7ac93017f56ba7a4beff00aa3db2f99659371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902586Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713318}
-
Khushal authored
Instead of assuming that the child initializes the filter on the received resource to a known state, always initialize it before using. If the client sends the resource with the specified |filter| on TransferableResource, then it is returned with the same state. If the client sends it in any other state, then it should assume that it is returned in an unknown state. R=sunnyps@chromium.org Change-Id: Idd2cc884d27c053edd2ac48078faf324914cc8b0 Bug: 1018898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888951 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#713317}
-
Miyoung Shin authored
This change converts MimeHandlerService mojom interface client in components to use BrowserInterfaceBroker Since MimeHandlerViewGuest is a WebContentsObserver, a static helper function is used to register its binder. Bug: 936482 Change-Id: Ib47255e7cbcdc0701491357bb21aea8d18d0602e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895018Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#713316}
-
Fergal Daly authored
We just disable bfcache for these tests. Bug: 1019077 Change-Id: I77245839258af1b842a736d5058fa244813f5d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889830 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713315}
-
John Lee authored
Previously, there was a race condition between when the IntersectionObserver's callback would get fired for the first time each TabElement was added into the view, and when the callback would be expected to have been called for an individual test's setup. Ran 100 times with no failures. Fixed: 1022008 Change-Id: I5e418cb8fc691fd4ecd32c3d88a9805f1bdc2f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902070Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#713314}
-
Victor Vasiliev authored
Roll src/net/third_party/quiche/src/ dfbd3df88..fa63b6e14 (21 commits) https://quiche.googlesource.com/quiche.git/+log/dfbd3df88865..fa63b6e147fd $ git log dfbd3df88..fa63b6e14 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 wub Fix a gfe_quic_fuzzer issue caused by uninitialized packet number. 2019-11-05 fayang gfe-relnote: In QUIC T049+, support sending coalesced packets. 2019-11-05 wub gfe-relnote: (n/a) Add QuicCircularDeque to third_party/quic/core. Code not used yet. 2019-11-05 bnc Remove QuicheMakeUnique. 2019-11-05 wub gfe-relnote: In quic_framer.cc, replace PacketNumberIntervalLength(interval) by interval.Length(). Not protected. 2019-11-05 wub Internal QUICHE change 2019-11-04 quiche-dev Add support for creating a persistent TUN device (that survives across Bonnet restarts). 2019-11-04 renjietang Change name of QuicStream::HasFinalReceivedByteOffset() to HasReiceivedFinalOffset(). 2019-11-04 vasilvv Add a simple QuicTransport server for testing and demo purposes. 2019-11-04 fayang gfe-relnote: In QUIC, add a connection option to use 2 * rttvar when calculating PTO timeout. Protected by existing gfe2_reloadable_flag_quic_enable_pto. 2019-11-04 bnc Add QuicDispatcherPeer::GetTimeWaitListManager() method. 2019-11-04 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_donot_process_small_initial_packets. 2019-11-04 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_simplify_stop_waiting. 2019-11-04 fayang gfe-relnote: In QUIC, add SetSoftMaxPacketLength to set a soft max packet length in creator. If a single frame is failed to be serialized, restore the actual max packet length. Not used yet. Not protected. 2019-11-04 renjietang Use connection's encryption level at QuicCryptoStream::OnCryptoFrame(). 2019-11-04 dschinazi Enable all versions in toy server 2019-11-04 dschinazi Deprecate quic_parse_prox_source_connection_id 2019-11-04 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_add_upper_limit_of_buffered_control_frames3. 2019-11-04 fayang gfe-relnote: In QUIC, add connection option to enable IETF loss detection with both adaptive packet and adaptive time threshold. Protected by existing gfe2_reloadable_flag_quic_enable_ietf_loss_detection. 2019-11-04 fayang gfe-relnote: In QUIC, add 2 connection options to set the start point of exponential backoff when calculating PTO timeout. Protected by exisiting gfe2_reloadable_flag_quic_enable_pto. 2019-11-04 fayang gfe-relnote: In GFE, add two QUIC connection options for cwnd bootstrap experiments with different multipliers. Protected by existing gfe2_reloadable_flag_quic_use_ip_bandwidth_module. Created with: roll-dep src/net/third_party/quiche/src Roll src/net/third_party/quiche/src/ fa63b6e14..7a4d20901 (7 commits) https://quiche.googlesource.com/quiche.git/+log/fa63b6e147fd..7a4d20901fbb $ git log fa63b6e14..7a4d20901 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 quiche-dev Send an ICMP6_PACKET_TOO_BIG when we try to send a message that is too big. 2019-11-06 wub gfe-relnote: (n/a) Make QuicCircularDeque compile in Chromium. Code not used yet. 2019-11-06 vasilvv Replace kMaxIetfVarInt with UINT32_MAX, as size_t on 32-bit platforms is smaller than kMaxIetfVarInt, thus causing a compile error on those platforms. 2019-11-05 wub gfe-relnote: (n/a) Remove a QUIC_BUG in quic::PacketNumberQueue::AddRange. Test only. Not protected. 2019-11-05 renjietang Remove redundant stream finding code when STOP_SENDING frame is received. 2019-11-05 dschinazi Update to IETF draft 24 2019-11-05 fayang gfe-relnote: Remove QuicPacketGenerator. Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: I2ba2a6140544cd2f07f43b4fa68c36873c65e6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900429 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#713313}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c1501a6caf64..62303e032c7c git log c1501a6caf64..62303e032c7c --date=short --no-merges --format='%ad %ae %s' 2019-11-07 cjmcdonald@chromium.org DependencyService: Return empty source paths for empty package list Created with: gclient setdep -r src/third_party/chromite@62303e032c7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic79b8a0e58316189ecfd35ae362c8ac1e265718a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b4b80864f88f..12e6d18c4860 Created with: gclient setdep -r src-internal@12e6d18c4860 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:984162,chromium:1004848 Change-Id: I9338f4f8015bfe840ca7ee8cf8e34d3557023f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902471Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713311}
-
Peter Kasting authored
Bug: 1003612 Change-Id: I6102b7923150414c339745b3831dc607b5c145ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902719 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713310}
-
Jarryd authored
Rename QuotaDiskInfoHelper to QuotaDeviceInfoHelper and add another method to it, AmountOfPhysicalMemory. This allows mocking physical memory in unit tests, particularly useful for testing code having to do with incognito mode. This change also removes a specialized function in QuotaSettings that was used exclusively for testing. Follow up to https://crrev.com/c/1890055 Bug: 1017120 Change-Id: If28105bba658cdff1e3f58340b6dc7bda8285289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895074Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713309}
-
tby authored
We want clients to be able to make logging calls from any sequence. The data flow of the framework looks like this: (client) -----> Recorder -----> Metrics Provider <----- UMA | | | sends sends grabs cached logging log info log info calls periodically The UMA backend requests log info on the browser UI sequence, so we must ensure all Recorder -> Metrics Provider calls also happen on the UI sequence for thread safety. This CL adds logic to the Recorder that checks which sequence a client called on. If it is *not* the UI sequence, it re-calls itself on the UI sequence. This changes the picture to: maybe reschedule on UI seq _______ | | | V (client) -----> Recorder -----> Metrics Provider <----- UMA | | | any seq UI seq UI seq Bug: 1016655 Change-Id: I81d5168eef8b0ad138e09e89a28b6efca3c6c0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902179Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#713308}
-
Matt Falkenhagen authored
The intent is to experiment to get data and safely merge to beta with the option to killswitch if necessary. This temporary disables the feature so it can be merged to 79 in that state, a subsequent patch will re-enable it. Bug: 1012143 Change-Id: Idf5cc9de833c0999a233b943dc856ef020182951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900797 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713307}
-
cjamcl@google.com authored
Bug: 772558 Change-Id: I93accea011a5671016e0985ca416c485e08e72c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902771 Commit-Queue: Connor Clark <cjamcl@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#713306}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=gbiv@chromium.org Change-Id: I23243efe308bcd4ed9e2ddc0dfe38db14bb360b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713305}
-
Kuo Jen Wei authored
We currently only support pinning camera app from its internal app id (Unified id in shelf mapping from android camera app and chrome camera app). While the default camera app id showing on admin console is chrome camera app id. This CL apply map logic to pinned app id syncing from admin console. Bug: 1017018 Change-Id: Ibc2386da04806a282cc921f1457d962fdb36778c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895019Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#713304}
-
Dan Beam authored
Bug: 1020725 Change-Id: I71b1458601374e4024c42e044e6d1ff625ec4f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900614 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#713303}
-