- 21 Oct, 2018 3 commits
-
-
Christopher Cameron authored
With MacViews, it is now very rare to actually need a RenderWidgetHostViewMac to have its own compositor. The only circumstances where this happens are - content shell - popup windows (the date/time picker) - tab capture of backgrounded tabs Remove the concept of having a "detached" compositor, and simplify the transitions between states. This change will introduce flashes to paths that rely on the RenderWidgetHostViewMac having its own compositor (which are now vanishingly rare). Change-Id: I0feeec67a42f05de05aa4d72fe9af93f033d9d64 Reviewed-on: https://chromium-review.googlesource.com/c/1292377 Commit-Queue: ccameron <ccameron@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601409}
-
Saman Sami authored
Sometimes EmbedSurface is called right before WasShown when the tab is hidden. When frame evictor is notified of this new surface, it might immediately evict it because it doesn't know the tab will be visible soon. This will result in an evicted surface getting embedded which will show blank. Do two things: - Only call SwappedFrame when the tab is visible so don't have the problem mention above. Generally there is no point in calling SwappedFrame when it's invisible because even though a new id is allocated, there will not be any CompositorFrames submitted to this surface until the tab is shown, so there is no point in notifying the frame evictor. - Notify RHWVAndroid via WasEvicted when the surface is evicted so that it can allocate a new id for the next time it's shown. Bug: 896633,893731 Change-Id: I6fbc339f606d70e65ecc79b0f74bcd44133bd4fc Reviewed-on: https://chromium-review.googlesource.com/c/1289953 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I4859bb33a11bff11c65a9568155e3fb114039193 Reviewed-on: https://chromium-review.googlesource.com/c/1292381Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#601407}
-
- 20 Oct, 2018 37 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/773e141a83e3..0c226492507a git log 773e141a83e3..0c226492507a --date=short --no-merges --format='%ad %ae %s' 2018-10-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bc6f52f36d5f..b8eec4a4ab53 (6 commits) Created with: gclient setdep -r src/third_party/skia@0c226492507a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Iefdc61468817dea12cdda2a769ee8dedf5e94f3d Reviewed-on: https://chromium-review.googlesource.com/c/1292795Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601406}
-
Peter Kotwicz authored
This CL reverts https://crbug.com/307333 for WebAPKs but not webapps. That CL made webapps reload when a user: - navigated back to a webapp via Android Recents AND - the webapp had been killed (which means that it is likely that a long time elapsed since the webapp was launched has passed) A WebAPK user is using window.history.pushState() to cache that a web page was reached by launching a WebAPK instead of by navigating on the web. The behaviour introduced in https://crbug.com/307333 was preventing the history state from getting restored when the user navigates back to the WebAPK via Android recents and Chrome has been killed. The rationale for reverting the behaviour for WebAPKs but not webapps is that WebAPKs are supposed to be sophisticated apps. Reloading the page takes control away from web developers. BUG=888100 Change-Id: Icb4803b0ee8b3444e0aade2acc2473b8ce1c23b7 Reviewed-on: https://chromium-review.googlesource.com/c/1275290 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#601405}
-
Khushal authored
Since skia's internal caching is keyed on text blobs, its important to reuse the same object. Make sure we cache text blobs in the ServiceTransferCache to get a cache hit in skia. R=enne@chromium.org Bug: 894200 Change-Id: I8808d649ca3520211d034e07e7d4670ffb39094c Reviewed-on: https://chromium-review.googlesource.com/c/1292722 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#601404}
-
Ahmed Fakhry authored
To avoid confusion when there is no internal keyboard connected: - We should not show the option to remap the internal "Search" key since that key doesn't exist. - We should also avoid labeling the options to remap the external meta keys as "External Meta" or "External Command", and just say "Meta" or "Command" as "External" here is redundant. TBR=stevenjb@chromium.org BUG=890522, 890950 TEST=Expanded existing tests. Reviewed-on: https://chromium-review.googlesource.com/c/1253022Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599409} Change-Id: I3136efe54d2544423e4dd9b23fe8ffabffe3caf0 Reviewed-on: https://chromium-review.googlesource.com/c/1292890Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#601403}
-
David Benjamin authored
This got fixed by recent work to be pickier around function pointers. Bug: 719699 Change-Id: I684c0ee1d9866ef5517fe983f6e86ab44fb16689 Reviewed-on: https://chromium-review.googlesource.com/c/1282202Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#601402}
-
Peter Kasting authored
At this point, normal/hybrid should behave identically to refresh, and touchable identically to touchable refresh. Bug: none Change-Id: I616e35e50a95d467c361bc40eacbb738a3368665 TBR: nektar Reviewed-on: https://chromium-review.googlesource.com/c/1287929Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#601401}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=timvolodine@chromium.org Bug: 681136 Change-Id: I98dd1c92df3d38301e0394e44cea06263f54beaf Reviewed-on: https://chromium-review.googlesource.com/c/1288512Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601400}
-
Wez authored
Crash can locate particular entries in a stack by scanning for start & end markers with unusual values. We add start & end markers around the |str_stack| copy of the LogMessage string, created when we're about to crash the process due to a FATAL level log message. This was originally landed with review: https://chromium-review.googlesource.com/c/1201344 which was reverted because MSan bots (correctly) failed due to the test's scanning of uninitialized stack memory. Since the test can't avoid doing that, we simply disable it under both ASan and MSan. Bug: 802393 Change-Id: Icd87f258aeb9556ab8e68d3e3431e80c01f1d3f0 Reviewed-on: https://chromium-review.googlesource.com/c/1292597Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#601399}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90b15ebffc98..91b0f1063bdf Created with: gclient setdep -r src-internal@91b0f1063bdf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I19f17d8611f627c323d6a840c897ad57bf21f845 Reviewed-on: https://chromium-review.googlesource.com/c/1292797Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601398}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=dpranke@chromium.org Bug: 753973 Change-Id: Ie5be77df8c85eff62c9e0bb7bee0e20bbc4c367a Reviewed-on: https://chromium-review.googlesource.com/c/1288172Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601397}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ia7a55dae442fdf272becf47532ad20dfd551e349 Reviewed-on: https://chromium-review.googlesource.com/c/1292374Reviewed-by:
-
Roberto Carrillo authored
Since our primary objective is to reduce the cycle time for repo-wide code coverage reports, we'd do better to have compilation and test running on separate builders. R=stgao,liaoyuke,jbudorick Bug: 896446 Change-Id: Ic8b7f6319b208405a310694134da6011b485d8f1 Reviewed-on: https://chromium-review.googlesource.com/c/1289075 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#601395}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0b3c5cb7. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26403 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I82ab75f9adc69facefbfb1bd8a8b576c266115b6 Reviewed-on: https://chromium-review.googlesource.com/c/1292399 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601394}
-
David Tseng authored
Bug: 896910 Change-Id: I7b8b08147943a214900e6b835ce7c45016167b22 Reviewed-on: https://chromium-review.googlesource.com/c/1292151 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#601393}
-
Dongseong Hwang authored
CL:1045256 calculates |uv_rect| of the primary plane in wrong way. It causes drmModeAtomicAddProperty failure. This CL fixes it. BUG=896945 Change-Id: I6e914707cb961e8294e8ddd160b75e48ae5a2b64 Reviewed-on: https://chromium-review.googlesource.com/c/1291590 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Cr-Commit-Position: refs/heads/master@{#601392}
-
Ahmed Fakhry authored
This reverts commit 4c097c39. Reason for revert: I found a bug in internal keyboard detection. I will reland with fix to be able to merge to M-71. Original change's description: > Hide option to remap internal search when no internal KB is connected > > To avoid confusion when there is no internal keyboard connected: > - We should not show the option to remap the internal "Search" > key since that key doesn't exist. > - We should also avoid labeling the options to remap the external > meta keys as "External Meta" or "External Command", and just say > "Meta" or "Command" as "External" here is redundant. > > BUG=890522, 890950 > TEST=Expanded existing tests. > > Change-Id: If979b80217298a5f6bb18be478aa2c457859a351 > Reviewed-on: https://chromium-review.googlesource.com/c/1253022 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599409} TBR=stevenjb@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 890522, 890950 Change-Id: I9cd4273a61c51751a20d8bbffbf7fffbb252246c Reviewed-on: https://chromium-review.googlesource.com/c/1292816Reviewed-by:
-
Jun Cai authored
This reverts commit 8e3e6c83. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651, 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/51cc30c12411..648d28ad6257 git log 51cc30c12411..648d28ad6257 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 thaloun@google.com Media engine and channel support for per-channel dscp values, specified by RtpParameter Created with: gclient setdep -r src/third_party/webrtc@648d28ad6257 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I27cdd34c150d2be9e783f26da58977e3e7c0ff53 Reviewed-on: https://chromium-review.googlesource.com/c/1292793Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bd5d55eea5c0..9b771ac49bd2 git log bd5d55eea5c0..9b771ac49bd2 --date=short --no-merges --format='%ad %ae %s' 2018-10-20 derat@chromium.org Revert "chromeos_config: Reenable Tast on VM paladin builders." Created with: gclient setdep -r src/third_party/chromite@9b771ac49bd2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I29869cd7fe4e250854738c290c9337dc859c67b3 Reviewed-on: https://chromium-review.googlesource.com/c/1292794Reviewed-by:
-
Peter Kasting authored
This removes a footgun, since InkDropHostView's View overrides provided a lot of functionality that any InkDropHost implementation would want. Also does various other cleanups: * IWYU fixes * Remove unnecessary qualifiers * Reorder InkDropHostView declarations and definitions to match each other and be in a more logical order * Initialize InkDropHostView members in declaration Bug: none Change-Id: Iaf067fbb6361324fbf2da1a82f6658a4b564775e Reviewed-on: https://chromium-review.googlesource.com/c/1282216 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601387}
-
Thomas Guilbert authored
Currently, we sometimes pause videos when they are hidden, as an optimization. This causes videos flung to cast devices to pause as well, since the pause command sent to the FlingingRenderer is forwarded to the cast device. This CL fixes adds a new flag to track whether or not we are currently flinging a video, and disables ShouldPauseVideoWhenHidden() when we are. Bug: 790766 Change-Id: I7729ab2c8187ffd1c77ebb6c48301165dea1d90f Reviewed-on: https://chromium-review.googlesource.com/c/1292820Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#601386}
-
Malay Keshav authored
This patch implements the ability to load skia vector animation files via the resource bundle. Each file is only loaded once and cached for future use. ResourceBundle expects the animation file to be gzipped. UMA metrics are also recorded to note the time to uncompress and parse each animation file. Bug: 890512 Change-Id: Ie0e17dbee9198b12a886f3739a034ad366bf9478 Component: ResourceBundle, skia vector animations Reviewed-on: https://chromium-review.googlesource.com/c/1272800Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#601385}
-
Takuto Ikuta authored
Currently MSVC_SUPPRESS_WARNING is used in a place. Let me use os-specific static_cast instead. Change-Id: Ief273eaf2cc3a6b5e99948b618f9dc9c005898b2 Reviewed-on: https://chromium-review.googlesource.com/c/1290574 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601384}
-
Sadrul Habib Chowdhury authored
Throttle begin-frames to clients until gpu is done processing the earlier swaps. This helps with reducing work when the gpu has a high load, by not sending begin-frames to clients. The clients always keep receiving the compositor-frame-ack messages when a surface becomes activated (or replaces an older pending frame), even if the gpu is busy doing work from earlier frames. So this change introduces the back pressure by way of withholding begin-frames so clients have to do less work. BUG=877906 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If34eb5c5af03961e17932c8f57caf352d0362bab Reviewed-on: https://chromium-review.googlesource.com/c/1282219Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#601383}
-
Mitsuru Oshima authored
A shell surface widget needs be created when the surface has a content, (https://cs.chromium.org/chromium/src/components/exo/shell_surface.cc?rcl=63840f211efada36274cae7ade3003a2dc88c74b&l=475) but it can be created without content if a client requested maximize/fullscreen/minimize state upon creation. This is necessary since xdg (or gtk3 wayland client) seems to have an issue if we configure before the content is created, and it stops updating frames, even if we sends new configure events later. Bug: 892291 Test: Covered by unit tests. Also tested manually. See bug for repro step. Change-Id: I115ec6540a0ec2fc5258c020bd05c4be623f85da Reviewed-on: https://chromium-review.googlesource.com/c/1278986 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/549b4ca0fa63..90b15ebffc98 Created with: gclient setdep -r src-internal@90b15ebffc98 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib5525440069d08a8e32bc70db58c91fe0bf740c0 Reviewed-on: https://chromium-review.googlesource.com/c/1292286Reviewed-by:
-
Ryan Sturm authored
This reverts commit 310c6fa1. Reason for revert: flaky previews test Original change's description: > Switching Previews triggering from the IO thread to the UI thread > > This CL moves previews triggering from the IO thread > (ChromeResourceDispatcherHostDelegate) to the UI thread > (ChromeContentBrowserClient). The new call sites occur in > NavigationRequest and update the previews_state in > CommonNavigationParams held by the NavigationRequest directly. This > means PreviewsDeciderImpl is being moved to the UI thread. > > Significant changes: > - PreviewsDeciderImpl is now owned by the PreviewsUIService instead of > profile IO data. > - PreviewsUserData is now entirely a UI thread notion. For now, we use > PreviewsUITabHelper to manage its lifetime, but it could move to > NavigationHandle (if NavigationHandle already supported UserData, > that solution would be ideal). > - ChromeNavigationData is update to remove PreviewsUserData and > PreviewsState (the latter has moved into PreviewsUserData and there is a > notion of Allowed PreviewsState and committed PreviewsState) > - Offline Previews committed checks use the OfflinePreviewsTabHelper > instead of PreviewsUserData now that we are on the same thread. > - Cleanup on ResourceRequestInfo to remove PreviewsState setter as well > as cleanup to remove PreviewsState from being passed back out of the > loader code into NavigationRequest. > - There is a TODO to re-evaluate PreviewsState during redirects, which > will *not* be plumbed into the network service, so DataReductionProxy > Previews will not be updated. > > Bug: 842233 > Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb > Reviewed-on: https://chromium-review.googlesource.com/c/1266196 > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Jian Li <jianli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601298} TBR=clamy@chromium.org,jianli@chromium.org,mmenke@chromium.org,tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,jochen@chromium.org Change-Id: I176df103620910300297ce0fb9bc6d233b4ebb2f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842233 Reviewed-on: https://chromium-review.googlesource.com/c/1292836Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#601380}
-
Varun Khaneja authored
Bug: 895547 Change-Id: I2d05a172f353938555e8ac1c9d7f0527fa69329d Reviewed-on: https://chromium-review.googlesource.com/c/1281914Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/32643cea2319..b8eec4a4ab53 git log 32643cea2319..b8eec4a4ab53 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 jmadill@chromium.org Use angle::Result in front-end (Part 7) 2018-10-19 jmadill@chromium.org Use angle::Result in front-end (Part 6) 2018-10-19 jmadill@chromium.org Use angle::Result in front-end (Part 5) 2018-10-19 jmadill@chromium.org Use angle::Result in front-end (Part 4) 2018-10-19 jmadill@chromium.org Use angle::Result in front-end (Part 3) Created with: gclient setdep -r src/third_party/angle@b8eec4a4ab53 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I38e7beec0c56a6283c108fe66c1820f30bbcd07c Reviewed-on: https://chromium-review.googlesource.com/c/1292790Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/93277a7fc8ef..98f1e59b41c6 git log 93277a7fc8ef..98f1e59b41c6 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 iannucci@chromium.org [git] Stop using git-retry wrapper on LUCI. Created with: gclient setdep -r src/third_party/depot_tools@98f1e59b41c6 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id3e109f3e431c49ad9e50e6ce2963180ccd56ee4 Reviewed-on: https://chromium-review.googlesource.com/c/1292285Reviewed-by:
-
Xi Cheng authored
This reverts commit b011ab56. Reason for revert: caused test failures -- see crbug/897352 Original change's description: > Upgrade image file management for Win 10 native notification > > This CL makes the following changes: > 1) Change to run image folder cleanup after Chrome startup using a background > task, rather than running it at Chrome shutdown using a high priority task. > 2) Retain the image folder to avoid deleting and creating it repeatedly. > 3) Remove <subdir> from the full path for the temp file, which is unnecessary. > 4) Delete the temp files in batch. > > These changes have the following benefits: > 1) Fix the issue of Chrome shutdown being blocked by image file IO for some users > as in the current implementation. > 2) Save some disk IO related to the sub-directories in the image folder and the > image folder itself. > 3) Avoid creating a deletion task for each file, otherwise the overhead can be > large when there is a steady stream of notifications coming rapidly. > > Bug: 888276 > Change-Id: I214680aa00bd7f19e84e207e82ada553583a094b > Reviewed-on: https://chromium-review.googlesource.com/c/1260498 > Commit-Queue: Xi Cheng <chengx@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601227} TBR=isherman@chromium.org,finnur@chromium.org,grt@chromium.org,chengx@chromium.org Change-Id: Ie79e62373c0076346499e450e48c2d16b55c6dc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888276, 897352 Reviewed-on: https://chromium-review.googlesource.com/c/1292834Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#601376}
-
Shakti Sahu authored
Bug: 896480 Change-Id: I9a0b2b041991a1dbcc63f3190df4dec650f4c25a Reviewed-on: https://chromium-review.googlesource.com/c/1286826 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#601375}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/41ba826ad7b4..773e141a83e3 git log 41ba826ad7b4..773e141a83e3 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d55d997310c2..17dfe1b679af (1 commits) 2018-10-19 herb@google.com Remove unused methods from SkTDArray 2018-10-19 mtklein@google.com any idea why SkReadBuffer has a vtable? 2018-10-19 bsalomon@google.com Use preallocated space for default vertex and index buffer sizes 2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9e4d040cb93c..d55d997310c2 (1 commits) 2018-10-19 egdaniel@google.com Add drawDrawable support to GrRenderTargetContext. 2018-10-19 brianosman@google.com Remove texColorSpace output param from various producer APIs Created with: gclient setdep -r src/third_party/skia@773e141a83e3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I6693036561c1ade1710d8972b3472821d18bb954 Reviewed-on: https://chromium-review.googlesource.com/c/1292789Reviewed-by:
-
Roberto Carrillo authored
This change should instruct the code coverage testers to include the raw profile data in the isolated output. R=jbudorick Change-Id: Iac30af93faa67179a2b61ef12ec52d65e18a1e08 Reviewed-on: https://chromium-review.googlesource.com/c/1272080 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
-
David Black authored
Previously we hid Assistant on widget deactivation. Then we removed that logic to instead use an event handler that dismissed Assistant on press. We actually need both since Assistant widget can be deactivated w/o a press event, such as happens when opening feedback via Alt+Shift+i. Bug: b:117990949 Change-Id: I75338ef112f5cef3445bf88903adaef2ccd56c48 Reviewed-on: https://chromium-review.googlesource.com/c/1292604Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#601372}
-
Krishna Govind authored
R=kariah@chromium.org Change-Id: Ic132d8e5e9d2848862285e95dab69ad24040f424 Reviewed-on: https://chromium-review.googlesource.com/c/1292818Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#601371}
-
Carlos Knippschild authored
Updates the OfflineContentOnDinoPage experiment group name and param value to comply with the upcoming Finch experiment configuration change. Bug: 852872 Change-Id: If110b3d215e9e6fd3184eaff6c33c9f3c5ac5ff7 Reviewed-on: https://chromium-review.googlesource.com/c/1292523Reviewed-by:
-
